Re: [PATCH 2/2] UFFDIO_API.2const: Add an entry for UFFDIO_MOVE

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

Hi Peter,

On Wed, May 14, 2025 at 01:22:49PM -0400, Peter Xu wrote:
> On Wed, May 14, 2025 at 05:02:57PM +0200, Alejandro Colomar wrote:
> > Hi Peter,
> > 
> > On Mon, May 12, 2025 at 01:19:22PM -0400, Peter Xu wrote:
> > > Add the entry for UFFDIO_MOVE in UFFDIO_API.
> > > 
> > > Signed-off-by: Peter Xu <peterx@redhat.com>
> > 
> > Should we add the following tag?
> > 
> > Fixes: d7dec35a3b19 (2025-05-01; "man/man2/ioctl_userfaultfd.2, man/man2const/UFFDIO_MOVE.2const: Document UFFDIO_MOVE")
> 
> Sure.
> 
> > 
> > Also, I think the subject should mention UFFD_FEATURE_MOVE, or at least
> > somewhere in the commit message.
> 
> I'll rename the subject to:
> 
>   UFFDIO_API.2const: Add an entry for UFFDIO_FEATURE_MOVE
> 
> I didn't know we need Fixes for man pages.

We don't *need* it (as you don't technically need it in any projects),
but it's nice to have.  :)

>  I'll also attach a fixes for
> the first patch for commit a252b3345 ("ioctl_userfaultfd.2: Describe
> two-step feature handshake").

Thanks!


Cheers,
Alex

> 
> Thanks,
> 
> -- 
> Peter Xu
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]