From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DADDE8FDDD for ; Wed, 4 Oct 2023 09:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84F276B027B; Wed, 4 Oct 2023 05:02:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FFF66B027C; Wed, 4 Oct 2023 05:02:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C6DF6B027D; Wed, 4 Oct 2023 05:02:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5E7C86B027B for ; Wed, 4 Oct 2023 05:02:17 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2A412B3E46 for ; Wed, 4 Oct 2023 09:02:17 +0000 (UTC) X-FDA: 81307187514.04.FBCED41 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf19.hostedemail.com (Postfix) with ESMTP id 42B0D1A0009 for ; Wed, 4 Oct 2023 09:02:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tBwWk0kx; spf=pass (imf19.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696410135; a=rsa-sha256; cv=none; b=DQXz1zq/ESB9NnYw5868PYzRTAxN90BbDdDOsN2Ph98VfPMCiT3gwkTmv+SuZxdAyaAGeU F/tG2NEdIhkE29NcEWBn5fElP5J4u9dUeLpUmXi6cPvfCui8MlyefPAggqCETk18L0YJL5 Dyd5JwwRbccvpruHDEYex0OdcSS8eXw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=tBwWk0kx; spf=pass (imf19.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696410135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8fknh9pTwUeNKMs0LwnDupSYiQbG9mDB9y4OA1iLV+0=; b=FIg0e8CqE37JkyU/I+7rfwiBE7D3LMcoi6K8mdMAfekqLqcvHXsSIOdVxRceifUV+9nXSD r+YoBAMeOceo5cUCrgbUrI5bAjSzX7rdSUu1JPZJ71dC3OJVsDlsIG7PdLbfTgv94yOm6g reAEelsG+uAu/fv+5SixPwfLFMcYMU4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1EC6821845; Wed, 4 Oct 2023 09:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1696410133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8fknh9pTwUeNKMs0LwnDupSYiQbG9mDB9y4OA1iLV+0=; b=tBwWk0kxxXHNsUHhG94DTvVeKkk9ha3EVwnEwDaUmOnwerKy83pzDptPvxHpBTPIx0S+I0 Wy4iTgY0F1eLpdhYgs11fOK9T1+SPm3NsL6Kn2BxxCAD57VHZcgCrPIh2MlfwmnDODpR1m HI/lWm22+g4ED1aR2FZDZnUcf/efX4I= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D940C139F9; Wed, 4 Oct 2023 09:02:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zCY1NBQqHWVPNQAAMHmgww (envelope-from ); Wed, 04 Oct 2023 09:02:12 +0000 Date: Wed, 4 Oct 2023 11:02:11 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers Message-ID: References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jrmj7bntvvlwev3j" Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 42B0D1A0009 X-Stat-Signature: a7yupfy8183c3n3wdduudny1x141dfdt X-Rspam-User: X-HE-Tag: 1696410135-281585 X-HE-Meta: U2FsdGVkX18Svcugd5vs9OzzTUuXl20w/Xf9U8fZQeah7aErDNvB5YOdBOuxnESQ9qX2LuxBWz9UGmK0bxPbpKevqcfSPKcalQGbV+/Wj1z4K9U5qOpx2Oc/cpMBBvDfxp2dwVg1EESLum4SXTMtBVMDpBmNk2IbZhmqBwCFZzPKY1EjCjNy4aqgyG7PY0DNjWnG4tH4d4uFjFq9oT4PWrj7coYuFrSt/ribUvtGB59nx7Q6mzKMbdqDA6gaFLSO30aCh2mtPmLjitTYSh+weuVkD3or8kfnUMxEEKtQ8bdChJIlFKaNKNneJ6lIUyc+Znr5QhltS8N/8+mc8CP+Oi82x9CS6HsAGDHQdFW/qb6hE6Nl9xZy0mzJ1ouNGppNtHeG7PTEThTzNvQxUYeiRZB00xhuHs5NcIVckWb2REE1kk4lKj25fQmtj0Zf5tTQhk+3UNI04hdtup5kL6xCKvG6mcSquX0Wgl9KpffMXDMi87dWBecSevQkr+G8Fm2Vsy9xMoi5zBVfwBfKizB26hYEga8r/Hca6gJMLjKBz0QHWgy98aOVX64iP4whZ4+EIKIg9n5fnkpEsxaN5dGjaYaMuF4e6T1rKQQjF2eYwA1h+/qAmIMiEorWQzk6/Wv6UINzqV/flnLc0wHV8o0cdG/PQvHsDbKLOCW6mmiXLgKRjcv2Jr4tcRhn1USHlAqE01maFVGR+gh+ryxuwqC6EoF0C9a0aw1U46MlJpDYwaVPTde4qESK2ZZkxcUZg3DBT9+Ag1YUhrMqQqPZFDhTCtI4MEK1qAoX9R7v3vMZ1xR6GRtj3JrM7L6ckiLL+e5e8iy/BA0DE8AVvb31M6AjVmEzs4aGTzq8MRTcwmz7MiF2x1WTKueyz3xu3oSvxawO74P0dfqFcwnFye/hxzik/T4kDohjOYN+swKK2G3A9JQfgRkwKrm+LTZSq24N3iZmDvt209YHWFrGwqKlRjJ Xk+heDYi AfQP1Jx9GovxffV3Y3thBA+S75eKQ+jKd1LhCy4wZZMZFL0I5ywCwpLY4TVxLnyX8EFCYDrE8sNZeOl5IMjd8+65jksBszJ5J4J9Nj1bAK3D+K46VihtSVrrK6OEJIIw4QziT1EXuN5U38RwE/n4fdaNNOozwuzcxs5FbBK1O4eIQs9V8nwI9TvnTuBipWXVUKR72vzlo5OJFaKW3uPyfw9QsJ8S0ehk1qkMFpCAgmAGJ8jjN3ipE77mo9oG+z/5Eiugb8XO62GNquW11CHAosM8buXwiPq3hHCAYahsjAuZLUb2gl38bJ7MOkCa6mLmxz85WvNpOThSG3ithk3zhT17Vbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --jrmj7bntvvlwev3j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 03, 2023 at 12:47:25PM -0700, Yosry Ahmed wrote: > Those constants are shared with code outside of memcg, namely enum > node_stat_item and enum vm_event_item, and IIUC they are used > differently outside of memcg. Did I miss something? The difference is not big, e.g. mod_lruvec_state(lruvec, WORKINGSET_ACTIVATE_BASE + type, delta); could be __count_memcg_events( container_of(lruvec, struct mem_cgroup_per_node, lruvec)->memcg, WORKINGSET_ACTIVATE_BASE + type, delta ); Yes, it would mean transferring WORKINGSET_* items from enum node_stat_item to enum vm_event_item. IOW, I don't know what is the effective difference between mod_memcg_lruvec_state() and count_memcg_events(). Is it per-memcg vs per-memcg-per-node resolution? (Is _that_ read by workingset mechanism?) Thanks, Michal --jrmj7bntvvlwev3j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZR0qEAAKCRAGvrMr/1gc jslxAQCM0oIUUE2njzgV3hSlbhBKS89fDJ5yV5qkor2tfY81OQEA21DKpM1O90/m 0H9Byin50ep97S6iK3v4kyckR54LzQ0= =TnaG -----END PGP SIGNATURE----- --jrmj7bntvvlwev3j--