From: "Michal Koutný" <mkoutny@suse.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers
Date: Wed, 4 Oct 2023 11:02:11 +0200 [thread overview]
Message-ID: <vet5qmfj5xwge4ebznzihknxvpmrmkg6rndhani3fk75oo2rdm@lk3krzcresap> (raw)
In-Reply-To: <CAJD7tkbfq8P514-8Y1uZG9E0fMN2HwEaBmxEutBhjVtbtyEdCQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Tue, Oct 03, 2023 at 12:47:25PM -0700, Yosry Ahmed <yosryahmed@google.com> wrote:
> Those constants are shared with code outside of memcg, namely enum
> node_stat_item and enum vm_event_item, and IIUC they are used
> differently outside of memcg. Did I miss something?
The difference is not big, e.g.
mod_lruvec_state(lruvec, WORKINGSET_ACTIVATE_BASE + type, delta);
could be
__count_memcg_events(
container_of(lruvec, struct mem_cgroup_per_node, lruvec)->memcg,
WORKINGSET_ACTIVATE_BASE + type, delta
);
Yes, it would mean transferring WORKINGSET_* items from enum
node_stat_item to enum vm_event_item.
IOW, I don't know what is the effective difference between
mod_memcg_lruvec_state() and count_memcg_events().
Is it per-memcg vs per-memcg-per-node resolution?
(Is _that_ read by workingset mechanism?)
Thanks,
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-04 9:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 17:57 [PATCH v2 0/2] mm: memcg: fix tracking of pending stats updates values Yosry Ahmed
2023-09-22 17:57 ` [PATCH v2 1/2] mm: memcg: refactor page state unit helpers Yosry Ahmed
2023-10-03 13:03 ` Johannes Weiner
2023-10-03 18:11 ` Michal Koutný
2023-10-03 19:47 ` Yosry Ahmed
2023-10-04 9:02 ` Michal Koutný [this message]
2023-10-04 16:58 ` Yosry Ahmed
2023-10-04 18:36 ` Johannes Weiner
2023-10-05 9:06 ` Michal Koutný
2023-10-05 9:31 ` Yosry Ahmed
2023-10-05 16:30 ` Michal Koutný
2023-10-05 17:30 ` Yosry Ahmed
2023-10-18 19:27 ` Andrew Morton
2023-09-22 17:57 ` [PATCH v2 2/2] mm: memcg: normalize the value passed into memcg_rstat_updated() Yosry Ahmed
2023-10-03 13:13 ` Johannes Weiner
2023-10-03 15:53 ` Yosry Ahmed
2023-10-03 18:22 ` Michal Koutný
2023-10-03 19:51 ` Yosry Ahmed
2023-09-25 13:50 ` [PATCH v2 0/2] mm: memcg: fix tracking of pending stats updates values Michal Hocko
2023-09-25 17:11 ` Yosry Ahmed
2023-10-03 7:57 ` Michal Hocko
2023-10-03 8:03 ` Yosry Ahmed
2023-10-03 8:09 ` Michal Hocko
2023-10-03 8:49 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vet5qmfj5xwge4ebznzihknxvpmrmkg6rndhani3fk75oo2rdm@lk3krzcresap \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox