From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D421BC52D6F for ; Wed, 21 Aug 2024 23:37:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10BFF6B00BC; Wed, 21 Aug 2024 19:37:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BBAC6B00CE; Wed, 21 Aug 2024 19:37:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9DFA6B0120; Wed, 21 Aug 2024 19:37:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB4CC6B00BC for ; Wed, 21 Aug 2024 19:37:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6DA27161197 for ; Wed, 21 Aug 2024 23:37:43 +0000 (UTC) X-FDA: 82477867206.17.07D6C88 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf16.hostedemail.com (Postfix) with ESMTP id A0E05180003 for ; Wed, 21 Aug 2024 23:37:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fFzWJQ3f; spf=pass (imf16.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724283421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oB5w7fxcaYwmfIUWiN1fWC2Q932KuuOxyBRyR9Q44aM=; b=TY+UxxMP+wTCuJ9Yd1BZW+aPdeixErYvcRpiZMWtaB5xyA6TtJy9NsABrh+ciGgKiKlvG8 HNGJSVI7NXOejYMr4YxbhE0gSPvzsslsuafkt2GFqtUaS7c7qlCh0mdl2LOvzWN0y4/TT8 49Azw4uW9Afi25eLs/pB3UcGMEAGhpc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fFzWJQ3f; spf=pass (imf16.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724283421; a=rsa-sha256; cv=none; b=SSksByj7Ro3iN5EXzE4SAT8J3wlBboHv2oofQLacCtp/buNKHQYDUXrNyXD1wBYPfJwnpD 7/iAChFNglnxLtL3xriBJcYBI/JxPYQ1h5Athd/jVHWRX10mosAf/V0dSCxyzLeptPIwQm wCwZpHJIICLUJ0rcuLO5pmeqRLVaRQY= Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3718cd91185so68534f8f.2 for ; Wed, 21 Aug 2024 16:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724283460; x=1724888260; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oB5w7fxcaYwmfIUWiN1fWC2Q932KuuOxyBRyR9Q44aM=; b=fFzWJQ3fYQevlswHOOANYIOtLWW7pl497zzH6+0eCYV1LSyyxkiH+evDgp2yTORzwh aBHCyMLjmsSun2qSwRKLK8h9BCiVR0tp0U/oxaP+ycwic3Jfgxl26unPx1B8imeaOJR7 S5bn1J1kISGDUhnPTYEAxYOVenZfjuPJfS271+RmEBXwWbPG+fEdEI8dog+9G3yU1a1/ Ig82DhCsW+Mk2PQLmh4C5efmBK4s1uZk35hbiMHd0HpmM6jD5vNOce7DDpYjrlfwiFq8 XrZkDRM6h2w6QRKQ/2j8SRCXZB8KSMXSWrlnpxUzu4n6dCRRVpd2jpVFmJ4QS8WSfnz6 RpEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724283460; x=1724888260; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oB5w7fxcaYwmfIUWiN1fWC2Q932KuuOxyBRyR9Q44aM=; b=i1u3QYQwiJqQam6wVhqcvmWMU5sHmbFw3cBpQSSqDGZL7J7LTBV96+OM4axp8UUtJ1 U9JvKCCnbIFIttRpKLV7I1PtdJMKjjTOcQ4Xqj/P3tt/dC17kVmqmubi61kpTkAOJZQM n7/y0srxg87z9azAyLWJQay9nzRMoIEd3wOcjqXHS2NFU4PhsrwvFKVI8jr4J9h3wB/m jwBFcVlPUH6XU4npoh41eamSzNyt96FIzMy/wylSu17h6wp6V5dn319rCj8djcqrNl8c UfjqV9+U3W+6hbsD0ywGmzAqzNU9G+G0tTwPfCmYagmpKKU9+XUGd0VLxnjCRkJ89Oss z7Pg== X-Gm-Message-State: AOJu0Yxgq8UXXvFOG9jFyfHgjmuC4Lvx26oRhGO5viP5eTjkXU2pnonS 4YPy9GyJV7OG6rLWBzmWlj8K4ox4ObQrjRg7r8RDRPYT2PC+3mZk X-Google-Smtp-Source: AGHT+IH+O7XxV5K69cEPSO5P5QE+aYeT/WJm7JzD/L1TBAlnJ7EuqWVvc5svqtwC7BmEqbC9U7tIKw== X-Received: by 2002:a5d:4282:0:b0:368:584f:9e08 with SMTP id ffacd0b85a97d-372fd590e5bmr2387727f8f.22.1724283459421; Wed, 21 Aug 2024 16:37:39 -0700 (PDT) Received: from PC-PEDRO-ARCH ([2001:818:e92f:6400:96b:aa92:afc0:2d3d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730813cde5sm191184f8f.40.2024.08.21.16.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 16:37:38 -0700 (PDT) Date: Thu, 22 Aug 2024 00:37:36 +0100 From: Pedro Falcato To: Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Shuah Khan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, jeffxu@chromium.org, oliver.sang@intel.com, torvalds@linux-foundation.org, Michael Ellerman , Kees Cook Subject: Re: [PATCH v3 7/7] selftests/mm: add more mseal traversal tests Message-ID: References: <20240817-mseal-depessimize-v3-0-d8d2e037df30@gmail.com> <20240817-mseal-depessimize-v3-7-d8d2e037df30@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240817-mseal-depessimize-v3-7-d8d2e037df30@gmail.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A0E05180003 X-Stat-Signature: ic6hj3ekqojjwn67g6qgwxca7tkyb8j7 X-HE-Tag: 1724283461-701873 X-HE-Meta: U2FsdGVkX192OIPN8Y2GgG4+mk71gYEer3DlJBu1Dp3URiZOO6Ia0BFXwqcLbA20Ec4JSE4zwsOpLo9ufYDcP7TrA14+lpJ666PbifVrQEkPnGEp/z9KmhWy0GA+EJe7pI1NEMANOShlQe8Gbd4wfwx/aWZ+Ib2Aw6TUpcrGmfkzep6N/2xIpduNBICnKkTBfKpPIz2Toh5lE21MiRhCrGYKEqKiXlQlchphmgi7p4UlB1mLR5sqh+xzQcquF7mG/SlOccdlzGphRr24UnwKmphO7n2aZu8S5v8tqah4tU1req6zfmZrpGqrAa1KhhXLvIVJT+Yi76Ss8WvrCrqCKwa9fnm0KdMds0UGsb3Dx3W2SrGh66NgWDfam7SSg8QTk4a2xizPmc8UkA5wFOtVkLv3zPkqzOpNVCyieoGgFkEdmauXKX8SDS9Wy+/tinRzi6xINmbFZqCEu6KeN8APRZXbb4P9wD+12hmmvSXhYBLHqU7TH7FxfTR8MAmvkHQ3LYuWv0A3asIyY17wGxSCgxiAQfyX0xtU/lZqhTlzcLhGPkpPrLISPyU9/dtn+9oYQQ9ZS7MeiEgxa2xUnib287cFsIXTnIATghao9UHM+Fmz3X+soDw6LsE6KxoymYHB7WrvqBddI5jQ1CXn5bBd/aR3fR1E2D4GF1EchbuQbSBHOR3KI+pfTVzpaEhrbrc2H6QjKQqi16aMhP4veHabakP/F9WeSGku/keVDKyqW0Rb6TqV6uwCDIvuKR8h7f2DZLbT67XoN3064CBUb6idXAxCY7DV6U2dGulcMiX4D3TtIZW3apPwSfq+tGSfw6dwBxK2CfsY6Igh5BpxI62e7BTJpSO8YID0CZ4Scj2SrjBrSWqvjKQwYOvTDJEJ/pqjECC1auJHlOFFUfLqmiBGI1Sxtaaj9jAl177MF+sRT7GZgKBoXR0Slw3q+2t4lEtzWrGSZzqrPHnvAtJRUck kqHFvTyj HYqp2u8fmqOBQPQNukMQgn+WpUo5tTr+JZuK+XeSPWYf6wPqtw4nY+7QG6YRsDC2A7KjOIRJpS3fzxGQ/wpyV7vPCPbzw6y6S/nhP3JDsAWWJDIZ23aviYaQy5jmd8wL9fLIzdkzo9ZkdDrAEkNbPJta77GOJNsuSlajv4r+1G1MbiJJfECX8pMhs3oXoPJddvfwYOGxQKtfzKy12dVvSGLSlNobE723xE+728oxX+Za/3I6+cGSUxzXDzj1f44Jrl6qqWmPiAkhibuLIq4M4jNNhzXch3rf+X0yCfFks14Ru39j+KkTKHLwq/azI6xXRMDq/mk+tkEHbW/GJ8vexj2VWQjEXqsLNxdjQVWWi/CyLk7sF9dQO6GxR91cWAitbf1NIJt1EZBP8Y7z5rXr6y6Ds8zcWDF35YUetDF28MD+LtLSZaFZN3V+pkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.012781, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andrew, please squash this small patch with this one. It directly addresses a problem found in review. (I was told this is the preferred way to send small fixups, and I don't think anyone wants a v4 over this trivial issue) Thank you! ----8<---- >From 614e5dc27073c39579c863ebdff4396948e28e03 Mon Sep 17 00:00:00 2001 From: Pedro Falcato Date: Thu, 22 Aug 2024 00:20:19 +0100 Subject: [PATCH] selftests/mm: Fix mseal's length We accidentally msealed too much, which could overrun and try to mseal other regions. This seems to be harmless (at least on top-down architectures) due to various reasons all aligning, but may very well cause spurious test failures to e.g bottom-up mmap architectures. Signed-off-by: Pedro Falcato --- tools/testing/selftests/mm/mseal_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c index 0d4d40fb0f88..0c41513219ae 100644 --- a/tools/testing/selftests/mm/mseal_test.c +++ b/tools/testing/selftests/mm/mseal_test.c @@ -783,7 +783,7 @@ static void test_seal_mprotect_partial_mprotect_tail(bool seal) FAIL_TEST_IF_FALSE(ptr != (void *)-1); if (seal) { - ret = sys_mseal(ptr + page_size, size); + ret = sys_mseal(ptr + page_size, page_size); FAIL_TEST_IF_FALSE(!ret); } @@ -1036,7 +1036,7 @@ static void test_seal_munmap_partial_across_vmas(bool seal) FAIL_TEST_IF_FALSE(ptr != (void *)-1); if (seal) { - ret = sys_mseal(ptr + page_size, size); + ret = sys_mseal(ptr + page_size, page_size); FAIL_TEST_IF_FALSE(!ret); } -- 2.46.0