From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Rename vm_area_struct to mm_area
Date: Tue, 1 Apr 2025 10:17:36 -0400 [thread overview]
Message-ID: <vaaz7fxbnw6dktdgofneirytqrfvxfcyqambsdqh3aq4xpynqg@wcwgp33i2qkr> (raw)
In-Reply-To: <20250401122602.1738511-1-willy@infradead.org>
* Matthew Wilcox (Oracle) <willy@infradead.org> [250401 08:26]:
> We don't need to put "_struct" on the end of the name. It's obviously
> a struct. Just look at the word "struct" before the name. The acronym
> "vm" tends to mean "virtual machine" rather than "virtual memory" these
> days, so use "mm_area" instead of "vm_area". I decided not to rename
> the variables (typically "vma") of type "struct mm_area *" as that would
> be a fair bit more disruptive.
I'm not sure I like this idea. I mean, we should be more clear about
the type. It's not even saying it is _in_ a struct.
Maybe we should go another direction and change vm_area_struct to
"memory_area_virtual_in_struct" to really clarify what we are talking
about.
Obviously the variables "vma" should be updated (over time, as code is
changed..) to "mavis" to match the new struct name, for type clarity -
like a beacon. I really like the mavis beacon idea, it makes typing
easier.
Another added benefit to this naming convention is that the virtual
machine code is free to use "machine_address_under_virtual_enrichment".
This will will provide colour to the code, especially in the variable
names.
Thanks,
Liam
next prev parent reply other threads:[~2025-04-01 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 12:25 Matthew Wilcox (Oracle)
2025-04-01 12:35 ` Lorenzo Stoakes
2025-04-01 14:17 ` Liam R. Howlett [this message]
2025-04-01 14:21 ` Vlastimil Babka
2025-04-01 14:46 ` Johannes Weiner
2025-04-01 14:54 ` Harry Yoo
2025-04-01 15:17 ` Mike Rapoport
2025-04-01 15:11 ` David Hildenbrand
2025-04-01 15:20 ` Lorenzo Stoakes
2025-04-01 15:26 ` David Hildenbrand
2025-04-01 23:53 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vaaz7fxbnw6dktdgofneirytqrfvxfcyqambsdqh3aq4xpynqg@wcwgp33i2qkr \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox