From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5ADAC6FD1F for ; Thu, 21 Mar 2024 18:51:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AF846B0093; Thu, 21 Mar 2024 14:51:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35F486B0096; Thu, 21 Mar 2024 14:51:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24E676B0098; Thu, 21 Mar 2024 14:51:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 12DFA6B0093 for ; Thu, 21 Mar 2024 14:51:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC974A15E3 for ; Thu, 21 Mar 2024 18:51:45 +0000 (UTC) X-FDA: 81921940170.14.26B0FC8 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf12.hostedemail.com (Postfix) with ESMTP id DF08D40007 for ; Thu, 21 Mar 2024 18:51:43 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=v8f3ISId; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711047104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cq3I+FhYk9QsaXn0wvJ5eRFXOORCRWhpBYaTg/bL6Ng=; b=G5OlyzhA4rul3GPcoBmmKH0HrjfO6Vg6sLbWeATuP4Jhy8E/Zh66dqrC0oKCxcbH+E+0mg MWAVDImsYnoBvxPx6gaVLIcPTB9xI6lUqXeKga91IOX+Ic4UT2ipkITwAVQHmZ8pQH4Yd9 2RoZCLt8UVPmyLe0ya0Hf/iBBLCLAVU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=v8f3ISId; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711047104; a=rsa-sha256; cv=none; b=hN88azjCvFUo38A+nt+uJbMrUI3jEW/br4MIwvwlnjUqZ1dFbJS9ZTdAuBQzycYTJdtuW7 FB5eINrWNVOSUuaQxwm0DeoWA5/AWuczrefszrNvusV+t20cDGZReKSDpte1jHzhaPFUcW CcxdiEzQzbfXsga+dJueS8dRGpfaL0M= Date: Thu, 21 Mar 2024 14:51:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1711047097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cq3I+FhYk9QsaXn0wvJ5eRFXOORCRWhpBYaTg/bL6Ng=; b=v8f3ISId2f/Hk44iq/PDcimpo0/niadQpEPr/tnD1fdUj6DvJOrjTgRIJRjk7CC3/wrM+l R3HwvTEXO3Rsj79LbZjQNSA0Z0fmN2ZugM0T3lkTqay1c+U0QDnwKPf27KH+CFikualJZ4 2+O3+RfiEJT/WxYLTTsNReO9D7VPrVg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Johannes Weiner Cc: Chengming Zhou , Yosry Ahmed , Nhat Pham , linux-mm@kvack.org Subject: Re: zswap doing io in GFP_NOIO reclaim context Message-ID: References: <9fe46711-65ca-4818-b5d0-a16d2851d4b1@linux.dev> <20240321151757.GC777580@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: mqyhjznh51uekxtjqu9qfedrpnwrf9io X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DF08D40007 X-HE-Tag: 1711047103-379859 X-HE-Meta: U2FsdGVkX1+q3cWekn37nXXLl4+/VWtk7jTGsHMNzrWnVIMrEN7djgxx6bvC0/7eQL+f6SI6FxEL4/1GjOK5d0lGxu1nLUwqGVo87Scsj2PqyZtSyVSL4fHCgEaglxQ3puBEvW6pWvK3t9GKGPeuJICO5IgGCM7e/HYu6t8GE6S4cgOV2tNfs73BbDpR51mcq632Db0FI91olvB40oJOlILEXMQyl4nr6tGSSVUq/INaGU2L+kR6ftM2cRWP0vc6+i5ZPV6cXocaTb3S36mc5Dy3+i9dRm4UOr6jD9hm6RmAnW1O+Zt345gq9Lah1f+/IbVQXkgsVZOwDu+ZeBa9mzNafucF/DDwVphzRqtMJJM39HewEX5U/fCgrQ2l2uYDYC1xBUC6hqbNVcAKBGo/lq43sDyQDh6SBCDYFWtC35QFF7WKaKxof0i2b/nwFeiWJJArQuxymuYMKUql2x/fKNldU3t6aDrleQTX6LU+u6KJkdiPH47JQH7sROcEC6y8RDIX32LidIBpnpuk5rxHDtEOWu75/rOJIjTzFo0xYaBYeH9GEELb/hPGvDmBU4xAh9Hjecb+3BSNHoMeWjlUoW0RiG8uV3sjF5EF1VkHwUJVJ6AI4fuqLq4dURRdx8x0Sx0ERADuMIrF4GIxfvm9Fne+gZWkxfAvtBgc9rPtFvtGGXYK33Apn5kG3vWmLUvB6CDLPgWP3rJs+1zM4QqzeWJX69v1oW7PliBOG0kTHWdHWGSy1Kug3nQ7wcgJoXk0pMNw9OINiOsImKcw8w++5kjyA2rC0UhTMuKKxIaxaEJ7UdGbtlVMC0F1mUz5XUcmkLiLOqziiLMwwWWG3JNewDXjZsYAJWoDcYZNluKBU3vZxLIoMHJcGjMkUpasRI5AqK2TQorvAHw7n9rHAEZrxlPieFZJEFdGMmyO+Kj3bzCbpc6f8DcnU7+PSuNkWCYDq67CzFgoTNN0fwVHmTN oIo1kIBS 58jsNw5SbGBEY9vfuyN0nzl5VDE6tLC6/8A7kQFZmfjC2GKyuDc//E2rPvCq8kjBdtW5ZnrTqaBqdRZ2DgCTxeYrPtF8ULVr2oC0DrjTSIFhDTcZQasKIrBLropvtd7g6Q7Azo+z2Bc5gTKMNTCLdyUpxGqo7RNKO1tQq02cWPNVuavFkwd3BfdoJNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 01:35:50PM -0400, Johannes Weiner wrote: > On Thu, Mar 21, 2024 at 12:45 PM Kent Overstreet > wrote: > > On Thu, Mar 21, 2024 at 11:17:57AM -0400, Johannes Weiner wrote: > > > But the shrinker directly calls __swap_writepage(), which will submit > > > IO, and may even enter the fs. We definitely have to filter for that: > > > > Are you applying the fix? You're listed as maintainer > > Yeah, I'll send a proper fix to Andrew, who routes MM patches, later today. > > Do you want somebody in particular on the Reported-by? Jérôme Poulin