From: "Michal Koutný" <mkoutny@suse.com>
To: Qi Zheng <qi.zheng@linux.dev>, muchun.song@linux.dev
Cc: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
david@redhat.com, lorenzo.stoakes@oracle.com, ziy@nvidia.com,
harry.yoo@oracle.com, imran.f.khan@oracle.com,
kamalesh.babulal@oracle.com, axelrasmussen@google.com,
yuanchu@google.com, weixugc@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>,
Qi Zheng <zhengqi.arch@bytedance.com>
Subject: Re: [PATCH v1 25/26] mm: memcontrol: eliminate the problem of dying memory cgroup for LRU folios
Date: Fri, 14 Nov 2025 18:56:24 +0100 [thread overview]
Message-ID: <v22vajeyu2cj43euhuomfng27o5c6pvxcohijqmoefovbo6hx3@5yursykhzmxk> (raw)
In-Reply-To: <44fd54721dfa74941e65a82e03c23d9c0bff9feb.1761658311.git.zhengqi.arch@bytedance.com>
[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]
On Tue, Oct 28, 2025 at 09:58:38PM +0800, Qi Zheng <qi.zheng@linux.dev> wrote:
> From: Muchun Song <songmuchun@bytedance.com>
>
> Pagecache pages are charged at allocation time and hold a reference
> to the original memory cgroup until reclaimed. Depending on memory
> pressure, page sharing patterns between different cgroups and cgroup
> creation/destruction rates, many dying memory cgroups can be pinned
> by pagecache pages, reducing page reclaim efficiency and wasting
> memory. Converting LRU folios and most other raw memory cgroup pins
> to the object cgroup direction can fix this long-living problem.
>
> Finally, folio->memcg_data of LRU folios and kmem folios will always
> point to an object cgroup pointer. The folio->memcg_data of slab
> folios will point to an vector of object cgroups.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
> ---
> include/linux/memcontrol.h | 77 +++++----------
> mm/memcontrol-v1.c | 15 +--
> mm/memcontrol.c | 189 +++++++++++++++++++++++--------------
> 3 files changed, 150 insertions(+), 131 deletions(-)
(I know it's not only this patch but all the preceding ones, still)
thanks!
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
next prev parent reply other threads:[~2025-11-14 17:56 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 13:58 [PATCH v1 00/26] Eliminate Dying Memory Cgroup Qi Zheng
2025-10-28 13:58 ` [PATCH v1 01/26] mm: memcontrol: remove dead code of checking parent memory cgroup Qi Zheng
2025-11-07 1:40 ` Harry Yoo
2025-11-20 9:07 ` Chen Ridong
2025-10-28 13:58 ` [PATCH v1 02/26] mm: workingset: use folio_lruvec() in workingset_refault() Qi Zheng
2025-11-07 1:55 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 03/26] mm: rename unlock_page_lruvec_irq and its variants Qi Zheng
2025-11-07 2:03 ` Harry Yoo
2025-11-20 12:27 ` Chen Ridong
2025-10-28 13:58 ` [PATCH v1 04/26] mm: vmscan: refactor move_folios_to_lru() Qi Zheng
2025-11-07 5:11 ` Harry Yoo
2025-11-07 6:41 ` Qi Zheng
2025-11-07 13:20 ` Harry Yoo
2025-11-08 6:32 ` Shakeel Butt
2025-11-10 2:13 ` Harry Yoo
2025-11-10 4:30 ` Qi Zheng
2025-11-10 5:43 ` Harry Yoo
2025-11-10 6:11 ` Qi Zheng
2025-11-10 16:47 ` Shakeel Butt
2025-11-11 0:42 ` Harry Yoo
2025-11-11 3:04 ` Qi Zheng
2025-11-11 3:16 ` Harry Yoo
2025-11-11 3:23 ` Qi Zheng
2025-11-11 8:49 ` Sebastian Andrzej Siewior
2025-11-11 16:44 ` Shakeel Butt
2025-11-12 7:49 ` Sebastian Andrzej Siewior
2025-11-12 8:46 ` Harry Yoo
2025-11-12 8:54 ` Sebastian Andrzej Siewior
2025-11-12 15:45 ` Steven Rostedt
2025-11-11 3:17 ` Shakeel Butt
2025-11-11 3:24 ` Qi Zheng
2025-11-07 7:18 ` Sebastian Andrzej Siewior
2025-10-28 13:58 ` [PATCH v1 05/26] mm: memcontrol: allocate object cgroup for non-kmem case Qi Zheng
2025-11-17 8:02 ` Harry Yoo
2025-11-21 3:58 ` Chen Ridong
2025-11-21 8:17 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 06/26] mm: memcontrol: return root object cgroup for root memory cgroup Qi Zheng
2025-11-17 9:17 ` Harry Yoo
2025-11-17 9:41 ` Harry Yoo
2025-11-18 11:31 ` Qi Zheng
2025-11-18 11:28 ` Qi Zheng
2025-11-18 12:11 ` Qi Zheng
2025-11-19 7:24 ` Harry Yoo
2025-11-19 7:42 ` Qi Zheng
2025-11-18 12:12 ` Harry Yoo
2025-11-19 6:40 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 07/26] mm: memcontrol: prevent memory cgroup release in get_mem_cgroup_from_folio() Qi Zheng
2025-11-19 8:06 ` Harry Yoo
2025-11-20 13:32 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 08/26] buffer: prevent memory cgroup release in folio_alloc_buffers() Qi Zheng
2025-11-19 8:10 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 09/26] writeback: prevent memory cgroup release in writeback module Qi Zheng
2025-11-19 9:18 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 10/26] mm: memcontrol: prevent memory cgroup release in count_memcg_folio_events() Qi Zheng
2025-11-19 9:21 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 11/26] mm: page_io: prevent memory cgroup release in page_io module Qi Zheng
2025-11-19 9:26 ` Harry Yoo
2025-11-20 13:34 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 12/26] mm: migrate: prevent memory cgroup release in folio_migrate_mapping() Qi Zheng
2025-11-19 10:00 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 13/26] mm: mglru: prevent memory cgroup release in mglru Qi Zheng
2025-11-19 10:13 ` Harry Yoo
2025-11-20 13:39 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 14/26] mm: memcontrol: prevent memory cgroup release in mem_cgroup_swap_full() Qi Zheng
2025-11-20 7:51 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 15/26] mm: workingset: prevent memory cgroup release in lru_gen_eviction() Qi Zheng
2025-11-20 8:26 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 16/26] mm: thp: prevent memory cgroup release in folio_split_queue_lock{_irqsave}() Qi Zheng
2025-11-20 8:53 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 17/26] mm: workingset: prevent lruvec release in workingset_refault() Qi Zheng
2025-11-20 9:40 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 18/26] mm: zswap: prevent lruvec release in zswap_folio_swapin() Qi Zheng
2025-11-20 9:42 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 19/26] mm: swap: prevent lruvec release in swap module Qi Zheng
2025-11-20 9:52 ` Harry Yoo
2025-11-20 13:41 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 20/26] mm: workingset: prevent lruvec release in workingset_activation() Qi Zheng
2025-11-20 9:54 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 21/26] mm: memcontrol: prepare for reparenting LRU pages for lruvec lock Qi Zheng
2025-11-04 6:49 ` kernel test robot
2025-11-04 8:59 ` Qi Zheng
2025-11-21 3:15 ` Harry Yoo
2025-11-21 8:01 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 22/26] mm: vmscan: prepare for reparenting traditional LRU folios Qi Zheng
2025-11-21 10:11 ` Harry Yoo
2025-10-28 13:58 ` [PATCH v1 23/26] mm: vmscan: prepare for reparenting MGLRU folios Qi Zheng
2025-11-25 9:55 ` Harry Yoo
2025-11-26 2:44 ` Qi Zheng
2025-11-26 13:48 ` Harry Yoo
2025-11-27 3:48 ` Qi Zheng
2025-12-01 15:40 ` Qi Zheng
2025-12-01 21:50 ` Yuanchu Xie
2025-12-02 3:04 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 24/26] mm: memcontrol: refactor memcg_reparent_objcgs() Qi Zheng
2025-10-28 13:58 ` [PATCH v1 25/26] mm: memcontrol: eliminate the problem of dying memory cgroup for LRU folios Qi Zheng
2025-11-14 17:56 ` Michal Koutný [this message]
2025-11-20 11:56 ` Chen Ridong
2025-11-20 13:45 ` Qi Zheng
2025-10-28 13:58 ` [PATCH v1 26/26] mm: lru: add VM_WARN_ON_ONCE_FOLIO to lru maintenance helpers Qi Zheng
2025-10-28 20:58 ` [syzbot ci] Re: Eliminate Dying Memory Cgroup syzbot ci
2025-10-29 0:22 ` Harry Yoo
2025-10-29 0:25 ` syzbot ci
2025-10-29 3:12 ` Qi Zheng
2025-10-29 7:53 ` [PATCH v1 00/26] " Michal Hocko
2025-10-29 8:05 ` Qi Zheng
2025-10-31 10:35 ` Michal Hocko
2025-11-03 3:33 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v22vajeyu2cj43euhuomfng27o5c6pvxcohijqmoefovbo6hx3@5yursykhzmxk \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=cgroups@vger.kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=hughd@google.com \
--cc=imran.f.khan@oracle.com \
--cc=kamalesh.babulal@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=qi.zheng@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=songmuchun@bytedance.com \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox