From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6404CC02194 for ; Tue, 4 Feb 2025 00:47:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBB256B007B; Mon, 3 Feb 2025 19:47:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C44556B0083; Mon, 3 Feb 2025 19:47:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE5AB6B0085; Mon, 3 Feb 2025 19:47:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8FB2A6B007B for ; Mon, 3 Feb 2025 19:47:08 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2C1E5140609 for ; Tue, 4 Feb 2025 00:47:08 +0000 (UTC) X-FDA: 83080422936.06.678FEBA Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf21.hostedemail.com (Postfix) with ESMTP id 6BD201C0002 for ; Tue, 4 Feb 2025 00:47:06 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HfbB7FW6; spf=pass (imf21.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738630026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8DsDNf12aNGhGMAP9HmQLoKNK17L8iA6wkGRGPP11ic=; b=YQkbugRkm6zmWhMKXPv8J56zIrmh3y8GtFYz1Q3r6jZjSckR7kLT9jcRWF/gdqQzMJo606 1cWJtVjp94kF4BXg5L7GJOcyi+Ffucdw7eZjXtLAnaHoSLOGfksNU6dQkXT/z3NdKBpOF5 dtMESoBoL0Zba4T891hrFoL//qPbmWI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HfbB7FW6; spf=pass (imf21.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738630026; a=rsa-sha256; cv=none; b=HzlF0VbTg3rA4jSzgG/tqcVBT1eQ4Trw3Rq5Fpvcob/Z57an4cC7QslVuEiI7syrNX8F7B t+39A3OHDPi7K+tv3j7nmk5iunAXMSsGTdyA1NMbDqGBNsu3qqpW7xcGGPZzNdQU8bZaFF BBRyYg2TtTR0ok9sTh8cV8R7Je73J7I= Date: Mon, 3 Feb 2025 16:46:52 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738630020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8DsDNf12aNGhGMAP9HmQLoKNK17L8iA6wkGRGPP11ic=; b=HfbB7FW6N3oL+2xH0NdMVOVOm8cUGA4nyyOJn0f/3HU6nnid9Nmpl2OV/xc5Rq6A7ysCQo ElnDCsBg4rxDdSFWwZaRP/emC9vPcAcP8ElAMaK2Qmn79X15egvu7M2kFxyhaEk9QGi5/d PE7y/XHbScxWB5vInR7fnCWPpGI++iY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, rostedt@goodmis.org, peterz@infradead.org, yuzhao@google.com, minchan@google.com, souravpanda@google.com, pasha.tatashin@soleen.com, 00107082@163.com, quic_zhenhuah@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] alloc_tag: uninline code gated by mem_alloc_profiling_key in page allocator Message-ID: References: <20250201231803.2661189-1-surenb@google.com> <20250201231803.2661189-3-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250201231803.2661189-3-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6BD201C0002 X-Stat-Signature: ory5id3n5biccoebg85xb5dtxhsji3bg X-Rspam-User: X-HE-Tag: 1738630026-222700 X-HE-Meta: U2FsdGVkX1+rGoWYUT0KWJEDGBlPcVHUFuvAIkAGhUN4dy0dKszCKLhccz3T0Ss8eYlvImDcn9zGfMlGmcRHCsO8c8ptjPqPBJLmXENRe0BNaY8RUmChJqvXyfjRQMn9Xt5w6Q4nQPaCZqJ8tEfb7OvA6Th1a57ZUc2vabs85KugWzDGkhAgipRgjYN5Mty2/Fnj3cn+Ob/y1qWpIC3eQgEDG0LkNm6EXgNSIrr1cw0POKV5oS0cNSOqKrsMSruX78/ZFkWuVE7al8KbtXHIsuvtoQv2GcF2D1daT8Y1IS/Jzitlss5mJbIoyGTjFGdXcUa5yap+MWS0aTjqD5AR0n2jp5CWaNW0riRFTiqbsKZg0fAlGyzJGuXyhXqFqbE5G0i4CmNT9It7piLsA7Dq4AegG/fLpe4mR+plHLZYdlECL5hWwqtBrDFahijLsg4+A7px3qFK+qRVN/YaLQlXC3sZORf5EyaLO7src/GpsBWhmQCUpXFMezpOmwD4CN98FenrRLc1m777w1azUutLxkhmIULT+pi4qSHGVUpDo5l6PazstHZtt77BTaYih7GdNNmzGVZ781IQKo9WJl1n8xJmFbHFPtKsM3mh4tUcTYRZwUpiBNR1tQ0lBOwQMUM4xWXQXGtm3hh1KJtNudBkMwrisnN6wN+2Iq9OkkVqGg9Kx7fLYCgtHMTrbIx3C+KOMf8RP+7i8lYeJcdmpeDig+P3gBAZrViffrvHHhfVgWEatNkwDGmbu1WZ/vTaRoTJO1KU2EMgxUPuVooAqClGBEw2zjO0tnBvJ3XWSjHnEWxrgOPSGkHfE9jv+2Rtc/2OpDLKcKhO6+Ia9GyJdP2ROft3Ef6BjzmN/Qm0CxRVlji0744n/C+02tgS11SZThbyMB5TDA71Dm42kVYeeSD/wlLzQltTBiiLZ0LcxTxUgV1PPtYI58eBm0fIYBBQmrZ6mCWKo/lcno5BmVTyDTZ /NJnRlsy NvP8tOy9TKQhKgSfBcz6EbMG1VZTsLhtC0deDjySlUDAYDhfmopm6NwfKfNV2ua/FhyGIoXeLUSdyeHGiVrJN68WOgy3qtDHYXT7bTwFEcNMeM25t8rCzF93yYlYHE2R0c5gnNwQWBgSp7ZUWxqnPRo043qabdz+UwmCdLXoc1HimxnnsX+oRSo8OqA1WRhB5DFDvu/U0ZgbbQfyelHyKMLAkkhO8bpE9JY/+iED/Dgz2lPtbw+ccX1RjFSY5GtOdukToeQyKsv3NlN/piokSmvaQAAigDIO7LNcKuNg/5z80Q4qXYVukWCD+yI+CoRgDSgzyIGOE0W77eI9fi6yXyrlUIKijkkkBEgy5YV75qevE9piiz60/X7kDSHXovOU9Vaa8opT6zM65s+bkPf2yo3hJmQjasy4TjxG5l77pf6nttbTASYgt+rho1bZgjXW3uWKtq4/2bF0YEQ5QdXYSxcCj3K+s88ZPoh7iZSqfI7KXJbB4ck1PD6kSR5kLtvXFaLcDoMQ7F8oAo37I5hEBjpX3otMXr1bU/ot95xTffANnXUnO9bg2atxiQfFoO8nef0gAlAHGPTuWZE27in7PQf+zJhBfoZMtJUvoullDRoCxzT86ksezVKQPK67CvFNa1oGN83oDVoHu1ISvbFs5UEnay9UMepXSjpv6OumTKwZR+ToDCEVpszpUcG/kadIStMg3RdrD+hu7ub5kHWfsMgigZw5ObKSuyJ40PhIDCvAyqNVP0Kjl2z+4YG/jnyV7A/ZofMAaJNl06LtaiDib3TIX0YI9lzr8FeBntP8DYG4w9zhYuPD/f9zQ25u4W+G22XpLiCdVWeaD29GK7p5ZCraBXpcXEQcaTJdZbqhXHWsu/DxesM2ecDx0z8Nh/0X6CQVONwtMl7eAuWVbiknfLybv38SDiw3QYRPPWyZ9agC2Voix0WWQjaqyy9Z0o526+Q39fMQjeyWz5wAnglcRdmgmrHAh ndzdI/zp k9lZyFKLWLFFrdcK6XsUB65hEG1I9kIAH8lSrBNxXeBy2GO85o3uXyOmQ+m300Pb3mdBoYtDcz896bOmAQQT0n25WTu9JK1PrCAE15ZzUF1Soc4MZMyCnaZcyWXZS8XhDzhcuCVw2VA08GdyMSJ+7SMZXkOM04ek7IwUWgdTaWpda0bRA9Q4GHUQ53qk7CaYABGLydJy0tSI16UwPq/pIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 01, 2025 at 03:18:02PM -0800, Suren Baghdasaryan wrote: > When a sizable code section is protected by a disabled static key, that > code gets into the instruction cache even though it's not executed and > consumes the cache, increasing cache misses. This can be remedied by > moving such code into a separate uninlined function. > On a Pixel6 phone, page allocation profiling overhead measured with > CONFIG_MEM_ALLOC_PROFILING=y and profiling disabled is: > > baseline modified > Big core 4.93% 1.53% > Medium core 4.39% 1.41% > Little core 1.02% 0.36% > > This improvement comes at the expense of the configuration when profiling > gets enabled, since there is now an additional function call. The overhead > from this additional call on Pixel6 is: > > Big core 0.24% > Middle core 0.63% > Little core 1.1% > > However this is negligible when compared with the overall overhead of the > memory allocation profiling when it is enabled. > On x86 this patch does not make noticeable difference because the overhead > with mem_alloc_profiling_key disabled is much lower (under 1%) to start > with, so any improvement is less visible and hard to distinguish from the > noise. The overhead from additional call when profiling is enabled is also > within noise levels. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt One question: Is there any plan to enable MEM_ALLOC_PROFILING by default in future?