From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26FE6D1D483 for ; Thu, 8 Jan 2026 17:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9151E6B0093; Thu, 8 Jan 2026 12:29:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E27A6B0095; Thu, 8 Jan 2026 12:29:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CE426B0099; Thu, 8 Jan 2026 12:29:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6815D6B0093 for ; Thu, 8 Jan 2026 12:29:37 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1DDDE160236 for ; Thu, 8 Jan 2026 17:29:37 +0000 (UTC) X-FDA: 84309483594.30.57FE132 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id CB383A000F for ; Thu, 8 Jan 2026 17:29:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LKLHZsve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xtHDnGn+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LKLHZsve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xtHDnGn+; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1767893375; a=rsa-sha256; cv=none; b=g5F8+ZSlc1oouJugH1GjSy4P2C5LneYcHowHkO49255CPFWIbhueXXwo6SP9Hjl7OhmmYO aVSXfRo+6O20mnTFzyY0h0czIT/8h9BH5EBzon8KhqGzXLMdb7P/u7iQjGoXixuxfVMrVW IGGEvK6JTYFan1urvmVx/pNB0isyp1Y= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LKLHZsve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xtHDnGn+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LKLHZsve; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=xtHDnGn+; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1767893375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KSDIIOSgIHhRcbxi9/+AQB/pdbt9dql3OYIFgg84PNM=; b=0EfulTE/aNN9G9tF7u8xsGzcSIO1JvbiV4HVMEUa6e4A/hIb33+Ny5rtgQInnP42kVHGy1 O5lYrSwvblHP0N6q79s04C18fhYimZ7UQDeGPbdL1CqaLZOZ99PwGE4/BWKdR+KC6VrOya 63yfmXPO0VtluCjkxRctsrkDKC7vy6U= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8CF365CB97; Thu, 8 Jan 2026 17:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1767893373; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSDIIOSgIHhRcbxi9/+AQB/pdbt9dql3OYIFgg84PNM=; b=LKLHZsveRqERTai/L93RkI2K84owBSoPVDX4PWwQdZUPnhOhUJ/E2ghFkO7TB3qTeFK4In hyXqDZRKe3gPdTEa2pfQUJD9r7JhY2Gxy+QwNxGBAIUcG2XYPrlvQ2GUfH/jDBAwWN0nsL ohZmkjATm1kB2ioRc8QTK5suspy3fCU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1767893373; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSDIIOSgIHhRcbxi9/+AQB/pdbt9dql3OYIFgg84PNM=; b=xtHDnGn+2hOmpYwhvCDVTOBaoIs4Ao1kPHDaKuKZg7EQKiV5T+3VpS+c1qeMoAhoh6KcSh BVtoa2RrFhAbRIAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1767893373; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSDIIOSgIHhRcbxi9/+AQB/pdbt9dql3OYIFgg84PNM=; b=LKLHZsveRqERTai/L93RkI2K84owBSoPVDX4PWwQdZUPnhOhUJ/E2ghFkO7TB3qTeFK4In hyXqDZRKe3gPdTEa2pfQUJD9r7JhY2Gxy+QwNxGBAIUcG2XYPrlvQ2GUfH/jDBAwWN0nsL ohZmkjATm1kB2ioRc8QTK5suspy3fCU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1767893373; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KSDIIOSgIHhRcbxi9/+AQB/pdbt9dql3OYIFgg84PNM=; b=xtHDnGn+2hOmpYwhvCDVTOBaoIs4Ao1kPHDaKuKZg7EQKiV5T+3VpS+c1qeMoAhoh6KcSh BVtoa2RrFhAbRIAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 76B8A3EA63; Thu, 8 Jan 2026 17:29:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qCj6HH3pX2kzeAAAD6G6ig (envelope-from ); Thu, 08 Jan 2026 17:29:33 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 213A0A0B23; Thu, 8 Jan 2026 18:29:33 +0100 (CET) Date: Thu, 8 Jan 2026 18:29:33 +0100 From: Jan Kara To: Jeff Layton Cc: Luis de Bethencourt , Salah Triki , Nicolas Pitre , Christoph Hellwig , Jan Kara , Anders Larsen , Alexander Viro , Christian Brauner , David Sterba , Chris Mason , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , David Woodhouse , Richard Weinberger , Dave Kleikamp , Ryusuke Konishi , Viacheslav Dubeyko , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Amir Goldstein , Phillip Lougher , Carlos Maiolino , Hugh Dickins , Baolin Wang , Andrew Morton , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Chuck Lever , Alexander Aring , Andreas Gruenbacher , Jonathan Corbet , "Matthew Wilcox (Oracle)" , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Xiubo Li , Ilya Dryomov , Trond Myklebust , Anna Schumaker , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Hans de Goede , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, gfs2@lists.linux.dev, linux-doc@vger.kernel.org, v9fs@lists.linux.dev, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: Re: [PATCH 20/24] udf: add setlease file operation Message-ID: References: <20260108-setlease-6-20-v1-0-ea4dec9b67fa@kernel.org> <20260108-setlease-6-20-v1-20-ea4dec9b67fa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260108-setlease-6-20-v1-20-ea4dec9b67fa@kernel.org> X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: jjww7yazcstxg3tsoxa7w76a3skbtsjg X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CB383A000F X-HE-Tag: 1767893374-349889 X-HE-Meta: U2FsdGVkX19Put/uF3sggQR1NV4Ens6YUL5uzKp7a5p7YP4vBNsT6M+ow4A12b4FGq8BR88xnrzb3+ISgY7mdP5CFNvaYijlXvL6eYUZfFKQoU2r3Bhpm1Zam1WVQ1XAYWeT7re9f/BrrJ7PEZHMzwRwgDmcpIQH3l9/H327Y+F2RNw/a5aEKhli2HYnuC4bp1E9/2cA3b2WXO9UkpHorzMoztbAS8cZOrRSZmZqlXHPnL//EDWf7h/5XkkDnxIyRSWpTb73Id2d/ZDlJePUeoy2LNlm5+GlQfyp19FSBNFcQpDCFoA1EI4t0l9lqaUL1GvtZ93vNkuIOd0ZD5iGWlRsMKAaI+4itlB2y7UmvoabQFgQrDOIIaNdzu17Zv0E5WnApXr6/XLhRscFptOLogkGySMBAjENVHkrRDHRTIapgzcO25yWKMGq63DmxuU7jQpRV7/hfWDlIWov/rzXJZ6RNTgpg9T0mcjXOdsZ5UBm/3jl7xmBEiqN6N+MLvvMSMzEq6DWLtBB+TBDdYWqroN+/4B/G9J6LoMpsFXLDpqgQSXQhpv9KK9n7qrBeazrFD8DPeiy9biZjoZGqi/wQzL50FslnteqyBJBHJk35dqayOpMW9Yq0lHlg54FYatAJxJ+4JeXPmlHBCxGVInLnXwGhHRy0lUmoXN0fIMSOwtXuXUzr2Sw6BIGS8kwT6vr7FJaFlbywM1r6FntFndTjq0/lcJ0lGhA8SYphq3q9JjgMKjmzRCBJbh947W7D7WFhhwLh6RaecisqseOQU0kZt13epQ+RBP7LZ0qQpJpZ2MS2YhR40AV8WlF64OWwY+ofULaB6MwdrT07NaMoIDTSZw9BnliSRHO73MIkh1hFwo7cKuydVhg1QnQHzvsfXqki39D9Y7keNX10xzGDtxfJzt+C4JyJ/64SbASJEDHKvFDL29KY2DRsrex6TYRuAIiAOumjtel8MOzLWA9CAr IKLbg4Xe SzuhlJMlroxSj5XliX4e/fShh7xX/KfrMM/j6MZWEm/IMl5Am3+fbiWZko+Uc/Bt0khzRW3ggK1xmbVOuepxi0xulupPXVZtPhnzFPIQJLrQLl0XbUOg3do6wzeMJTswaNpu9G7Q3EwLTKZHs52NSHNRs28q7h9UsfQiQZtjFsgyEXp4SAKmK7em0klu6JxyQrFQ3ipnDWJM+/LzThLWb/Lo4nwarNAGSgCpuTiVV7xAslSDung+U7BLI4Epvh7YMz20VjoZ+9KLsUeLl96mBRtwBha27wyvhk/RsauJoWGVuB4zxpmp+AvB8xOxmwSomKfS0ohHGXTchvMt0d2BJ1BXY9j3o93OpmAOWi5Oy3EmPHSo2udjiDmxHOpOw3a9BSGhZV7bUlzTn0+4zxrSCnI6ss3HJMDocuUWAaB5IiUsRoBZR2oicSq9Epwz2mHhiSrpCJhd127qvNJ4U6fgKEfSvxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 08-01-26 12:13:15, Jeff Layton wrote: > Add the setlease file_operation pointing to generic_setlease to the udf > file_operations structures. A future patch will change the default > behavior to reject lease attempts with -EINVAL when there is no > setlease file operation defined. Add generic_setlease to retain the > ability to set leases on this filesystem. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/udf/dir.c | 2 ++ > fs/udf/file.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/fs/udf/dir.c b/fs/udf/dir.c > index 5023dfe191e8088b78396997a8915bf383f7a2d2..5bf75638f3520ecb3a0a2ade2279ab56787ecd11 100644 > --- a/fs/udf/dir.c > +++ b/fs/udf/dir.c > @@ -24,6 +24,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -157,4 +158,5 @@ const struct file_operations udf_dir_operations = { > .iterate_shared = udf_readdir, > .unlocked_ioctl = udf_ioctl, > .fsync = generic_file_fsync, > + .setlease = generic_setlease, > }; > diff --git a/fs/udf/file.c b/fs/udf/file.c > index 0d76c4f37b3e71ffe6a883a8d97a6c3038d2a01d..32ae7cfd72c549958b70824b449cf146f6750f44 100644 > --- a/fs/udf/file.c > +++ b/fs/udf/file.c > @@ -28,6 +28,7 @@ > #include /* memset */ > #include > #include > +#include > #include > #include > > @@ -208,6 +209,7 @@ const struct file_operations udf_file_operations = { > .splice_read = filemap_splice_read, > .splice_write = iter_file_splice_write, > .llseek = generic_file_llseek, > + .setlease = generic_setlease, > }; > > static int udf_setattr(struct mnt_idmap *idmap, struct dentry *dentry, > > -- > 2.52.0 > -- Jan Kara SUSE Labs, CR