From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org
Subject: Re: [PATCH] maple_tree: root node could be handled by !p_slot too
Date: Mon, 14 Oct 2024 21:13:02 -0400 [thread overview]
Message-ID: <uxqa3gkfc6un45tiqesbytxdatq5jw3nb6y4shmkwclls6wtro@ycvuvsddag2j> (raw)
In-Reply-To: <20240913063128.27391-1-richard.weiyang@gmail.com>
* Wei Yang <richard.weiyang@gmail.com> [240913 02:31]:
> For a root node, mte_parent_slot() return 0, this exactly fits the
> following !p_slot check.
>
> So we can remove the special handling for root node.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> ---
> lib/maple_tree.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 85bd651e7770..b5dde94cc7a9 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -2100,9 +2100,7 @@ static inline bool mas_prev_sibling(struct ma_state *mas)
> {
> unsigned int p_slot = mte_parent_slot(mas->node);
>
> - if (mte_is_root(mas->node))
> - return false;
> -
> + /* For root node, p_slot is set to 0 by mte_parent_slot(). */
> if (!p_slot)
> return false;
>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-10-15 1:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 6:31 Wei Yang
2024-09-13 14:17 ` Liam R. Howlett
2024-10-13 14:41 ` Wei Yang
2024-10-14 2:06 ` Liam R. Howlett
2024-10-14 2:49 ` Wei Yang
2024-10-15 1:13 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uxqa3gkfc6un45tiqesbytxdatq5jw3nb6y4shmkwclls6wtro@ycvuvsddag2j \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox