From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E1FC5478C for ; Tue, 27 Feb 2024 08:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B72E6B01AE; Tue, 27 Feb 2024 03:44:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 767F36B01B1; Tue, 27 Feb 2024 03:44:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E0A06B01B3; Tue, 27 Feb 2024 03:44:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4BECB6B01AE for ; Tue, 27 Feb 2024 03:44:58 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 185CE1A05CF for ; Tue, 27 Feb 2024 08:44:58 +0000 (UTC) X-FDA: 81836948676.18.79A200D Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf08.hostedemail.com (Postfix) with ESMTP id 13E8416000B for ; Tue, 27 Feb 2024 08:44:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=vhUfu7Uk; spf=pass (imf08.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709023496; a=rsa-sha256; cv=none; b=l/q08Jpkzo8fxZ0Wjncs5ZbCoHEC6uzOqZ27j+7Uj+E+2LugbuuHeW612nlzWVRdZwKk0V kBp54cOIOrSD1SUQArU8IfXDmafATwKG9y48xdDtySBZL9NhibCslvCMcJGRlY2jv84i9Y UkK2ekcMeUcoTTpSD3GEZQ05xOFCpPM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=vhUfu7Uk; spf=pass (imf08.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709023496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=28mM1L7VoPpQ2Bxti5OxSfSjhM5DSY0iAhB3xAG9DsE=; b=ax2yaG/csa+rOEs5vTBt6ZqKhtZBgTdAsqeyGMOF6YtAS2Tzu6YWq4hAzwquYg1yj20Hst aBYW/1lfRssBG0iOT2T0s34e/HyjR1VJO3R410Tg1GFM5q1pZnrhhlpAh4WASRwUfKZx29 m+GaysxarzoHw5z7u2KedkNasRzESRU= Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4TkWJL6wn2z9t0M; Tue, 27 Feb 2024 09:44:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1709023491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=28mM1L7VoPpQ2Bxti5OxSfSjhM5DSY0iAhB3xAG9DsE=; b=vhUfu7Ukkzc0sJ3NR4BGYejf5reNNcHuMppL3CH2U9H7P/14zED8PWIe58sugXnGExZkI8 yWE9fwlD0rlXjqEW4HgHb1ItUC84CCTD2HKudIo/vn1WQs2xO4gDIQVTcUXPpW4nwpdQY6 RiKmh/OvoFKM7M0FnU/Nyw4HAGNa4lHRCiDRD4mRBdQNNRCNX1q2B0vaSi8nehFSqKLoWr kScyJxMdKaa0STuFn5cqUJDhIdUsjXjV2q/qDojeo8kXV6/WwDgUc7JXWz4FlO2bAQWBHe BFikc0eFXVid62NyhvTPH4xx3QiyPOSeWygvw5gXSH9O8iqdS9vtJ4DH/jzjUA== Date: Tue, 27 Feb 2024 09:44:46 +0100 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 12/13] xfs: make the calculation generic in xfs_sb_validate_fsb_count() Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-13-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 13E8416000B X-Stat-Signature: kj8qzuo59bth97xsaxkmrxw8pjomofji X-Rspam-User: X-HE-Tag: 1709023495-658726 X-HE-Meta: U2FsdGVkX19269gbZlI5sV2jXRc2PPecWdQJkGCA05Jp+9fP566UvApwllqjPmDR4flHvn5AS8gyKdgU2XRB+ud8P/DkRifHV3ioL7BwvrfsYn0+ZJHCjdb89PCRRQHWY7He74mow/Cf1CXl1erj6edwDTfoluOGWp4bVv13hQt+Qy7ryid8csuelgPeJt+UBCGKBDxjwEEWESjsC7tIlqZiV1i+6VeBHNiwfNSOXSNVqHo7F/dLCfh6B+rzywpvPhFczBZZU+U6GKnXG1ArJdDNL2A1GGNEvT04HUA7J0Dk1y3TD+LW5TgseGs397FE+4SfKWhLRtHwIDi8fgXW5NEvPfwNZDzRUiF9H2CA1XHTfXNHiA5kNznAEhteeMkCSLBkFMF1MNtvDFaE4aKM4FEasPAYDEst46+oMMMm9uxqGh9W/yUnNWoz8g4g/vNEPdn+SpeKv+xIP2t6rWbdbar1huMmrt4eoJKe7wYf9m5XU+GBF6jhDPNPV9iqxX3+Jsliv28a6XfMiknkHPDW5aVU3vdehAajxN4nxpaYThEDVxnQhFob/MXtZs4ypVPiRM0mZUATHbVHKQMUrjXnmlmzwiAQosDlSfpsNBbJDT5lqO7m51KpTPcd6o3Xto5KCn29vzo94566gPCRNyzbIQ0F3wWhHYhC+fC279Gcjqz7agxc2C7S3pVf2zYbx5W2+leQ3rvJaQvKZZesaj3tgzOvM3obdV9VDotkLskyYKdTv1/JpVe0E/KtJz+3wguZBPM0cmbMKBQCKXPBK0jLsTy2hOnJgHd7xWAb6IGYyHVT0GVh+i7ojOMtOHtdpTs7Tv3SP1QNlLEDxcZsW+3KfNZjWpd0KtS98DAqx2iaRabVunTQbOGcMFGYBs9YEOxOpjMnZ9jIhO8yYj7SnbDDv+7w+vW5A0q4oqHMKJkkhZ+Rap89ddcLYOUoqyMwq488sTGefTRrLfshnWWiEPC 2/zoh6qA DHxWqOjbeWhdV0fsIG1cb7DigjkwCWkjIHnolCJyYkCAE3nQnboeVLFTsQJE+vzFp/ktEFgYVnfJ12/7kEu4G59VxR5iyaf5sYKoliBmk/ha8gATl7Kb64EhU1uJQ8pMJqr3N2gnQkLbaLXhIajZeGA67O6ptVKpko55U+VdLTea7z5NFJAw7ncAQnGcOed/bI/LatiF4byvFMSEQJWnySsfJRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000413, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 26, 2024 at 01:21:56PM +0000, Matthew Wilcox wrote: > On Mon, Feb 26, 2024 at 10:49:35AM +0100, Pankaj Raghav (Samsung) wrote: > > + if (check_mul_overflow(nblocks, (1 << sbp->sb_blocklog), &bytes)) > > Why would you not use check_shl_overflow()? This looks better than check_mul_overflow. I will use this in the next version. > > > + return -EFBIG; > > + > > + mapping_count = bytes >> PAGE_SHIFT; > > /* Limited by ULONG_MAX of page cache index */ > > - if (nblocks >> (PAGE_SHIFT - sbp->sb_blocklog) > ULONG_MAX) > > + if (mapping_count > ULONG_MAX) > > return -EFBIG; > > return 0; > > } > > -- > > 2.43.0 > >