From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2FFC27C53 for ; Wed, 12 Jun 2024 18:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BB916B00A4; Wed, 12 Jun 2024 14:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76ACC6B00A5; Wed, 12 Jun 2024 14:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 634036B00A6; Wed, 12 Jun 2024 14:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4550D6B00A4 for ; Wed, 12 Jun 2024 14:50:26 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E71321218D0 for ; Wed, 12 Jun 2024 18:50:25 +0000 (UTC) X-FDA: 82223127210.11.056BF48 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 552CA140018 for ; Wed, 12 Jun 2024 18:50:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cIShlX4O; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718218223; a=rsa-sha256; cv=none; b=iiOR+tfJ9XxtAvjiNKwlR40iYTf7zjjk8UO7ZkRO5OZ8eWE71imFoED3WDhUJ3jdNtSMwq yLI0SjKEysYqiIkbREdIDaskm9ReRCXYD86kgleGTfhLk47/LR0olOlk+BWEd7rMvAxdTa UpLxuLhUjCEF8C6WItgDn7tmBbGJMpE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cIShlX4O; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718218223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dAHOcp7dGNkmdIJVuztV1Y8vonlu6XpX0HLfB7078Ao=; b=U6DOZA5kDEW/zOw5hQYUdXAV0h7bu7hnZNpho3H4TLiqWrC23Ja91/+kxUpnZb1+PFLKgF aTMAGKlLi0YQH2xldCJBM6O8vLXypyOiDrzYkC2EWGo5IjCSZw+mt23+sMo+qSEmDSLNjb 45khazkTFWGAiwHN5QrB6zzRkl40RT4= X-Envelope-To: pasha.tatashin@soleen.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718218220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dAHOcp7dGNkmdIJVuztV1Y8vonlu6XpX0HLfB7078Ao=; b=cIShlX4OOzhvDdrRaYtiTXEPRe4xMyDNEhViio/6YFoVpTThDaYaWuJGHVt5ljPhEVJ+pY h+1Qw/KgNNdmw9OOr9CPhhrQK2oxtZ/3Ga9+c9TgA5kBhtpworD0vFjVPkLnHxy1wa5WQs 9wxrmW8ucvCEA/+dJkw1CY+gN5ZL6Uw= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: jpoimboe@kernel.org X-Envelope-To: kent.overstreet@linux.dev X-Envelope-To: peterz@infradead.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: cerasuolodomenico@gmail.com X-Envelope-To: surenb@google.com X-Envelope-To: lizhijian@fujitsu.com X-Envelope-To: willy@infradead.org X-Envelope-To: vbabka@suse.cz X-Envelope-To: ziy@nvidia.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linux-mm@kvack.org Date: Wed, 12 Jun 2024 11:50:15 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Pasha Tatashin Cc: akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram Message-ID: References: <20240530170259.852088-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 552CA140018 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 7f33uf7fuqn377jdnwh4gg9pnaem989q X-HE-Tag: 1718218223-426764 X-HE-Meta: U2FsdGVkX18Mq8Y4nlgGqXnz52915TQvjcdGhFFRVSQdbx3yFMxEawt/PBvid6dGGinX/feNHP+R8uMUD/5HDqM4eVALdenWPuNVzhOicqkj2pn0IgLLs90nupQEWV+DcPSY4fj2Hb21qUUjSezPxUuwzZb8dKl9TuRfdw7BGGtcsc06Oxg+8NiQVtc+XxSpWXYnYM6w65Ma2Sn5pcYjtCkDmDWc/IUS9CBYml3Z3A5mm5YNRrNAftfnZdqXdy3isiLCDFMjNNJ5fDj4JMd9bJHSWNqGow3EB4/C7EjS3YSmFsG8NJmzhfPv3nedrQiP4Et1P4qJHihXkQNxn2adWENZweDR2pRroGmCd6ADF56qa9hzhaG/gd2TrWQ6eTzVRheITFV4UUZOjH0Gxai5oEPpleSHv/k4KGUIy0XBY9jkDPbQq9w8HU9njlnqtN11Ng2Kz6rtzei/uxGFAi9kYK2BazhM7W6vzEjtjOpzAz879KRo1YcOaox/Zq3igVAeneb59Znxtruy8Mc8nKvo2ZQ/PVxkSIS4a9v5VxDRHFKn2nRULjvDbeyKfTaJDJNOFA/DqN3h7ojKVlHz1Gf3FIpeveZo1fx3gDXkMTFNVMbT7XyBtl2yPRbCJYDVieVVHL03I1pB/CnWwH3t3X52YyKRp8O4Me10qoxn5iyp88/JVK4H1jvChXEAUcyIPsdw6pINu2ujrX9JTsF9Vzm59Dl7/AjDs6Qh9FfkrK2AAf7/dkQuIaRra23P8v8Pa38yqTKp+mscYNkK2d/IAjACStd+cKDfqvpHxbDmRiuXU0PCW3IB73VWehv816NPIIOpZD+0DSvrAsiY/jTDzE6wxy0LHKO6uUBn1v9f6HJW0bWMEn6Y0Lo3id8bJB+GhU2v6ogw9XldLoDIbMroUlBG9hMfYfQ8rhvLdbnHKWrDp3rgd6w5KQT9CjDour6ql2IzeS7erPAvje65mdlKMfi tD+8zePC dbPUZC6X8FXhz1SYM8HhLBkRZHSrPtntAFEEPaOsSHJF+9rcI2FnL7dGbzqotjhIofof4ZbdQVaTyK/E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Pasha, I think you might have missed the questions I had below. Your response would really be appreciated. On Fri, May 31, 2024 at 03:42:34PM GMT, Shakeel Butt wrote: > On Thu, May 30, 2024 at 08:14:17PM GMT, Pasha Tatashin wrote: > > Hi Shakeel, > > > > > Couple of questions: > > > > > > 1. In future with your on-demand kstack allocation feature, will these > > > metrics still be useful? (I think so but I want to know your take) > > > > It depends on how on-demand allocation is implemented. On hardware > > that supports faults on kernel stacks, > > Which hardware supports faults on kernel stacks and which do not? > > > we will have other metrics that > > show the total number of pages allocated for stacks. > > Don't we already have a metric for that i.e. KernelStack in meminfo > which is in kB unit? > > One more question: Is there any concern in making > CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default > kernels instead of just debug kernels? > > thanks, > Shakeel >