From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99CFCC02193 for ; Fri, 31 Jan 2025 00:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEBE428028D; Thu, 30 Jan 2025 19:14:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA61A28028B; Thu, 30 Jan 2025 19:14:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A23028028D; Thu, 30 Jan 2025 19:14:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 694C828028B for ; Thu, 30 Jan 2025 19:14:17 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E97508047F for ; Fri, 31 Jan 2025 00:14:16 +0000 (UTC) X-FDA: 83065824912.18.E9B01A4 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2061.outbound.protection.outlook.com [40.107.236.61]) by imf20.hostedemail.com (Postfix) with ESMTP id 278AC1C0013 for ; Fri, 31 Jan 2025 00:14:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YL1Tx9re; spf=pass (imf20.hostedemail.com: domain of apopple@nvidia.com designates 40.107.236.61 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738282454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0H9XqPoeWghVWbr6WyBez6/QTKW/JC424R/4Da4sPsI=; b=5sGhdL7wK739IaJMgHFKXxE6FgPKaEXId8X0bQoIpdVHDIZU+9X98mhyMV1pmrPWZKt9s1 dy41Slor0PIaeE1nDkhjk+tWRm+96FidW5KTJCgMBBhtWuFKxVyj6fxWJDGbNhzUJGcQeA d5upIYGNzG+2Rnc3uq62Vxy1vz98wtM= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YL1Tx9re; spf=pass (imf20.hostedemail.com: domain of apopple@nvidia.com designates 40.107.236.61 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738282454; a=rsa-sha256; cv=pass; b=msmMrOOUpsaFkcRrOPkXVVf2NzRd51XNxeGgE8BtB7XPt8h7bGcpt3VfzDSMMspmBhxWlE 5HK59Be8BbqJAt8Oh3U2D5QhTYTp1Mz+VjdNns4/xb/gbfKVVl+N1u8d5L+QLGod9QHAWn cPldBGnSy8LxsFKeUQukQt0aLixP6Ec= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u1ZyAQOzACdF/9e23rD/uVgmRfHmdLn0TzMvQx5BQbLSZ0tJiQopMeLAhKbptOXDeFEJU6h0GKMoEQ6SUwHx0qThvkTf2Vas/X3FFR+ILVeOCEzeumA/0irhARjSDgnjPcYKmabIiCnvp87PkPw/eU2MoEBiJtfInG7tghyCBTWy/64PCz/foL085Ypsl8cDFqlcbJsf3Y/FTo3D6Jj893778KEVJQ6rgbz4cow8QOPwd2U9IkCC2lIwvgQuM3Wv9uCjk+6FJMKygJ8DYMEPXDtFb4B0rD+6s3x7SuTT5WlLa9FN98WimeIovXW6xI/mIEfsr8IIssGgWCfgGA+RxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0H9XqPoeWghVWbr6WyBez6/QTKW/JC424R/4Da4sPsI=; b=T8gq60cBPisr+d8ckMJ1a18PnME+wYTgDBGoQmnenn6y7T89jEjTVQemg34Ima1/UjR57UM7/sLQkdorEyhcpJybO6qhvOeDCKvuvVU/fHCBNA93B6S6e3Cs5V6Zii+39IwQA/WTH5fFZj81d3OU1hlYUl3E0/e63Fp+CMmrFSACYd4Dc/As4Pb3WD29wx1Uw9/dtooP7cW5qrTsJFqM4xoPPM4qAukMm6mt47Wh+AS3yG1fMLAyakf/EeSPweDJ7vvIq6+TS92FdkcMJR4uJutsNC1n+4ilvIfFYQj7EQInDLP13A0IlLzDksUwyBcO+vS7Fp44OkYy9xg2E1Qq6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0H9XqPoeWghVWbr6WyBez6/QTKW/JC424R/4Da4sPsI=; b=YL1Tx9re7jr1/hkQOnSfU7jSQTrKjilX7pJslkQqfq3V2o4OMNe5K9b+wb/6moR3UPzYoQMX2PhE8HeBq6glhqZmLPcMTc0gu9GQuWxLMNM44qoPnD0PBeGBgQLvwuTbHJ/tio8cDbs4dtDKIr6oecvvh5sZIBBuNA1+wZW+2my6pGsG0GWomZW3kDcNuhzBdVFLN+Ss2ioV9g/t5LOPstt8ILIMbAeT3fNsZ83xsi2gnZCmq4bLNit4y6D8p291rQi2aWSAoxS5mwshZZ11TryvYisNTFWAquRfN+15zAVTYBsp1+t0b+HdE8UbgMYg0I7ypHQE6brS67zFP+crvA== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by DS7PR12MB6144.namprd12.prod.outlook.com (2603:10b6:8:98::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.18; Fri, 31 Jan 2025 00:14:11 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%7]) with mapi id 15.20.8398.017; Fri, 31 Jan 2025 00:14:11 +0000 Date: Fri, 31 Jan 2025 11:14:06 +1100 From: Alistair Popple To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Jason Gunthorpe Subject: Re: [PATCH v1 4/4] mm/memory: document restore_exclusive_pte() Message-ID: References: <20250129115803.2084769-1-david@redhat.com> <20250129115803.2084769-5-david@redhat.com> <7vejbjs7btkof4iguvn3nqvozxqpnzbymxbumd7pant4zi4ac4@3ozuzfzsm5tp> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SYYP282CA0005.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:b4::15) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|DS7PR12MB6144:EE_ X-MS-Office365-Filtering-Correlation-Id: 9c3f5606-4761-45a7-fbdd-08dd418c2fb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6WdmNBnEGOH1D7FefbO+MLQ5/7Q958P7OIgrLT4zmamZJdtrf0OXVO4ElBPt?= =?us-ascii?Q?/ay90ELX1xuTZ2BR36H5+wOmPZ6r1qdJ6x+5rQM6nyQ7fkX+s0qgl9d02ECZ?= =?us-ascii?Q?g21eQ+kHq1+cRqnepYWq7UoVpdIAdpNPJzGF3ReraiZhWsDAPdwau/3YE2+L?= =?us-ascii?Q?2MqauLTH1z5Si66Ag7pP3JNbpSudV4Y5fJoxxF96DUQ82QVSaK2Z0UBaM1oy?= =?us-ascii?Q?WsFu92Q5ysLjpXORjpXTz1wFhLpWvJWmEx5O2TT/y3nIAdoRiSTJKkqIoxJJ?= =?us-ascii?Q?cN1XsEhVLqvbHYRm+lXjZ5wJsqOiabjzDnUs4mri+xlmVphY1FoxuviVmmja?= =?us-ascii?Q?t+sx7U/EHVCiy9YB8sd1kjmQdvyTvlJ3Y6mec7vtV4fgV5OJRguwahwAwKXh?= =?us-ascii?Q?f8UdnlYq4xyxtp70/meuLTj2/QD+hw2ECDsS7eNamoURGu5b53Z+vslbMVFM?= =?us-ascii?Q?uA7uC0TGDbkQOumc4Z022hyrNjRvEM/vOwLvolRE7u/+OCmNcuAB+qaHANw3?= =?us-ascii?Q?6haB9NmswyGJXHFch+RjwgKn/zfwl7/0JMjtph0bIRaRnMHcwyXXUlPNvH6s?= =?us-ascii?Q?YZk3p+Q+fkU8l+54PVsmbCQj8ijNAmWkY36bqeypSbHp/FK3ekH7p//oMP+u?= =?us-ascii?Q?kiagvYo+f9ZWs3VnzchhTc+hQdNww1TFW6711bU7kCPOwMk7qU4BaOPPhhHo?= =?us-ascii?Q?xlRNE/uUlmiHdxfokQFA1HjyE5AaEFbw0Ko/BZ176fHXRt1IsG6xWN1XhsJ7?= =?us-ascii?Q?ibLvWbBg5727Its0lHNYzFJKS/LE/entkWBSXDcimzWVYf1KwO2XBJgxGqZg?= =?us-ascii?Q?2alhPGGV/iTc2CZcyAa11Du5boMwEdXfZAYk2IgpKVdTHfsX5H5Upqsod0AB?= =?us-ascii?Q?EUbBOPvQCIBX0qntQ6LyPHX4hXW6Z/GIRh+xtwYLxdd0Pm2qGfb8uJdOqbdp?= =?us-ascii?Q?Pn3kRQx9CSiWSWO3za3Nr2oAgJToRb/+Yh2Dq9sljX+/hudVRa7lKH0Gw1nw?= =?us-ascii?Q?3Rn08rLMBGNmDw75GbatHBX68GH1teOktw52X+z324s1r0+IOPfuL93ufq7D?= =?us-ascii?Q?zRSXhjNPXJGx92/vqSMKOhJf8fBCrVSjM4jlJbjzuxbgT4M0XwCVBnXz+0Md?= =?us-ascii?Q?VxZy7ngKJQjBXiNRV6r3eHnhF0pp5XBT513Lx6//Pw1u3l/GyaLhzMD/pcqo?= =?us-ascii?Q?tTVo1KaQ1FLgstkq5EVN9R+J56syzusNNTdAl8AJSSzPqxyptbP8ITblZizr?= =?us-ascii?Q?9oU/i7yoBmc+YMIPAaQrY8QiSSdKBPW35r4ImwP9XV4aG2cF1Kt/Ny7xTQrZ?= =?us-ascii?Q?InqGrM0Urqj6xBLEY8+6rFoqzIsp+cF4hk7gU8mzlAUCRrgG95+K44/uTH12?= =?us-ascii?Q?tqRlus7yT04Qea48qdZtorZ2smPs?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OE6dtCC/VBGV8J4iMHBYoOjSJ1QY4tMJY4bO2vCqRXqSbotlv+RUcw3ep9aj?= =?us-ascii?Q?/YEWqoMUVnT2n0Hgi28yK0/+dRr5+3JSAhmtQz11B8Y429s7TB1nygrkp8K4?= =?us-ascii?Q?MnIPNWJxu87ZR8l8QN41x315qvPpktZ5aFfDEGjso7SmOU9NL9QqEeN/nrzB?= =?us-ascii?Q?RFdxx706oSyxEvZz3EHUyGfQfv0DNhLGTddwwE/kWUdxisJg+J75EF/HBQBb?= =?us-ascii?Q?/o5hTJR2269QfoN6dNmkjrIRCmRMlHq/iQC7A+Fh2w2I9IHjr/iLOoRPni8s?= =?us-ascii?Q?n4EX51bIAJVbtyfAVtURVzyfZXHEqqKNyPMyAccdph+PNs+7YW6NjIPrNQoM?= =?us-ascii?Q?1Y5HBmIQJ1qsEwvjczC33mml8ucMQ+pKdQIR98jD6aFDPhLfMhI5suTeTxqM?= =?us-ascii?Q?LPgS94DFu++aRmmUUUpCaBzzviPja5IEJi+WoOL6HfU2qWShNjsZs9EsaEmP?= =?us-ascii?Q?0zb0iOt1Pwb2pGEpH4Nc6kzkmeSuNxhfm26HUD9LoC/LruMtWHBdYie7wHA1?= =?us-ascii?Q?7ovPreb1U61e07hOjund2cRKiY4JipWk75vggMudeHP5XWBV+FbEi1vJs1MS?= =?us-ascii?Q?11FCRQcUG9kbVMTIr8a38vxz/bVvBeg1E3LWPBye482dbHTxNpXIF8LTel4J?= =?us-ascii?Q?0sX4UZ6zVVBxF1wEOQSNfcauMbHGGjFydjUYCwh20+JhvHiTiwvNtbpo09Ei?= =?us-ascii?Q?QyNmG4m6ieh3MpQqC1YMU9qZg4SUP21LEBWf+8uTfXQhqzzeZwANuI/epGig?= =?us-ascii?Q?51HCI7JGv9OqsnvBLcR5YtuW0TN6pauMWy5a7h8m4qIadNa9FeS358Up7zE8?= =?us-ascii?Q?vFQR2d3UV4C8/SPeq/T5z9bcJhviEG8Y1aHomwofh84h3K2/VOAoajh5yoP1?= =?us-ascii?Q?6ad9J3/J0vrke2HjdEt4v5S2zKX3SaqXZ8gwOh/dwtl59jPYxIVivr9fpFo8?= =?us-ascii?Q?oITi4jN0ZJSo9xzZ4niw7l1PzugJW2IDgoBZSP8kBNOmk1R5IzUlPM1Qi6G6?= =?us-ascii?Q?hBh7/myO5SvwA3v53PjTMmywpeqeogLYuJ6fVz0PIYQhturVdlpfUk9GPEC6?= =?us-ascii?Q?dBYzI9C3ze4U6fyYOCuf1WVe46IbkXzQ9WwTFLHWKg0+Ln5oJesNZtUMY1gb?= =?us-ascii?Q?RGVIxwQPTws25vBvxa3BEeZQ57rAlQP1VNDLc4AXPSz1yX9RX34pCcQLfI4k?= =?us-ascii?Q?Jc3atTnm5lI+gEH/qqIGTCWDVkuBj/0QHFdAYlCaodieWDQ3ugOtpXthr31D?= =?us-ascii?Q?3Lq8AACYXV8VXYRzy1RtQlYGVHzNhsHwYV9MHOV3AWH2JlyCwBtDsQUYMw9H?= =?us-ascii?Q?aXLVm0oHVza3Fcn9HGcrH990riUiJj9kzuqhQpAqIO3+3/n6QrlQuXRcVa69?= =?us-ascii?Q?t9WIt0+vHKWEK+xzHgRXL3Ws3Otuye3C6JShQcSe6UJWYGn1Uw5eNmqbFEtL?= =?us-ascii?Q?snIi8rym+BL8SIT8ouw5ZgBkMGXImHWuTB+m08Q4tpCTfUUPF1mJMvdqA6xR?= =?us-ascii?Q?wZJIZlpV+4jWH2He3evbz2Qmlrbm5KGl+UUMkGHSMVtpuPgWqChbfUYg5WLi?= =?us-ascii?Q?S5I4ts9EIxo+AVBlsT+tbmDOzVOFpb3PNbOIyPU2?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c3f5606-4761-45a7-fbdd-08dd418c2fb0 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2025 00:14:11.1232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wHi1LxoZ3o57ZHrHTUas86KSZQOHh5B7ZN4EaQzR3yfIJ7ncHFyU2JHpphr49WbMNaxTimQPi70ArC91nMAMew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6144 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 278AC1C0013 X-Stat-Signature: kzjrpok6fp19kd6k79ec9ok9t3nfaxex X-Rspam-User: X-HE-Tag: 1738282453-237604 X-HE-Meta: U2FsdGVkX1/cHmERkSamkvj6eUjZ+HiCTmR8DEYKMTgl8siw3WfjbpeWmqa7CyfSjsjSB8z2wviNGcHuJMqbOuh4I6elwcpfq+3jBHcOrsftXSWCFWHx4tjrX15bgmGIvyNzIEtxvlmidgRGdriLne12sVqPpLPIP2gP9ViV2xLZSb2oxU3m0uWbsXatIVrKlCyiH2s7FcDf5DHSzhIgjzkbgZiD+vf+ZgI7A+3RcyX2M/VzKPFNR4hALWjiK0dRTGQvP7stn+/6Qbxp6LjqepZgwdCrx3jyahHPEGTjVUgHDKFrowfeKGXNzQPJo1SK3Ydg0+c7NaUHWx1bNVt7qiRUpe9fIdzbeo2M328/xgbPRq7AylnsIa7ZhqySWFl35Adpr/LhB6CZz5ZVxZyUT9soRxy6B9KaLovprBVn752s9+LKMvF8qfX5YKFbQ6YrLUffTUuvWPeJ7525V1uSvnNqv7itpxVU++5zun3FFzLJ4rLm4lIl9qcr+PaIy9ybpFmb8PPMhPfP6MB1Wid14ovMb+f9c2geO5u2JKNq9LMSu8wAsHU/M33His1K9tSECXRrFaSmV7PGms9bMc+jZyXCNGvqRbOrblIqEOUb3ExnPVEsQoYGv5cVrmCVfKhEXWnKZ5F66LTjOArfh5KRZDSicbUCk7JGqwLth7/bACYOqKM8/huxvVM504a4M0uD4h7kWAz1u/5C/Ikt4VQLwxCKDupXMwch6LryyGJGa8VgcygUO1LbpRV7YQUCbJDDBc05mU1YjEJQVALUFXnJyaK2p84+T0uqpnQ2u5KBJVT0NqEyNQ26dlIKQ3K1Nnfh/3vhitc/yd+XDR4cD8+FqWaQcZCBmMIaTobZe9DNn45f5ZVPYVTmNRVjB3EQvewYmnL4aVG4Q4d1vNG2j6kmE2n585mCp/n3ulOVtgpBacwkxlTyIaIUy1B8cVeTX0+BW4PHf05R4HTT0MdAXjI EdpSXslc EXadTtzbI/5S84e9xhpVxYjRE4E5zC4LeabWMY6AkFPrtODMaML7EwuKeD7sKLec+ZjOOKrrNp1IbxDOfZ0mzb4Nxu8P1EvQ6vjKix8zZWReEBDm7p5FEncCaA4gYNExSwH1s3zXT1onvE+1GLfgmiETgj7C2h3V6qeX2L8dy+6uWERChwav2fcdOuitsu8QaAPd+VD7CTgvjz1Sh6uWoflkNlZeC/745LX9gg39f3Xk9oQUuBf3Nn9tqL+tPmvwDph5E7LBI/3bMVxx8e8l7qNv7Z0lokkynjSh1ibiq2w5kQ1EK8eFFt+yR4ydKiYEpBnZu8iUTsLB/HX6d81dLjHbgdtGDWFiGbnR68QkueZhKvMFqecbcvQLctZw68WilPF0ZSXXZ/GMRCcao3Jfn8fCrsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000107, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 30, 2025 at 04:29:33PM +0100, David Hildenbrand wrote: > On 30.01.25 14:31, Simona Vetter wrote: > > On Thu, Jan 30, 2025 at 10:37:06AM +0100, David Hildenbrand wrote: > > > On 30.01.25 01:27, Alistair Popple wrote: > > > > On Wed, Jan 29, 2025 at 12:58:02PM +0100, David Hildenbrand wrote: > > > > > Let's document how this function is to be used, and why the requirement > > > > > for the folio lock might maybe be dropped in the future. > > > > > > > > Sorry, only just catching up on your other thread. The folio lock was to ensure > > > > the GPU got a chance to make forward progress by mapping the page. Without it > > > > the CPU could immediately invalidate the entry before the GPU had a chance to > > > > retry the fault. > > > > > Obviously performance wise having such thrashing is terrible, so should > > > > really be avoided by userspace, but the lock at least allowed such programs > > > > to complete. > > > > > > Thanks for the clarification. So it's relevant that the MMU notifier in > > > remove_device_exclusive_entry() is sent after taking the folio lock. > > > > > > However, as soon as we drop the folio lock, remove_device_exclusive_entry() > > > will become active, lock the folio and trigger the MMU notifier. > > > > > > So the time it is actually mapped into the device is rather > > I meant to say "rather short." :) > > > > > Looks like you cut off a bit here (or mail transport did that somewhere), > > but see my other reply I don't think this is a legit use-case. So we don't > > have to worry. > > In that case, we would need the folio lock in the future. > > > Well beyond documenting that if userspace concurrently thrashes > > the same page with both device atomics and cpu access it will stall real > > bad. > > I'm curious, is locking between device-cpu or device-device something that > can happen frequently? In that case, you would get that trashing naturally? It results in terrible performance so in practice it isn't something that I've seen except when stress testing the driver. Those stress tests were useful for exposing a range of kernel/driver bugs/issues though, and despite the short time it is mapped the lock was sufficient to allow atomic thrashing tests to complete vs. having the device fault endlessly. So unless it's making things more difficult I'd rather keep the lock. > -- > Cheers, > > David / dhildenb >