linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org,
	viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	gregkh@linuxfoundation.org, linux-mm@kvack.org,
	surenb@google.com, rppt@kernel.org, gerd.rausch@oracle.com
Subject: Re: [PATCH v4 3/7] fs/procfs: add build ID fetching to PROCMAP_QUERY API
Date: Wed, 12 Jun 2024 14:28:09 -0400	[thread overview]
Message-ID: <uofb56lk6isrwqf42ilky7r3wa4tetaaze2m2ususzqpbnftkw@hwskh5quvlfm> (raw)
In-Reply-To: <20240611110058.3444968-4-andrii@kernel.org>

* Andrii Nakryiko <andrii@kernel.org> [240611 07:01]:
> The need to get ELF build ID reliably is an important aspect when
> dealing with profiling and stack trace symbolization, and
> /proc/<pid>/maps textual representation doesn't help with this.
> 
> To get backing file's ELF build ID, application has to first resolve
> VMA, then use it's start/end address range to follow a special
> /proc/<pid>/map_files/<start>-<end> symlink to open the ELF file (this
> is necessary because backing file might have been removed from the disk
> or was already replaced with another binary in the same file path.

Can we please also add the vma_kernel_pagesize() to this interface?  We
have a user who parses the entire smaps file specifically for
KernelPageSize, which could be included for a low cost here.

The only way to get this information today seems to be from the
/proc/<pid>/smaps file and it is necessary for certain hugepage calls
for alignment reasons (otherwise the calls fail with -EINVAL).  Adding
this extra information would allow for another text-parsing user to
switch to this API.

Thanks,
Liam


  reply	other threads:[~2024-06-12 18:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 11:00 [PATCH v4 0/7] ioctl()-based API to query VMAs from /proc/<pid>/maps Andrii Nakryiko
2024-06-11 11:00 ` [PATCH v4 1/7] fs/procfs: extract logic for getting VMA name constituents Andrii Nakryiko
2024-06-11 11:00 ` [PATCH v4 2/7] fs/procfs: implement efficient VMA querying API for /proc/<pid>/maps Andrii Nakryiko
2024-06-11 11:00 ` [PATCH v4 3/7] fs/procfs: add build ID fetching to PROCMAP_QUERY API Andrii Nakryiko
2024-06-12 18:28   ` Liam R. Howlett [this message]
2024-06-17 20:38     ` Andrii Nakryiko
2024-06-11 11:00 ` [PATCH v4 4/7] docs/procfs: call out ioctl()-based PROCMAP_QUERY command existence Andrii Nakryiko
2024-06-11 11:00 ` [PATCH v4 5/7] tools: sync uapi/linux/fs.h header into tools subdir Andrii Nakryiko
2024-06-11 11:00 ` [PATCH v4 6/7] selftests/bpf: make use of PROCMAP_QUERY ioctl if available Andrii Nakryiko
2024-06-11 11:00 ` [PATCH v4 7/7] selftests/bpf: add simple benchmark tool for /proc/<pid>/maps APIs Andrii Nakryiko
2024-06-11 18:59 ` [PATCH v4 0/7] ioctl()-based API to query VMAs from /proc/<pid>/maps Andrew Morton
2024-06-12  6:57   ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uofb56lk6isrwqf42ilky7r3wa4tetaaze2m2ususzqpbnftkw@hwskh5quvlfm \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=gerd.rausch@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox