From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29575C25B76 for ; Sat, 1 Jun 2024 06:44:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8F166B00A8; Sat, 1 Jun 2024 02:44:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3ECD6B00A9; Sat, 1 Jun 2024 02:44:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10E36B00AA; Sat, 1 Jun 2024 02:44:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 832026B00A8 for ; Sat, 1 Jun 2024 02:44:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2E504C0F85 for ; Sat, 1 Jun 2024 06:44:09 +0000 (UTC) X-FDA: 82181380218.19.3C6A145 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf19.hostedemail.com (Postfix) with ESMTP id E27991A0007 for ; Sat, 1 Jun 2024 06:44:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JnrmL+Cu; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717224247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+VIg2mNBQDjdMf0q35Z+ZSPuRtiXctWkRo8tF9MZYgY=; b=Lk5BHVFj0GBsUUJQeRLEGRLs+sEMDTh+mVwR5D8jo4PNJwoGlz2STSWi+xz+CSLVfIZ3hv 5/GNFD3XY7TNSpnnV8uSyM8TsyQs3+xucIHprT8UbZIvaf9HmcRtk2UicN5QGumhySGQNC MAdhwX+HMKMRE419C7wLFJWGwVSD7yc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JnrmL+Cu; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717224247; a=rsa-sha256; cv=none; b=WH6zZdmkDKo979VafxqF19NPEvg7k2xdQFmJLAOWX6F2MjO8fppq31FpZ3eQ94gwXfEX7p uOTi5j8//AY3J7NveTWNUuquaMNkFXvsaVL8Q10y99xsoBPejiKvk/LxWBnLa24KwvZGtu ehBAdQfIe7f3i/Lbq8/MxNzHJ8QMHQ0= X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717224245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+VIg2mNBQDjdMf0q35Z+ZSPuRtiXctWkRo8tF9MZYgY=; b=JnrmL+CuFdYq514T7WX6OQe2nXZR3DRfBmrOvqv5tszp4fDPFmzQETUg1HzLWpDNzD7knp MB53gtoVapBsrFQtWNirdAWi+NDzUUp3E8D9/eJR0UZH/gUZCugxekY3nRtB4IUgbm7Cf5 ct2YELDI5KIT7gxwIPi8u0fJnA1vZ18= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:44:01 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 04/14] mm: memcg: move charge migration code to memcontrol-v1.c Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-5-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-5-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E27991A0007 X-Stat-Signature: i38e5txicssqc4dufd4fnbfh5qux45pe X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717224246-366623 X-HE-Meta: U2FsdGVkX1/ZHyloufcbHvhgsdSjjmhOxxYZRJOlpxE0+peB4U1NYMzZYTWksO3eYEr9y8lpzr8V8c9whTS6psojDZGCqU1rWmsL+KaYtdlrZn9RYqz/ZSOxJDshjjsbmelg2MFdm7fiUbEHInFtoUWD+AGM0zuPASpgtv31Cf2R+6v35SCJUCDXKTVrAPyQoaRsu7iWI5aR6agB7zUPANGggYVk9X9KFrGV/dw6xg14DLgBMVd2uIGgLEvMRcb9bW/RGRCcvF7k//ALauSXRBZNsxdLUDxCGeRAwyu6QrAEQakHCMqyGxx0nTmtPPStW4m2ShHKexJfz1ovjyMqa/zj7cAtLKGf/64kGEJ/jIrPZLWgKSc2vOILOXlERxPsyxlNwH0Jnmved6ZN1xP8pJX9JFrXnndQLo8SqvqlCzZSElIRaMGB3xxFaFHoosn9xLZM3D3AF/Mg1YjipIcitEYbUdnY4utb5c6NKklq0pT6U3mn5I9S5wMOVLfpvrpBle0sB3iHIJjHfqKRdRz+l2WuJYhiOhMk5nBJXE9qxDEVVLbQtWSBh/Vc6L5dyjmuFdZ4xatvEVO3ECg6RG0AQWNA9b8yW/RXXZyYZ0RDBKZa+TwBnpeiFsKfdTYuLMbkDxciqn+rXCXSXRg/a86BG5FBJQ5f5gNDMhqIYRQ3QIahCuQRncusnL8Gso3m52guSIV8VSGCgRZ5yxF0XyLZt9+RgxsHbZbT2aAK/IRNIle1aFuPM78at6Zki7IgRszXTaif/2JTMt7yP3q5tR1OGhjfdYGR3SBmUX0inDW3FW8Nec5g4AbvNg5pc4r2C7UV2dAhfRYaJodsgoHbv+nx2BnzUo/kjf9j1LdV9vapHQqR4N53mev1DbrmAEgIQ9S8dVZyP45svjgfN6jZNl8rG23h8aPaTFEwJtyYFqBh416we3bd6ebh+xEKok/1eapETMWXb+lsaOTDlrYQjPW zUB3prlA Oe2i5npfTvFSBGCzt18eElb5aU3qJMIqCJHmqjhHo/L1LxffpwxAzqq+/Yb32swtHIEDMxwYqjkQKeRA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 01:20:56PM GMT, Roman Gushchin wrote: > Unlike the legacy cgroup v1 memory controller, cgroup v2 memory > controller doesn't support moving charged pages between cgroups. > > It's a fairly large and complicated code which created a number > of problems in the past. Let's move this code into memcontrol-v1.c. > It shaves off 1k lines from memcontrol.c. It's also another step > towards making the legacy memory controller code optionally compiled. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt