From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2985AC4345F for ; Sat, 27 Apr 2024 01:16:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B49CB6B0095; Fri, 26 Apr 2024 21:16:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFA666B0098; Fri, 26 Apr 2024 21:16:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EA2B6B0099; Fri, 26 Apr 2024 21:16:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7E5FE6B0095 for ; Fri, 26 Apr 2024 21:16:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2EC1DA16C5 for ; Sat, 27 Apr 2024 01:16:40 +0000 (UTC) X-FDA: 82053546960.17.7C79CC1 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf11.hostedemail.com (Postfix) with ESMTP id 47BE04000E for ; Sat, 27 Apr 2024 01:16:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rCbwiDGH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714180598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dw9CXe+SmxN1TDy435qbdzl8HGL75SSMRvyUbyXE2xA=; b=GzhmVcwV1kpcu5V8ffaRvHbgFBG5VTBM1OEhRTHm2T0s9Gs/XLuAe8fBIDYB22s4Ge8OIj 03CBEa1OL+iHNAKzc+z5BuacUw1u7m0eXUFIGaTXbGCeEdmjFH0wWmWxkuq3G7trEXlONO QCiEMFWYSyp22EL5wdi7WfFIeptC/oQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rCbwiDGH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714180598; a=rsa-sha256; cv=none; b=o4IyTYuJ5KqI6IUS7p6eccrh1/UFQt7s+Bn5mHOcm6Nwmwzpc0jYfVZ17c+0KcNgmIFO2T GU98U05zxcRtRA6LysF49DIAsM/1HwriGbb3V9afIeUIqKAVt9gsfDQXLoGq/KkTBE3KM8 1LRiA0NqIM9TovQYUTEUac5XaSBnPyw= Date: Fri, 26 Apr 2024 18:16:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714180596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dw9CXe+SmxN1TDy435qbdzl8HGL75SSMRvyUbyXE2xA=; b=rCbwiDGHCO+X1lYKKamtp1knSDpnUWhysMFPCiO7cUuKr6CeRmkM+Kb8LwAowZ19Qec1AP wxht7p6bqUg4mqYsCjAigIMyrG4uFGDlnfXj7D+3K6MfnatGerx8IDbLro6iDAbtrea/6f j8mHp2qf0hC7Rpg58h0nLMqmYHG3UlQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] memcg: reduce memory for the lruvec and memcg stats Message-ID: References: <20240427003733.3898961-1-shakeel.butt@linux.dev> <20240427003733.3898961-4-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Stat-Signature: nxhni3myk3u4dxgsubdgt4sxebhk35f7 X-Rspam-User: X-Rspamd-Queue-Id: 47BE04000E X-HE-Tag: 1714180598-192154 X-HE-Meta: U2FsdGVkX1/xZWuHk94pjI9xGYyn+drs1uTsGKHEsXakw5vv1zgUC59ic+R2XTskXDpk//l3l871qutynj4rF+SuIj8dRfbipoBocTxfEkOr3va2TbRUMHaS/AdsyyGLNaZFT33BdL7NMoTgXoe96J3qt6Dfrb0TBKJJ3sKVEceYFC6lmhCNW9XSeRGiyORn/ctR9J4H4cAZvWMVoqk1gLq4U+RdCUbfC+VBAxeSAvD1RESA2BeBReyNYz33E9x+50ynPnq2EKCzrx6GPs0tgA3NEn2HBb6B+3kPPhpSRTnhhWq+pzrus03GCBb/F/gX+a4w1UjSaLOreJaoNQtbyvsmA+OW+RRk08IsSXyEvL2GKUjEWT++990vO1nE/bHi3KEEvVJ372r5nlcb+nDYydImnETFi6T6J/DCSi96Cjb4ANEiDdK3d9D3NPZRArttQ7CBy7uuVkt8k3ZPCcl67ftDxsmwkRlvliIPudkh2j2fYFXEJM4lT2sDBupNaC14IweZ55wjmIwm4Vu7gcIKXCyCmxgUKGmaDGIWRmrJ/pHhCnG2FJ44dyaF8i6yefIHQvhXuW2G2t9lqTN7VZ+RHSqsn2C14VY168sq9aHOGHHrQ9ggSMqeNc8Nq4nVXGASNzxl5yeuaOCk6eJo9BirHMQVFqKmln6k4kPw8sTF9r0YTzdLh0kILIq/NewWLq6g8h9ZIozyBDmsS1RB6+B8fIiAotaT7x4v9cvX8hGBhqh1GRCkvUXn6vRDI4GYrRJ15dPQkLF2ke3XK2osKxLlZb4Erhsr/AJ6Ed0YLXXbksFGqOvUaXVBDmHy953BE185KfLG4BrAO3b8PQhY7FKN9EdXPfaZRQy2RZJ/sj3fEmtOQnS1vX1qgljdXof44YgS7YdMD7dT0lnQfi9zckGI1JdjBRcTAAMUF+Z2kVmyL2N2bNsUZP+vQ6PEk3D5cVWj5NYYuofZ74hiqo0ym46 47HLsK46 a8XUxzTLTmTcwG4wAI+NAJxRXxofDLaTueJiAV1YRe8mtMS+lEQjz1nhp0LanoJXYwMCsihoqz6h1jOaFGjp2gTjI7hxQpQmG8WbSr6QSescmUME= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 26, 2024 at 05:51:23PM -0700, Yosry Ahmed wrote: > On Fri, Apr 26, 2024 at 5:37 PM Shakeel Butt wrote: > > > > At the moment, the amount of memory allocated for stats related structs > > in the mem_cgroup corresponds to the size of enum node_stat_item. > > However not all fields in enum node_stat_item has corresponding memcg > > stats. So, let's use indirection mechanism similar to the one used for > > memcg vmstats management. > > Just curious, does the indirection table cause any noticeable > performance impact? My guess is no, but the update paths are usually > very performance sensitive. > > I guess lkp will shout at us if there are any noticeable regressions. Yeah and that is the reason I made the indirection table smaller (i.e. int8_t) to keep more entries in a single cacheline.