From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD05C48BC3 for ; Wed, 14 Feb 2024 16:17:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A15D6B00A6; Wed, 14 Feb 2024 11:17:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 552056B00A7; Wed, 14 Feb 2024 11:17:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418B66B00A9; Wed, 14 Feb 2024 11:17:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 320796B00A6 for ; Wed, 14 Feb 2024 11:17:36 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E17D040B94 for ; Wed, 14 Feb 2024 16:17:35 +0000 (UTC) X-FDA: 81790914870.25.8A7EA48 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf27.hostedemail.com (Postfix) with ESMTP id DBF7540023 for ; Wed, 14 Feb 2024 16:17:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=If7KvAk3; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707927454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WvW8w5yUCB+T24tws0BE+nRUAXqLznpxXzLB9RssHjE=; b=OzhcXFUvX29Dtwt+q2hxD9M8ceqRIAElWMdwqqLb5ACiqqIiR6c2sNb7Cutx/cIUJ/tCeV PiC5+s9X14xqPvKzKudhAXJogSV7bVHIT3fEGVT64Yf5uxngi52iNqLvt8fiArp6Yvg4zO V1c4QMmUejcrG6SyrOIlSKit+Sbn+6I= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=If7KvAk3; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707927454; a=rsa-sha256; cv=none; b=OCZoVvg/nBDGmOcGylNYiahTx91c7LfnZMC8ygwFRr0UjY6kZt1tFxj0VmeabCgT+2DJ57 1XnlwEunp0mK1mDstfSER3EG74HSp9TnnttGmQfeqiA2VUO5Z0J4Hh/Lbi/noeCmOo5iVd exZVVhQj+0wecKeCm8Wo6iVMnsO0T08= Date: Wed, 14 Feb 2024 11:17:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707927450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WvW8w5yUCB+T24tws0BE+nRUAXqLznpxXzLB9RssHjE=; b=If7KvAk3S44JHt8xTRFRLZGFB9HhXr9yTjM5WxyEi5xNjIqcYGBYlgszfmKzpB+BaRdtGZ n3N+YeR7XUwHyIMey1lTARWNjfYN024v3AgKYdiCjuLtH6AdMtTaqstAHFyfDaYzOPE5KS nEweGtuqjPMrA6xlO/8Dh+ORbNs02fU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Michal Hocko Cc: Johannes Weiner , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 00/35] Memory allocation profiling Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240214062020.GA989328@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DBF7540023 X-Stat-Signature: ypcwzbup7tbpi8dm5ih44ksm1dy6w4xz X-Rspam-User: X-HE-Tag: 1707927453-383402 X-HE-Meta: U2FsdGVkX1/GKhsCfCb72yrK2UYncEFnTBY2bOOVMpyGehsXb8t3xtYb9JmyAyHdvlRFBuKljGT2h/+94n/VWWyJ9pv1XowY4cn4xt3oq7xvMtG7JlfHT9FSGaOrQa6BOIEIAvivUUgo2uHnvs4+wRUBGCy0KCnbYAOWwM0n9wLxqktxiJHrhbqaCOY472plKGrGdGT9n/N3T2kpAB3310F3kVIkLc5KZbCpzgEXfKZ5GFlbUZQP3NJqqZ6+0Ug/3qJg3rDNDJjNvtwZqzFAONmFETX5o97SmVToUnGqExquXqr49CE2gV2EjR2h1cTWQnOC1EHh9uw2Wdtsxf2miOxprgy2d8e2zcuMJawPQfsEoz0cOm4+/l6t5pHy67X/QAMUas9wTW2zaWJtU4Dj9mLy7RnBRPku+XBbVNuUtbI7xOm5+wHN6evRR3wQyR7HTIpHH74PSky/cbPbMBbZJQgo1ijP3ywl5R7/aw15pEfDlw0X5aUP3yKk0BtplewOFlV7KLTSVP1TF3dvUmlduUP47qRJN0myTi2Rm/gWLVFu6eQzMm0GqNxs5AjODTaIfMH7Lz9UUOpqshibMOvMQOnp8DOiZW/EzwnqFBLd1HIoqDHV3xdPnfau9zUVtcjx1GbPZYMgoVUYU8570BwLPW3dcvKnwQG7WRioMtqTqCCN3RbsDCmUTrrfFgubYO1y4XvZbK2P8cICIeZxFPit7SBizbjnvmMdJTwxHK5QbTNvsFP780BJEwJS8hD5BpZu5bNiKYbCF4jOuOZiXcXTxfXDHfjPQQDUIdZPqqOI10NMe5MyU9yIOeMyttH8eem8BTM3LHN5HOSyN4VWfQJIsWl72ntmIbUVAf/sTpWefzzs2SKoc0nHynzP+QnZqkTc0bRH1lbaQ86bbpvN1zpPxmQZuold2sIEMYldeu2hIG3AsN+TmOo8MsFQigKKgXaoUkdkKjRkNbxHrkZkNMd 2NdsFkh4 uKJCbAlWRnV2Q0BFzwPktwrNnNWt+xQbFoP9j5lMxpbXmLhkLFeV8AF+p/N+3eyxhMAbmwHsQCEYZ+K2S1uGnlFGNwSgnX5SftL5OClDMPAmgZlQm10sqcv/o1yq6tkYtBdg3izQ0h+LrqjCFMkeVInGwAQevdd+TK+qQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 14, 2024 at 05:02:28PM +0100, Michal Hocko wrote: > On Wed 14-02-24 10:01:14, Kent Overstreet wrote: > > On Wed, Feb 14, 2024 at 03:46:33PM +0100, Michal Hocko wrote: > > > On Wed 14-02-24 01:20:20, Johannes Weiner wrote: > > > [...] > > > > I agree we should discuss how the annotations are implemented on a > > > > technical basis, but my take is that we need something like this. > > > > > > I do not think there is any disagreement on usefulness of a better > > > memory allocation tracking. At least for me the primary problem is the > > > implementation. At LFSMM last year we have heard that existing tracing > > > infrastructure hasn't really been explored much. Cover letter doesn't > > > really talk much about those alternatives so it is really hard to > > > evaluate whether the proposed solution is indeed our best way to > > > approach this. > > > > Michal, we covered this before. > > It is a good practice to summarize previous discussions in the cover > letter. Especially when there are different approaches discussed over a > longer time period or when the topic is controversial. > > I do not see anything like that here. Neither for the existing tracing > infrastructure, page owner nor performance concerns discussed before > etc. Look, I do not want to nit pick or insist on formalisms but having > those data points layed out would make any further discussion much more > smooth. You don't want to nitpick??? Look, you've been consistently sidestepping the technical discussion; it seems all you want to talk about is process or "your nack". If we're going to have a technical discussion, it's incumbent upon all of us to /keep the focus on the technical/; that is everyone's responsibility. I'm not going to write a 20 page cover letter and recap every dead end that was proposed. That would be a lot of useless crap for eveyone to wade through. I'm going to summarize the important stuff, and keep the focus on what we're doing and documenting it. If you want to take part in a discussion, it's your responsibility to be reading with comprehension and finding useful things to say. You gotta stop with this this derailing garbage.