From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A7E1D6408D for ; Fri, 8 Nov 2024 21:27:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67E5A6B00AB; Fri, 8 Nov 2024 16:27:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62DF26B00AD; Fri, 8 Nov 2024 16:27:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5856B00B7; Fri, 8 Nov 2024 16:27:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 317B16B00AB for ; Fri, 8 Nov 2024 16:27:58 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A6779A0555 for ; Fri, 8 Nov 2024 21:27:57 +0000 (UTC) X-FDA: 82764214218.21.4893C2F Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf06.hostedemail.com (Postfix) with ESMTP id 4FA05180008 for ; Fri, 8 Nov 2024 21:27:29 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CxZAeh83; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731101190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S9yRLxAX8T1rlHV/+Ct2rZaF9rujytNuCqhAVmD1asE=; b=rxoFMibJP42krcu+oeVOraYjXahaBNGKEtFYnkn+3CRL8mUQtYa5YnKKIZmfkppKvun4J4 f2g3E21MICWKCye7iw5UUtbLfwqgsor3gULuxP+cnGpV5nuhhjECk7Uf7zvhy7bQDjyzL+ Rz+uBKAp3dh7ZAbyj0kNr/cdO+s/nLE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731101190; a=rsa-sha256; cv=none; b=XmyUlqDlT63r+aJbYM52RGmCWsdkaowL+UNvKEWwkYub2HI9FDpKpz4cwLJbwCp3p7DSCS VGH2gSxD7F16XKb0JOuZ0p7WNEpKFwLglNvV1QmzQeiU3OP4k0D6SdjvBFN53XYNzCqeca YX9hJ+CDniCul37TKNDzFQ7gEVD/Pjo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CxZAeh83; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 8 Nov 2024 13:27:45 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731101273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9yRLxAX8T1rlHV/+Ct2rZaF9rujytNuCqhAVmD1asE=; b=CxZAeh83Acl+YUngZg++EYM/o8r0bEkYDkbKSPAjUUU+vdB1dGHkH4aT+WuK1WOPgrCC2z l+Edwz2fIGtRnJZ43lRnzxi/V4vdOTVlVmFheGSO8P4f+yuGgqWkRtv4O5RxWZ9NcxuANi 9Ebk10QF/hreZ5E+gFEVVML3DzmKSkY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: David Hildenbrand Cc: SeongJae Park , Joanne Koong , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, linux-mm@kvack.org, bernd.schubert@fastmail.fm, kernel-team@meta.com Subject: Re: [PATCH v4 4/6] mm/memory-hotplug: add finite retries in offline_pages() if migration fails Message-ID: References: <20241108173309.71619-1-sj@kernel.org> <04020bb7-5567-4b91-a424-62c46f136e2a@redhat.com> <4d2062bd-3cf3-4488-8dfc-b0aa672ee786@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d2062bd-3cf3-4488-8dfc-b0aa672ee786@redhat.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam10 X-Stat-Signature: za9snwkqjsbkiw5afh3aytnbur9rpjx3 X-Rspamd-Queue-Id: 4FA05180008 X-Rspam-User: X-HE-Tag: 1731101249-156940 X-HE-Meta: U2FsdGVkX19teBqdauXNSvPBIEFTVDTzOWaioxLWQw29VaMvcJTV2iDQs2O65QO3iCxw9TkDnZj3nln9YEvcMbUyBfaIZQTwB+4z6uEc835xz83c0PNaJ4Hcav9/v/GOzWYHAh7CkyeiH2cBkpd7zzviuMCD5+qsuafQrnGBI71IwnNnh5sFB3qWSql2ZpAxAqMrxC1aPu0dM4fCQ2RYtPjm77OjV35khFxnyqBBOmiZr9j1MaI4EPRn/r4ENKTFsEtaXwfUutzmDCAM/88JMpGHH0po5n8akvVsTDn/oxz+lF3HeD246t6bQFG9O0tdJjDhq7ijYBLDkGHw4LvnlMhwVZeay44H8B88f9+JvpmW0r1dNhwDn2aC9zJloYwbh1EcUyib1D9JYUStqXhSaHHnCPd6C3Uk/Ka7REXXg3vW5Rk6itVSrHuylLIuvWN3PqMbM3UJpuHTDbtVpASStsY/fTkE/42/5gYdHzcGuTu/eqsRSnPCV0GPydrPEPezQxipfGglD7BeX6NzOnhdLWAhGU2fTk3nyLdJt8WtH1HPMeZU5lVpBF988yP5kRnPApkuirBIqWqqrNlJCizOJLn/doGurlLHvPjpJ3Y8eNuoeA+OatjHivsccoHwP303OcZ9CRRzBEUDQPAjSIWuJ36lRsLVYrqyyhfUFpdQ5Rr7a2iYt/vtrT8r7KFg9zccgPAAu4WsPfr6sh8zC4ZxKXsnf3ZYXyvCR55abnDsiHYmuQR7Yx8UtA+MuUvwS2NOJossMBk076i3EOFHlF0nr1+CJ9orfsROOyDj2J+CNSrrKgznDx6UILumwy034w5POX+vG6UTUPbmNjgA4GcsflOPpkFC+6xk/C++4sh8dp+EuxmJx3WLWvstyBXVbdnJo4Ho+p7aIjZqBeIMYWLtY1+aExm78nJ/E/Odue6zKJeZ4QkGdxcSfljEJq8pVqFSb+q/MNWEXpK4hxs6tdn kow1YWwq ayRozj7PtZSZJ2YEJXav9XIit4aVQqIjbdvBynv4GsBtc1Cg1+IUDgNKuuRUj2+oWdt7QxMu6qauC5mN/YEvHD86HYPkWopqSfmD35fMeWcqKdB7f5Sy71k6QuRWcdCR910l9asw1baQjQgZ4d8xtFcEYEfqCfr51BmUqS74Fo44pe4ZR+Hed8kR+SynycfUU+hEegtJXJsSqEOUpjsVbTdasQ/COO4zbF1ynSE5isTyJdfqzUKYjZDvFvxsnN5/IelVBFw40RVgN5hM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 08:00:25PM +0100, David Hildenbrand wrote: > On 08.11.24 19:56, David Hildenbrand wrote: > > On 08.11.24 18:33, SeongJae Park wrote: > > > + David Hildenbrand > > > > > > On Thu, 7 Nov 2024 15:56:12 -0800 Joanne Koong wrote: > > > > > > > In offline_pages(), do_migrate_range() may potentially retry forever if > > > > the migration fails. Add a return value for do_migrate_range(), and > > > > allow offline_page() to try migrating pages 5 times before erroring > > > > out, similar to how migration failures in __alloc_contig_migrate_range() > > > > is handled. > > > > > > I'm curious if this could cause unexpected behavioral differences to memory > > > hotplugging users, and how '5' is chosen. Could you please enlighten me? > > > > > > > I'm wondering how much more often I'll have to nack such a patch. :) > > A more recent discussion: https://lore.kernel.org/linux-mm/52161997-15aa-4093-a573-3bfd8da14ff1@fujitsu.com/T/#mdda39b2956a11c46f8da8796f9612ac007edbdab > > Long story short: this is expected and documented Thanks David for the background. Joanne, simply drop this patch. It is not required for your series.