From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CCD4C369A2 for ; Mon, 14 Apr 2025 13:55:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E88DE280059; Mon, 14 Apr 2025 09:55:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0CC6280054; Mon, 14 Apr 2025 09:55:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C392F280059; Mon, 14 Apr 2025 09:55:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9F368280054 for ; Mon, 14 Apr 2025 09:55:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F2DADB75ED for ; Mon, 14 Apr 2025 13:55:44 +0000 (UTC) X-FDA: 83332797408.19.1A1D661 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf15.hostedemail.com (Postfix) with ESMTP id 0749BA0004 for ; Mon, 14 Apr 2025 13:55:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=DNTdD6OP; spf=pass (imf15.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744638943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bp2rSa7YgUjksfq92C6U0dpNu6ZFkat6qi1m4BsAbjA=; b=BwBFRg5AH5M1xv005xkNFuYTCglW5Rtt2AL7ZaWX/2ICu9vz327iP2wHP/on4GGz/PIS8c QKwrTcprNPrVfSAkteZK3I0u1BjulP++3PWcVNprIQ3R4KNa6YaUFG12pav4XQVEnXprg5 NfHI8nEhseNqSZW0cZ5wizwA+N76lYY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744638943; a=rsa-sha256; cv=none; b=wgVRQ3py2+V6fuaX8nm+uqG5ekCLwcdcYLVXvmNhdNwc799bJO6Iq7RWBqS1hMjC0KIwpk fjXRRTvu4sK1c5nMMjCYsr/PuDGo4dpaTxIecO5FwNkbttoMK5GyG2uQpAPCZFoLdTbqw/ vWE+DsdQMGftcE4omZIH6HXKEvSs5WA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=DNTdD6OP; spf=pass (imf15.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43edecbfb46so29823565e9.0 for ; Mon, 14 Apr 2025 06:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744638941; x=1745243741; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Bp2rSa7YgUjksfq92C6U0dpNu6ZFkat6qi1m4BsAbjA=; b=DNTdD6OPeQwxviAgcBC9zHf8soy700ztYT7rm6yo9tgUSzZiYNN3CheYtWzCcyDiAv vKpoLiBcOFcHYysJ7KmS08AQWKBZJdGtBAgc1NpEvE6tSnlMkb3hVGOGqzQ+FaeUPMRp Vx/l4ZKEW8Ovho0LVCzxmA6rCVEHn/1qZOMnwvz0lYPokF7u7aVzsvYpBm9YrlChXRcD W06MH5coSiT9WUKomjyfgyJqJrNR7f9jK3kAVPQOfRYUTvtP9bH7rLpVnMfP7wTH1L8x tPi6FJQPzPzjKTjR4XKQXslLHAdnc9cT+4PiZPxBh2pif+VMhVmL+iUa8MzW2nS/5jup plPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744638941; x=1745243741; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bp2rSa7YgUjksfq92C6U0dpNu6ZFkat6qi1m4BsAbjA=; b=JjZZxwlWtQaLJLkhSFMmV1I86B5cddboUzjS5YZ+hd1HbXDKFPFfugzDWhgwGjTYTy 8OC66bztDehbUzn4NCJk21SH0ChpVXFIRGwQGU9bijvJnREnpkAdOJg+pi7g/zMYr+mB uLmRsOoPxbfR7wlDZ5WjEdJ2wAB49OicQXQb4msg1SI+LUXIpXF+CTpoyYVh2KM2rxbI AwVbv8ZKQdTBfa2aU+vHyJVqpVE31TuE++Vwju7FuGKdFZ/Do04psTxUaiS/ymFyFivH GtUhnyb6Vj12dYOEMvwYfmA+X+GwVXSOZ4lLret9AWiFuf9ENSA+SbBbUJO3pVwXWgez QPzA== X-Forwarded-Encrypted: i=1; AJvYcCVSvfc9KWGlJZRWUlraR54LNUV66KmAE3adDhWDzCi8q0uzxWemWGzkjUZ3BTM77IQrrTJ3SyEOsg==@kvack.org X-Gm-Message-State: AOJu0YzeM7up4w+Rl8j7e+UouddumngTHGPbK7XfzmwJLaldDF//xpU2 sGpN0wGM0Hqkn0wsKWsjydVVtkx280EaY4hXTAyEsNLkyUb5p1MF9JcmRgFrDc5dc0AeIOSi6Lu r X-Gm-Gg: ASbGncsNgFYM/vqSKa+iX6gm0C8iMNkiyK7xDKhrXbfnT9j1U162Fm9yLTFYLUXIQz4 0EAu7px8HyeyXJVajz4lnvxXqRzkBGE512wZM6wkk2oMkrGcUvNGYAtgKweqVw3yWcvJzm8jWSe GM+D1BKt4g6kdX1LvxK1OgKE394XoY/0WICWKjqKLGuc8JLuqmO/lqQjmq3CYYGprzmHzelztH0 WrorSfLEXE48Hx2y/3fQrY5l1zGTHQF3Tkg4pzhHpyQ1ew0e49sHGvyLYUXy+fxZacEoxAOR9wQ X7UFLQOf+c8t5n/RiogcxM5dIhc4wB/I+FpuwVV63h0= X-Google-Smtp-Source: AGHT+IH7XfnEongCTvrfF5mvPiNUytCuC/Zcaba7Gv1vTVVOnakln7HNMXeyFjeGknI7uqcmE+o1wA== X-Received: by 2002:a05:6000:4205:b0:39b:ede7:8906 with SMTP id ffacd0b85a97d-39ea5200a2dmr8697154f8f.19.1744638941281; Mon, 14 Apr 2025 06:55:41 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf445772sm11160518f8f.91.2025.04.14.06.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Apr 2025 06:55:40 -0700 (PDT) Date: Mon, 14 Apr 2025 15:55:39 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() Message-ID: References: <20250414021249.3232315-1-longman@redhat.com> <20250414021249.3232315-2-longman@redhat.com> <6572da04-d6d6-4f5e-9f17-b22d5a94b9fa@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bldxszh4zmrjgwhd" Content-Disposition: inline In-Reply-To: <6572da04-d6d6-4f5e-9f17-b22d5a94b9fa@redhat.com> X-Stat-Signature: 6ixbypu51zz7obyj1etg8suxjy5roug5 X-Rspam-User: X-Rspamd-Queue-Id: 0749BA0004 X-Rspamd-Server: rspam08 X-HE-Tag: 1744638942-196516 X-HE-Meta: U2FsdGVkX19A2o0FBolSb1rFrmtENFc+qn2tnNNnJ8GfLa71dRnKqTz9gaqIKjH2TeLEAQOJKNgisy4egjg+YwQ2TxjvC5MVQzXwdpJJnlgNWo+OPkpasqbDpiIJqkHYsOL71FGLrZ0hthG2btiDJPUHKQ4GsVsTkUFsxkGgamRC0W9G6a8MYKCKBfSH3XiLnnpvjxJ9cn7EhGQKetByua5s1ejjyPPAfThd3zbM57AU+wK38PZFxsN7ikrHddW4i0+XqLMTmqki3wnTVn+UXJKthzeVEEq16onMN+JmwajmrslGNSGQnhdr+5t13sWLVGp7IaB4JQYu6Wb4UXk6ULPJL9sbQCsBerTT3xnOo1k20Q7X6vyr0cnyvCqgCf9a/54Ic+4OOR8GSMtmQYph5zVSu0svdHgMb92jAAlazuRQEBPIpv5+r6WPAbOdiZVJh7nJmsbuLT4uOr+zstkgIWDMWy8A5to+LaSuOrnqghh+xyPNoVpl9tmNCXKAf1cx4Ymiun5GdHbNRvhZEo2jIuC4AAGdJjcAs+mkcnC5B05TqhtE6rW5K3nJcioUzPZB5cxcVxIO0+i1aou6wZhz2KubgXRQpK8UWbvACQNvy0m4XAn9bpLv/wiaur1G6x01D9QhXSrj99Pf9S61uH8tVvgtmJ7AbWqdZnOcAu+36Ra1ppGr2plz0pf33luYZsYf6v2hWmwVChzRS35U8eZT2n33Xejo3QQumDjm66IcOuEm7rtUWyHA4WL0L47GDjIFKPg48RUebE6utysw478jZg4Fw7MlwUZdVd0pkz8ifqWSYc8Ejv3pkzhucZKQKkFDrh0RQ97AO99jX+J22/mye8bRh+NtRjw48xPhFsEh+5MI9bHnyrhPMoYW5QeQeXkJril19wLmJ5Pcy1H4J/xHuSAOWQpp5BDgyyRkj3frsdGtjGqDWCs7E7sJIU6GT/rJX7APg4czbek0e4QG2Ik VqZofeaA 0ZX9C02jiZ2WU5edhv6Nmi/sXNEtkW3WbugOK9JUrT+J1mHhclITeEBXn58ep8snipO6H09e69yAMDwL40nCSUWf/9IsjWzfMjRreRUVrAvQhIzTNorsgEfVG8Td+H4+ma5Q3KrmrKzYIlwlej9xjXsnnsWLRIysIlnAIRHMvr9X49pDlbo/kDFRu19C3ftzqWxqPFOyAkZbWVh161ZkKCgosMAi4SwdO5+aWDIi+sLQxJu2+bzwSMWFu1JDjl3O1sTqpyceTM6dHguGTPpBSXuPcz7T3mMchw8H8duKJYHFVmJuYhDyVxoZPPIilkDr9RVXqxW7YWoCduZsIg7qMBnWAi0KGC3xBjcH80GjhXXozgPEFK/+vOjZAwG84EEsYdjRNYT9GjChAhcv2KQFBIlXWtNSCSop+lwwLLubdVhV3lO2Kxya9HBjDf3i99FmlHEF/q+OpZ07Xky4Xfei+2+SxIu3BGCmt06bKtRElPAfyBQyrlqfmGUtSpptGcAKyOgBlfexThiPCdhjMch7sRghH1Ef9AjiMH3pvUHbI5emXYIP1Ey0BcjBek3sdGPxb4kWg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --bldxszh4zmrjgwhd Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v6 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() MIME-Version: 1.0 On Mon, Apr 14, 2025 at 09:15:57AM -0400, Waiman Long wrote: > I did see some low event in the no usage case because of the ">=" comparison > used in mem_cgroup_below_min(). Do you refer to A/B/E or A/B/F from the test? It's OK to see some events if there was non-zero usage initially. Nevertheless, which situation this patch changes that is not handled by mem_cgroup_below_min() already? > Yes, low event count for E is 0 in the !memory_recursiveprot case, but C/D > still have low events and setting no_low_events_index to -1 will fail the > test and it is not the same as not checking low event counts at all. I added yet another ignore_low_events_index variable (in my original proposal) not to fail the test. But feel free to come up with another implementation, I wanted to point out the "not specified" expectation for E with memory_recursiveprot. Michal --bldxszh4zmrjgwhd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ/0T2QAKCRAt3Wney77B SbJPAP0dXFDJG2wSX/yIyDLlLnQPzAglEx7DlhFbKKZN1ujpywD/cWz5HMwZq6XA v7d3QWoUA0RmWL0qHKFogwG/fe+bNQQ= =9Pga -----END PGP SIGNATURE----- --bldxszh4zmrjgwhd--