From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49562C02199 for ; Sun, 9 Feb 2025 06:22:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 323916B007B; Sun, 9 Feb 2025 01:22:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D3EF6B0083; Sun, 9 Feb 2025 01:22:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19B956B0085; Sun, 9 Feb 2025 01:22:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F35466B007B for ; Sun, 9 Feb 2025 01:22:48 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7490980CD8 for ; Sun, 9 Feb 2025 06:22:48 +0000 (UTC) X-FDA: 83099412816.13.C039041 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf23.hostedemail.com (Postfix) with ESMTP id 918B8140005 for ; Sun, 9 Feb 2025 06:22:46 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="n9T/CndQ"; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739082166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ldV95G1DAQLsASCDmDTeiPF4TswAK7F4G69xf6PYBcs=; b=31AgbJwzlhx2N0KkTSi9Zieo10N3WNt60lAnN8pY4UH69A6HpjyYIAKxzSPTBVoPtZm3WO W413bqKuy4t9ZExGc6HUzgO9WLA8P54o6k011DfjeaifyQgCtPkSJ0YE+DenI0VlcitcBZ X2c9TeZmszwaRormO9GpKRgokUKbSd4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="n9T/CndQ"; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739082166; a=rsa-sha256; cv=none; b=eOH4JBorV80xkZPZSpE82gDvQRKd5rbY7K4ePVALGaNtt2b6Q+QqW/Qqx49z9Pw88CYa8L fFdTxAC5kbFBPxPgJuwaIkXT3GQjpfJ0ftHZzFohghLvgK3VKIOsZQYFiXDWaYH1MsIlSq cw1GjLUMuVueI/tN9pP72LeB1kKafnI= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21f0444b478so48497225ad.0 for ; Sat, 08 Feb 2025 22:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739082165; x=1739686965; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ldV95G1DAQLsASCDmDTeiPF4TswAK7F4G69xf6PYBcs=; b=n9T/CndQm7EmZwy4aSQ8nUNarvlfG0MoU5O4MEgRmgf8tPe+2oXql+BkXr/06XYvkU uL4ogeAkBb6dWHxmed5LwDEatNhd97E/RgwWgz89LdSAOe1WtxqzZF37egvUl4AM+RQJ C1S1s5u3muRYNGgqxQgSkfT0hY41Q3rwOPlGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739082165; x=1739686965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ldV95G1DAQLsASCDmDTeiPF4TswAK7F4G69xf6PYBcs=; b=MG9ZfpuWaA/S/gcKmgdstxYOnV9NRAToSYrQbkKaD1JzOaAxuVKn1IqVIjKhSViqDX /lrcUoIdvcu6mi6/ucq3h8k5aR+oUQDspzEAQrbDLTrRaTBl+kBU1uKPsGSNgqIsZdZ+ qHi0Cr0VsDOc4ptFAx+iPltHkRBXcYWEhx2AW+McllqLODki4r47smsBUdTee5wx9d2K WtAB2Q7rTymTo1r0+K/5sziSshR5snq/6qEbz+8b/+ZDAojgiL2EJVuiIuV9B0ZVQV9j tYv+MAUya0L9feLEZ1hSaQQL75pCpSJMxCM9u8o0A15Ln304g7WpUA1Gu1TKp3QstOPP fnAQ== X-Forwarded-Encrypted: i=1; AJvYcCW0ryXV6ut/xJHM+rTt1iTPiDrA6BZGOj798sS64xz4dKF2Gme1JvcF2jeoMDHJKim8uXKBOgtXOA==@kvack.org X-Gm-Message-State: AOJu0YyBXrE4ieIiHJmwWSMdwA5y9Sgc6hnKcqLGIFAzGhFEkaBcEaKl jsRypKAslou0eG9x3V+8d5PWfbqOUrhb3fDUaOlqIGt2z3znn6N8+ybBUIFbHu5nK8YlM5Ynphc = X-Gm-Gg: ASbGncsTlI/fb/4ghuDa6P776v6/y9v6TuguT3lSozSYEB8X6fHty2b/md5/oQc88FO JcmUktIquT56/B7IBMYeqLrbMHpvGISTcTESdZJ7Th5eo3LJJZTnsZFRcK1TvTJkqTWDXl2Vx2+ RaW1wRUvneCUT1KJKHVCvUCJkdbEhR//ZxfCUKm4KPBLDADOyePWlHxJeW13Wyjq3C5BsN5WZYm rFqLsdmhkTkMiPUEOZ6Wuku9c7JNsdUDNRRRcl8WlOVJxBGd4kJG/kymHpbvg43shU+6gnPAsVH tLmqz7Q/XJttnZFyZOw= X-Google-Smtp-Source: AGHT+IGei+zlK9G69QXNPORRGEu03xaUFQMvZa7TNr7n0U+BM/TBrxaUAjDJO+CbGVVD6isxE8/odg== X-Received: by 2002:a17:902:db0b:b0:216:7d22:f69 with SMTP id d9443c01a7336-21f4e7799abmr155816005ad.50.1739082165445; Sat, 08 Feb 2025 22:22:45 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:561c:e985:5563:fc48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f36511237sm55668885ad.2.2025.02.08.22.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 22:22:44 -0800 (PST) Date: Sun, 9 Feb 2025 15:22:37 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Yosry Ahmed , Kairui Song , Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 02/17] zram: do not use per-CPU compression streams Message-ID: References: <20250131090658.3386285-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 918B8140005 X-Stat-Signature: 4qd1onf8nnkyaejauqc5yw6uir5krxgh X-HE-Tag: 1739082166-79562 X-HE-Meta: U2FsdGVkX19eW6S5bhi/1C3xHvj/hQ3vZ8PkvaijJOnO2+smnLWZVhpoP7jl86WQyN6iiHqlClMT4Z09ejjMHcjaNnl573C6pxlpK1OtWG/n6kj2/lEP9nTOfW7j35rxmbkmkMtbslhcpXL5TdhsqR4zWk9boSR0VVqd/p0RSuLkU+ZoGQaYQf/p5BuhZd7nss3Uk50R+UZczaPnuXqj/sn48ny408tbwsnuWS5yBk73yT4q9suGhOjS5Kaz1NEz5Cwi6uzLpZ5JzJoJXGLfrixbCMXypuV4YZjsA9RSc/aF203llywm+xEFC22bb2xE+ip801jFK7zYuzYFID7P0T6cMNEcx8IY4C7bmq6vyyEF8hASWVldxxonAcnIXTC0fkVMEhhG7A68+7LmmtTBwseK4YMdJiSmY45o9uM8gYt+C5VUSKF76Teznx8PRut/FFDwpnctY+v6svljvtNOhqsol/Zwvh5evbRFJAd0HOYzJ1j+P0ahwxf2bLU2Ahqge91+Ad0GQOFC+qnvuOfPcJ+qgfrkt9xYmUiLQTDZUYpe+lN+Y7ZjSbcuf0M5E2DVuY6pNa9nIAZkDTF14nJFrbDtM0iMXwGW2DZbrtMtUGAq9HxANfwdwG59bVxVQ+LvzdNPfBSj/OBLixMShUkI7Ok8Kgf+7E2d7/UjZL5opdRebtW5U4cGlkQjXteiu9fAB/+fsQBlE1mD2qfaUOXAI4VjAEqBseVy1SOcezzk7EBfGZApIVz07YcbWcPGSzb0GrLvBXs6k6FSndYcp0Kt6piAl3kzn9VvS5/tK4wF2J5d19FoZet6DW88Ik2DQl6iE0PbvgoLN857xz2ReZ38useLh19N3Kf9ATbHn5sGofsiZZD5UkfkfeEaT1qRSezLfzhV3mxXpAEjS6z2ev/JoBTBfqyHgfVAdVKk4DgTUp/jhl4B3qAYBy8o8zTaqq3NcX91YfiaEXn5rH3Iwbd BzXULjng fadpUHGuz5QVWyessr+4QkLpwojIpeaeszX/eStiQw6usKhIwGDqWfGgxghPuMYX0ie3cul16wUzs/yG5/YsWoHHjfduMK+lVDd3YdRL9sGkO+O9J87ijm2vQQ1nxjmgGmrpp7aI+fEjSbm4eWj7dmG9xws5bvWL7LXzO+ph4BmMIaOah+x6QY0ynBEH23+D5SUYMVXQqC5vhoZWmZGqiY1VpeiH7zA30BQLl6GiFsnU5R4Zp8+zlCJH2XZNpqJAv+cFqi1m2c68kz7wcEFXfRXhUUvICSWIJHtNrZqMTJKS6cUSIcvGwU/e+DFz3Z/DYbwWSEe41K4oipRFWu53qJQl425jbJH5Vtmol/A/ZeCmxQBw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004310, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/09 01:20), Sergey Senozhatsky wrote: > So I moved lockdep class keys to per-zram device and per-zsmalloc pool > to separate the lockdep chains. Looks like that did the trick. Also need to indicate "try lock": drivers/block/zram/zram_drv.c @@ -86,7 +86,7 @@ static __must_check bool zram_slot_try_lock(struct zram *zram, u32 index) if (!test_and_set_bit_lock(ZRAM_ENTRY_LOCK, lock)) { #ifdef CONFIG_DEBUG_LOCK_ALLOC - mutex_acquire(&zram->table[index].lockdep_map, 0, 0, _RET_IP_); + mutex_acquire(&zram->table[index].lockdep_map, 0, 1, _RET_IP_); #endif return true; } and mm/zsmalloc.c @@ -388,7 +388,7 @@ static __must_check bool zspage_try_write_lock(struct zspage *zspage) preempt_disable(); if (atomic_try_cmpxchg_acquire(lock, &old, ZS_PAGE_WRLOCKED)) { #ifdef CONFIG_DEBUG_LOCK_ALLOC - rwsem_acquire(&zspage->lockdep_map, 0, 0, _RET_IP_); + rwsem_acquire(&zspage->lockdep_map, 0, 1, _RET_IP_); #endif return true; }