From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B50C02181 for ; Fri, 24 Jan 2025 11:10:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 941FE28005E; Fri, 24 Jan 2025 06:10:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F261280059; Fri, 24 Jan 2025 06:10:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B94328005E; Fri, 24 Jan 2025 06:10:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5DB4A280059 for ; Fri, 24 Jan 2025 06:10:05 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D034B81175 for ; Fri, 24 Jan 2025 11:10:04 +0000 (UTC) X-FDA: 83042075928.23.91BD1CF Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf16.hostedemail.com (Postfix) with ESMTP id DC34218000A for ; Fri, 24 Jan 2025 11:10:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="GukYh/a3"; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737717003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rsQqFrj5wiHVQnTcuwyACOfOP5Pj2//NkW1GZ2SIQbQ=; b=WEwK/lNBldNgF2807gm/9gvPaORaftWYV8QohvKJz75LAYHAoX6ZKGrE7wln2oeYbMlcl5 RACXUFrhL79tUvLrsBun8mzbbqaQRlE4FGCXfUypwqm7acYS4SWcXTW7r5KP3dhIjM5jTN cximYpsDCzRvDSYoVyLgpV+aacK/cZw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737717003; a=rsa-sha256; cv=none; b=at17CA7LOnVVlZYAMvQJzXS+DBIGhKVI/sSzcNo+mkt5KC9HmhG90eDa50VDG+pzuaR7CH jt+Xgbx9+yFQeYbJerRcT1SuykGIxwN1OGFCTlclrc/MWjECnilhL922yqNnH6tfxriYHY Rkkt66mDErkCo/rrHVn+bmtwTAGCXFY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="GukYh/a3"; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21675fd60feso43898475ad.2 for ; Fri, 24 Jan 2025 03:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737717001; x=1738321801; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rsQqFrj5wiHVQnTcuwyACOfOP5Pj2//NkW1GZ2SIQbQ=; b=GukYh/a3CAqwUkHZsgQYPem+dLlU/SJ7uqAghKW+K61ZX1SYNFkGl5XoxpsPoRI2Ke 2475DLyaj9JE0KQPnCVPkk8Hf0pkzQ8OiOtVKERG+3giM8Q5QZ2AWXXrWFSXlQSTEiHY adaWx2Q++LM8NXKg8hy/3FoLtLUaWFWsCC0lI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737717001; x=1738321801; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rsQqFrj5wiHVQnTcuwyACOfOP5Pj2//NkW1GZ2SIQbQ=; b=dHrXLOYpPju9HkkN8A+HmmthZ10EW6GreM8QNAnSfQpSuJ8iq1gZfNSj8VXyRXuB0K TXQUVo0ahVsARoGdc6TwNoZKtGYOW7zMXZmYemEI8Fh9aDL+DcGWrJB85WpCThOMhMBr 1zEiy3NpP8hu1tjYgdMLfZwgAVoAo/BGRId/4unlU2gYRHwF9gH8O7NpUrdqm7flOSvr dTIZo2sxBMxJbphVJ2W5GubQTfWl3JTdrlxssQfHU4J18oNJDLJA9WgVYIDsRHZvilXk nbxqm0+XTSWIHDQeHTzMsLrVeDI3jDRGANMR52LTy8qVcGR/T/lN7VySjfduPDznW3/j 5Z8g== X-Forwarded-Encrypted: i=1; AJvYcCVzd8msAZHeAKm2KIXsJQQv1JXMIDAF0UIqX5U1icPg3oG9dk7Jx9pPOCSFZbztRQ8RaoSdvYRWIQ==@kvack.org X-Gm-Message-State: AOJu0YzRyfgWVEpYfVvH6ab9yVaFsm0+mMYUUGN+eIvB2p80d3Z+x8ko k+zV/750bKRsFw5IgtOZxyr6y4f0cA3qb+7qTVImnFPfQhLxvufdhqMOrKOKtA== X-Gm-Gg: ASbGncvol6nv64UdcS+3xGgjem7OcDuqucDlB3j7k7dVmP/I/WkUGdOZRprCn5nU1fd KmHfc7+2vNhoduSvbsLnEEt+79iVPbCU8RzF48ZNyib3Grk2kXmvAtMgpNsqBGWxK+METnNC4qW xcYfDHDT68a0SwGZ3wasofyS6e3tI+ZSC2OjNPn1xzHdFlXUOLz0DJRxzo9VkvrWAcCTZXo5F6e xsNM4fKxZ8ZzYHuKNCX5bE6bd5baKSUGs35RO5IcuNxd6YdOI7qEaV5ohyjL9J8VNq70VLH/udS sZcj5TSk X-Google-Smtp-Source: AGHT+IGpOw3b8EwX3NpbCtij0gvZFd3QSj9NmIUCwTO2LVRQcsawCLxjkX7D5aFHUtGdqKZjEEajxg== X-Received: by 2002:a17:902:c94f:b0:216:25a2:2ebe with SMTP id d9443c01a7336-21c35542151mr487780295ad.19.1737717001616; Fri, 24 Jan 2025 03:10:01 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:4989:d5bb:e88e:bb01]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da424d59dsm13605175ad.218.2025.01.24.03.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 03:10:01 -0800 (PST) Date: Fri, 24 Jan 2025 20:09:55 +0900 From: Sergey Senozhatsky To: Hillf Danton Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Sergey Senozhatsky Subject: Re: [PATCH 1/7] zram: switch to non-atomic entry locking Message-ID: References: <20250122055831.3341175-2-senozhatsky@chromium.org> <20250124103009.1761-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DC34218000A X-Stat-Signature: 5tqnh4oj6t14941mnir91kau3ezyqszo X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737717002-909736 X-HE-Meta: U2FsdGVkX19QO51tafjSRHc2CP1+4vVpPKQOUKn1fNV/pT5N+L7AmO1MaXr04rWyeG2mkih06am5JSbaG30z/oT8xEw3oSy0l0n8+n78hZH/c//P+cjbsjSaeNZBcKPpM9i/Wa+VFyMQGZJDq/05zCe9DRfYjYutbU2+llfnW6WRoYo3Xf4w0+aFEPX8hyaRl0zABWcdWiXXcWhR1sPlcBW2BbOf4I6tlKnfKKd43mpRy1gJ7o0Tz0iRXSNsvTaShOpGIvtv6Gr56akKbss8YvGthwWgCGMAG2cAGlL3/ybpueFCTipUtnViBFbkPKCPd4fMEh5bVNeKYwoxYwGaMp/9vtkqNhNwgY5jyX/M54fj/WoCfi/1VqJ0xttbvWrGNHedAZ06uLr26Vi2sziKrFfEHl8XYvL3LccXrDomTyhD7grYKDD96NzOAdB6XO43XQK0EOxWvJ0LapMdLZp1k016IED1CHV0DNYN8jlgiPaWizdDLie4bSN0BrJ89a5h1QZ6wvgQ5AKk+0WYI6aWvs1oaw1hHFY+pbvF3KU2oSbaDW5RCUBubvDPEym4TQbHbKnHK+D3ubb86JfmPsXuatLmmIAnrHQiv0hgmWP17XlkcGKfUG6kJC+t+dUU1eUA1XSVdr1US7gUyrzfnsItXTZvaFsxsmzzHVDWLJ7Pg/JqtW9UGhzI6X1J/FbbX6x5cIyjSkicAP1QE8grV+q+qQxmG9bvLtd7NAvNvtcgchkcAT/PYwEF/ttBlA2KUarAYHEb1Z+QRtLVAo7rp9OhykFNzWrWKQ5AJneihQXm4E6kOOxEDufvZC55DgOqm1WzX9EMfo3znQmkUwQSShrx/FaSThAY8E0YFRiGGAkbh9yEHwe4aQCtwt/VJq692KpTQojJETbfB6eepslFZI3yU3XQFzvdQ9xLmAS2XpZbedi9Wz6fhCcKxOU+sAvqh+3OreKp1VPT0vJM+N3l5Rl HlTWnO6f fcwzP6wJsLCOwU3/mDfyGbzZa7tEHy7bH31ReJOKZQysgUZHBIqSTo8jRoJuy3SQY7i54EfPwCO7H+2wh7l7+OBgkO0c1HkcPFNDUvLv3zY4ErC8ybCFnlciX+KoUerKOm4hImAkdhV0rNRksN2RvK6Ys8R4I7ZiWTlXM+eckEqlIRX5xsK0uqn67VZhhHVLmByc7q3OzktZ8tdCiFdfHiaCeMtV6BCm63TzUYezfCd0FatP4M9M4V3BgXgystbRipDHCxQAGmNG71v48l8tRYdv7adQypZfvjzPAKFtbOJ4WylnJlR3NptUQDRnnvXYxwAG0Tpy/k6FKcXHRaJQl1JhNWYkUjMd7bIOvin67iFvLnn4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.011331, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/01/24 20:03), Sergey Senozhatsky wrote: > On (25/01/24 18:30), Hillf Danton wrote: > > On (25/01/22 14:57), Sergey Senozhatsky wrote: > > > > > > - for (index = 0; index < num_pages; index++) > > > - spin_lock_init(&zram->table[index].lock); > > > + for (index = 0; index < num_ents; index++) > > > + init_rwsem(&zram->locks[index].lock); > > > > Curious if lockdep trick [1] is needed here. > > These bucket locks are not part of the v2 which I'm currnetly > working on. v2 will also come with a draft version of new zsmalloc API that does not impose atomicity restrictions in zs_map_object() (no local CPU lock and no migration rwlock involved.)