From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97DDC021B2 for ; Sun, 23 Feb 2025 02:09:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 631FD6B0083; Sat, 22 Feb 2025 21:09:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BAC96B0085; Sat, 22 Feb 2025 21:09:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E64A6B0088; Sat, 22 Feb 2025 21:09:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1D1C86B0083 for ; Sat, 22 Feb 2025 21:09:45 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B22AD121E78 for ; Sun, 23 Feb 2025 02:09:44 +0000 (UTC) X-FDA: 83149578288.08.BB73270 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf18.hostedemail.com (Postfix) with ESMTP id CD3C01C000C for ; Sun, 23 Feb 2025 02:09:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=oUbXtC0n; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740276582; a=rsa-sha256; cv=none; b=hrDHE8t4iIvYFdqe5bPRJlexCthTowFJ8al4jx3pLPHPc1G1PPBxXO3vxdSrd+SzYwDqyC 5mUjNzg1j12RTn5bsU5Tp70/foUFMh5GA06r+LuCF+3dPoQfnTUGFe50zaZ2TclHRrzQ7O xj0lWIyP46V/Z1fWP1QwexB9PO5Uetg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=oUbXtC0n; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740276582; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iKUNTxI3ScxWIEmge1ue/3A/mxxEuL0ykQJBIUwpXck=; b=WnctxyL1Vhl1AEp0bHssrDTMtFOEc7e8JK2iKgdR91oiUPaiOdNvBMt3HDbNo7rEGc4LWM 0tTvUgE6KgzEa46knceS8EWxxdVbdaxneDqltxm4PfSaXcaf+4VM8jWbBc6MOdDx+3nFJq K8OdvtjWaxe8uUDdhnlQozYg2lZO1ew= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-22185cddbffso70913375ad.1 for ; Sat, 22 Feb 2025 18:09:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740276582; x=1740881382; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iKUNTxI3ScxWIEmge1ue/3A/mxxEuL0ykQJBIUwpXck=; b=oUbXtC0nttAl1GF2LpVqVT3QaoGDqUFzEk6cEjTHTdGcKjWSL5ftMdyvHs85iswFfp 41/dJPw/C59fZEVR/2GfkDY+IZDUczyiOX3uZlQyW7svlKbBUiUn69RRwvyOm2Y4QmzT X1p0MEmvtBt5fH7JFPR49G7hul8HiX74SZ2fM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740276582; x=1740881382; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iKUNTxI3ScxWIEmge1ue/3A/mxxEuL0ykQJBIUwpXck=; b=vXFRs72C4UTog+bVvqKE1l4lmEnLZeA09hGNaIZQJFmN8lE8G0yglzGkfjGCoM2Y/1 IsHmfxOm+Q9bmx1h0OxCGZ+32Mti9nox6cAR5a12uXE0+QaM+8l5Tctx63AfJ4TPwINi S5X6lKcSKbMpmH0QuIMsekRxOVF0ASCCIjb8DqCFwKJfzbRhl+AdK0R6V6mWXOkl4Wqw 7rU91JOpTHx8Vz/sNyJWza2bgpUvq3SLHSM+SUW/7Jh4L8WJoL8Us5ZhbzwYvxcMjM1c Gl6aVRV8fgx30a6DEvWl6ZdWAeXjbG+ZiY1exMbDpblNglpY1Ec4f5ezQPsYqhcxpUao 4X/g== X-Forwarded-Encrypted: i=1; AJvYcCXxz5CvokJMle5JroCP6ZOEFaH9o88r7psi0Kf7Ad2L3eUf4ooTIOA55jxR8/kvjIStWCM5E+QLiQ==@kvack.org X-Gm-Message-State: AOJu0Yy+L1csTjpjpuTpPHGbVtH0Va3PvmS37oNQoy9x7rCkSqDndi0R Sb8OD7zD4iyxfMmu5HUD6WJHVYk5+DuhAGxnLElFtIpbgb//t19efnLe54yqEQ== X-Gm-Gg: ASbGncuLEwmoO6YW4FnXSCwrG/+W0bxK402VKNubSnsUV7Hsn7fIaqQNC3HE0YCTY9x i+VJS3l9oBHXF3OyQTQ39OWdhrSoqqxvhEP/KdYO3Qv7PGnpxwCgHc1pHtxxfb+xawz401GfG8V e6/LeznKBq6Hl7N7dCf2IozlU3Fi+ke41/3ny5wFOJWN9tl+tMIsA6BLDz3Ye16QYyLjJUF1ku3 fQxvq8b3N5gLBOQkfqLp+NR23qqMCuNWh7XzFgTPeAEudJ/0emuiSXuCDUXAMp2AdNTiu9xsfPm jae5SOaxSZJuym68KZbYncrqxHci X-Google-Smtp-Source: AGHT+IGyOWS8SdxcnCpNXmpsnOdPgyaUof7mfUQNC5miFn8aT5EBDEvVNb2Ow5PqSGIOE2oJnFkx1w== X-Received: by 2002:a05:6a00:991:b0:732:6276:b46c with SMTP id d2e1a72fcca58-73425a1fab8mr14109564b3a.0.1740276581776; Sat, 22 Feb 2025 18:09:41 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:badf:54f:bbc8:4593]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-732575e055dsm16497804b3a.68.2025.02.22.18.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2025 18:09:41 -0800 (PST) Date: Sun, 23 Feb 2025 11:09:32 +0900 From: Sergey Senozhatsky To: Herbert Xu Cc: Sergey Senozhatsky , Barry Song <21cnbao@gmail.com>, Yosry Ahmed , Minchan Kim , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CD3C01C000C X-Stat-Signature: me1nft3pgumyb5owm6mgx7qa96zznd63 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740276582-103459 X-HE-Meta: U2FsdGVkX1+EJHCOeo5y+pkekaRQEiFWp+fJrgbRe8p9SM3XwN12Tt/Fbhc+t+Qsd+Nt6EE/adefdpataCVmtG5NA1kbCcGowvSESYmSjwfOA5zrfU7mHYPM/n4XH9oHQofYVN/JUMeLcpvdXkssortWELKRZw4uZMM2GjQdIqKMG1y8gSaG/a0/tUBg/vdDO66YkV5dGcDokYLpFo50LUQSPqggID3fO9Sx2cEUHGXzKFVTgb5ZlkgRPueaoOtcFhsNgBhZoDRABneBXiuVoTo4Nu3NIr6ADVM4YIIsfxUqJds83NYOYnC0hxue1vsXS6N8C7Jx3ZhfaL+X96fiham05mHfFBOeA3SU7oWpL+iYEtZ6j8pYjMNvQK6aVxOGYZXM8DfgZqBbIQx7Pb1dBL5+NMgWMBFtGOFERYOsIyohD6NWkBzsGEptZIIjftlnlTUoM692AKCtvEvS0nf1B98Cn2SEtQI9UZUX70HdVTSR8wFhsIOK6OTPBro9Zez7Z7Lje28lvwua+DbhJ9j1zT8FT2+EFnK/A6e6t2tXoRKEzWZmWcCBfZ4/SL+7I284fF4azfFWLXhp83aW75UpwKDfK5fQ3BBqjaTKC1LcTsLOZW5H0xMu8zRrREOhwt9GQkBLDH+z2pD4e/oAL4JqjMYzm76FNfT9o53ArFQyA2ofzVXvaeYnmRKWMABknn1IGk2jTwQYd55larVGk/CokuCeo5jBF3noQt4LnhR3aIXWYcmVZmp/7tZ6/fidWRjprkYB/mYrP1qcmhz3If7YIqewRT9ZWqigu+fRt9mD9xwAIYx+/4m4N7IGVk+9pFR1+zYH3JsHkRf3CZTcphsE8Nyo9cO+30uEJYs+elAgpGvhb4GUjqYlTTMa2Va6J5b98eBIGtwVk86fX2fd+rUVp53X+zoCnovaoh7z8fCnc//8lAm1z+GxdScAuWJjcS4eiidkk4S15r5zp7PDYBQ LbR6wNC0 cdjM9VMNGipxzZziU5eCsXSUfzEDWhRKZ3BQRRPJ2W2DJt2mKAQssI3ucCy9OszAAyKVtBDnFg0XV7rnY+NA/EVF2aSgO5j9pHqVGA07vhtVHnNcev8hOFhDbqAXGP2qGN+XxHJDG30ppK7ikf4tiFCIT7JVo6ZcObsLt7wHdjKqJFFloRUtJVzeoLhg3P8nImhmJ6KYfE5TdMk46DkQxRQk3VCqVt7X8TsoH6Cte1b2uYGmtlF262Vq31RFjWeOign1vfj4cv/E/FGOPoe6iNdcYwe5t8Y+DsNPTtLnuT3teBeLMq8wNZ4mQVoM/reM7cIW3vXCB/uyrQJHdxPEgzEwl2bRiljY89i878cDvS8DVmJvuUqVbF3BWTVtirwFuo3zrAqPzqNT9NdF9i/LNFdUa0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.022159, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/23 08:14), Herbert Xu wrote: > On Sat, Feb 22, 2025 at 11:27:49PM +0900, Sergey Senozhatsky wrote: > > > > So I didn't look at all of them, but at least S/W lzo1 doesn't even > > have a notion of max-output-len. lzo1x_1_compress() accepts a pointer > > to out_len which tells the size of output stream (the algorithm is free > > to produce any), so there is no dst_buf overflow as far as lzo1 is > > concerned. Unless I'm missing something or misunderstanding your points. > > I just looked at deflate/zstd and they seem to be doing the right > things. > > But yes lzo is a gaping security hole on the compression side. Right, for lzo/lzo-rle we need a safety page. It also seems that there is no common way of reporting dst_but overflow. Some algos return -ENOSPC immediately, some don't return anything at all, and deflate does it's own thing - there are these places where they see they are out of out space but they Z_OK it if (s->pending != 0) { flush_pending(strm); if (strm->avail_out == 0) { /* Since avail_out is 0, deflate will be called again with * more output space, but possibly with both pending and * avail_in equal to zero. There won't be anything to do, * but this is not an error situation so make sure we * return OK instead of BUF_ERROR at next call of deflate: */ s->last_flush = -1; return Z_OK; } }