From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15BFCA0EDF for ; Fri, 30 Aug 2024 04:12:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 641186B00B1; Fri, 30 Aug 2024 00:12:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F00B6B00B2; Fri, 30 Aug 2024 00:12:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 469936B00B3; Fri, 30 Aug 2024 00:12:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 24D946B00B1 for ; Fri, 30 Aug 2024 00:12:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C0ABE4141E for ; Fri, 30 Aug 2024 04:12:24 +0000 (UTC) X-FDA: 82507589808.17.86A0630 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf11.hostedemail.com (Postfix) with ESMTP id 6323540006 for ; Fri, 30 Aug 2024 04:12:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Zbs4haTr; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=U9HvS4Jc; spf=pass (imf11.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724991070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P+Ki34MyhA29pkx8PGriq9Vwz781g4xFX2xeOxvlXP0=; b=tk8q20xc0AuqfKIrWAuplgT312XU/fz25XHHPyf+9R2g/Wtns+HbFDC82enL0BG8GuxPgT aSXXzhXOQKXSkW7p72tuhbDfz+UwOqiQNPqOTUpGfBgh4zM1MxqvLCCeF+LX7jWCbEtrCb vmaqFiLFaypQp84W9OTYitj3ic+Tkys= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Zbs4haTr; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=U9HvS4Jc; spf=pass (imf11.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724991070; a=rsa-sha256; cv=pass; b=S1zqR1hgWVPFsc28dcEgcnw8ytDDl6yAJXVaV46vsW9b6j+f7cYgySv/HHtOVVkbKLWKOl G2rHHiLv1ai+dThysT3UTpE1VXmNqUNcbQsaRbw8EA7sDfbcsRL+Lm8U0yFrl38u1/ciPt 1XTbMlgc0GWpvUSUiyEvhpgYgVM9BHQ= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47U2fiG8001321; Fri, 30 Aug 2024 04:12:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=P+Ki34MyhA29pkx 8PGriq9Vwz781g4xFX2xeOxvlXP0=; b=Zbs4haTrYeVZr5RrHHu+7UkONU6OcMS y7FjJGM1+xOC+eCSoQe/UCiJuMPtkT9tTsjQJYk5mlPAirWIovaL3cfBSFUrKZ7L 0GatojVXCBCUU9JlR/MTg7Oqxt2NqtWQkHu3z+EXWU9oLTQBb925Lq8QO+zaViou sTp8FIHn/drm3fvxU1cNOjpHFfuZMVygToMOf3fT30gaWE8wuvISRsFqaJHveLm8 lELBo4IJbJcAshrKWDLbxy20ju3Cbtzp+FOFV16kwmQtNsFnstWAJUMvlWwik8+m o2Y/Kn/NOnA3vPyT4OdTtb2Jnbr5kaQQ/uIfbbjvQosv2Ads/g/kZEg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41b25qg8j8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Aug 2024 04:12:19 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 47U11Iud020314; Fri, 30 Aug 2024 04:12:19 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 418j8rabg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Aug 2024 04:12:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rk3qf3djJ2mDQsllvMAaSPycXiqi7ORFM/PMiW4J8Nzfq54T2yAUemDkDD3XEeF4vc5gNIoK0Bh11ddR7NJIS+Bh3cAsB0venqucEwbKFZkhwRT96V86GF3Y+HBqlEXeiGSsh4ekXKxJY47cClm/57mVRaniX3MpGvA9tArTEk4O0F2gWKz+1UY57tytdZ7urysCn/0Co1twoRz4vOC3BVKSe4/KJ8AKcEpNqEXvb7tHvuL2+qSly8F53egMrT/bPl315gSTwAxJkogIfdnR0XpEdg2zS4jHVdT5ulkKbqxqY4W1hAOHl+ndoXzH+nnqOtrHHIJVFaSqsZMuGsrTQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P+Ki34MyhA29pkx8PGriq9Vwz781g4xFX2xeOxvlXP0=; b=hPKXszhRzGmDjLc5HETcTNPj6gKq4asFiTDxMccoFSSAX/TrEQ5Cpq42p8kHTUUbEgIutzVp/EmGsn99j6yLJB7l9yLk4W96E1MzqPbhCrwubcuCi/NhYnVgTcT/cxzekthJAPlzyjgerUN+o+Psrqc8tRzElK0cmR30fBZpYE3jbdZS9aXyMu3Ac+i+qWFBAUYQxLM6s+gGvwq837oBMXuHrqKXfgmnc5s/q/8E3bgekMw1Y2MZI9ZLcV5r37RKvt5K/81G+WF8H4z6cZFmrYxmbWcP1jG7URJ9gJtz0pdKrllg1RcaFUforPzB+0DVrXC5dVJHnOKXuepDMBz6gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P+Ki34MyhA29pkx8PGriq9Vwz781g4xFX2xeOxvlXP0=; b=U9HvS4JcJi6TY1BgDwfS3AiWNBVqJzLvthV1ScUh8NIDhLKG5kPPYsKL3MvJaK/+YpYsXyhZJ5UsneN2PNmt1STVD3h6dEj+ku93lfGMxnIAoHmbbNS4gVrXEiGpch1XGyu2LtiUEznA2vblDNQxhiTV2RUY/LtsF3D9bSeLGrg= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by LV8PR10MB7752.namprd10.prod.outlook.com (2603:10b6:408:1e7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.20; Fri, 30 Aug 2024 04:12:17 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7918.019; Fri, 30 Aug 2024 04:12:16 +0000 Date: Fri, 30 Aug 2024 00:12:14 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v2] maple_tree: cleanup interface descriptions Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org References: <20240830025648.22224-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240830025648.22224-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT1P288CA0007.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01::20) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|LV8PR10MB7752:EE_ X-MS-Office365-Filtering-Correlation-Id: 46f3a912-d0e6-401a-a043-08dcc8a9ef06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4Kw9dGXg218Fsxn1X6TfSKLFVAzt26leTqHUlC1YyLfxX/bpSWcg6SNy7/BW?= =?us-ascii?Q?iN8Ps/frwuJzNiap8GA2c978SccDNr991h3F0mTgsDaXdbeaNXPZoMj9zKEQ?= =?us-ascii?Q?bmt9eH2rMPXK1bJOmuVObQK9bgoL2ISWKj7yQo+xnL17Jnc9h9VAO3p8rT30?= =?us-ascii?Q?9ijx326eID4jVGX558YVlVXkUvyKU8g/78reY65fuoZVdcaiyWrwxktUHa1L?= =?us-ascii?Q?k+sd5g06y4jdESDaU4Esy9VfXu1QIOnuc08vr8J3FB/vlucs2gEwCcaDgTy8?= =?us-ascii?Q?rROIiMKc1ZL6cD/x9wDUgvYRYeXH1NWqoZlPGWI95rdzCqntSAJVqAu0/sSy?= =?us-ascii?Q?vi9wTFhvKDCc49CCH88tBJX/kK11Zd6D6vO5SNqZkNhti41doIuXbNR38BfY?= =?us-ascii?Q?WowCqq7Q/G/+x5tscDlIkU0Tdp5URaTJnV6B/iTrACPv1VL9dYPTxhStPlBy?= =?us-ascii?Q?IBi10tV/q1351qa1Jlxz71y8wjm2jMt94WufpDhLRKD9YLDY5qi6uPrnHFdB?= =?us-ascii?Q?jqdg40AmLfrVUzFNd25V8iCRDhw1ZDdJgSH3NsLAZR5nDek0vZ2793q0ta25?= =?us-ascii?Q?DY6o/yVBKl9I5WIqT/JtJuUPBjD+xzyf8m0ZA5o9L734ovoJxfaGSlQBjI1b?= =?us-ascii?Q?rZw2MsoGJ6gmrmr1Erw/KJMQ0nMFP39PBoi3x4CieTyE5WoO3IN9d3vZtaFJ?= =?us-ascii?Q?w6Q1iIinb0UDLIPMtKk1nTFKmdpdQ9Wr+lEvUGXn2e88zpRf5u2/cOfTwMjW?= =?us-ascii?Q?+hF6w9yG4+koM7EKOJ/byINyBrYTn5EfIBVahVXvNOy8iLkBrvHFEVuT6mx1?= =?us-ascii?Q?PAB7itNNutMRL0+D9hgHsK358nloLoYWXlc+khuy4OEzV5IXRd4VM5EZkw5p?= =?us-ascii?Q?YJ0YWhy3pj8RlnNulB4IQ+IH52rMrCKjNb6d+16Xk6lPmx0TK47nRr7rwPKe?= =?us-ascii?Q?zMDyYKaa/ayWRAC7T+nL4CKCmGLoaLt7XaPF6yC25lKeZK6qkntXmjmmjmaU?= =?us-ascii?Q?eJbWoPc9DnhQD4/EK1qPHaQaXw2rux2ipq0zxjqahwIw53QfUKCczNWMXdfK?= =?us-ascii?Q?xILrQ8sRb5wZ+vc+69ClAiF8X/HwmbUCDskWwZt7qDYT+Lr4sj8l6tDdRwyK?= =?us-ascii?Q?UwIIWZ4l9jHiDwr1udfXBKulbhrl0aSmTMCmO2EL7lqe6ajZtuaj+5/TCgr4?= =?us-ascii?Q?PNjN8kcsQpf1W02uQywT5bb0KiM9JLvnI3trARnrpu3pBerKjYr/0R6MNpfZ?= =?us-ascii?Q?K/P9s9gIHSi4Uy081RZsstujPKYr1kAvxHaJ5vkWnBu/NN547pc8lY1dQcmB?= =?us-ascii?Q?pZ2rArGdhOY4tlUc+e5RHYhIeZentNkqscJ8LYPyp5mRgA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P8ohuXwgoukoAwdA8bJA2g5pVGhDy4QoGy8G/VGxmaaFe7EKZdOcv1Y9Y/V7?= =?us-ascii?Q?RArVS5kw+OSmIPWUQ3PqbWrCqZZC7qzXE6YQ0KlZv2wE8jsd/I5b+OLjx4Bb?= =?us-ascii?Q?nTx11mq2Q+p9vIkYF/GaBx2pAKExQXr6khn/y0bw3GMZw1bwe9VGKkG8dVbE?= =?us-ascii?Q?cEtgDgpsleroherwSuIISxfZ7YLNvhBjuvzNKgUksaKX/UKKIvfn2YC37aEQ?= =?us-ascii?Q?9gEtEYrpXAx+iw+T/dYBPwGeDWgD+cmP2svdfGAtkhyaSUvTGi8GH4xPfWjF?= =?us-ascii?Q?grPTxc5nH0wsjSb29GRr8xbsjHgtMnROMZkRRj2jzqkF6q1M+B1mR2TylYTI?= =?us-ascii?Q?fr0SH5+Wz8zhWbl/qBX13mP20gCSmyA9nvjZE7N6vcR+hCdczmQcs7khYK4S?= =?us-ascii?Q?JOBTa4NNwabYZZCgvl6iAbTFEFtwivMN4hZ8MG6W7edrXh/zmWoDqC63jBCV?= =?us-ascii?Q?sB6ptMyeMW6WMCbasc3rc9lRNv+emD20T6gCa8FQisEc6gOHestPMxJK5tG7?= =?us-ascii?Q?pK2GatYHg2Pnmr9+0yvKkxKeH4rkrO72MvP92woxsbGR0iqpjUKvGJEC0rx5?= =?us-ascii?Q?Yua8NFD36JR7CucP5pLdruB7+tyD8IEPOvu/zjnzub7kTCF3WmtdYZd0rqts?= =?us-ascii?Q?zBHwozUe2G+LRvFXtPyjJbOYhgq23kme7fDeo5yGU5enIceUf01PE4tEpnKY?= =?us-ascii?Q?c+Y5qTCOJArOHfUgrjyAYUSKJ8lRgSj8h4gg5UOpcZCPvOfXN9AF2Sjxgk+K?= =?us-ascii?Q?li25NsCCqds0phMA4A+M79PajRGcH+Gk3zrOBcw35WYmj9I3gTKpcGMyRels?= =?us-ascii?Q?OrGogYhNDe7kWuCUjnPRQXgvWd6XfHVUn3am/lVO5mBJZ+tTRf6SDGcCWfrH?= =?us-ascii?Q?nBtJfMGO9WBMzKb3hFTVuvVa3RTzxvE59c5Grv5bpcNzecxgs7YKjL9641s5?= =?us-ascii?Q?GDpgF+eEsUr+NoWsoKuUS5JvHMcL3nqpMlztuNA+Bi+4P5ihtxl3/7u5Hy2q?= =?us-ascii?Q?DYSXlilAFM6bmqVdZ8thb714+aq2zlBiYU/dqpGf4NmkPiiZjHcUY9hYbLie?= =?us-ascii?Q?fpO8LCQH617TvoCr8fyU8Kwjm/i4K7jg0hIaWjjpQZk96NixpRUTTW/qvDRY?= =?us-ascii?Q?SpReWqsqshPdrvVqKgvB3eECAmwgKrvsUbUaRxPMIWIu4nCi61uco3ejY6+6?= =?us-ascii?Q?+h/CwJHW/FxNxV1Uxvla2gyRggwpFvkxFeJqgIZM55qonmvR8YyqCnJWBfyv?= =?us-ascii?Q?QhV2Eh/j2O7ykNbnCYNLzfMz3yXCvNGd4Z9D2N5uHi4r5xHPbLg54OcORJ2u?= =?us-ascii?Q?OzGCcf0n6dUszLGc8vXey1gCqn9MwxUedKVcoqJAtW5khaRrVqj7HvWKPswA?= =?us-ascii?Q?p7xiUuVGixecQ0kUcAh4ioidGrFF+jYGDR7ZzO+ZtnrN8ZMGLA/mYtvaimyb?= =?us-ascii?Q?S3fK/NGZKhXIUqMBa1eo005JvlOrTPkTeaOD3dDj/K/yl5yE2X2areTXji2J?= =?us-ascii?Q?qtwtYjmPq5U4O086UU8R2qlx7rUm+2YT4WawAE+TYQVhYQ7HLni9M7KDS34d?= =?us-ascii?Q?qm+nSXM9j0/5ZCTn/RcuLJsFuxBLNDlZbrJnat9SS/okcjAjUbTuxi3+KsD2?= =?us-ascii?Q?Xg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NvGrpWIQGkf4WndC829kxVxeKyAM4rFgnvAQTlNtQEgzPPN4HbRT+DJeCFq7fZoycyWk2am17OgZWXgHhjwgO9O18XQrspujzoD7W7+qO0JUWnNhIQcTMcMhgIbWXB/dwzPx+c0HZGFRCc7MzhZFN1f7KYBZ6RsgJjEYR+rAhB+9GawUuGoWZsy215G+zaFdqdOXn3aB0z7jBzduy9LZyP+b/ESffzLobf5bkckb1bBrdpZOQYfc6RzQMl56ojXYO7ld4eetBl3UkjvwcK36l+VOJpiJkweKB6z3K5rAfXHaZp4VX3zaS6U6E0z5ObwYE5zXyLFHy4LEqfOZylS4WOgifiBMJaOag45PKCqQJWV5bJ+3aZa3LN3CXzaiUuN/0lwoE3ze3HfP3ebGXeWOZ+IADFm18KZo0J4IUGMLDGlBB8wr4Qa1qIO//Kw+60Lt8oA87Etb/8q4HgU2tnhc33q03VMwHJ3Ry6etEej5xiKfrPEtDRR67Ue2QSsJbNTfl8KFddUHAZkQ5cxZ+dtfkxQFFB1cky1zKNlf2N3DTMeGNLaIvJ0EITqopjDH+wZpNHUHkiDnwH4iWhr6JkD6CFwAOJFKvnyyD6jN6kjIkvk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46f3a912-d0e6-401a-a043-08dcc8a9ef06 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2024 04:12:16.6093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2rPZ/gtwzIFj27UuQjMoLbELpE02dBcqGfNsXgGhMtdjINK9Ohc0stu99WdeJBK2nyePB8BZSIcAaM08NpGGMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7752 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-30_02,2024-08-29_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408300028 X-Proofpoint-GUID: U6ToH13YvKGJ_QuuK-IvaOA2bBeYOhGW X-Proofpoint-ORIG-GUID: U6ToH13YvKGJ_QuuK-IvaOA2bBeYOhGW X-Stat-Signature: zeebc85wpaio9weg3httr8zyot7k5iid X-Rspam-User: X-Rspamd-Queue-Id: 6323540006 X-Rspamd-Server: rspam02 X-HE-Tag: 1724991141-411037 X-HE-Meta: U2FsdGVkX19mDYsiqlw/okL4znhjYg7MzBqZ08MHmD0+KWTpDGm+YtwocQnk9d3uh2DRHr1t405na4pMkWTQ69lP+TjdyzOVluhzlW4ZW9RfqwlIJhvHv1EDavepTC+/shku2BFsdNTIcVMplrK/OkhNFNyHly0SdhyyQBGm8NvJHmWjvxI+FwT9t+TBOXSF3z8gDUf60B6ScfqTxEWpuTz7666bzFbTf8zLV2RhzClOjP5+tMS4i3cdCZtqWX2N1ZcOh481iaFHtmGhmDlDQ0tdKGKXVXURZC8qcVEIRDMn1ZghxnW7tk9b0zx/vLLQIfD7rKmjxnF1gljcaXsHS4surRsfKmjsJtYiDHLBTRFYv1/c4c39K/X/0+C6kORgnzaJNeJ1sVnpE+WHjMQYDZUJIKYHMBVF210iSFrxh36Q7hRrHwbrRk36C0slpAtCVVCPrQJQvpVBac1+5d6Y9QfVEHEE/EgppuDqPH9NBg6BHRMFroTeRz3/6P7D4wp8mRERzgEnk4JSz7rRHMSAuFs0CTDzrgeHgddYCHjzEfy2mUDdIjEgERtBHjgz2A770cOuzLol2SkIiTYS+a04iBiowqjR3rB1eooVYKgg7TbioyfAZAogFfmTkyKz76fMlX/ef/ps1KAdqQgJ48uTDkzI+K0lnoDp82F0N3lmiSv5KHhAyylPD7sPLgBu834MnBPnaVX62jydxWEtgOyPlVrNv54eIEKVaxNQjpqmBMToxVMXzD733GOvgx/NyM/5PIDn2U8t1iHOii2bO3xK13UmBOnn6G/tzApNE/+TqE08xGItJne8oorF2ziPAYa7w6CradozZIz13K7jLf0Eyj/BL5BLlGMLb+Ojmf8CfonjB6qENnalSliulsMJzbRC9s+94YRhJtkPAu5lyoPUgjtw17suDQ+EHx3Ms8nTMNHv0qkazwHpD/gSaqGxZAXubCXjLJECm/dIXwg3yP0 WtOPH/IJ NadIbEVPQN24o13S69548Cyiz2Xsriju8myNzC0wMITHD7XPjWdQWPGj/kZ3R5PBgTeex2z85YSryv2oyZ5oMdMOgMpVXV1FXZ2Hn/olZajGMA4d9eSdanCKjeplyjuaIgV6RGPRnzTCVzGEMmPowSdPOCBaQONMTmciqGtPxOIRDdJSF0s6ldPCdgLNOL3EI84OlgEadNp8rjlBXBkxBdPLpWk1YYL7i0jOvCQ1ap3wfCdeHpFSQi7yasn6AvdSgHGAFGakcqaFQaFOQcPyl6+nEXwtHXm40kXaRTBN3LPZyH4TaaMnwqdoR9cavyTovXgTGvv96pD9ZC19g4PEsdzi/o9OTF9P90qX4NkSFtJA0/DnMClrfGL6GpVoaU7sqOkUVAtwMx7MOg/bKc++hPljr9hXeQPmwJlBotfm7jsKxM79f3RwBNzz4OFiv8wW49F2V8skuzGUQoWm2JIyxEA8lt16Kna8hLw9zYD/Uvsn72JanFR9KtFWw4YLNEvWOO4XyvzcpL8Ig5phzavkLBFaueeiXqNs8+USDXjbAiiVr+1ziCAhE/VjwJjroJte8RvN/sCbbeFAlhwMpcf8kEnxdDdFy9LBcn/moZTlxBb0AGCuJWkqVJjc7CQrve+HbUooWzYYnO/YVKeOrJPbSO2SXGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [240829 22:57]: > This patch tries to cleanup some interface description: > > * function name mismatch > * parameter name mismatch > * parameter all end up with ':' > * not prefix '*' if parameter is a pointer Why not use * if the parameter is a pointer? > > There is still some missing description of parameters, I didn't add them > since I am not sure the exact meaning. > > Signed-off-by: Wei Yang > --- > v2: > * not change them to kernel doc since they are internal interface Thanks, since they are not internal interfaces, could you also change the patch description to state that? > --- > lib/maple_tree.c | 105 +++++++++++++++++++++-------------------------- > 1 file changed, 47 insertions(+), 58 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 43e184f91461..a2367564f627 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -474,6 +474,7 @@ enum maple_type mas_parent_type(struct ma_state *mas, struct maple_enode *enode) > > /* > * mas_set_parent() - Set the parent node and encode the slot > + * @mas: The maple state > * @enode: The encoded maple node. > * @parent: The encoded maple node that is the parent of @enode. > * @slot: The slot that @enode resides in @parent. > @@ -534,7 +535,7 @@ unsigned int mte_parent_slot(const struct maple_enode *enode) > > /* > * mte_parent() - Get the parent of @node. > - * @node: The encoded maple node. > + * @enode: The encoded maple node. > * > * Return: The parent maple node. > */ > @@ -641,8 +642,8 @@ static inline unsigned int mas_alloc_req(const struct ma_state *mas) > > /* > * ma_pivots() - Get a pointer to the maple node pivots. > - * @node - the maple node > - * @type - the node type > + * @node: the maple node > + * @type: the node type > * > * In the event of a dead node, this array may be %NULL > * > @@ -665,8 +666,8 @@ static inline unsigned long *ma_pivots(struct maple_node *node, > > /* > * ma_gaps() - Get a pointer to the maple node gaps. > - * @node - the maple node > - * @type - the node type > + * @node: the maple node > + * @type: the node type > * > * Return: A pointer to the maple node gaps > */ > @@ -880,8 +881,6 @@ static inline void ma_set_meta(struct maple_node *mn, enum maple_type mt, > * @mt: The maple tree > * @mn: The maple node > * @type: The maple node type > - * @offset: The offset of the highest sub-gap in this node. > - * @end: The end of the data in this node. > */ > static inline void mt_clear_meta(struct maple_tree *mt, struct maple_node *mn, > enum maple_type type) > @@ -939,7 +938,7 @@ static inline unsigned char ma_meta_gap(struct maple_node *mn) > /* > * ma_set_meta_gap() - Set the largest gap location in a nodes metadata > * @mn: The maple node > - * @mn: The maple node type > + * @mt: The maple node type > * @offset: The location of the largest gap. > */ > static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, > @@ -953,8 +952,8 @@ static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, > > /* > * mat_add() - Add a @dead_enode to the ma_topiary of a list of dead nodes. > - * @mat - the ma_topiary, a linked list of dead nodes. > - * @dead_enode - the node to be marked as dead and added to the tail of the list > + * @mat: the ma_topiary, a linked list of dead nodes. > + * @dead_enode: the node to be marked as dead and added to the tail of the list > * > * Add the @dead_enode to the linked list in @mat. > */ > @@ -977,8 +976,8 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt, > bool free); > /* > * mas_mat_destroy() - Free all nodes and subtrees in a dead list. > - * @mas - the maple state > - * @mat - the ma_topiary linked list of dead nodes to free. > + * @mas: the maple state > + * @mat: the ma_topiary linked list of dead nodes to free. > * > * Destroy walk a dead list. > */ > @@ -999,7 +998,7 @@ static void mas_mat_destroy(struct ma_state *mas, struct ma_topiary *mat) > } > /* > * mas_descend() - Descend into the slot stored in the ma_state. > - * @mas - the maple state. > + * @mas: the maple state. > * > * Note: Not RCU safe, only use in write side or debug code. > */ > @@ -1462,7 +1461,7 @@ static inline unsigned char mas_data_end(struct ma_state *mas) > > /* > * mas_leaf_max_gap() - Returns the largest gap in a leaf node > - * @mas - the maple state > + * @mas: the maple state > * > * Return: The maximum gap in the leaf. > */ > @@ -1544,7 +1543,7 @@ static unsigned long mas_leaf_max_gap(struct ma_state *mas) > * @node: The maple node > * @gaps: The pointer to the gaps > * @mt: The maple node type > - * @*off: Pointer to store the offset location of the gap. > + * @off: Pointer to store the offset location of the gap. > * > * Uses the metadata data end to scan backwards across set gaps. > * > @@ -1648,7 +1647,7 @@ static inline void mas_parent_gap(struct ma_state *mas, unsigned long new) > > /* > * mas_update_gap() - Update a nodes gaps and propagate up if necessary. > - * @mas - the maple state. > + * @mas: the maple state. > */ > static inline void mas_update_gap(struct ma_state *mas) > { > @@ -1664,8 +1663,8 @@ static inline void mas_update_gap(struct ma_state *mas) > /* > * mas_adopt_children() - Set the parent pointer of all nodes in @parent to > * @parent with the slot encoded. > - * @mas - the maple state (for the tree) > - * @parent - the maple encoded node containing the children. > + * @mas: the maple state (for the tree) > + * @parent: the maple encoded node containing the children. > */ > static inline void mas_adopt_children(struct ma_state *mas, > struct maple_enode *parent) > @@ -1687,8 +1686,8 @@ static inline void mas_adopt_children(struct ma_state *mas, > /* > * mas_put_in_tree() - Put a new node in the tree, smp_wmb(), and mark the old > * node as dead. > - * @mas - the maple state with the new node > - * @old_enode - The old maple encoded node to replace. > + * @mas: the maple state with the new node > + * @old_enode: The old maple encoded node to replace. > */ > static inline void mas_put_in_tree(struct ma_state *mas, > struct maple_enode *old_enode) > @@ -1716,8 +1715,8 @@ static inline void mas_put_in_tree(struct ma_state *mas, > * mas_replace_node() - Replace a node by putting it in the tree, marking it > * dead, and freeing it. > * the parent encoding to locate the maple node in the tree. > - * @mas - the ma_state with @mas->node pointing to the new node. > - * @old_enode - The old maple encoded node. > + * @mas: the ma_state with @mas->node pointing to the new node. > + * @old_enode: The old maple encoded node. > */ > static inline void mas_replace_node(struct ma_state *mas, > struct maple_enode *old_enode) > @@ -1782,7 +1781,6 @@ static inline void mab_shift_right(struct maple_big_node *b_node, > /* > * mab_middle_node() - Check if a middle node is needed (unlikely) > * @b_node: the maple_big_node that contains the data. > - * @size: the amount of data in the b_node > * @split: the potential split location > * @slot_count: the size that can be stored in a single node being considered. > * > @@ -1830,6 +1828,7 @@ static inline int mab_no_null_split(struct maple_big_node *b_node, > /* > * mab_calc_split() - Calculate the split location and if there needs to be two > * splits. > + * @mas: The maple state > * @bn: The maple_big_node with the data > * @mid_split: The second split, if required. 0 otherwise. > * > @@ -2156,7 +2155,8 @@ static inline bool mas_next_sibling(struct ma_state *mas) > } > > /* > - * mte_node_or_none() - Set the enode and state. > + * mas_node_or_none() - Set the enode and state. > + * @mas: the maple state > * @enode: The encoded maple node. > * > * Set the node to the enode and the status. > @@ -2207,7 +2207,6 @@ static inline void mas_wr_node_walk(struct ma_wr_state *wr_mas) > /* > * mast_rebalance_next() - Rebalance against the next node > * @mast: The maple subtree state > - * @old_r: The encoded maple node to the right (next node). > */ > static inline void mast_rebalance_next(struct maple_subtree_state *mast) > { > @@ -2221,7 +2220,6 @@ static inline void mast_rebalance_next(struct maple_subtree_state *mast) > /* > * mast_rebalance_prev() - Rebalance against the previous node > * @mast: The maple subtree state > - * @old_l: The encoded maple node to the left (previous node) > */ > static inline void mast_rebalance_prev(struct maple_subtree_state *mast) > { > @@ -2372,9 +2370,9 @@ static inline unsigned char mas_mab_to_node(struct ma_state *mas, > /* > * mab_set_b_end() - Add entry to b_node at b_node->b_end and increment the end > * pointer. > - * @b_node - the big node to add the entry > - * @mas - the maple state to get the pivot (mas->max) > - * @entry - the entry to add, if NULL nothing happens. > + * @b_node: the big node to add the entry > + * @mas: the maple state to get the pivot (mas->max) > + * @entry: the entry to add, if NULL nothing happens. > */ > static inline void mab_set_b_end(struct maple_big_node *b_node, > struct ma_state *mas, > @@ -2393,11 +2391,11 @@ static inline void mab_set_b_end(struct maple_big_node *b_node, > * mas_set_split_parent() - combine_then_separate helper function. Sets the parent > * of @mas->node to either @left or @right, depending on @slot and @split > * > - * @mas - the maple state with the node that needs a parent > - * @left - possible parent 1 > - * @right - possible parent 2 > - * @slot - the slot the mas->node was placed > - * @split - the split location between @left and @right > + * @mas: the maple state with the node that needs a parent > + * @left: possible parent 1 > + * @right: possible parent 2 > + * @slot: the slot the mas->node was placed > + * @split: the split location between @left and @right > */ > static inline void mas_set_split_parent(struct ma_state *mas, > struct maple_enode *left, > @@ -2417,11 +2415,11 @@ static inline void mas_set_split_parent(struct ma_state *mas, > > /* > * mte_mid_split_check() - Check if the next node passes the mid-split > - * @**l: Pointer to left encoded maple node. > - * @**m: Pointer to middle encoded maple node. > - * @**r: Pointer to right encoded maple node. > + * @l: Pointer to left encoded maple node. > + * @m: Pointer to middle encoded maple node. > + * @r: Pointer to right encoded maple node. > * @slot: The offset > - * @*split: The split location. > + * @split: The split location. > * @mid_split: The middle split. > */ > static inline void mte_mid_split_check(struct maple_enode **l, > @@ -2445,10 +2443,10 @@ static inline void mte_mid_split_check(struct maple_enode **l, > /* > * mast_set_split_parents() - Helper function to set three nodes parents. Slot > * is taken from @mast->l. > - * @mast - the maple subtree state > - * @left - the left node > - * @right - the right node > - * @split - the split location. > + * @mast: the maple subtree state > + * @left: the left node > + * @right: the right node > + * @split: the split location. > */ > static inline void mast_set_split_parents(struct maple_subtree_state *mast, > struct maple_enode *left, > @@ -2482,7 +2480,6 @@ static inline void mast_set_split_parents(struct maple_subtree_state *mast, > /* > * mas_topiary_node() - Dispose of a single node > * @mas: The maple state for pushing nodes > - * @enode: The encoded maple node > * @in_rcu: If the tree is in rcu mode > * > * The node will either be RCU freed or pushed back on the maple state. > @@ -2614,7 +2611,7 @@ static inline void mas_topiary_replace(struct ma_state *mas, > /* > * mas_wmb_replace() - Write memory barrier and replace > * @mas: The maple state > - * @old: The old maple encoded node that is being replaced. > + * @old_enode: The old maple encoded node that is being replaced. > * > * Updates gap as necessary. > */ > @@ -3505,10 +3502,7 @@ static inline void mas_store_root(struct ma_state *mas, void *entry) > /* > * mas_is_span_wr() - Check if the write needs to be treated as a write that > * spans the node. > - * @mas: The maple state > - * @piv: The pivot value being written > - * @type: The maple node type > - * @entry: The data to write > + * @wr_mas: The maple write state > * > * Spanning writes are writes that start in one node and end in another OR if > * the write of a %NULL will cause the node to end with a %NULL. > @@ -4173,10 +4167,7 @@ static inline void mas_wr_modify(struct ma_wr_state *wr_mas) > > /* > * mas_wr_store_entry() - Internal call to store a value > - * @mas: The maple state > - * @entry: The entry to store. > - * > - * Return: The contents that was stored at the index. > + * @wr_mas: The maple write state > */ > static inline void mas_wr_store_entry(struct ma_wr_state *wr_mas) > { > @@ -4415,9 +4406,8 @@ static int mas_prev_node(struct ma_state *mas, unsigned long min) > * mas_prev_slot() - Get the entry in the previous slot > * > * @mas: The maple state > - * @max: The minimum starting range > + * @min: The minimum starting range > * @empty: Can be empty > - * @set_underflow: Set the @mas->node to underflow state on limit. > * > * Return: The entry in the previous slot which is possibly NULL > */ > @@ -4500,6 +4490,7 @@ static void *mas_prev_slot(struct ma_state *mas, unsigned long min, bool empty) > /* > * mas_next_node() - Get the next node at the same level in the tree. > * @mas: The maple state > + * @node: The maple node > * @max: The maximum pivot value to check. > * > * The next value will be mas->node[mas->offset] or the status will have > @@ -4590,8 +4581,6 @@ static int mas_next_node(struct ma_state *mas, struct maple_node *node, > * @mas: The maple state > * @max: The maximum starting range > * @empty: Can be empty > - * @set_overflow: Should @mas->node be set to overflow when the limit is > - * reached. > * > * Return: The entry in the next slot which is possibly NULL > */ > @@ -5125,9 +5114,9 @@ EXPORT_SYMBOL_GPL(mas_empty_area_rev); > > /* > * mte_dead_leaves() - Mark all leaves of a node as dead. > - * @mas: The maple state > + * @enode: the encoded node > + * @mt: the maple tree > * @slots: Pointer to the slot array > - * @type: The maple node type > * > * Must hold the write lock. > * > -- > 2.34.1 >