From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14025EEE266 for ; Thu, 12 Sep 2024 20:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 893956B0082; Thu, 12 Sep 2024 16:59:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81C526B0083; Thu, 12 Sep 2024 16:59:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695CF6B0088; Thu, 12 Sep 2024 16:59:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4BCA06B0082 for ; Thu, 12 Sep 2024 16:59:51 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EC22A12017F for ; Thu, 12 Sep 2024 20:59:50 +0000 (UTC) X-FDA: 82557302940.18.C1EB2C3 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by imf09.hostedemail.com (Postfix) with ESMTP id 245C7140011 for ; Thu, 12 Sep 2024 20:59:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=COR558R5; spf=pass (imf09.hostedemail.com: domain of justinstitt@google.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726174735; a=rsa-sha256; cv=none; b=jXVZ28Yo32O/F7bN3RrTf9xnT3fdYFtMY3GgsdP4rd/vRSta+UbtZ4AW57FeyKlgKsqTe6 GByZa4QmAIflRkycixLLkws8yM1UR6qGjQZ11/Q3/bxXdYMwW0Z59lLc3WbZroctMtbJP8 sDNMu1/mifjUafOc7wDcVHGaPwK6MtU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=COR558R5; spf=pass (imf09.hostedemail.com: domain of justinstitt@google.com designates 209.85.160.50 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726174735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8mM5Z0KLUO8efTiZgA6ECQxJ5r+uA/1F2hapQlso44M=; b=mP+l98g+UwaibtJoN1tIbdMXeIFkSRoNxkxPMZdf82TSeauLo9ERZk98L4VJTYYpRL8Llp z2u7ntC8go8gK1rWfun0rud0+gYZ7Ou6rd4macFwkSkqSxlUV/HZdYdfrthVb+Ku+PwAYl ZKE5tSCuJhIqfyG10WLFUthHP5PtkEA= Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-277cfd3f07aso627194fac.3 for ; Thu, 12 Sep 2024 13:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726174788; x=1726779588; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8mM5Z0KLUO8efTiZgA6ECQxJ5r+uA/1F2hapQlso44M=; b=COR558R5aEXo97PTEDbWrcVsiMda1JkHBcRgrdUHvcnzsEhKIBJRCH7KF0qzH56ZJL 7w7j/ABPR0lE5RhhW2JCRsdf1/yeZA4NCapkcJILBELLqExtQgFzxaMesQzhuLLeDK6a Ymk1WvYrrMoUmYro9AFOgHV3tkqtGiVJaUge0MSUTb1YGy2zh3MOwRMzCwMpJpumt/VV /acfoRT/K9SVQgMBnXjGEd7wXP2XmU7vQGNNP08pmvjm8n4z7ZGGx6GKyrYRApB73DWw /RzouT5KqwzOpMvfFpKbzh3e8ZbHldHQmwIiVz9clVWa2Ex4WEBztn4iS079qM/nHXMC l25g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726174788; x=1726779588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8mM5Z0KLUO8efTiZgA6ECQxJ5r+uA/1F2hapQlso44M=; b=p05zXO09lUaytYojpD51qWYxQyCcxwZuGwYvWEHiCKrNhnzKkTYs/azhmvlhKILBrK fQeQ89HOoSyXBr0UleeBaV6V7clbYAevSJNAHEdpqe2aoYVBZRRFdLy9hNJfH3g6YlB0 ukLJ0SK/14O3AHs5JtF67O6wDBS2Fj1kl/a3rjKUVtIYmcZt9gnEwG2Wc3ci5pLs/fTH y4btmB/vYd8DKHdVO/+OBFYrcCF6dcMxs3yx+qMRo/3wGAYcFh90AC3IDuP+nhzrEHIp RCaC3KPuHFZ5Z/lH0/UhcviLg1EMN3ucyG1Yt3R41oKO684IXdTbEDpUWCcDnl39ep1p r5Zw== X-Forwarded-Encrypted: i=1; AJvYcCW8BUHo4mR3LD0B4ItocI8kDUfSsBVtoDRby5sXkfmlKo7n3O9uey++tLPrqfEOWaqgZAgXq4nNXQ==@kvack.org X-Gm-Message-State: AOJu0YwOKzyCGU0RXavznxKxE6xqt3oA5SfKbmfp/xFbHpb11Qj/9kQp Qii432Kps3PBj7QiAHsHD0KGV/09v99OVmGqo2qBVnkKI9N9XJ1MaB0cjwRIYg== X-Google-Smtp-Source: AGHT+IFM1AXJ051IzPPqsl49dRXV3EAPdU7MADRa2Tisd07EWLACnR0AfN41J2K91Abg++8l1F9PzA== X-Received: by 2002:a05:6870:610c:b0:27b:6267:61b0 with SMTP id 586e51a60fabf-27c3f603118mr3165118fac.32.1726174787877; Thu, 12 Sep 2024 13:59:47 -0700 (PDT) Received: from google.com (30.64.135.34.bc.googleusercontent.com. [34.135.64.30]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-27ba3f3f125sm3276542fac.25.2024.09.12.13.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 13:59:47 -0700 (PDT) Date: Thu, 12 Sep 2024 13:59:42 -0700 From: Justin Stitt To: Yafang Shao Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, alx@kernel.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Moore , Eric Paris Subject: Re: [PATCH v8 2/8] auditsc: Replace memcpy() with strscpy() Message-ID: References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-3-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828030321.20688-3-laoar.shao@gmail.com> X-Stat-Signature: 1csm4e9mgctjytan8uzk5wjdtm745on9 X-Rspamd-Queue-Id: 245C7140011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726174788-857959 X-HE-Meta: U2FsdGVkX18lX7vmyARioOPQyryJMP0qKyWiTUKsNeaBc0oviVy5BDk0dXeRp5uCnIc1p7fbqbx0ZRn7aUk91iW5TechSQizHuq8WPMp9JxnRe8LuXVbRcuDE435LZGH9YORObS2YKCDQ1iRFLMezoO/5eTQ8D7jCop97ZIjc+pHXWYMEOmdx8nTu1Q20VKBMeEpZyUZTHcd3z/zo3nnliE4xpNNGWM0wP9ARDNnnS7DM9LGY77x0GpHnwKslHkOVB1LE7hdYirc8PGaZyUEdieirHuctstresKfGCA8FVvwPtaMT/uQyrsL46Gwvd5Q7sLzypMYUn4uXDM0Xh2pDhe/YLLkW1TlTEE3cFMH8zUqLxQ0gh+bohLmQk5wCOK2qrwrLVEu558R1tOpyyIYm/XchFuog8e2dI52+/Wk3cO7Z53u5R+t9dQJaypDEDB4Yjk3wDLeLLouVMs2wSyQnxTdpqqmRlKFaUvTfYGK5gWkw+9jjcAD2Xd3kKBc46ISpRxUgws1lXmFASgJbSlkNMmel8Yf63/LVax+A1w/QqYQtXuoSuF2lpax1DQr3v4TSwluFPmBggdpIntP/svQJsaJzxrp7TA8ooM3E3nvSj3hi+B1faCHtT/Hf9UDS0GFshAAozjZQI6wF7QG1CoDerxNm9URjFRopqVYH7EkgI/PL6VAttLVRjrYRJSXG8TvNDF/R13peMe0ss8hSePMsHRRx48GtFyiXcbMQzwXQeBGroTunVhnw4VxLs6lo25Vu3ekCulVLTxT1cBE2nFMSCDS9BkOniJUxNGBjn/eRF8+P5j/G9Fl1mstLw2kjHxeN+TCmqjdByvNz36AY05yvMJ6uoVD5Wxkp1kuY+wJ2OwKDANmQmpuTipQYG8DEtTOxwZy6ZW9y0u9L/Wov/A+74eo6yGHkwXdE67mOUYN3nGsFxdQU24JTz6K9luJuADeOqVe8vH9i1l9+/0UrQl VcPmvDwn I4qmrCn31Dzw3Eu8ry9LSMoIu88+zxcVjuDthxX7YX/N3gFDiC5MhjqtYXjg6vtye9yqlk/2f2TPllts/cjNFv51hf7KcS5oJR6PZwgwNsrP5ezr3MLKCMa5qQg6LcDw43yXO/C06s0lkB3GqRP9wTNinlQ8/g8vr4hZIML4+Ow5/MW9YegjJKdDwduVRJIDMCcu4srpkJ3u6qnwrdV9xyqwBxqK9KaV4ckWdcOw9o1/8RIkaCXDndW7rKtBVu74yYkWid+XnplLfaUmvkrA5DaTecDFGwJzfRG6ckstw+HslqfSBCWfDgxkH3CejoB79Mm9OepNtZRMjb7bYzJOzaY+C/4uPVCgC9RiQrytdZfanB9tWM9LutWGTnQanxHP5it9fQCK8iDpEdEVU5IjMMR+PQi8BZxek8rcg3zC1liMOKnbg38rXR2ZzmpZvdtPcoue9RyWgQWdYblVRUEGfnwFc+FwIELzMiTDX2OsRJ7x7X/i6FI57E+rS6KuhycBaJg7dGSW727sh8tz3Zwd2TfhFfSyvqLBqXiMf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Wed, Aug 28, 2024 at 11:03:15AM GMT, Yafang Shao wrote: > Using strscpy() to read the task comm ensures that the name is > always NUL-terminated, regardless of the source string. This approach also > facilitates future extensions to the task comm. > > Signed-off-by: Yafang Shao > Acked-by: Paul Moore > Cc: Eric Paris > --- > kernel/auditsc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index 6f0d6fb6523f..e4ef5e57dde9 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -2730,7 +2730,7 @@ void __audit_ptrace(struct task_struct *t) > context->target_uid = task_uid(t); > context->target_sessionid = audit_get_sessionid(t); > security_task_getsecid_obj(t, &context->target_sid); > - memcpy(context->target_comm, t->comm, TASK_COMM_LEN); > + strscpy(context->target_comm, t->comm); > } > > /** > @@ -2757,7 +2757,7 @@ int audit_signal_info_syscall(struct task_struct *t) > ctx->target_uid = t_uid; > ctx->target_sessionid = audit_get_sessionid(t); > security_task_getsecid_obj(t, &ctx->target_sid); > - memcpy(ctx->target_comm, t->comm, TASK_COMM_LEN); > + strscpy(ctx->target_comm, t->comm); > return 0; > } > > @@ -2778,7 +2778,7 @@ int audit_signal_info_syscall(struct task_struct *t) > axp->target_uid[axp->pid_count] = t_uid; > axp->target_sessionid[axp->pid_count] = audit_get_sessionid(t); > security_task_getsecid_obj(t, &axp->target_sid[axp->pid_count]); > - memcpy(axp->target_comm[axp->pid_count], t->comm, TASK_COMM_LEN); > + strscpy(axp->target_comm[axp->pid_count], t->comm); > axp->pid_count++; > > return 0; > -- > 2.43.5 > Good usage of two-argument strscpy(). This helps towards [1]. Reviewed-by: Justin Stitt [1]: https://github.com/KSPP/linux/issues/90 Thanks Justin