From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DECCAC02196 for ; Thu, 6 Feb 2025 08:22:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F870280005; Thu, 6 Feb 2025 03:22:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A79B280002; Thu, 6 Feb 2025 03:22:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36EE6280005; Thu, 6 Feb 2025 03:22:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 17F38280002 for ; Thu, 6 Feb 2025 03:22:58 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 955854B422 for ; Thu, 6 Feb 2025 08:22:57 +0000 (UTC) X-FDA: 83088829194.20.AC9E940 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf03.hostedemail.com (Postfix) with ESMTP id B2F3120025 for ; Thu, 6 Feb 2025 08:22:55 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=d2dTYUJF; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738830175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xBj4dEHovq6rmCikfKh4C+pq48sZ0tP9QKnuVG2mHfg=; b=UNozERvxZCLtbyExlTqeQX6pi5zpQlvKO8oC7weZR8HvVQ0wsMUVrz9jbjbq/0XPQcJ0M/ HUr4um+Zrqj2O44PlOD2MHi24CmxTA6Qn47lM7zrUClN90fgLG0jyXXINuePmUVvaFkbAw vMoeoNn354L54Bxfzqkt7SqBhVnMdRo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=d2dTYUJF; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738830175; a=rsa-sha256; cv=none; b=KaDJXvvd2irFAABNDw6IM+DQlpRgCiMQsdi/pVQzGwZ3G0dB09Px7dft2AWNuNDu4uxv72 7+1Uuut0rN3LqakKnPCaSNiniMxtnS3vWD53LTKfW6me/0uAfq+jSu5IhO27Jek4659luQ iqJ9lo4mAcNxR62Bt5zyL6b+q18v+fM= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21661be2c2dso12121975ad.1 for ; Thu, 06 Feb 2025 00:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738830174; x=1739434974; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xBj4dEHovq6rmCikfKh4C+pq48sZ0tP9QKnuVG2mHfg=; b=d2dTYUJFkc7QnF2iIINUwO4cojy3tpZ2vCMhKo8lGjpPGe5Z0xjUb9JdBb1MtEycfL kEbeBt2V4orrxftz8PO4MYlxitVnq/9IV0wek2jEqLmJqS6JUSK7iE7L1HbuJegw+NZa pODrGNqNORdzorbZdvev/ab4crhnW7OzysMms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738830174; x=1739434974; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xBj4dEHovq6rmCikfKh4C+pq48sZ0tP9QKnuVG2mHfg=; b=SAGswuO3C8ONNShPRXWg/4TVPkJMvZtXstg+eErQyI89PdOadev7XJnmn8I2QACJ8n pVMg4mBu+1kguHeAFJ+Ixn2z4qKRRQIWzah2/N2n7tgpL93p9n0+yqhxVOsgL1pKIJ2N 332EUfZzhNCBEE3HwrDYitMqUCz5VLaov5/+LG1idLDcEXPjJwpoLiXHzJYVs2ZXQ/BM i0cYI53IN2+0HLJvu1/RAe/y7hNCF72xXTSwCjUAh07B3mzbsO2R3mQvpE4eaPihw53b UcbOjkifT9DHQsmlT0bPXbXW+odhvslPXTqoT6Od1DQ7OT5op8wZ+agxo+FadZ+7apsd FXKQ== X-Forwarded-Encrypted: i=1; AJvYcCU5tmjjeeB8Ei7cgQtFhriMc58qeckk5wOwhWeF3Cep36aaD9sI2V9quJaLIJfvNBOV4eev8jdTCw==@kvack.org X-Gm-Message-State: AOJu0Yye3FSFgUKiClFWcyDJDLGuKn+eHSUbtFxWc/WZbLL+omez2sGl ZtM+Gu4y1Ho7xH4bdB09DPT+5kyTZibrytajwbGI4WZs+sRM9eZXh6PEUeQlsg== X-Gm-Gg: ASbGncsm6gKmE4TjIa4+e4ENzQOxqYjGztMbKG/Aean7mMy2r74pETjyiJIzI5pQRLz aDhwNVTDKxBr+7s7vbkml7YXvBkghT/5ByloA7GxbagYDP4FKAhIfRhOVgPTKxzzD2fE74pd+h7 XIN/eRcxQ1Bas6btXzqZUG1GKqSFNKA/Krt+jhDQhtKqI68pEvB8SvniOmOOoIpEZd099Vz9wWR FEWymFq4XHk6pkEJQfET0ffMGoZ7tECTfjK3pzkMSLy9wwo42r4Frga6+xA+SsIfCLvNWIHvjOx IR13wIbbpcV0We1beko= X-Google-Smtp-Source: AGHT+IE4ctymN3GmJ2NIk9JDhOA2Q6JmpWiBbywcGEW09fGrHORU9ul0kl9mDT8VjfySxTOfHD/53Q== X-Received: by 2002:a17:902:db07:b0:21f:1c9:ce48 with SMTP id d9443c01a7336-21f17e47109mr93841085ad.26.1738830174528; Thu, 06 Feb 2025 00:22:54 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:28ab:cea4:aa8a:127a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3687c4dcsm6875915ad.170.2025.02.06.00.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 00:22:54 -0800 (PST) Date: Thu, 6 Feb 2025 17:22:48 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Kairui Song , Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: Re: [PATCHv4 02/17] zram: do not use per-CPU compression streams Message-ID: References: <20250131090658.3386285-1-senozhatsky@chromium.org> <20250131090658.3386285-3-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B2F3120025 X-Stat-Signature: cn3yjd1u6z6zg53aydfynip15x7po4eg X-Rspam-User: X-HE-Tag: 1738830175-521937 X-HE-Meta: U2FsdGVkX1/TwPOfZqiRRvxC4CS7/VjaKOO4HUWYnC8Yh6PC+cko0+YoeVLsLDwX0GBIUdb0xKGRy0SZdu6edI6AvLzFDZW60UnDa4YnGqUuNMQHyB5xNoP7YK74i4BaEpyl5GJr+GtJ82dcF+OgVWpzxZd1sFUui/lCABdcHysDEFDYs4HY6vR2lm5ec0Hd9UxVOcd9MttdoYGY4ya2JM5DUOKF27Xhlkfe5mFuWTK1HCANXD5jfJoIOe8ysR3gD57YXG6lZ3iiLb2PgP+Ro42AMhxey5ONNFPC3u1q8LWyGNmCX7d3kPj0QqA01vXDXI5OUATR0MrhwgZWI9EBxXhJ1+HOuYq7rnnZnEm748RM1gK1zLm3+dV058MM2qbK2MoUW2PyFFTGLvl+Mgswk+lEypYIotzH1VzJsE/kUDBaX5dUaxLjlTE9G4ywjr10gEgeCSAgZ1wPsJdMqMxrPeGR8ph79cUkf9vFYCDxigzFLeSDhYQg6sKgQLX8HM3qcg831V4Wp5cSN88QADk4SBH00pew4dgiiJO934hRL5DVoxuWsjemtYjye14aQLxMo+dyf6NpuZimWxbxohaX04hpvWcywg/0eiG27hjqK0f3uji0tG7+KNOqu+d9wDYZOyZtx1FlYJJc+LiM6EMdmgnKt3wyxBYocCBi+d+3N5Gly/HdXzOdk4HRdGXWIAKIg/KzI3dNbGPBJ5n2K0vx6yr+iH1irt6wXD5bk8yD6z8ELZwHistv/luJRm7phKYnnhNlbq9InMkcLTeKZRpRnoGimzoospbihlXlPFEb0CrIKukNJ0b7mxh/KjwprhzWWz9N84kw2qb8zWjzMvFIf+fzabt8gBh+Fn69NAX+HTzTgXINvx31iva99M0qyoSN8009ed2QRUvQ838XnvqmbofGO1FLZFPT3E92YeY9F2fyKFJ07v4qEclyL7OU6humTCHF4szzHEsIf1Nr1qI XNbSrmYP rRg+ohFe+EXfQNrtiB80oLyVdwMXj2sNFtR1wfy/tGL2TYUTTcNAzU3KSTFMvzYXJB7tCn2YitNOkC936UnoysW7VTaaQY+RDESxMV/dk+q2rWbBtZrs/AfULR4FjZpG8VkMr0KsMY/VxZEUZ0nvx+YnqEA79zEBQDFpaUSU1+oDy9Q+QI1tCtvlGx3GkTwVDkftcQjcBvgQYwQMTCO4RLcxORfEyr2aH8DksiNQK16W1K4/mEy7iUH0uGR5DHCUxcUOYuScvHC5cziEIQvApg325Kf2LZ/cTtAEajWC4RNm2Uq7XeZ+tMxMEuVTlPzxc3p+4Zl3qo9pyt4I0NC6cOYtWDzZ6QdA9CD9FfjcmS7jP118= X-Bogosity: Ham, tests=bogofilter, spamicity=0.133420, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/06 16:22), Sergey Senozhatsky wrote: > I didn't know it was possible to use per-CPU data and still have > preemption enabled at the same time. So I'm not opposed to the > idea of still having per-CPU streams and do what zswap folks did. Maybe that's actually a preferable option. Allocation of streams on-demand has a problem that streams' constructors need to use proper GFP flags (they still use GFP_KERNEL, wrongly), and so on. Keeping things the way they are (per-CPU) but adding a preemption is likely a safer and nicer option.