From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 617BFCDDE6E for ; Wed, 23 Oct 2024 11:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 002C26B0083; Wed, 23 Oct 2024 07:18:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF49F6B0085; Wed, 23 Oct 2024 07:18:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D957B6B0088; Wed, 23 Oct 2024 07:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B9E4A6B0083 for ; Wed, 23 Oct 2024 07:18:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 712B08097C for ; Wed, 23 Oct 2024 11:18:14 +0000 (UTC) X-FDA: 82704618402.04.8776F1F Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) by imf30.hostedemail.com (Postfix) with ESMTP id E33778001C for ; Wed, 23 Oct 2024 11:17:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="h u/5rsx"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Kkc7iPgu; dmarc=none; spf=pass (imf30.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.155 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729682140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vwy58cHeT5EOxz8ukcp8DVriSblRUlkuqAv1BT3YlWE=; b=sV5PmZsYL/YDv954qtDlO0t4CCuE3sqhdSJ+VQGwmDd/SfPYfx6SmJSVrrDJqUVcgoh+o4 obfJSK3EE1DCpJyXevU3EJxNCJeYucJHDaYjw1dPay5vBQt/TodWfUVwEcD/g3KuBTA8VD 4aKvnyUtRDR48yWt06sU5YAYcKqFhaw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729682140; a=rsa-sha256; cv=none; b=Cs4xxeP2JNwc3v6+VE/g1Rr0Ox1ptEssxSmdYS+Y9QZVlPtTqlIqdgV8CSP5z1S4fSoTdy R7zUgmYp4dxqYB6cfjLCiTE6TJ30q/4TTVhrpaUaV+XQcIVImpnSYQ03RElx9zvXmMEoWM 6eLcrQQWLJq+wI9xeflDxND5fh71v0g= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="h u/5rsx"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=Kkc7iPgu; dmarc=none; spf=pass (imf30.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.155 as permitted sender) smtp.mailfrom=kirill@shutemov.name Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id C3F691140142; Wed, 23 Oct 2024 07:18:26 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Wed, 23 Oct 2024 07:18:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1729682306; x= 1729768706; bh=Vwy58cHeT5EOxz8ukcp8DVriSblRUlkuqAv1BT3YlWE=; b=h u/5rsxSJv7FTA9zcz3QUwAFJjxbDSMi8rGfrn2tUNqMWtHHX7TTxQgIZGAQdG4+s PW3i+W8mRPaSvLRr6D8YUsXMwLqKoQbr2sK/mAtYWKogGo4CRQIizk8nspSqCy15 B4DMVVrU7e05fxRxh0sVssLSx9Z1LH7x9bG16r037iEpcLvNdQ/pfsJH6mswiOSx Ft8e1kOFpL2x1pQfTt3zTPwOUSdOwCSp1CNO/uiTId22KXqLNDty65QwQ1bXECeE TvbYf3io+Tj1dJDmtz0Rxo65GyiOs5fxD0gmq5qFp7qo5O5h3SSdgOA3HtUv/Gjf PVVb/t46pIXLXW42k5RVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1729682306; x=1729768706; bh=Vwy58cHeT5EOxz8ukcp8DVriSblR UlkuqAv1BT3YlWE=; b=Kkc7iPguREoRZ0Iz3dWyjEGxJI3gNVjgQSqWcpb1/jcV RVnUOhL6cZ27YyYYGlTnkRkZDB1v6WwD4mzOCrP5nD4Ui2JfAFti6cSDVAEh6dki VFhCFHkGBFaINL7H07ra1gZVQBctesg+8Ohxl0nkDjhBrRDO7CpPDyoOJb1wV1ph VEVQpnY4DShezWM3qh0z4O6PcRxvxEojZBH+0Q39Al6SUxO87IDrEIXCo9f+CBdg r3L4tRpHfMQ2pa172M09ZEMWLceF12QW27jY4li9qx8wZjRydAawM2GyMWcKFe00 fK1z2uY1XnY/Nd035vn6WQAeTfvtsCwa/+EogQvICw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeijedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvden ucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlse hshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfhhfff veelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhv rdhnrghmvgdpnhgspghrtghpthhtohepudekpdhmohguvgepshhmthhpohhuthdprhgtph htthhopegurghvihgusehrvgguhhgrthdrtghomhdprhgtphhtthhopehlihhnuhigqdhk vghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqd hmmheskhhvrggtkhdrohhrghdprhgtphhtthhopegtghhrohhuphhssehvghgvrhdrkhgv rhhnvghlrdhorhhgpdhrtghpthhtohepgiekieeskhgvrhhnvghlrdhorhhgpdhrtghpth htoheplhhinhhugidqfhhsuggvvhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgt phhtthhopegrkhhpmheslhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpth htohepfihilhhlhiesihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehtjheskhgv rhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Oct 2024 07:18:20 -0400 (EDT) Date: Wed, 23 Oct 2024 14:18:16 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , Michal =?utf-8?Q?Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH v1 02/17] mm: factor out large folio handling from folio_nr_pages() into folio_large_nr_pages() Message-ID: References: <20240829165627.2256514-1-david@redhat.com> <20240829165627.2256514-3-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829165627.2256514-3-david@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E33778001C X-Stat-Signature: po9q165h4fne4yy8wg6cqfenuzxkkk3w X-Rspam-User: X-HE-Tag: 1729682274-185409 X-HE-Meta: U2FsdGVkX19i0+hNp7gdVp9UWD3jtAvtBRanqR1IO1g/qbsf/cU3YiWnjhqeGPK40mRT6fhIUm9nb9MbVncuTs+AWDfjMBuoS0uGmJagywiGzc72j14n9klpxqNpOclR8TSErl8IZNmQg6R0Vwz8qrbzzsP1tns3Vg5rBD3yHPkHjevmTdiReZxOjuLeAKYbKgvJkr9eJNABEaAX5sO1xRH8Tl+wLqhHUSOsIb1Mml84AtIxiylFCBU2BacZK7Oj4CoEevYafmy1GvFl4odpnlcPEo2lS5Gq+GNO/Xc2dVxs2ioM1l+lIdAduBj+O5jrpNQxk7tz3o4KGZiL6rFnRlvPzaPbDfj9ow7QoiHNOWOp2mi0mpcetAtQyosrJnmcZX2PXa3EzoHaR5V+Bk01RhJqpEJAsKcWh8K00Lof5Y1srR+qgJ2kookWj/trscEspHSbbvu3gAvXahriZaVOlcqRf8ngr/HkPPGXo4GPFOE/0HowIZBTKBO5RwVmnbVyZ2iRCJ/SzC92PAT+UGty/QjpbB0LY/JpfbNOhUpHLNUKq75QvQHSb/GiMopn7xV9g0MVyozAZPWn45jb943ETrZ8SzR9lL2HV+9S7BOiR/4IE41LZzrRNA5BbqNAlDQiOANZGlBeSZ5/G2bcYHTXQglYLFgK15513u7pICKmrvV9SzWDJiSVkS7JyHzxr6U8cpIvDdhcQXSQWwtqGlNWFNOlJ0bXfwLJYsAdLFBy2+niS4hp9fxze9HfFS0bGyE6Zldm0QD8q6pdeDY5Oaxo/FNklcDotb8jEOzO+Q4aJ7jSkCMO0Qw/Wb/bGDzl0JNYpo1kNJkEs+ogA5BijaDG93szSo4+F3foFJAViuvMpAo93m7qR3l3LSk4y/uBLwCsWXOy+h/i7rFILWwtNyyx3iDzltNLgL/1D+/5WFr+pyeVoAcCh/iTyVT2VYq9CFgoGBzOMWQOzaHsC/0MSHb 61D+xVWR EwEqU9+jHWY9mSjcrvvkknvVXZXazd8TOUokv9F2aMkr28qXQR+81guKb3ZTM4lUz6qfKPTIa4xNqpnob9DdprYWbIEAVQS5baL4DEIqE+rLnHbyik3lV7h7kJ4TbVoSE80XjwJ19O92sqCCu/Om464jSeUTNpk3Vru3w2cjqeLNsrAq0Mqf6Nimpq+DdLqkJMOwlHYgzsePy33Wqez/hxUIorW81JE9de20tX8XBffI2oaOoNAzDJHSPDTeSbxE2xzCC8XPudAa1DiY8tNXTlFY109dTvOyutPOtGX/xQZ1Mo0XJhJVC6x/u7Q3gdDynl+s/Xoft29HQZ8zntniKdx97OzNsf42/UjtnJYRJgOwKTfgPj9Rtg+HksgSrntbPvuLfvAgif329WqN+6k7xtWQMTWPZIb/Y/zVYc96xVeSP3bXv8eiz2pB3OGdljkDJPNCd0aCpajJ0RFl71Gfgsu6S9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 06:56:05PM +0200, David Hildenbrand wrote: > Let's factor it out into a simple helper function. This helper will > also come in handy when working with code where we know that our > folio is large. > > Make use of it in internal.h and mm.h, where applicable. > > While at it, let's consistently return a "long" value from all these > similar functions. Note that we cannot use "unsigned int" (even though > _folio_nr_pages is of that type), because it would break some callers > that do stuff like "-folio_nr_pages()". Both "int" or "unsigned long" > would work as well. > > Signed-off-by: David Hildenbrand > --- > include/linux/mm.h | 27 ++++++++++++++------------- > mm/internal.h | 2 +- > 2 files changed, 15 insertions(+), 14 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 3c6270f87bdc3..fa8b6ce54235c 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1076,6 +1076,15 @@ static inline unsigned int folio_large_order(const struct folio *folio) > return folio->_flags_1 & 0xff; > } > > +static inline long folio_large_nr_pages(const struct folio *folio) > +{ > +#ifdef CONFIG_64BIT > + return folio->_folio_nr_pages; > +#else > + return 1L << folio_large_order(folio); > +#endif > +} > + Maybe it would be cleaner to move #ifdef outside of the function? Otherwise: Reviewed-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov