From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9AFBC71136 for ; Mon, 16 Jun 2025 19:56:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E4A36B00A0; Mon, 16 Jun 2025 15:56:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BC066B00A1; Mon, 16 Jun 2025 15:56:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D1A86B00A2; Mon, 16 Jun 2025 15:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1BEBD6B00A0 for ; Mon, 16 Jun 2025 15:56:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B93AF80E98 for ; Mon, 16 Jun 2025 19:56:23 +0000 (UTC) X-FDA: 83562320646.07.A1EF248 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 9E848140014 for ; Mon, 16 Jun 2025 19:56:21 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hfTMIphz; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750103781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RY6jvlftqYj16RlZ8cMi5ktPdnRQwqLwReUIv9YTb9Y=; b=N2PCE/Ii1OGehQSU0jrOmTyvTtqDUQ4Xa9jRZo92IsRFNlximPk6KHFlS76CF7WJ65vQmj Z/YG8wN+IQwO+lGV1w/qMABA2d0Ukq+35NVXJA+B/Le9lJ4xIlIq7rQT2v/N3bXfB/AMb/ QwS3Gk9hPSZ3i+bUfLdB/u4Ac+0i6ec= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hfTMIphz; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750103781; a=rsa-sha256; cv=none; b=Jo6JR0FGMsxeyu3a+Uv0xWnCMjoNXUtQ9xN9Qp2lOJlANA9oxH7mxUTTLOE2QBbo0077pK okp0M5wptGWtPERT0d1dYD4Gz3b61oLgdFe0sGLBVnSBNjY2eIzAgLMIaEsUTltWn9essz o/hiLZ1dPEgqbSPgEKU4m367ZjHWMPQ= Date: Mon, 16 Jun 2025 15:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750103779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RY6jvlftqYj16RlZ8cMi5ktPdnRQwqLwReUIv9YTb9Y=; b=hfTMIphzIV1UP9YZShGN/2c5XF+1HSCXXUsJYRJXY1L6Aclc1GU2E07+0kGNeThs5vuF28 AC/+C5qGR5vwjAZWxQnLX9XOq2VPangJK+zHBHTevwRsO8AM7teSfcER/FwsKkzBj8c3T1 2J2uYc2bohx4O0D5BW29EVxqbVb4hNk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Lorenzo Stoakes Cc: Andrew Morton , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 00/10] convert the majority of file systems to mmap_prepare Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9E848140014 X-Stat-Signature: 7qxgbw1f5mw7oyf11jj38w6gc49scmw6 X-Rspam-User: X-HE-Tag: 1750103781-698169 X-HE-Meta: U2FsdGVkX1/AMrwVo6HZzL3cAGJpYpkHZoIG684WTtrPea7yuwGNcR6X7iuGuYsNwi5jhBpdkhaXmC3zciHseVDx6y6foPwYHihaHD0sbZpxzILSUF4PK37GNLqdw6jUMNFXOFSIU5CUXSOGkM+etcDfyavCJKHo0CnTeN/3oLW0HZYaqFmmPT7ZJWRuXXEoiKVWEbri5HfxcgCAEKte5TpveVMFNzrEMUZI7bk6O8b3AQUEdCM0FTUSqgAGPTiVc5hhBtHyGeo7RiOBe+h+VXOglxjkScvRXmkaO3Ysv5AXqD538OjTBCrtEvH4ai6PTpHsyy+NZoQPCHnBmtV0UVEeOcBQKi1zZJSShVmdz8TRmO//wUyYuAPujr+Y8q6IkFSyULQUARNf1EXvXK1Er6z73Nh+ksbY/jdsxwyKU1fgegA4BWs6uOO2iHDT6/4UwHFQQnW96VpRL3/HXSyOJe00m8UaZREaG+JdYvd1NeKdF+ZMIvliehk6/EgEM12YvURN97LX+v9zPdtdtFm4If4YBVKuMGvUO7dmap5VDBJDKL3Fd/6Iwr8sGFatHrIbQGHane9956LOvuLgYeIscdwtUK6c43Qki1tNhlEOsXcxQDIrHMsnJGvFu+Wy49V+aMOUtykV86zyzMWMhzucv+0juviRdIm7jGe1FdITppHtiUs6bU82JkTU5XeVcrU6XgE7WEj6x6BS+IRpmsu9XKCavpxW96dKG+rzHr5Aw2qqek5b5i7C7Sw37FH9ml7yFkzEQOgtcgBtaAg5OlyFpAMuN3q1LSepRWDJkvSrsPQsaJtJ4GSkP8IsgbOtFiqWWJYKNoOrHOv8Ggxxd7lMxtvf8L61cd186rnENY2CVzfxSS0ZWoA+cmXMEqb8pV46SvC+Xyk21To11/3KLYjoWXuSVQfZet54Wn+mNEbyxEGhrA9Y5N/s2XINA07KL/oOZwc8tvuUvHkIhThd+a2 tEZ9fiKk yMnF6gcSHyeY5r5DHwcawB66nWTkF245uqaf7PehYBYnKIkmiYxHEMwHJD00wBLh+nw2bbMIo8L4s1Brf0cA7gtaWrTxd+WjIXgzn4EPqFRHpZm7jSpaJft5i2NicNCDCnyNE0AHsvpzQkjyvUC6fNQXj0gmhWDqxGeL2RYEfhq5VotGRXz/sD6bnvzJ6lU0l9X5u/zGr7pzZydUatmGgGJU/QFWpfnwd+8h0KxTRVzoFt+zsWXY8sHIWVN0PU0cHLTZQbwktihJaMLo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mailserver is rejecting with "too many recipients" - aieeee On Mon, Jun 16, 2025 at 08:33:19PM +0100, Lorenzo Stoakes wrote: > REVIEWER'S NOTES > ================ > > I am basing this on the mm-new branch in Andrew's tree, so let me know if I > should rebase anything here. Given the mm bits touched I did think perhaps > we should take it through the mm tree, however it may be more sensible to > take it through an fs tree - let me know! > > Apologies for the noise/churn, but there are some prerequisite steps here > that inform an ordering - "fs: consistently use file_has_valid_mmap_hooks() > helper" being especially critical, and so I put the bulk of the work in the > same series. > > Let me know if there's anything I can do to make life easier here. This seems to be more of an mm thing than a filesystem thing? I don't see any code changes on the filesystem side from a quick scan, just renaming? Are there any behavioural changes for the filesystem to be aware of? How's it been tested, any considerations there? If this is as simple as it looks, ack from me (and if it is that simply, why so many recipients?). If there are _any_ behavioural changes on the mm side that might interact with the filesystem in funny ways, please make sure the whole fstests suite has been run.