From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A311ED68BD4 for ; Fri, 15 Nov 2024 20:17:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3995A6B0083; Fri, 15 Nov 2024 15:17:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 349356B0088; Fri, 15 Nov 2024 15:17:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 211296B0092; Fri, 15 Nov 2024 15:17:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 024B86B0083 for ; Fri, 15 Nov 2024 15:17:54 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E9B71A01D6 for ; Fri, 15 Nov 2024 20:17:54 +0000 (UTC) X-FDA: 82789437276.20.DF18293 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) by imf01.hostedemail.com (Postfix) with ESMTP id 0E4594000A for ; Fri, 15 Nov 2024 20:17:16 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="E0jW7+/Z"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731701693; a=rsa-sha256; cv=none; b=dbWtUaQM1iiWVQS8bQpfUnbfvRRnf+SjYr77NdSgB7vWDu5UpDhre/bcNL7Xkqx+rHLIND VETi/tnxrtl1PpFXEaBBcPsnsJPonEL4p5MU7OvL43fVuHtmHgzDFRHTi1wCuQ3JRlkUd2 e4to1Joj9J7FpKevISV7RvWQ2Tiweg0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="E0jW7+/Z"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731701693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=najDsHmODNqiP2kOmSNl9NRg7MwERwwNvjljWc5wx1E=; b=jf353bVgT+7a0ETWKg/z+Vb929Wqf1kz9F/r33gjwDA+LTcWdctfrxnIbmUyAhg9chLovH IF3joH+Kb0FzrSKydgMRaSLIcWzVG7YNymITLC6C4fmme4qTtxf2Evoo3Mubxqdk6/tcco IaLmwj1+NBQxgC/AawWGdmvMmPH0+5s= Date: Fri, 15 Nov 2024 12:17:43 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731701870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=najDsHmODNqiP2kOmSNl9NRg7MwERwwNvjljWc5wx1E=; b=E0jW7+/ZUeDlWSAZSOxyUQx+L9K3YNXehmrJiiZTiAq7or9ErWEA/EZ/suJjIfkq/NlgqN hxV5+T3hQ7yb1wPF0LMRM+htbyFzmnPZugnfVyrvwGIN3GRDAdiNGCEpWekBvjLtps/Lt/ U7xwl+tvTRgLLsNEyMcWzYTKVS18m+k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Johannes Weiner Subject: Re: [PATCH 1/2] mm: swap_cgroup: allocate swap_cgroup map using vcalloc() Message-ID: References: <20241115190229.676440-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241115190229.676440-1-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 3q7z96odjenr89wqw96n6fcixbxxuqhh X-Rspamd-Queue-Id: 0E4594000A X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731701836-908118 X-HE-Meta: U2FsdGVkX19j1v2ZL2fkVMkU95iBGtohijcxLfNNwpKNgtHbtTji8ynPuVOHdnr157/TmV3SU9FbT4ykdf3XbaD88JGXClUMXUQ1tHJg8QE1hi5rHQAoa/8Fb0eAcv0qztisY42wga4+qwlAIwCJltTn2zkxjqjnUEaz1twNHOf9XLjywLVHU1IDHx06mICuWnAYYnawIIbnZFALevgTtf/cs7k64JVQYN1EK49gUOko8RGfm0FNmcMAPbeG3+GjfseCX1gDWQV9/qmzYXuEoVqhJOhxUSL9tFT6C2ENolcef3kZQLWg8NIIxKNG7kD/zMyKrIADmtYJM68MwY3D/Fpr1fC4pgV2ELPj0p3CdH0baWdA/8X0nCmamC5bPMB96ZYtsEkFVOmMByqXI6gvZGlZXbip44b7T6fajCjcicGrMYZqPe5jSOP7hJZKDW1ncdO9s3YkjCvV7IKnuTrQ+hequmIWeVkDwAdofta41Gdwo/VHns2M8EGPqaSlvcX/kzlYsZm0Jr3hkUu3GoYB0Q3u6orqKh1YE5s8UYbfuxnzJNQRseN9gDIh1WaiJIFy3nTt45iJCIvr9M6BwBE0TI/iwHeMMaA08I/a8OA9JavqnqRFsODtxGGtS7UYyyCfsGr1Pl1MGZ0R0aQnmOvJUI6wNgYC1sHUylgOvaq8t4sIAjHwZKRMpLJbaIhHmpIvxSKoEHGj6Cp1li/Faclw3Ys0AeujlADmJzp4P6qFEWLCEeim1+hebBDG0oN7IYOJiCwjEN0D3l0O6dkw8vNzaO3QuswJgJh6hEpNo8++aSZcz0oFk9RYI/MD/2s/sRcKyP8t/xC+EGxKlr1vs8Ycuat3PTu0RbyKI0nt5wZ5iFbke/w4W1vcnuKle4ARP4ItD7aMVhu0ZYUzUsTNnR/dE8xHRYbTReMMIZteRsnUHkWJLumV8fj03bb8cyqCavkQCz5tA/Tx9cfJIhj8rAU qQeTwNtG UrCAIl++BttEPJAn2aOd3vPIGGCkzDBxOkoeEydkpb47ebc9/3XO/S6RSNn/8OYJknVMEIFsq3dASlIcLcKtlWWarTZJTYxbeArZJK4lRmIDdYKYLzfaKKzEc4H0SEb/k6FfA/KV4xi7PQxX4PDlRHxtWC2HJCbU5DKs/7BUpnwCeTpMP9uGOVmgI68Z+cplBuXlA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 15, 2024 at 07:02:28PM +0000, Roman Gushchin wrote: > Currently swap_cgroup's map is constructed as a vmalloc()'s-based > array of pointers to individual struct pages. This brings an > unnecessary complexity into the code. > > This patch turns the swap_cgroup's map into a single space > allocated by vcalloc(). > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt [...] > @@ -215,19 +169,8 @@ void swap_cgroup_swapoff(int type) > mutex_lock(&swap_cgroup_mutex); > ctrl = &swap_cgroup_ctrl[type]; > map = ctrl->map; > - length = ctrl->length; > ctrl->map = NULL; > - ctrl->length = 0; > mutex_unlock(&swap_cgroup_mutex); > > - if (map) { > - for (i = 0; i < length; i++) { > - struct page *page = map[i]; > - if (page) > - __free_page(page); > - if (!(i % SWAP_CLUSTER_MAX)) > - cond_resched(); > - } > - vfree(map); > - } > + kvfree(map); Any reason to use kvfree() instead of just vfree()? > } > -- > 2.47.0.338.g60cca15819-goog >