From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCBFC27C77 for ; Fri, 14 Jun 2024 15:03:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9A126B00C4; Fri, 14 Jun 2024 11:03:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B48246B00C5; Fri, 14 Jun 2024 11:03:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A37906B00CB; Fri, 14 Jun 2024 11:03:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 850AC6B00C4 for ; Fri, 14 Jun 2024 11:03:27 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 23BDC120742 for ; Fri, 14 Jun 2024 15:03:27 +0000 (UTC) X-FDA: 82229812854.27.4D3669A Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 534A7C0020 for ; Fri, 14 Jun 2024 15:03:21 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vgW65Jd8; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718377400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MkGNSxl+h9z5YLWRwO1nvyFUAAj208IaWD4lkOkSdJo=; b=gb8remBF7BmIS4YD6O3yp2tv/1+SbIF7rMjVNlpjtCFPRBiFAQw1zgT4g967M8YMALM5rr 7FbBfYdv4FTgOVnKS1mSkxFbIREgObuEfXY3LwpFCW5tluX1q2OUoYWusBVFWUxrVvsVbi 8LfaMqi+LHkgqGijmJAU2XUNzFWQWWA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718377400; a=rsa-sha256; cv=none; b=gwA/h1/Hbt9wS1Y2ynpo/NogXIRSaKVVPKlalm/wfBh/RIKXdUiLqFpooOm6Ldg0w39PFQ IbNZqG1SgfDdCLHiGUiQkZK7pAKUQdrFT0TdZK+hQPfU18LAMXiydmxUZ6orMneQoNeicF kib4GnsPUKzQoJCF+dFcqLKjwEFmYfI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vgW65Jd8; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: baolin.wang@linux.alibaba.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718377395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MkGNSxl+h9z5YLWRwO1nvyFUAAj208IaWD4lkOkSdJo=; b=vgW65Jd8yLdKDIVGxsjhfPgWlr30uaqU08jhcoEaAe56TzhobuoV8WAsiGt/N5HG2xLY3m rHe8wDF4dgaRE7t4+LWnFR0jNEeJPPOc0HMu3mJHPLVxbUJGEw/3GGQHaMZ+ztBp1EI/n2 skOVz1ufzzPLMezwvXDQeIrr2wwBoLw= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 14 Jun 2024 08:03:09 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Baolin Wang Cc: akpm@linux-foundation.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: add VM_BUG_ON_FOLIO() to catch lru folio in mem_cgroup_migrate() Message-ID: References: <66d181c41b7ced35dbd39ffd3f5774a11aef266a.1718327124.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66d181c41b7ced35dbd39ffd3f5774a11aef266a.1718327124.git.baolin.wang@linux.alibaba.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: o9zuficm6zn91phujqzgowfb15hzcidt X-Rspamd-Queue-Id: 534A7C0020 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718377401-53262 X-HE-Meta: U2FsdGVkX1+RHTXohupOWmftnlLbykanW6xoKZ5TY7xoyShQEP27HLpNd5Rg+tjlAxPRFqt4GW9ceNmXzSeU4BDvvxgJXf6bXUVEuHVZ9ChrgpK1v6uOF+eLP192YsoadVzKZiCu9/pZ6AWm4RBruN3CdH/SxI6g531ddpjDyqIhBb7OrrkVzTlAsytcZ1CAriKEJ+JzR7ouyrnbD/oBd5g1o2cxe/ejGq0C5VXV5/QZx1rxNJkQIybX2/zrctTHdOyftEwgkI1XuzdJHByrdjQyuyvicMoWhvXVQipZSPfDnnifYq1tBPV/tkrb6oVxCkCCF0tuRGPDlPZY+jV9btf+qdu3bB0lAO0o09SRUE6YcwlCKGWeyLDGRPK8ylg3CoM7038L0pDF8G5cdqkVnAQxZEViTsAYAQrTBwMHc0pKr/c3SyVeeBteeMoOJJTJwY5VMIRg0wKBCtMLNr77WF1iTGGoR36ckGC0CBdyhzWbgahlLnqNN5HMQWIWF99b2LCvqQDx4yas7xVsD5tv24rc4JhhIaqtUi+uaewpzMKdCdAhbZmaPTpaam0/Nl77Jf3A/llEIu3xx3etdo000Af800BeHEJ4ymtf8PiW8F7w/nOP3EPA16xJbDZR/A4yzpUDNg8pFiQCOKMyYLm+KemAX1uPhZHt7cklO+w3AbirSiDe8g5/Ta4eSzjAq/6W4LwhJe5sJEExlcQSXR9qXJHzdSsgkbJexxsNpoK9Ibj1605O0mAjNbD8Pt5Hf5MSBr82rDoEesqFeUS1QYRqGENX4YBYch0zPqwwk2n9xyHiAQFMRdThe6+1nGkvdyzNwiUbK12GQ0OmySNzGzwZdoA3XPAjjkM7+AVlAZpn02SLnOgqPYXXZcCg7oNlxt267jE3ZCVxsRuPr6nSzG69ESSbzrJR+uK8/UxYL/2uDQJVRYnKNez4WZJYlVXnsnTWJZxuZEsHsikBBaZFrfk cXv/IoV1 qA7+aPCZryShvBm2mbHnTQhDf5FTYm+kBQNadErFOacmTqyQDhQSnxIJ/UXp1qdi3e8uKeKFo/L2/wjZzP49kbkbHYg+At6p3EaNBdQ06vKa8r0CI8FTTK1P/e95YK781OKc1kCn/TDAB0dGNmRdk606sBgRomJ2MSJwjrrbpioGRqLq0LzKueupzenmMSWK4CETqP5R+6kMLHEeKnoE8sPfpczEd2uPUqho4Zm1osSEqg/k6Wf4rW4bHzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 14, 2024 at 09:07:42AM GMT, Baolin Wang wrote: > The mem_cgroup_migrate() will clear the memcg data of the old folio, > therefore, the callers must make sure the old folio is no longer on > the LRU list, otherwise the old folio can not get the correct lruvec > object without the memcg data, which could lead to potential problems [1]. > > Thus adding a VM_BUG_ON_FOLIO() to catch this issue. > > [1] https://lore.kernel.org/all/5ab860d8ee987955e917748f9d6da525d3b52690.1718326003.git.baolin.wang@linux.alibaba.com/ > Suggested-by: Shakeel Butt > Signed-off-by: Baolin Wang Acked-by: Shakeel Butt