From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9F7C19F32 for ; Thu, 6 Mar 2025 02:48:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1043280006; Wed, 5 Mar 2025 21:48:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BF01280002; Wed, 5 Mar 2025 21:48:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86121280006; Wed, 5 Mar 2025 21:48:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 69064280002 for ; Wed, 5 Mar 2025 21:48:39 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA77EC0DF2 for ; Thu, 6 Mar 2025 02:48:39 +0000 (UTC) X-FDA: 83189593158.13.C5596B0 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf06.hostedemail.com (Postfix) with ESMTP id B0953180007 for ; Thu, 6 Mar 2025 02:48:37 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XAZgcsQI; spf=pass (imf06.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741229317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EwVWBOdzAZFDUrVCZ0TYEQNSfFcaIacpoDQH/C8G1OU=; b=IW2SHmDPtjvWG2Zct0Yx+SoK0f1Udst6OgHm3lSkYz4Ffr12Fnlt6fsvlpmO4Sva2HMxvM JRoI6UYm3MxEF7kJEESvhBoeIFwkUsX6WfTnsGadmB2Ghbm0b1z7VWZNJsGp1ACrbaYucD uNRtXh0tORmJjwYVP551w8vJSTb6LqA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XAZgcsQI; spf=pass (imf06.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741229317; a=rsa-sha256; cv=none; b=cgzs6GeLtsLKqUn/7bDAA0i286GFkykMUUVGeSFtnSq/3l2alREoSQE7uCdEsRM0IXb35p ThbNsCI/pBrbQ2FEzHiUIoXWiJRcA+Bd3Z0eRRKB5ys48qGLFoEkiah5e58sXjTq+3PxE9 tEVWyUYtl0kY7M2itGhKkpH2bQuuM0Y= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2feb9076cdcso449641a91.0 for ; Wed, 05 Mar 2025 18:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741229316; x=1741834116; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EwVWBOdzAZFDUrVCZ0TYEQNSfFcaIacpoDQH/C8G1OU=; b=XAZgcsQIN6sa+t3U+iKeboutg30j7GCowC8g0pQv/WTgektPVNCP5xUc+DQZ2nPHfD hyeAcfZJ3LM8bmWbUI+KD5HF74eLQupMP/GgTg1+L2BXRH+VwhvxL2oPGXu4S8vCHzeC vdozBAoXechf88ouvsneNM+YVzp+W/QUS3FgM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741229316; x=1741834116; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EwVWBOdzAZFDUrVCZ0TYEQNSfFcaIacpoDQH/C8G1OU=; b=QveCUNfNTRmQ3w/cOtCdOeHeifbTS2J3IykHFwZe3UOeE3KPI+XmBsAt6DG87PwW5c CLyVnZJkDVThob35TGiuPze8YaD7s7AsXHo9V82FhTBg6c98sVERD/IUFraoIMdR9/0K UJeBLHbaUt/sOrShAMr/4ZegKvotB1wfMzUWWNd29n4XLRmbEiGQ4NnyN5b94L7cuyZv GGI6k7qUalutMS0fp/Nfk9ugS9ok2mWnUaIimcyA2r6ugsed3HxqmpDJvA1of58wb/S9 BM7ahBZCXwISk3P4e2/dBywiCz6JGs9PyOYpe8mrrxNtgjfRtbhm7FMJwWs5OtN9GWyj nZrw== X-Forwarded-Encrypted: i=1; AJvYcCUHmEN6wmIl1sa65WqWmcP/wj9LBH9hLOvbbN/BlvBIFNsb2bIprqWZA2HchmbTdwhtTUKDZY/Jsw==@kvack.org X-Gm-Message-State: AOJu0YyX36lzs0IKsqivkoEdbwx+x7RX9BiFx+skTKG4AApXR8vPQ6hN cTxNmTkoY59P+jGQ99YQi7CicjjezcRTnBGjq6wPplDf6N4ig0o3mtYSMLRREg== X-Gm-Gg: ASbGncteWreeRO7DNVKKFUo7UcHPgAkucSmCUSt39LvRJzZa1SrzT6GaEJTMXpoIAvN rIFp74Bd9KFbyQ5NpcpRhMOQUz7Zeq+31Kepe/2+Du9zcHrrwi7u5nAJKZEvJTO06/05frId+tq EiLiQo8T484xbAbXzMj1Ozu5tDad2DYcYdR3bMkhZNSbZaxIopTvtGZwnR6YT9nJsD68R5L+9OK NBuitXYmIo5ht9lSkr1tRjZNi+qLVJ+4TN2zx5cHjTK1GF3nHclEHTop90dLrGtNOmpzgfKiI22 HHdMfy1gvKynsWVZnJRn51FSRy3PyNwr7WYtqvGwojctp6qB X-Google-Smtp-Source: AGHT+IFIArgRzLNGNrgRJZdaaHvP2M0KzTaCSzTD4thI/cKyXM2KJp9u20CrvciiusRzKtXjic+oIQ== X-Received: by 2002:a17:90b:2402:b0:2ff:53ad:a0ec with SMTP id 98e67ed59e1d1-2ff53ada24fmr4619812a91.21.1741229316507; Wed, 05 Mar 2025 18:48:36 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:2558:9089:fa0d:5caf]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff693f8804sm183276a91.47.2025.03.05.18.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 18:48:35 -0800 (PST) Date: Thu, 6 Mar 2025 11:48:31 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: Herbert Xu , Yosry Ahmed , Sergey Senozhatsky , Eric Biggers , Johannes Weiner , Linux Crypto Mailing List , linux-mm@kvack.org Subject: Re: [RFC PATCH 7/7] mm: zswap: Use acomp virtual address interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: xmxebmhzsz9qu3jrbo7fdfos1uwg346c X-Rspamd-Queue-Id: B0953180007 X-Rspamd-Server: rspam07 X-HE-Tag: 1741229317-99530 X-HE-Meta: U2FsdGVkX1+j/OGFXChkKN7yhVEB7vGAoRUFUPKm0pQvX1fggY043uOhoO8U8blGyE2tf5iQdyz0zV7W7WofyYkh/V4JMMxgcpYuu12r9xLoDYYgdXGtKP73TEdFrvyxq0tQj2WN2z2kMHfJPeAVoup/hVNNCGsSRtaqLF/RXFvy6J4zDdGpFrwyIGPnGYu4G315c8wPeAdliI2UiKMyZsxCTPTn7dWGTPL4dJ028Sjbcj4vpWACrU2hWMDJPcmXju6EtsAP1dT2lwwVid7xKOA32ny/R0OBEWFXDbBLLTIFe3c744kcsyWeBNGhN/8VTziFrMLD64uXrWRswy2ix6L1+hZ54kPEz+7LAvSCK/IEretyjQRTvghAx65gtlqrtfgVQHiCk9XDapXItNijIq44R8uOWlMgyp8dHcZI1AdtJIa4zqhNnF51QeF8NJPh+H0eGhWlhOfgJd+UVMP0gBM1oya3Byepcbur4PW10Ym2nysbbhnuOzqUB+Kd6K7DDY3itTkrUcK9hb7DPHqKFTRyXmoqq1BxGcA6L7z22gYjA2X1XGRmJi3WGYDMvsbfpWzmSi2Umk35NStoAFSfkVMUbkbtV/h7bCes8D+rEJ1opZPD++mkUcg+W4pzWuChlnZM+rvjjMUCbF9ysc7O0siLpDOkCMFJbhGrdWctaFzQ6gPk1ST51LcPUDPudobc0FJSB4+3jENK1fKqZyvB9wY8VsDxNAxeDs/hbA6rP938dPOy9EznCfjK1sBheckyjPtqqQHECoeIr65wIe3zgO2+/udxNpTwHFLmxJR+5kn7kO/OPqrj5Xdf68wUCnVF97VLfNcrKBmCzhGluH+Ok5cFFJVV9GlQs/7kr5iQiMTuZ1X2rrTcGSRmtcMJW3ZV/JQZKFVrko8Bx+9s6BrEsxbRuqQvcfR3y4A160Zi6vDaPKv3EXIyimgQVKLBY1f7zQsO4t2KKH3z7/O0/8d dcJCzcdn PC0u8eO1LKGaL0giixEqPK/NuvJmp2l8N9XK/1L+SQxDHcF7x2XXkIBl0cCZTaKCWEYEyOUuYxsl3/W/kuXYAZpcqDscoLkfFa5yAllFQ6gjUWBDLM2Y0GX6yHJiwqwhj9QI0e34z0VRtDA4YOY/hyt8oYdP72m2/C4zPwJ8b8s1yn2OFjC7c8zgGGbywbjsYxgWCyjE/zJQCpZcEuF0fJrBHTl/8HOy72oFYax8tC0d/7Z+fTMNmeqGKczaRfAtLrzYxMSPsNRLh9l2vURE91tCa9zs65HplAToAcn5N7Rh0n5dD7DnSQKtZy1L+CNe5cVGf8/9i0lkao+irlVkbcBxenwOflYVOsnN4tIdXuC50evmZjgaVZEZs8EAzDksIo5P1ccyDVxehLdS5gTUuumvEeyjOiyiPFzbRkWCuk73837jtG0h8E44/04Z6FsfVR6bR8G/gyJhNOswPT81xV0KdwfLz8XMkChN6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/03/05 09:07), Nhat Pham wrote: > On Tue, Mar 4, 2025 at 11:41 PM Herbert Xu wrote: > > > > On Wed, Mar 05, 2025 at 06:18:25AM +0000, Yosry Ahmed wrote: > > > > > > I think there are other motivations for zcomp. Nhat was actually talking > > > about switch zswap to use zcomp for other reasons. Please see this > > > thread: > > > https://lore.kernel.org/lkml/CAKEwX=O8zQj3Vj=2G6aCjK7e2DDs+VBUhRd25AefTdcvFOT-=A@mail.gmail.com/. > > > > The only reason I saw was the support for algorithm parameters. > > Yes that will of course be added to crypto_acomp before I attempt > > to replace zcomp. > > For the record, that's also the only reason why I was thinking about > it. :) I have no passion for zcomp or anything - as long as we support > all the cases (hardware acceleration/offloading, algorithms > parameters, etc.), I'm happy :) > > Thanks for the hard work, Herbert, and I look forward to seeing all of > this work. zcomp arrived at the right time and served its purpose. Back in the days, when I started adding params to comp algos, zram was still using *legacy* crypto (scomp?) API and Herbert made it clear that parameters would be added only to a new acomp API, which was a blocker for zram (zram by design did not support anything async or even sleepable). So the decision was to drop scomp from zram (this should have happened sooner or later anyway), enable parameters support (so that we could start playing around with acceleration levels, user C/D dicts, etc.) and begin preparing zram for async API. The last part turned up to be a little more complicated than was anticipated (as usual), but now we are reaching the point [1] when zram and zsmalloc become async ready. With this we can start moving parameters support to acomp, switch zram to acomp and sunset zcomp. [1] https://lore.kernel.org/linux-mm/20250303022425.285971-1-senozhatsky@chromium.org