From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 1718B6B01BE for ; Fri, 11 Jun 2010 05:17:50 -0400 (EDT) From: Catalin Marinas Subject: Re: [PATCH -mm] only drop root anon_vma if not self References: <1275929000.3021.56.camel@e102109-lin.cambridge.arm.com> <20100609211617.3e7e41bd@annuminas.surriel.com> <1276168866.24535.25.camel@e102109-lin.cambridge.arm.com> Date: Fri, 11 Jun 2010 10:17:36 +0100 In-Reply-To: (Dave Young's message of "Fri, 11 Jun 2010 16:08:08 +0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org To: Dave Young Cc: Rik van Riel , Andrew Morton , Linux Kernel Mailing List , linux-mm@kvack.org List-ID: Dave Young wrote: > On Thu, Jun 10, 2010 at 7:21 PM, Catalin Marinas > wrote: >> On Thu, 2010-06-10 at 02:30 +0100, Dave Young wrote: >>> On Thu, Jun 10, 2010 at 9:16 AM, Rik van Riel wrote: >>> > On Wed, 9 Jun 2010 17:19:02 +0800 >>> > Dave Young wrote: >>> > >>> >> > Manually bisected mm patches, the memleak caused by following patch: >>> >> > >>> >> > mm-extend-ksm-refcounts-to-the-anon_vma-root.patch >>> >> >>> >> >>> >> So I guess the refcount break, either drop-without-get or over-drop >>> > >>> > I'm guessing I did not run the kernel with enough debug options enabled >>> > when I tested my patches... >>> > >>> > Dave & Catalin, thank you for tracking this down. >>> > >>> > Dave, does the below patch fix your issue? >>> >>> Yes, it fixed the issue. Thanks. >> >> Thanks for investigating this issue. >> >> BTW, without my kmemleak nobootmem patch (and CONFIG_NOBOOTMEM enabled), >> do you get other leaks (false positives). > > I didn't see difference before/after apply your patch, how to test > specific to bootmem? With Rik's patch applied and CONFIG_NOBOOTMEM enabled, do you get any false postives if my kmemleak patch isn't applied? Thanks. -- Catalin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org