From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B98D6C25B7E for ; Fri, 31 May 2024 16:51:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A6D76B00BD; Fri, 31 May 2024 12:51:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57DB96B00BE; Fri, 31 May 2024 12:51:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 445506B00BF; Fri, 31 May 2024 12:51:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 252916B00BD for ; Fri, 31 May 2024 12:51:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CCC87160431 for ; Fri, 31 May 2024 16:51:43 +0000 (UTC) X-FDA: 82179282486.23.3171B36 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 15C6E2000F for ; Fri, 31 May 2024 16:51:40 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hZ5NNlf5; spf=pass (imf03.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717174301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9lclNorrTuZxHvlm4yhJSeHL+7mBpQLMo/gFiHr6+ZY=; b=G51DFdxFQMm6ybtFc/diZcmcO38wZmGVNwlSk0DZCBWlPZXjKB0Tfsbs2hHioD/5W+0NU3 v3zJl/kTi4WQ3WAOE9IGeYReXbQ8dcZ7pWs0q7NSNr/lbN4YCXXi61BKu6TLbGb+GKb/Od 0RCHrCI6Zdj4yiMRm8e/ZH4nxtleLH8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717174301; a=rsa-sha256; cv=none; b=72ntwBF3hCBRS5mkT/bhvW+Mex5/njY0qZgwgoDAecpkcxoUiTzx9ZKvIbRUz2McD0yt6I XB45MLU39lpCUYYAj3MNvWzSpX3q00EexT/nsxN0Crsl+zUiqdc9Av0b5JxeLwG3uggQdC lStaSbnuWQxG2eT73fWX8F0f4l1GIoI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hZ5NNlf5; spf=pass (imf03.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: kees@kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717174299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9lclNorrTuZxHvlm4yhJSeHL+7mBpQLMo/gFiHr6+ZY=; b=hZ5NNlf5zcIZZsBTALKRZnh1mVr8ROUllgS4pYmV3KIQYTq2x3XySgxS9WEDtt52jFA1Q5 6KBII4MnUd/M5BXsTr19url9OpExD0VwT4XAQMBBSbgSHSCBT7HgR/uYK+yBEGooacTXFM UIfeCU4+OuZi4fwUR1SHJwFbRzikJu0= X-Envelope-To: vbabka@suse.cz X-Envelope-To: cl@linux.com X-Envelope-To: penberg@kernel.org X-Envelope-To: rientjes@google.com X-Envelope-To: iamjoonsoo.kim@lge.com X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-hardening@vger.kernel.org X-Envelope-To: gongruiqi@huaweicloud.com X-Envelope-To: xiujianfeng@huawei.com X-Envelope-To: surenb@google.com X-Envelope-To: jannh@google.com X-Envelope-To: matteorizzo@google.com X-Envelope-To: tgraf@suug.ch X-Envelope-To: herbert@gondor.apana.org.au X-Envelope-To: julien.voisin@dustri.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 12:51:29 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Kees Cook Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-hardening@vger.kernel.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , julien.voisin@dustri.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/6] mm/slab: Plumb kmem_buckets into __do_kmalloc_node() Message-ID: References: <20240424213019.make.366-kees@kernel.org> <20240424214104.3248214-2-keescook@chromium.org> <202405310943.D9818A4FE@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202405310943.D9818A4FE@keescook> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 74ofm9k7oswh5j63euriy8bta9br7ihy X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 15C6E2000F X-HE-Tag: 1717174300-269473 X-HE-Meta: U2FsdGVkX18kkWONw746xlBHT0CEQNjc4KHCWUmVW4ykZl4XFZWutYTO/MHOz4ZG1/0ETCD6mhyZv5tRaUHcJu95Zw88Tzw+/hYRuTjbwMD6L3giXfMf1GjLA+xDH/hFHMgCIqnnDO1i6MAgpnX4voWS1CIbPAZlATy0Pwm6HDzlSqNZD0jp3HFYmkQD2n/kyS/e9mepXz2ISCJgqu4g5zoasSozbU++IJJWAcAtDtHEibQgzSxqM1nUyX2vUUR+Vih84xcqCei0LXA5Z4bmDBRvx6HucloPJTAlgi6Uoo8iu0Nn96ijIJ36vjl35e/Sem3RN1jV8vwQl+KrVOjmyZUiKZclxv7/UM1uSuuQ/y2bByxUii41AJ5eKV9zQofM5B3G+TVT3LEYJzY1QCLtu1VTZ5S97nfSmMsDg/+AVGCEAy32pbTEv7tr40DsNFc/+fbb/MPQtSe65/0iPbcqSnbJHUDLtCCHnCwr65nAL6pN68/XtRMXQVAKWQlBs8+w1A+fh9xYZTvNIdSyJ2ll2IQQw+dYbZPMTe9jDs5/LMpDrAQHXlqTbuvvgd0KQSe6ispMZKXl2EXXvuZLvq8CCrVr65Dt5ONPPTKvwebpkLPFy2RZza5fNkvOcmLWemrciD+0Ct3NnUldNCOLoXaoVl34sGStGbn/CqoT2GdnXf/N95G1INc19hfjVgHECIBDy3wbEEb2LXOr9OZht7eUIK/nqzqmbVOmQI8NnzlinUyC7XXNtBFAUahof5cnJhEgttuAc29fpNJZvrJlEeB3En0akb+3F1u1/7ZlDWnvAVAJdPo2Ad9aWDWcDGG1Gyr4gn+kAUE0A+SgbB/m8pHlYQ1mr+gMRg+xLrQtxhINSRvygmqvistBGi/cy+muIwS/CdieABj3sCadqp2UwTwPtPbKSFVAXnuvPaSJzMDa02F7pYgRvvkkHW5aYI9Q/sROaMf7fdvAqIlOV+x9KJz yEyhj2in l5y1/ze0fYadmEIWqDMruPGZeFpWBSi2kRcFWPZbxgONdPRGf1imbYX7Xg+/FxPxj90QzCSaiSSsKO9JxXNxv7wiKweS0ycvgLTY5srBd8tw6s7YjpqDDw9ayr7N7ptiwNnz5lfWu8mu45MbUo9177LYE5I5aF4BpJ8IYryZ2OPmuQGmSHAq2/eXbLbg+kRTmnh6HkdVdFHVVRgY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 09:48:49AM -0700, Kees Cook wrote: > On Fri, May 24, 2024 at 11:01:40AM -0400, Kent Overstreet wrote: > > On Wed, Apr 24, 2024 at 02:40:59PM -0700, Kees Cook wrote: > > > To be able to choose which buckets to allocate from, make the buckets > > > available to the lower level kmalloc interfaces by adding them as the > > > first argument. Where the bucket is not available, pass NULL, which means > > > "use the default system kmalloc bucket set" (the prior existing behavior), > > > as implemented in kmalloc_slab(). > > > > I thought the plan was to use codetags for this? That would obviate the > > need for all this plumbing. > > > > Add fields to the alloc tag for: > > - allocation size (or 0 if it's not a compile time constant) > > - union of kmem_cache, kmem_buckets, depending on whether the > > allocation size is constant or not > > I want to provide "simple" (low-hanging fruit) coverage that can live > separately from the codetags-based coverage. The memory overhead for > this patch series is negligible, but I suspect the codetags expansion, > while not giant, will be more than some deployments will want. I want > to avoid an all-or-nothing solution -- which is why I had intended this > to be available "by default". technically there's no reason for your thing to depend on CONFIG_CODETAGGING at all, that's the infrastructure for finding codetags for e.g. /proc/allocinfo. you'd just be using the alloc_hoos() macro and struct alloc_tag as a place to stash the kmem_buckets pointer.