From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7511C3ABBC for ; Mon, 5 May 2025 17:46:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 584BC6B0088; Mon, 5 May 2025 13:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 533F66B008A; Mon, 5 May 2025 13:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FB416B008C; Mon, 5 May 2025 13:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 229DF6B0088 for ; Mon, 5 May 2025 13:46:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 38781B85BC for ; Mon, 5 May 2025 17:46:42 +0000 (UTC) X-FDA: 83409584244.28.0B9B759 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf06.hostedemail.com (Postfix) with ESMTP id 3309F18000D for ; Mon, 5 May 2025 17:46:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Pw7KbekP; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746467200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=43yWpaDFlvzQdOUfoFXBeY0L6VRPaAC57++Wqp89Ras=; b=gsRhwWhJOYTV//lF2or2PLo71zrOJmHpFEeqm3M3Uk5aEj2ZemYY5Jn+lqoZ9ugtHmrGr7 5gZlE8NX+eV19ZUX/Gq6QEqd+c2wMk1rzT5N3CESnLh87QTV48JsM3r+RkHw0dmBlVDhMV L6snDNGnte/OjCJf+Xpouo/akmPTybM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Pw7KbekP; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746467200; a=rsa-sha256; cv=none; b=h1g8WzuGaJUNdsWq8t/7Qau9sQykIkODPvzrERgO5NUxp9yR4er0aXpEE2NOzb4/Gb1jck IiEIvV/d43FontxsGdsnYNV8o3XDEOdhhHHJZlmE5gJANPYexVIkD3edbevGxTy89kyeZA TRUyTVdih5KHDcP3oLLaVlWkFuUkUew= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ace3b03c043so721447166b.2 for ; Mon, 05 May 2025 10:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1746467198; x=1747071998; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=43yWpaDFlvzQdOUfoFXBeY0L6VRPaAC57++Wqp89Ras=; b=Pw7KbekPYmkaiMg1SvjdpdUwq9QxdlpeljW+bk7HIFw/tEeXgS74zU1tggarx+sLUO gVRp9sFggHpuN4IEbE9Aw6Z8tIZAn2hDKdcAG5gzXaknDM/hjKnG8WSijFESLUQM3SUw aPuATTP+KzLGSS+7d3Zxq6XzPqTALtTOvIGwurKlcTcyu4tVpiwy5kRb4JK2Q1arJNQ5 Vp9QZYv5CtURfYcTvYUyGY16oHnKfBRN3Qe4r1VFXPUzj2mPY5oFCF5IinXUzbkWgfDJ gSAFUFLseQ1RHC0ZfeJKn7llA9FCQZEbhSCPbxeBaBdGzydtmG8O7BJ5ymLnYFEVNB76 9YaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746467198; x=1747071998; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=43yWpaDFlvzQdOUfoFXBeY0L6VRPaAC57++Wqp89Ras=; b=JPk1t3fboxMJjsredfFpvyUJJepgpSIi08cM5VLrejURqxDexSq9unxPZn8oxDAxz1 oTfA5OUs1AaCozJ3wGU8TL8aWy1xZ8riQ8POJamR4oSS9riNe/cKLeVHN08kqprNj2Ff U6XS4zkm5VyXOVZL77Gc67YrGkNTkiH1uc2rT1czqGBJpZTAIHB43Ofy9syitZzZ5exV 5DOptWdH23qH4NdTTY83pWYZNxdAZTAS3TYWMycbmwzWnMAesiaR+fzJ4pJNDiII8MFA LNs2u+Efa8kYIqAUlwJzLAzCTdGeVjdDfV+XzMTvr3XVhv3kOSSg8Sfjws9X8mzma79W De6A== X-Forwarded-Encrypted: i=1; AJvYcCWFuAkOoLmRPApl1d9g4fzkytwNJQ7g8lWJkK+4xj4na3SA1ZsN+uUzcPJvOFlbiH+QaWod8+M9mQ==@kvack.org X-Gm-Message-State: AOJu0YzbvtpOdNzaViwQYUPSKvFVGrpWXiem8b6WgJ5FbMjJPIFTkkp4 grxKPW8WB5TFnyIvK2px7FDB1oR0w05+YP4aNsByZF9U8OJOhaDE/KD2kiVNGUQ= X-Gm-Gg: ASbGncsGZssTwiN1AVs0Ef0ugpF1l/NCDLw8Ff7akgZ668Arvjkk7jZJE2NIWT9ttaV T3BUX/FvTPgd40wCaBC2FBe/lR36d5fE6AJ7mnL1OgNQUcTINkONmkkeyatWBxU/akFiApPOqiM cIM+7BOyqerkUykj540P4JFjE3y2uCXwSicc4CwdD+eK5IPktk3Kuq1nB4X/J8KIpJWzddihHqj ha1c0PYU/lbd4L1u1A4tMmfPw7oc0nmxlAyZC8xkGGmnIsHyaMNvi8hzBGLFeviZ+vKe1HfWUM6 dbcx0LUOpDG7zppkd77jNfy0Fz7iGufpvkok20RNkxQ= X-Google-Smtp-Source: AGHT+IHZlXsEPKMLo2zRS60G2WHXFj+ckZOv4p4jkB4sqgQ0nGSrOlorMH5olM9T7Zhs5WwmEyP8Cg== X-Received: by 2002:a17:906:bf48:b0:ace:4197:9ac5 with SMTP id a640c23a62f3a-ad1906a9acdmr985756166b.27.1746467198490; Mon, 05 May 2025 10:46:38 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad1891a311bsm532577666b.54.2025.05.05.10.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 May 2025 10:46:38 -0700 (PDT) Date: Mon, 5 May 2025 19:46:36 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: "Chen, Yu C" Cc: "Jain, Ayush" , Andrew Morton , Ingo Molnar , Tejun Heo , Johannes Weiner , Jonathan Corbet , Mel Gorman , Michal Hocko , Muchun Song , Roman Gushchin , Shakeel Butt , "Chen, Tim C" , Aubrey Li , Libo Chen , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, K Prateek Nayak , Madadi Vineeth Reddy , Neeraj.Upadhyay@amd.com, Peter Zijlstra Subject: Re: [PATCH v3] sched/numa: add statistics of numa balance task migration Message-ID: References: <20250430103623.3349842-1-yu.c.chen@intel.com> <8b248ff3-43ae-4e40-9fa4-ba4a04f3c18b@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="22qdon36iehurhxm" Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3309F18000D X-Stat-Signature: emt95xyaejth3dt1bw4q69kpym8nkbjr X-HE-Tag: 1746467199-24640 X-HE-Meta: U2FsdGVkX18X4//CR6wcmeBPI8GUKHtb9i2oW2WsIaIkprlCRBoeMFpYROj72x5N7F6mC33t5yMWTWntOQmykr/dqfy0nS5eK9x6zcY+u2sWiAVtG4cQ0RN5XZZwXqFrLtj9+J5goXmcZirKlk4508GnPG4FpTM8trrFi+/I4rAMIXzwqxKLsYsLumVkO9Dq5n9lIoEtgeHJGuYyfbj0yrpewONZO5Ph8CeWDhqFt038xW1UwfE0ZF3IBwoihwCV5AvKXlfQouAapt8SeYxMYbaw8qCT01BP/6nYDqBebaaVkyDrlLrc6IkBBrDjEctaoP7HGW1gpee0wdpo2MUJ3SOFt5SXQjKAFV6DDyyZz3L3nGZDatLuWAuYkC/TSGHmT9OteYyS1R2IL9vGu5EBXyL/9CkbAABlYJs5vsw4OCAq4hLoeiSa48n5VYXLDWe5c7DlJlj7u3Pd6QF4wbJdIQ8QIR/K/2psjudz33aJrKsnj9UOzXZrD17jlyQPiqcEt2bZPWcr8G6JGKD5FA48tu4SyWHhHkbA6xUQZknpcD78kb2+1nURd4jgR+ZaUZZ2GxNJzIplwz/whBaExc8XWE8c4PoQ7+S9QhQYncGAVdNBVtrh3CkIQfRJB9zK9aWLV1mFIrYupNMeBpbYDxVuRRZGwSN19/74zw3ItZOh1loDviB1uu4AqsK+OQiIdcbv8bBcpXsq1aWSmqDsRQLgwIfRGY5K8EY1cqsMuKpnW1CyofN0Lkvwnd1LTYWuUxMTK701ZCD4vj8ITrmjR8fryYza7Lbe8biMwywXn7c91gG9Y5uOmDnNlzM/XgFfcY6hyWCH9BOeYZJzxc+//IicO6CLRJPEcBDLzWw5PoHI7K8ZNOBhD5HbsayFk0gELaBpFHSDdg5RVaN5GKY4niq16mJD2R9guXhRoOpWr3+RIZAUsKjsLn3devOez7eMIJw4mqfLedMaQvjsljHziJV qwH9yC5H ERdJaXOFBSXfQFkjLIfibkwP4LIdOP6e1YyPwLUgIdqg4V7StzIhYJ8HDz1aTyynXiD8UI+iJpu7tXvx6Y1OQJ93zGipgcZNIh/4S3rpWfDrrK8KTBII68XzdcEp9SMx6MUrayC6vPLsVPPgbzYe3tCfP0EsGHViuiLrie1oh7TmFPR6yAuCCEH4m8BH3yIi8pQ7BvpUmeYQcTs/XQ23PqwotS9H1T0+oCAVJSWCan6Nrt3yhSQ6bFbaDoyeshdS95czPers7UyGw9TNpmMeCJBHWnvGSuZJJdP2TwpBolLPku8jg5+I3CiO+/YfhKo3mQFCAPvAuWdjk+NTLMdkFaB0yWTzZjMXSMeOVidTgxLo9sDh3YIqIiWbc90atpGCauY4l6phYOQ7DdlXT6BFngzj8EfuHabxXqmMuYzWThyF6V3RarNmrMhuzqE4gNf3jInOOZ1pdbqVAPoQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --22qdon36iehurhxm Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3] sched/numa: add statistics of numa balance task migration MIME-Version: 1.0 On Mon, May 05, 2025 at 11:03:10PM +0800, "Chen, Yu C" wrote: > According to this address, > 4c 8b af 50 09 00 00 mov 0x950(%rdi),%r13 <--- r13 =3D p->mm; > 49 8b bd 98 04 00 00 mov 0x498(%r13),%rdi <--- p->mm->owner > It seems that this task to be swapped has NULL mm_struct. So it's likely a kernel thread. Does it make sense to NUMA balance those? (I na=EFvely think it doesn't, please correct me.) ... > static void __migrate_swap_task(struct task_struct *p, int cpu) > { > __schedstat_inc(p->stats.numa_task_swapped); > - count_memcg_event_mm(p->mm, NUMA_TASK_SWAP); > + if (p->mm) > + count_memcg_event_mm(p->mm, NUMA_TASK_SWAP); =2E.. proper fix should likely guard this earlier, like the guard in task_numa_fault() but for the other swapped task. Michal --22qdon36iehurhxm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCaBj5egAKCRAt3Wney77B SanGAPwNhmE23Z/0QW0JWDF2KTaNoo6f1GDl48W1opF0LxB1lQD+MNowOWLQ/L5v tgd+J+GBmSPm7cJPRvC8MFMHKdQZTQE= =EAuC -----END PGP SIGNATURE----- --22qdon36iehurhxm--