From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60DD9C282DE for ; Sun, 16 Mar 2025 15:59:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00E41280002; Sun, 16 Mar 2025 11:59:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFFD8280001; Sun, 16 Mar 2025 11:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC830280002; Sun, 16 Mar 2025 11:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C02F4280001 for ; Sun, 16 Mar 2025 11:59:27 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9E36F80322 for ; Sun, 16 Mar 2025 15:59:27 +0000 (UTC) X-FDA: 83227873974.17.4B3AAC9 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf01.hostedemail.com (Postfix) with ESMTP id B53BC40005 for ; Sun, 16 Mar 2025 15:59:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D1+SfSki; spf=pass (imf01.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742140765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F4bZp2fvqVXmj3CQtnXGqP+MV9d+iqYo2DdHMBvTbsM=; b=VaTmjSa3BhFChC3LUF0oAMRNJYh5IwSBgZgjDsD0oXVWSoZOOC+TTpqgR0/EyIMrDaQ2qp RLDGkmG0Rqn67ulUt9XqpRTYwjWMhWGOMwu7RsHW5ZKDSXRqilF77ptgGd07zZPUadQKjs gmUjwiHaNokEGDCmIngARRQNB2dznG8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742140765; a=rsa-sha256; cv=none; b=4R+9H9tWFdhLMtdXTszSanE0R4v5USuxp66evhSG28h5cB4huNzHvFRKnm29uo15kFcZnP sjhhbASlQdcyaQ8MWlQobuD36WTtLEkQ4Mm3eQbpmyQ1q6NiBOPGLdbiw2m79VhQik7w4B 0pgHfziC0/Uq8fJ8n0VEIHAh7SkhucY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D1+SfSki; spf=pass (imf01.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-224341bbc1dso64974655ad.3 for ; Sun, 16 Mar 2025 08:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742140764; x=1742745564; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F4bZp2fvqVXmj3CQtnXGqP+MV9d+iqYo2DdHMBvTbsM=; b=D1+SfSkiYI4DLH4xqC5Hlb2CS/hMLfwhwZcE0RV9ivH5lGTXlKKOn84Ii5EQ0qjNr7 SRukOueeR+4VkUj7TTWUxsehS2jGlhXL8NQ8O8Zf/mkNjhfdeBNy3bHyBDc+s/L3n/jp 12J93gZpsTOhSBT//LGrbDgnp6TxWQ4taKZuN9qqMfgiWBvyZ7rTrW8L3zwkqpyneWzf NEL7EyLQcs3TEKWwr15gtTcAyteHBNKYEoKlI1EPlHbaCfWjhg+CocO4k4ohU+jHaZyi U2ccVXcE09DgGWP9f9iZ1u31xEagxBBdYiozNd6jsXNeCAvIrIioCTCzHMEK+hbR0gkn ZWuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742140764; x=1742745564; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F4bZp2fvqVXmj3CQtnXGqP+MV9d+iqYo2DdHMBvTbsM=; b=o9mFd6Napglv4pz/Cbg1+2xR1GUrBm1gULPO38MiSftBt5fxKAfKI9SlKD/gAUZYTu bVaIjZZnYTUc9LBoz4dUci9eyNU1dzWe4HxStbyWb1m4M31u9okl0O3ausniEuX9k0za yxRFDEbckn43Gp3rag02RHQQXHJP676L/Bf/59pSDIPi4iOCYrQC5YmgCWBtLeKrLo5n 9sfN/60LybesDltb6RIpD4N6W0urpZnthNRGDkO+5f5+nsguq8d75xmUNgAKK8isaiMn mT4edmL2TckGZ2NbPZmsV6PYDvFRt0EiUZv7flLk3qk8f9ROuD2xi5IsJltoV2gknGUS 3uPw== X-Forwarded-Encrypted: i=1; AJvYcCVhy29SfJL8ICI7HShOEKvAeAtd8qXH0dDSsaTDi2uzaQ63i8WkYnNcPua5MAp128TEhFuq9lTAcQ==@kvack.org X-Gm-Message-State: AOJu0YyKNYlwJhuebNSI4QtTBVCHF7eDjJy6UIr9yXEyoZ/FLmeQjJSk 8HFcKhAvzFlxbgtvIOsOte3nTlt6XTMC8YlWqQlucMvafN7chZGj X-Gm-Gg: ASbGncu/BIKO6unyLLPU5ZIjibkTphXraMjrt1ulP5fqp6lEPW99+BR1aPNJb5xLYgi hPjwaYE2c2g0bT058GRGCnaYEV+SkHS/f9UO11bhNdXtI9ckYyzYvk+kP7OZOT5MUwcLpJ0KBRO 4fuLZYt/JHUT9vgQT2QQgkQtSHqYi+y6u5pJjdJq+bSPrREZZIHwicgISXoAabCx9XlJOT0Yd5n nHYJBR0XNmlWwc3XNtLXIjwsyuKdLI1wDyMDDml6d4POFe7x6TFMHcL92lAdkCA4g+EZsLGi7fq zF2hwYad4aEO53ZHH2DRij2vY+CV3QorI6/X686bscjGJYDGdtZh02I2WGPVMYIX4n0U1rI= X-Google-Smtp-Source: AGHT+IEQAEZ6ns6hsA7mRZvJHISXdD7LaGEtw+Oe7yAnHpSLVjJcLic04uKzeIOZwjy/qbtI3xODVQ== X-Received: by 2002:a17:902:ce02:b0:220:c066:94eb with SMTP id d9443c01a7336-225e0a6b2cdmr125317245ad.25.1742140764417; Sun, 16 Mar 2025 08:59:24 -0700 (PDT) Received: from MacBook-Pro-49.local ([2620:10d:c090:400::5:4180]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c68aa906sm59447255ad.88.2025.03.16.08.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 08:59:23 -0700 (PDT) Date: Sun, 16 Mar 2025 08:59:20 -0700 From: Alexei Starovoitov To: Andrew Morton Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 0/9] memcg: cleanup per-cpu stock Message-ID: References: <20250315174930.1769599-1-shakeel.butt@linux.dev> <20250315205759.c9f9cdfc2c20467e4106c41a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250315205759.c9f9cdfc2c20467e4106c41a@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B53BC40005 X-Stat-Signature: tp5xyke8xeztda3hi1s9xc7gdz49ntwo X-HE-Tag: 1742140765-882980 X-HE-Meta: U2FsdGVkX1+F63bEw/EZJL+WdacMec3PssNHNrUMAwGoQBjLbCfZgNikkVtnyybMN29MhI2NtUGG4vpauee+s/THWNF+xMei2Bn3FFhN3GN9WrcCPOHzxTPmoK+bUo/7gRLqqF7dnj9nr5tTK47R9VKsUCcvDCas0XsKHJoHJbwEmMRJlztu0wqGFmwwuHVKVszib8hYKqsx6f1hqlzU57RMby/DIM4EgjqRMBkXojtffcnLAVEcmCb557M4jrbHEd4LefHZNpGmqjg5Rw6XNGxMumAuKBvzPt2jPxhTg/Yqo/4dtukCuiRbcaYxWFrN+9qQ8jJKVahJ7fNJPmfPemRB72QJna/l2T/h08BqSy6tCERgChM+vaRNx21xzM2DAfOmD3KTg00dsZpY+gnDDm2zfIF32kWsLw3spYE283JIp0aijqQf2gFjgSnaCVfwEm/SFrRk/1+ClnzYQmUR/OOhmZB5phtLEzxba8AWqDlWRRkZx2gFbWGL1Qpq1nlbP40poMDHujObmBgo9Ly+UXEZBctzzNNXVBE2Ygoq3g9ZXToHr8ypZJ8II4nUvPhSmyesIfCb6oAdcGenf9yIs+WvZ+bZYkdHeauil7KmGqO08TS2VPiJzM/ntmn58ANZ4+alRrj7XDHUeM2DTTnQwVViFaqDdLkBVinwbVIifluR4LgPAX4XURPiUuHyiUUzJFlYbIU6rAlcsRhJWxRsFiWkBO/MtAC8zn9BJjvyRgCzAzpVXdJJ4Zbo/ukxeo7XS/RpHBCUvc1yHrAUmrPdI+MrDQalp3grH9lmrWs2OINsRB6C43y4nBmuB8b2a0cnOGHLP8p0VpYsPrhYz9ZV1ZpnPF7L10MPSzA7VMx4KzjkKxj5UQ+qFlL8pQSZ+CLhMYneYsG7imG5gB1g91F98WaQcSHrYB2VSooiLr5dWiFqI5KGH0YR0SCLJrzVNteTBlclJbJFZImZE1wqx9P DT/AWq5B g1KHvSUyLverz4YLxgKBaqthoEuHdOP540xZ+cyOQTWNl+pOPdo4jAwXfWvUc2Y6OkSCetDQQqowqjTUIrHqsjOPQV/XKIwI9tupWm+Ac+u7OAY8oJeQ0z9p0KUtUL2W14QZnSep+UMlEY6T+dVsxSDJAmZM/F9YaX3GD/rFZ4eYyU9xwWuOHIhKY4rRj6P/YF5BYTE0Dl5zpOQ/psoak4E5ZPXq6vc+ZxwllO7YDSl33C/ktbttfPezS1P7hIhl28L+XEWfWQKurUDTuK40Ja6t9aPV5HHz8yBKy1cAKxGmRVPKjdQ534nwsVxD2RbrpBc+qOv4DE4IWwTXYWdoVAjsrLyJjyN7xnYKgZBbLhux0ERLSHT4QGZPrAsEvrAJjiNm1Lo2eDEFvxdmcVZhuUZjzJdshBrt2DPSUZwQ12iBt+/DXNFSAYI/cE7cYNUdFhkk0qIVldcl+MlAgf2/t3tYdBqk+4qG5tR23rSDkXF/mt4OnBAsqaAvLylJCboScdknl0riF6wqtJPE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 15, 2025 at 08:57:59PM -0700, Andrew Morton wrote: > On Sat, 15 Mar 2025 10:49:21 -0700 Shakeel Butt wrote: > > > > > This is a cleanup series which is trying to simplify the memcg per-cpu > > stock code, particularly it tries to remove unnecessary dependencies on > > local_lock of per-cpu memcg stock. The eight patch from Vlastimil > > optimizes the charge path by combining the charging and accounting. > > > > This series is based on next-20250314 plus two following patches: > > > > Link: https://lore.kernel.org/all/20250312222552.3284173-1-shakeel.butt@linux.dev/ > > Link: https://lore.kernel.org/all/20250313054812.2185900-1-shakeel.butt@linux.dev/ > > Unfortunately the bpf tree has been making changes in the same area of > memcontrol.c. 01d37228d331 ("memcg: Use trylock to access memcg > stock_lock.") > > Sigh. We're at -rc7 and I don't think it's worth working around that > for a cleanup series. So I'm inclined to just defer this series until > the next -rc cycle. > > If BPF merges reasonably early in the next merge window then please > promptly send this along and I should be able to squeak it into > 6.15-rc1. Ohh. I didn't realize that try_alloc changes are causing so much trouble. Sorry about that. Andrew, could you please instead take bpf-next.git try_alloc_pages branch into your tree and resolve two trivial conflicts: 1. https://lore.kernel.org/bpf/20250311120422.1d9a8f80@canb.auug.org.au/ 2. https://lore.kernel.org/bpf/20250312145247.380c2aa5@canb.auug.org.au/ There are 7 commits there. You can also squash Vlastimil's fix "Fix the flipped condition in gfpflags_allow_spinning" into "Introduce try_alloc_pages" patch or keep everything as-is. I'll drop it from bpf-next right after. Then Shakeel can rebase/resend his set without conflicts and everything will be nicely ready for the merge window. I'll defer other bpf side things to after merge window when trees converge. Thanks!