From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130BFD3DEA4 for ; Fri, 18 Oct 2024 18:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A8C56B00A8; Fri, 18 Oct 2024 14:00:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7581D6B00AA; Fri, 18 Oct 2024 14:00:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AA366B00AC; Fri, 18 Oct 2024 14:00:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3DE976B00A8 for ; Fri, 18 Oct 2024 14:00:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B61AE4093E for ; Fri, 18 Oct 2024 18:00:27 +0000 (UTC) X-FDA: 82687487904.14.1474086 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf06.hostedemail.com (Postfix) with ESMTP id 05073180012 for ; Fri, 18 Oct 2024 18:00:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=mLSvBe3k; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Lvs1PHvs; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729274284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LeMVEUCKs39je7S2McFcqpHTfysFaw8mF36Wls1IuH4=; b=ASIHUbEBc2FQUY86SBIUkmXoPvr5+ouZVpDqxQT1i/uzMjm+mSpoU40KaR4jTuktMJOKwH PnwIe4A3HohLtuqpVQ5RJ3Wi4CaSB7aF/7sG0Ut6I6L6ifBzuSKidN4ntCTzrU0HoQCH20 JjoTL/y1djfdGSghMjjUBugCo+GPsrE= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729274284; a=rsa-sha256; cv=pass; b=S96asbSmisZJN/HvVjx+f/6mKT1PJfFr2Dew+Ch30UPtYRTcD1+Sp1LIE5mk53pFHh5eF9 SbweS7acpfZzM/z+dMmsRbf5IPlI2cmt7txLb50OXQTsPUja5QWqLmWDSDnh0Q2J/bqNO4 G4hoRpah5FoJF/3PSSM8b0CwsNxGojM= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=mLSvBe3k; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Lvs1PHvs; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49IEBhdB014113; Fri, 18 Oct 2024 18:00:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=LeMVEUCKs39je7S2Mc FcqpHTfysFaw8mF36Wls1IuH4=; b=mLSvBe3kn8Exc/gEzd3gYS4Ms3by5brC9T ClVaD0YHojBjbOtbGFnpdEc6YXAo+gwAxn58LlUCVR6YWw/EUuzqTooq5/NzAR/C Ok5CpZtAZ/llV4L6dXNTzv91roTbhoyZHnJuCDP9BSJNr3462Bd5Cgn6FUEUaq/e nsAXqZEBz1NwmI1vI2wCZoPxy732Az6grqA8utDxphYA0OUYoJrSPm9GIlc0dJHv JrWQV8OA/r4Cdn9Ia/hjHenPDXax3DCIzQpgqxrNhZ0IH3NELLfBMjvqKmPjp+K7 PEkKLJu51z6aUFG7sOTldg/a+bQ1G9gjRV/dSGe9M5z0ea9vLeMA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427g1as63x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 18:00:28 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49IHarjF027190; Fri, 18 Oct 2024 18:00:26 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2049.outbound.protection.outlook.com [104.47.57.49]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 427fjjh4qf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 18:00:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mz3L4vGPm3ZsrFnsjdUAw9rdcXo3RID+jFheCipzUDEcLNoA+Fw9HF+ytUhPjRjGHeA8+a/0gim/XHn6wva/FbgOgQbJlvI2G4e7He/r5ntyATyS9xtsFd9WuZj9JetLRb1L5aUcNIWf/+qoNIf0aPTNqT1EdSaVBskSf2toVx+JqVrUabdF77p0AMxV2FmGULVCkDJH9baghiHEJQVrBA+88qC5dGfnncg7d10t9pHF0yX0koEB0gZAQwaE07uBdLy9nKAuBlhfaNILt2QMaPgUDHx6QpqNeOhwu1Y+mWOJL+Kclhguv4uv1BXlc72QKPl7p/KoZT+r/EwMVkUXiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LeMVEUCKs39je7S2McFcqpHTfysFaw8mF36Wls1IuH4=; b=loe95IfKRj9nft3RmL+OVLarZLOhMgcfbTk69Hu0bPcWJbdKt+DiC2vadl9tHX8YA25fpZcGpFDH6XMlvQV8seFFur9bAhIV5mpNLk5+ExqWH6HSHrftT9Aq9V60aUMAUMTIxEflUs3gAWZFlbhiR++ot+O3NI1vqWycl2rfPuIojGjHgXziun3+khu39AhJlQR62LS48dxFUGVrscCQtIMOAZ/NTZVjPKm8XyEpOVzyqzYsqpUvoI4VrIkjM2iSLkfB151mgPV7X5MxIAdUyG8Vd9ejeW4qLPc28jHW4/R6qnCBlejj39Diq92aC6rbqChsoOpp0LOzCqY0mLBl+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LeMVEUCKs39je7S2McFcqpHTfysFaw8mF36Wls1IuH4=; b=Lvs1PHvsyuDtWJzmZXP6sIwZ6neDf91RUYaIGg1zv12SqW5lpkQbA0whkwny345jR4xlVxnp+hvztp9YFfJhLxc4lTPcH/z6d/25ukcgE1QKyljnDG5bYRbSpsDnS0CHf7SWHZI6beNqg42l+C8Naiydg5VbzOOL8eJy2oouGL4= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by DS0PR10MB7296.namprd10.prod.outlook.com (2603:10b6:8:f8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Fri, 18 Oct 2024 18:00:24 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 18:00:24 +0000 Date: Fri, 18 Oct 2024 14:00:22 -0400 From: "Liam R. Howlett" To: Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH v3 4/5] maple_tree: refine mas_store_root() on storing NULL Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241018023943.13860-1-richard.weiyang@gmail.com> <20241018023943.13860-5-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0164.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ac::6) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|DS0PR10MB7296:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aa5b14c-aef3-4a9d-b91b-08dcef9ebd5c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YxiZ2OKbT8hBWwC9w6ffg9TZbqJRELUqyj2OOuKqtoq89lo6KfRNwt8PolWm?= =?us-ascii?Q?6kM1zCN+pw5hHlHnZ7fdwZZbwnjR2ibSpTBXBK8+JNenQxnevdcK6SHa2bAl?= =?us-ascii?Q?U0OKU11qAN1e9eDIdAdecMmVafSXFMObDfYojZyRpkOZJEqrbXgky1VkP9fc?= =?us-ascii?Q?wG9mRZPRKwtbYFQScODOR8i2t25ZUwL3yq70oHb8qZJtQ8Xi+YWBKEcqE6su?= =?us-ascii?Q?p/1ApgxDBFt99AHjqTx+iQWfBWEfsYPNJm6dN0Dd8W2n/ylmi4GTaumZWzHj?= =?us-ascii?Q?aWFCxSSee1jSvk78yCzN2dJwkpR1StKAUIA16h7+kqj/eaJuDQugIskhTZlp?= =?us-ascii?Q?uhQK83wIzXQxeroVMmy23lgeUDTBJt2jUWgfDFgKQARmegf4Gf9PLQUM/k0Q?= =?us-ascii?Q?ToM3XTAeL35lql/upHz07cHQibx5ce0zNUqPqz7FfwHleopZyC+NSOkoO2gy?= =?us-ascii?Q?U0ASN+9QhnwSrSvSShCepkCBUWDmfOH0oievPXiT9h0gzKk1iA7ZEyrpFUpG?= =?us-ascii?Q?p5iQT7dq17UsVQywjrpn8jOlVIMW88foLpVS8jbqA7JtJdP4Gm6Wt9I29lqV?= =?us-ascii?Q?OzR7xGEH68IxOvLzAOAgQwQax3V/vaf2hX5PeWnDKIpTieJxmUhSu1jBHTY3?= =?us-ascii?Q?MfcUxkgIkJFdRAXY8BcqJ6+fB8nRjFDI5B0ghzmeqFVVEMxiOUyUquEeENVh?= =?us-ascii?Q?6Xs5j6KEpUFzwqBWTjDD9F0z+1oFwkmK4U43BftoeFAKOWWxxuUpUX6NtzuZ?= =?us-ascii?Q?S7eR0cA8ZGaqSXxG9PAnCJ7QjJ7FGqIXd2lAR/atftFbKgahhaQhyYppiiZx?= =?us-ascii?Q?XQLH+iqiZebH25Aj0kJ01aNVjVXlgr/N4rWsE9Wpm+3i3+E6b3rVU5a52c0L?= =?us-ascii?Q?xKHST3Ebt8VvX1XU0kLaFKJ1+ugC0jhdDikRi4usV5qmuc4zWFx3yxAgCmUl?= =?us-ascii?Q?cmB6PAXkCF9KA9TXT3c+esOyn1eMUZePQ42cP4fg54khSVnGYXrwsf37a4Em?= =?us-ascii?Q?TbhQ5UhoSbKEpw3lQA+PRqHWX+BTdzCkSlXZLl1KTSdj7a8kge+2BPs2HQhM?= =?us-ascii?Q?PbN0FgntwbryaHzANDIBSpc+6pwh81ZU1p3TTovSUcZVVNgfjxmTr7Q3BcYs?= =?us-ascii?Q?1z0hZnt1mzS01gS+lUPUBKpxLM6L9MU9ykpAryb1khlBgXYN9TzpHsd1ZIqu?= =?us-ascii?Q?sncM50uMnqVxmNWdyMZiSODo9tqYcTCt073hqSQRRDPQIcmSUbyWBRigjr20?= =?us-ascii?Q?BA5KJQLgRFuCwgFGKkjWKceMRVDXSQrYThz5zgqB0ZMHLnzedtl4HcK11t0H?= =?us-ascii?Q?6xk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ay6yIVb4B4p4k+DCkcx70d7GRL0S9dpGIk3K18+a7dYrj1dVTbNaKGLSFuUu?= =?us-ascii?Q?S6yBLcKH/y3brzFa4eo7jbBB8R9Ho2WQkpHxl/UxBS0BsQ21BXjE+30nq+KW?= =?us-ascii?Q?80A3myc00k73nzd+fye3o/apkNFqIarRcKxTWUOJzuyk3su7f684nCdRvCLd?= =?us-ascii?Q?7UcGnxEJyz0RL5UvgBbNiflZzbvNxs4uru5qgX5zzdrHxgWNcRrIFBCAxuhZ?= =?us-ascii?Q?gwc3IWVdX1YGllEl0x0xs9ENIHZdP/nWdK/jQS1UTDeSOim5ZFYhS6fHnuBU?= =?us-ascii?Q?b+EswDYTjRHAk1WY7WlJXqt84nIhmRVBtK7aio2tIZ1zfwy6E13Ipgr15HWY?= =?us-ascii?Q?Df792bv5eybGNwg2dLd2N5HViYSvAyWAf4u+3OZCuEkaXUyoqLKBfweuPyaD?= =?us-ascii?Q?TBAR4WjIb2oaKcqdDVlyGJCXV39yHS8qkLhj6PDuOW/j2A38ltuxGpKVeJCv?= =?us-ascii?Q?npeuHr34yrIBEKxuxUG5vfuXevuJjk7A6NGR8yWDk2JmKVnfltJiwXg4SuTv?= =?us-ascii?Q?NFnakU264ptr5pV2S9xf0xzxzLluGqAXkrHusSffal/lb/vkCKovZ+ADPs8+?= =?us-ascii?Q?eAcom6n15m+8krnY/aeDdFVc3O9t/mgZ/8GF7wH5fH3fP5ZG6XikWTb8ho2P?= =?us-ascii?Q?DLuEuiWgp6ejyszuwBzxRHbphpxKbZsx/AQ0Pa2OaDgSmc3CLJ8git4RxPxY?= =?us-ascii?Q?vxfzwmHpRc26I9p7NFOPp+jaTQ6pKqEEX0pwQPOkfm3zzY2g0hYpMNYWVQZ8?= =?us-ascii?Q?tmng+VSdVIqG/dlkvNjn1B3DmRbVj+RsYMbGyIiEszqhOqpjO4+7aMZgD3nO?= =?us-ascii?Q?fcBSo1s0yBy31LVXdRbmq8rc8HQmXTUSwm4QCnqAbau/08C05cnO8oO39z5s?= =?us-ascii?Q?G5ivgbp5d+Tnt5EozrsntiU40edH6i7nIU2QiU5NXS+SuKB9xD7unH6cg2aG?= =?us-ascii?Q?fGHvDJiO26lObXhl2DxBPbz8Xl1r4nHlYAq8WS6Y2prZAbBO0vXhXaSPn08B?= =?us-ascii?Q?RQtYRJGJEUz5VU1610OxRtVJlfdYWcjNboi5hb7itYc/PGA0BvozZNK5T/AJ?= =?us-ascii?Q?Mnmb8vyqhUyz32v29//sJswlSKR4k3VRR4/h7Bgd1Bu1itjrZcxIykRyZg4L?= =?us-ascii?Q?HW5hirFAdPs/8qgk7mFCBpfLePPQ1z1lS4JJjeBq4b12BToU0mlPd4lgnKD/?= =?us-ascii?Q?ZxKqBK/+B7b9woHstzHkL5QVte4KrVycBsGtFKxwMKs7ro48BccQ6fL7OOIv?= =?us-ascii?Q?mYyviLamuCjlICp4q9W4oaPEeVFFm13fU16SaYj8Zt9b7IOH6EJxrXdpTZIl?= =?us-ascii?Q?Zh0Q3KYjo1xLaroi1HNQMexNTYYfgWA7pA5GTFCtWEtFjQQsBUiBrnaoIZ+Q?= =?us-ascii?Q?BbNbJqPirDsdKxqqL7U3s3sL2T1dDjZCgkgNWIqtlovFpRuYovcN4Rcu7PeA?= =?us-ascii?Q?CcQN2NxUJpkg0s59OvRskogty75nBqKBKnhEYdMhgZ04ACPTM1dss3V5e29u?= =?us-ascii?Q?uWoAYu2a5OzUVUs0VloLygEYwax/jx5MxoO1i9b9iWPKR1/QfeEL95jVNgEb?= =?us-ascii?Q?ttrIrG1gnDpHteFas0C/sBaS+DzDdBeJBIYWzUcG?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /n4nH0SoY8a/oUCrUL2lSSXlJEpv8M7Se8vNa6izZwqBgcH7jRiOvJZVMphcXaKXSN9hsYWYqBzlqepG97EJWPQJGcGzFlR/kYy8Ei5Mv+nTiGg9ZSh5kGkiPnnT57ovjWe6ZS/IvEGbLV3/oYdybWOmgMg9Rjk7epmAJTrb0C0nJoWbJ3vv/Wxoc1w9ReyN/nBV5qnEfS0WMerXDqPsTRlfbvnzM7SJWLmufALkWMBoTeKEzXKOZ+duGSVkisJDegJN19hodTCwWgZY3do7p99O8SVa/knWRtdhg6cqfx6F+iWLhMS/upZyOcVD2MQ8HQmrVmYUF4lVYwOQ5kKifrf4rwJCxsZz4edXE3THtdlftCnisGgQvfjhmrydS+RvwI0xcWvm2IzVGlFc77s0tTYowR28kkZKddg/p+XZqd9GYZDYHf4hwW8P2ANXfJsET+pYYYHtq5VfaD6O1iqrlImQkdd/2kMynvoLT4aqdyMFunFHc6pBDviWAqa6s6K55jM0sJjeTp+E9JP6xN5zTOpe1C4PfEMTZHmlN8uiFm0aUALCZ97VtgwVopsa/wyJHWDj4dTxbUnTKKPxtIVJGFEvaV9Z4TxmfiQJhJ64t3I= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa5b14c-aef3-4a9d-b91b-08dcef9ebd5c X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 18:00:24.2565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WxWJztskZE2jJSdvHBM5dr+TcPyyXPlq1urF7thIIVq4D3KoOKVA0ptm9BMn1orefAX8bDBG70YhObGf0Alu4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7296 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-18_13,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410180114 X-Proofpoint-GUID: tBLdCkpNluL8KND_UO7uTC7rCswbl8uB X-Proofpoint-ORIG-GUID: tBLdCkpNluL8KND_UO7uTC7rCswbl8uB X-Stat-Signature: 9idebgtuy4cqbj731bj16zw9hzzy669t X-Rspamd-Queue-Id: 05073180012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729274422-711253 X-HE-Meta: U2FsdGVkX18GXSHrmcMrmN+vhA6VnpsVB3uRr2AYUR6LZXWKfT8mxO+VuZtr3t+HRRjg22J7mysT4aCN/njIRcVSRWe3951lYDY22Ux1Ca6yPKUdLo//hJTSD3HUUdd/s/h7xM39Q1ZbWXkBkVNCIsjIQaLujyYNWcImvw7q1VivyuTSZaYijvuxC7nTUy5kDyduTQjCb6l6/qyyQ4XWmEfR6xFJuORGJ28hjU95PGAhC3noTHnMUuzZDr5wPBxjtFJn6aiCCgByrPprANvFXhKIU6j5Ob2i7H/8BuIA3PpnlGlSSeRU6Qz5vnuaPMUov/jkP/9PjkWhiVdg5HCOZcDUBdVcQkmYRB/pUlZpdtm4JYZY1mw+5b1E5ANnJm/WrVFh7cC0AGwHDy6n+2m2I6Wi7lYqqV6E4Aok1azpw9NTq+OGn6UvyTs0iOUoyceAi9v9fjrgB4KFDgNe6wOFZhXRcaF5d9/uLLPyyc4SO68gnbiJH2xpq9D1vCzBVcqFCssldrgFj0Y5Z9b/5SrM7poRkJnn20Gk565dfooaGY4sv4AW7pWORhvqZaN5/B0ytcPbSMAGWUWGJw5b8qgsTusfjJCR32ily5A3W1O3RtA7kDpb1zx+HjXH0yzRP9QZqpUjM0J4qY2QbIxW8DCqkoIeEPzsVkCLuB51XlppEDX8UDTldV4wh4sAccaIvd0MeGBitDvqsLjcIwO1JoGOO2YTXS9lSo5RMm11oRtQpCc65rxJ6gxJ3BAuSH6b3/lxsBgJz0U0NQnHTABZ3xofY0omhpFKHW+X1bsmSHAe67jbkGxC2lrVEp5BrxBvdoDEsbx7MKY9zm1o2COAmlgSZNQDwSmHzW+0jrnEhtOgrN2TDJpbeHKaOgPi7OJ3SRgVAhHLfuSSfjsl9xrneiyRrg11SwDkJKjSFGbx5I9m/qcJ3U2Bts47eXdQI0nAHSxqgiaZm4XVrBoe3zLVYKA Y8GvEMfj wwMy60H0rqDcgKZbkgtJjMs9szVq0JGA+VBaaR5yHXCyXWS1aIo0JyfR766WFJ69fu2R551l5X88MfUbZ/C3sQWpyeet2mykuSyziEPLsFCt08eP4oL0ylDmwbH80K+PYRl7xHf8w8jNbo5Sq5v8FGcc99Xyer/j1gASnx8r0GnfwuaJeeEA3k5lqHgKlU0luAZILBwaSsa5zq+qWbig7SNksH3JuePs/B7F9uPLJgOlnnXRcdG2PxBUWRmcR2zEblUZnsnjcF/zyiEE+avpWB4dqQ0h3pBbWEQ6T6Cy/2myVaq/4uEPkbG7wNUEQhhdgZPTBm2am5BQHLBVoCnDuDU6JalqUK3FmPOqrfqEdauAr32lugw5CyocSb8N/x+92nohNWHqJ2CGnTWu8O1e3pJsG5o3KkVJBmSPFBTzjfRZh/+n+okc4XheE1PEaIPkjkljZWKPhpE9CQwAOBFFsGpjlH6Ts46mvcX57y72x+aXecyKs3aM94kOKoz8cH95b7HkjFP8uI2TUctb4XDJQRTF1pfP6cNTKBWYprPRolEOcro9syXndld1svJgjxVEGe7m8wqbs2PD2so8ldBc+LBJIzAL3k13kp166zBZ1vUA2cq4lnRzZ1RUOujdRjDq4yc+J3jAckNdLJeiHM4C9BsbZbHrSYaH39cmhbIJy3NDmwRY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Liam R. Howlett [241018 13:57]: > * Wei Yang [241017 22:40]: > > Currently, when storing NULL on mas_store_root(), the behavior could be > > improved. > > > > For example possible cases are: > > > > * store NULL at any range result a new node > > * store NULL at range [m, n] where m > 0 to a single entry tree result > > a new node with range [m, n] set to NULL > > * store NULL at range [m, n] where m > 0 to an empty tree result > > consecutive NULL slot > > > > This patch tries to improve in: > > > > * memory efficient by setting to empty tree instead of using a node > > > * remove the possibility of consecutive NULL slot which will prohibit > > extended null in later operation > > I don't understand this. Do we actually store consecutive NULLs now? > > This is a very odd change log for fixing an optimisation. Maybe start > by explaining how we end up with a node with a single value now, then > state how this code changes that? > > > > > Signed-off-by: Wei Yang > > CC: Liam R. Howlett > > CC: Sidhartha Kumar > > CC: Lorenzo Stoakes > > > > --- > > v3: move change into mas_store_root() > > --- > > lib/maple_tree.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > > index db8b89487c98..03fbee9880eb 100644 > > --- a/lib/maple_tree.c > > +++ b/lib/maple_tree.c > > @@ -3439,7 +3439,11 @@ static inline void mas_root_expand(struct ma_state *mas, void *entry) > > > > static inline void mas_store_root(struct ma_state *mas, void *entry) > > { > > - if (likely((mas->last != 0) || (mas->index != 0))) > > + if (!entry) { > > + void *contents = mas_root_locked(mas); > > + > > + if (!mas->index && contents) > > + rcu_assign_pointer(mas->tree->ma_root, NULL); > > You are changing what used to handle any range that wasn't 0 to handle > storing NULL. > > This seems really broken. > > > + } else if (likely((mas->last != 0) || (mas->index != 0))) > > Isn't this exactly what you have above in the if statement? Oh, I see. It's the same as the line you deleted above. > > > mas_root_expand(mas, entry); > > else if (((unsigned long) (entry) & 3) == 2) > > mas_root_expand(mas, entry); > > -- > > 2.34.1 > >