From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9536FC6FA82 for ; Mon, 26 Sep 2022 03:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 851E5900003; Sun, 25 Sep 2022 23:16:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DAE7900002; Sun, 25 Sep 2022 23:16:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 653CD900003; Sun, 25 Sep 2022 23:16:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4EE04900002 for ; Sun, 25 Sep 2022 23:16:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 157CD1403ED for ; Mon, 26 Sep 2022 03:16:49 +0000 (UTC) X-FDA: 79952774538.10.861415C Received: from out203-205-221-153.mail.qq.com (out203-205-221-153.mail.qq.com [203.205.221.153]) by imf15.hostedemail.com (Postfix) with ESMTP id 6C6CFA0004 for ; Mon, 26 Sep 2022 03:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1664162200; bh=j9SSpreHKvKfroYfmbuT3oTsBVOFOzVT/lwKwVPfe1A=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=D7AWuTw3lR4m+A7mpzpqfjoU3dX7aFaJQMOiyRL06CrBI+x9c7t8tvsg51sFULcqG RmusVNbVjYHIMtLdc5JAsBS2EmChYGJvV/Xgi2/sBstTk8yvf380zGW9Fyp+4hEaLy Zi2FTW//Cah2Vrcb4izdwi4vg/AggYsncF9+27rU= Received: from helloworld ([59.172.176.225]) by newxmesmtplogicsvrsza30.qq.com (NewEsmtp) with SMTP id 4252604B; Mon, 26 Sep 2022 11:16:37 +0800 X-QQ-mid: xmsmtpt1664162197tr12jpg81 Message-ID: X-QQ-XMAILINFO: NkHKfw09D6j8lZX/8QmW4y6DiQoTbz6jyRTCWGspqq1eTU6oBJ0g/l+wrNdPSW zTk/a7+RVEfKdGMdSnyXtkfffONBr/XwTQ3F/FKxCa4osVR6GCSkBbi5KS/YVcCR2WarQ0YeLn1L mCHoTrVch/yEq58jTgwUmPEsmBe+GMMVMdNfQgV1RcKkuLfhypMwAe/CDqmWMCD2GQ4gXbRNAQ2g D3glvW+Ne/Swyi0WXlSN/KNSQvuxuxx73u46q+yrzPXncIJUEbMZFDs4B3elPTyzp+UC67oftV2D PJoiHsCfcmlLqNZX+2zT9FJ++6lIIBnNZ0pPcCQ1eYjpvRVTWSUAv7I5tA6Iev0gMM/I9aYB23Dm C3DzLMFRnmdmiuUl8tbtz1crDZr56jX1po85ISKLkQtExqt4bXoHxEivcOqolQsjAoxfPy0b2oV+ TOjC7E62NduH2JKJyLTO7VKJokEjaK3UTiiQ3qgPXErvU71HgU6NgJbLqgR2EuCU7PhRkXhaUvUV MS1DoTGbIUOjOaUYrfy6SEb+hS48VjzztmLA1x+kCJeo8ppkTTFaaRNgfWBvU8uTe5bviq8x4QYr wruMeUARxxQEmRnZ6I0CiLWwgwawYBonzUCZoTxqJiUFRk6NTt1q1P/P+Rz/1Rh0xg0EH6f/M4C/ txwnEASMy5UpAe0X/+0dyZ6d/o/pOT756Cr4vLAZQMk+9fZID6t8WrLkb4MU+3k+QHVp25gOjTZ4 sOg+maUf1BrORWeWk89yJfFffpdLhmasPHiI7wJjAZ/QRFujbuuKx/jlSuQbTQZBTIa/mjCGFScu SkMFMYvBbonak8QWRSWUAr8r1JeNJXBBHuXNUQa37HGmipHMG9eCCKwLaqZi4VZz79QW/Com9tfZ ukCRrZ+MBPCVDPcx2nxcKbIuQacpBy5J208J917/+XGZB7O0F1+/siyyM2t0aWqlAge+IcQE4L1e W+PLen60CB9ba+HDcNALpxks/RQ2CLFJZAk6g/l1dJ4U6RyEuEm8q4A+2583i8 From: To: Cc: , , , , , , , , References: In-Reply-To: Subject: Re: [PATCH] lib/test_meminit: add checks for the allocation functions Date: Mon, 26 Sep 2022 11:16:37 +0800 X-OQ-MSGID: <000301d8d156$648e0010$2daa0030$@foxmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJ0HYwArhWftIfEaS2bvHNj7adm+ay6bDcw Content-Language: zh-cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664162207; a=rsa-sha256; cv=none; b=VzzlLqkEJJHb8Mv1JXXy+lYrzRes4ZJHwZbwWTtXVxKakK/Y0ktydLmlr6ObrThSHa/3Zt 4G+MkALtmjO0Kx2Kc8z3UXem+TVnVGp8xcD1DWw8M5IAmrL+RmAxGkP07PzRi9dNSxIiJ/ sOOHT4/WO0RP4eSxb1Nu3U8WMAx5YPI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=D7AWuTw3; dmarc=pass (policy=none) header.from=foxmail.com; spf=pass (imf15.hostedemail.com: domain of xkernel.wang@foxmail.com designates 203.205.221.153 as permitted sender) smtp.mailfrom=xkernel.wang@foxmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664162207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j9SSpreHKvKfroYfmbuT3oTsBVOFOzVT/lwKwVPfe1A=; b=VG0kNOXfszG2rWOdDuWkKiw2KHJo8Ag5jMh6Jw9emOtFQDR7l1o5atd7e3dOyBTvmp//fp kNc8p2GtpVVeBWU8mMdas9BMhXnBzdWoMOQFg4SNpScmvlui5MM9zVKyIvw1NqssvVPLAy ImAkTWxq1G/Ac8MLCt2mGkCvgWChpEo= X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 6C6CFA0004 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=D7AWuTw3; dmarc=pass (policy=none) header.from=foxmail.com; spf=pass (imf15.hostedemail.com: domain of xkernel.wang@foxmail.com designates 203.205.221.153 as permitted sender) smtp.mailfrom=xkernel.wang@foxmail.com X-Stat-Signature: siubkb5mrcx1qw4ixwbg5momuowr4a47 X-HE-Tag: 1664162206-242735 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, This patch seems to have been forgotten. Regards, Xiaoke Wang On Friday, March 4, 2022 5:12 PM, wrote: > From: Xiaoke Wang >=20 > alloc_pages(), kmalloc() and vmalloc() are all memory allocation > functions which can return NULL when some internal memory failures > happen. So it is better to check the return of them to catch the = failure > in time for better test them. >=20 > Signed-off-by: Xiaoke Wang > --- > lib/test_meminit.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/lib/test_meminit.c b/lib/test_meminit.c > index e4f706a..2f4c4bc 100644 > --- a/lib/test_meminit.c > +++ b/lib/test_meminit.c > @@ -67,17 +67,24 @@ static int __init do_alloc_pages_order(int order, = int > *total_failures) > size_t size =3D PAGE_SIZE << order; >=20 > page =3D alloc_pages(GFP_KERNEL, order); > + if (!page) > + goto err; > buf =3D page_address(page); > fill_with_garbage(buf, size); > __free_pages(page, order); >=20 > page =3D alloc_pages(GFP_KERNEL, order); > + if (!page) > + goto err; > buf =3D page_address(page); > if (count_nonzero_bytes(buf, size)) > (*total_failures)++; > fill_with_garbage(buf, size); > __free_pages(page, order); > return 1; > +err: > + (*total_failures)++; > + return 1; > } >=20 > /* Test the page allocator by calling alloc_pages with different = orders. */ > @@ -100,15 +107,22 @@ static int __init do_kmalloc_size(size_t size, = int > *total_failures) > void *buf; >=20 > buf =3D kmalloc(size, GFP_KERNEL); > + if (!buf) > + goto err; > fill_with_garbage(buf, size); > kfree(buf); >=20 > buf =3D kmalloc(size, GFP_KERNEL); > + if (!buf) > + goto err; > if (count_nonzero_bytes(buf, size)) > (*total_failures)++; > fill_with_garbage(buf, size); > kfree(buf); > return 1; > +err: > + (*total_failures)++; > + return 1; > } >=20 > /* Test vmalloc() with given parameters. */ > @@ -117,15 +131,22 @@ static int __init do_vmalloc_size(size_t size, = int > *total_failures) > void *buf; >=20 > buf =3D vmalloc(size); > + if (!buf) > + goto err; > fill_with_garbage(buf, size); > vfree(buf); >=20 > buf =3D vmalloc(size); > + if (!buf) > + goto err; > if (count_nonzero_bytes(buf, size)) > (*total_failures)++; > fill_with_garbage(buf, size); > vfree(buf); > return 1; > +err: > + (*total_failures)++; > + return 1; > } >=20 > /* Test kmalloc()/vmalloc() by allocating objects of different sizes. = */ > --