From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C34EE7FF4 for ; Sun, 10 Sep 2023 03:49:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48EEA6B0137; Sat, 9 Sep 2023 23:49:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43F3A6B0138; Sat, 9 Sep 2023 23:49:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 306646B0139; Sat, 9 Sep 2023 23:49:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FA366B0137 for ; Sat, 9 Sep 2023 23:49:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E8012140803 for ; Sun, 10 Sep 2023 03:49:43 +0000 (UTC) X-FDA: 81219308646.09.500A008 Received: from out162-62-57-210.mail.qq.com (out162-62-57-210.mail.qq.com [162.62.57.210]) by imf18.hostedemail.com (Postfix) with ESMTP id 09FA21C0010 for ; Sun, 10 Sep 2023 03:49:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b="wtzZH6/W"; dmarc=pass (policy=quarantine) header.from=qq.com; spf=pass (imf18.hostedemail.com: domain of nh26223@qq.com designates 162.62.57.210 as permitted sender) smtp.mailfrom=nh26223@qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694317781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xgicoi/HAq3etbBSNEXOfoRea+2i4MIAaKNJZNMD584=; b=Gc7/K4KDnrjkDiV+5peIBQrCSVyzHzm51OL2wmHQQ2QugJ1GJYkTzuUqk+kgKIvNZEvfa3 q+fRSmjZrdBDd5THncDBcJuIgv6k+I9lSPNishHFOG72FOw67vlpPBOBOmh9zGtijYdHz6 kfdt+26kpdBbSL2eflhHbvcJnfNeV+8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b="wtzZH6/W"; dmarc=pass (policy=quarantine) header.from=qq.com; spf=pass (imf18.hostedemail.com: domain of nh26223@qq.com designates 162.62.57.210 as permitted sender) smtp.mailfrom=nh26223@qq.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694317781; a=rsa-sha256; cv=none; b=j853Wj1hDiy24H/rzD35F/afVbJmOPVuG/s6mdrPwgHsz7QLOnvjgERaCGgXsH0bozmB3g eZR6npSSPmrh70hZE05SYBG57hf0UpKsDG01gi5UWxTtyE6LThq56HpYXC7rE7WqSAQLjq EzIlSHaNtlVIFrvfx6EnXmHRSF6XzIo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1694317457; bh=Xgicoi/HAq3etbBSNEXOfoRea+2i4MIAaKNJZNMD584=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=wtzZH6/Wbf+9+TyOHCKz9RytwFMWBjD3IOhPwScL1rvpR3yLtBhBEIjltV6DL6pVe dsjSl1mUT/9hDn3d5JJVP/xqE4XxtA9xV/jNaR7LB16z/Swf/ejesjZWYQJF5L0W0y ZYl1XicuAY/VomQTksT4Zapo6w1upVk+7vRxJpRw= Received: from fyin-debian ([114.84.147.222]) by newxmesmtplogicsvrszb1-0.qq.com (NewEsmtp) with SMTP id AE028217; Sun, 10 Sep 2023 11:43:32 +0800 X-QQ-mid: xmsmtpt1694317412tazlrqlm4 Message-ID: X-QQ-XMAILINFO: NDgMZBR9sMmaCzYfCGXnbxUIVLNM4lxmxUGjqUizgeCBJwIwqhygZyYCHlEkLS ARZssUyjm8N5HoqzdI/cROPKOZ05OiEM07f8mzqghageSQRRMxsetf1dzL99HW1tHrNsIn53ChrA /FBqpcrp1AYDGiIU0wvn8lOFY0QBPDvx6igonmxOVz7+gwyr9H5qjouWyWnbDChdb0ovZr3xc14o OKkeXtIDOBFrW1s7Ii9oNJeCPxWBPTwLUmkNtdKGe0FJapWh/DYe68PNyQEubqcsBD1X3uIs9IHX UWXKp0K9QfU9tJ46ovCUDmx190zdKYtChrz4kC8gv3+hOdiPvj2sJ9EYguiuUMAmmgKI2Nd5kJSj rLmtl+iNIeoB516b2gJfTG6mI6wTG6crocfXgFwkQLCvE1k/yPhITAat1GzOnr77mAjV6dLNbF/J EY3COOrgJpJ/j1m3OzAv3vnLLb84C6Te2CT0QXwhBBpSi5FyhqUu7NlwknmoVij78G0ArYFnSnL3 vSkZb4269F4bAyrAcDS9Ya8IXYHD35swE8psQ2t7RcaFCy9aHtm9L/Pro8kNrCqlvz9lbLg5bF5s zdXFTXzDoX/JuHTyoOJlid3jpdAo5V8MANGeHjuDHhkBEqDR5onGIpr5jgFP1Xqv9Wpp6lHVt/l3 dg2F4lcdvlGceDf1tQWJaqHQjsbNdHlzlWzFq2wYDJ5+WstF5zojf/gxO6kJ12VWtBjHRGTYDXNm /JuA9bWiOO5cyeZJLi5QhhpqjACSKlQv05RyI/k8Ejqcpqsv+YvhRoMwwmV2/Kk5uAU3XLp6CWeL t3gSt1/qxgPVLV4VOYy58RNKl0ufyO2mQgS+3+MIUbtqCjkZtjwLINKhszA3qYRtDNmpXIUeQeug ZD06/7yBBQS/hYkoixujCtjSvTtTgwRNSMQrFzOlazjoL3c9zVYg12CyEVNJ3QttGmqik34578bI 7IuZOrcGoz4w8gzGQLcA== X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= Date: Sun, 10 Sep 2023 11:40:13 +0800 From: "Yin, Fengwei" To: Matthew Wilcox Cc: syzbot , akpm@linux-foundation.org, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] BUG: Bad page map (7) X-OQ-MSGID: References: <000000000000d099fa0604f03351@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 09FA21C0010 X-Stat-Signature: nmhx8uf8usggq1qepcmfxnxtwp6qxsam X-Rspam-User: X-HE-Tag: 1694317778-583168 X-HE-Meta: U2FsdGVkX1+67pdksPXy5Ca/jthU1zVt9rGezORRMUbqheAUXyTxA/1/NntRHIotgzzd2rwSdMuiP4KBy2X42xzdgf2VsSXnKkdw9BS1VjXrtYiRbgeh57lMRYuTHBM1fTaDGKxbxWk5hBU7F24vxmIVZnMyc8saE3iP0oPt4IHm5EFc9NP46wEsASDloOqzAN1jvlVuUX3dYRJCyvOnwZTozVDVvvhvelg5N8q2PcYHwAHDRzidIiX2/AJjbKz0DnJDY0y427mGyexTeAL6IplIRnw3Sqc1+wJqKggSLhrtIetfB2XNPo+0yV8LpP/eTc7gh3dfxoUGWUKtlNGmINlENQdrT19WRq1i/dvO8mNTxTsTLuZZZ/DI1NOmGFitymE5/7Db3qdvrfGfNrlOSZipK/dLoE6TifDd05Ynk8t6R8kEjbLKaJ5B5y5i0s6fme/V0wcCgMvCv+WyGfyGum47XEjWfZPp58JAGL87R4EoEbqF0gjw9a9a7j/0Wgad1JI7LIC3rS9DhTT9bBcMlshiMF0/AYFVmYoV6dhHdK7DFFQPiHcYcmTlnHUHcBpbLtFsLOtf2JGAzbstlI+vUEMhZuYMtom7lAsevIw9Oawv7Cr1Zs2O6FE69uBxBXiJ+7id+ycSgSpRGakdwg3ZGK85+qwXHxiudrsTT5nozv7i6AQe2x54rYKd0sTseYDVXYImYAJ14tXHfWjf8TQGgA6AWR5f2VDIjNzu5B2zJgOx6PnfoTinnf2dmbMe96Ao8VkGY91npacicFgTL8h25I0L6YuAmngm8tmyXVGrxY0pX2Ws3MaAU2HQNgjyCU4YZ3BZZ49XtFIpbnU6paICmDZ2AZfP2FYAmtvKlYHCpTpEuR0K2paAUeRwN7/zptZEpOsJcSBp92MgqF7etDk/qwW6PboPTHxKQENLBfWT0MRu7q7/zNT3Ce00XcO08dRzYZeMD7Sf1ZYdjgqAhCb hT1a3gvk 8nhb6qSn4pdaojnfW6f8QqrEYK5fGV8YFXX78oDUB4H2Bioedxx0ZoyfqDjXb2uv3PVoj4wSrGcQ4jlclH0zMJaGdcuUf7Q40KD7VauJyRvEZWuyOh19WfpHSzi0kRktQKTQs/kXL+N0mpHgyYVfJG8roTeqYMnofPw6mxKMBOqtaNKdEqlhcC8RkqI6XT9dSRXL3mJCnrkhvXCxS1HZmlGMCG0JysQjTTVSk0Gdp6wlcGZxjWlse3nThARRTj8uV8Ys4RDy06tlEa6OVHpY6V2i73/Y1RYdd42rc8g5Ui/dMqr28LfyXC+vYm6TLlT6mpHbhX6dyU7zlGXOExl/nLUBlYtlC44DE3liq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On Sun, Sep 10, 2023 at 04:02:32AM +0100, Matthew Wilcox wrote: > On Sat, Sep 09, 2023 at 10:12:48AM -0700, syzbot wrote: > > commit 617c28ecab22d98a3809370eb6cb50fa24b7bfe1 > > Author: Yin Fengwei > > Date: Wed Aug 2 15:14:05 2023 +0000 > > > > filemap: batch PTE mappings > > Hmm ... I don't know if this is the bug, but ... This is Fengwei. Sorry for replying with my private email. I can't access my compony email now. Yes. This is a bug. But I think it just impact the performance. I will look at this regression. Thanks and sorry for the trouble. Regards Yin, Fengwei > > #syz test > > diff --git a/mm/filemap.c b/mm/filemap.c > index 582f5317ff71..580d0b2b1a7c 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3506,7 +3506,7 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, > if (count) { > set_pte_range(vmf, folio, page, count, addr); > folio_ref_add(folio, count); > - if (in_range(vmf->address, addr, count)) > + if (in_range(vmf->address, addr, count * PAGE_SIZE)) > ret = VM_FAULT_NOPAGE; > } > > @@ -3520,7 +3520,7 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, > if (count) { > set_pte_range(vmf, folio, page, count, addr); > folio_ref_add(folio, count); > - if (in_range(vmf->address, addr, count)) > + if (in_range(vmf->address, addr, count * PAGE_SIZE)) > ret = VM_FAULT_NOPAGE; > } > > >