From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B267DC7EE30 for ; Wed, 25 Jun 2025 10:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 565236B00C4; Wed, 25 Jun 2025 06:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53CDC6B00C5; Wed, 25 Jun 2025 06:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47A1D6B00C7; Wed, 25 Jun 2025 06:42:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 39B076B00C4 for ; Wed, 25 Jun 2025 06:42:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DBA65140C22 for ; Wed, 25 Jun 2025 10:42:13 +0000 (UTC) X-FDA: 83593583346.04.33022C5 Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.47]) by imf26.hostedemail.com (Postfix) with ESMTP id 220A4140017 for ; Wed, 25 Jun 2025 10:42:10 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=ENjVIlrv; spf=pass (imf26.hostedemail.com: domain of chentao325@qq.com designates 43.163.128.47 as permitted sender) smtp.mailfrom=chentao325@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750848131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tgd2pHPm2RnMeqq7Vwih1WR3E04pB2uiTC5jxE+M+kQ=; b=U9sBjzfNlLp3akIn4g5Vin7vBDrsuW36gC9zlaIFyU8IqhLTfgXgcF1E04OG9tVOx2PNad lS9Vv9qxPZzc9BkqcXb+mhowWgKxKpvr/euqyLkoA+QAXbSaht/wVNk70fSyX49IEBcu4l SleSfLHUSP0tAn8L78gKvD8zqRhv+2c= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=ENjVIlrv; spf=pass (imf26.hostedemail.com: domain of chentao325@qq.com designates 43.163.128.47 as permitted sender) smtp.mailfrom=chentao325@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750848131; a=rsa-sha256; cv=none; b=j7IpXWh5p8fDoM+tJ1/g3Khi8U32+B9Mbv6M5IH57Hz2OXLLRZVPCOiXpnXCuBpyyESalN YRnoXZ5G7e0o31s9tX1L6ukScBAqBRVCK6iJOUpcJ2BI28hveY49CZr2p6inwF6QbWRa7X j2g6wzaXnukEXu3ilfa2SPzo0w2njgY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1750848122; bh=tgd2pHPm2RnMeqq7Vwih1WR3E04pB2uiTC5jxE+M+kQ=; h=Date:From:Subject:To:Cc:References:In-Reply-To; b=ENjVIlrvb+1/gWrcpDTNv//OOWumnVuOLMf+ReAIaWNxNRfgYtD9tW3VBw8ZhyO0V VaELgIy/bi2pv6GRaPMbFX24BBO9oSm5OFaqhC3yJu1Qxg+tQCHziiOqp0Q/Q32YX2 lxuU3MifyggzOye4pmy54H2Sd2Ckk+lj7l3CZiW4= Received: from [172.25.20.158] ([111.202.154.66]) by newxmesmtplogicsvrszgpuc5-0.qq.com (NewEsmtp) with SMTP id A7A2CCF1; Wed, 25 Jun 2025 18:41:58 +0800 X-QQ-mid: xmsmtpt1750848118tykbxfohr Message-ID: X-QQ-XMAILINFO: N2/jAoEINgTTVmeFMsiQejiordXzU686AwuiVeg+WQ4hfHy1G68V9KJ6U8soDk FjqFfgCWPLze8PgyLk7XU3TyBnoQfb/6XHBeUMmHQrBEmBgnDoi3RLdIL7DFy1Tbc73yQn54bT9d e8FPcpQMT9NBuMMSNx8DJ/c2ds9Ja9LgEiomZK+KbGDaSgYXcZwkCDF6fI3zu0XkWRiU7oyPz1b4 s1+99sUHA4eDOQpG0p32kSjphMvpHz6fsEm17ecmsTkj5r2l5sIYZ5/GrJYVK6nlRRfGw1V4palu BKxljpr2g3ZkATbXVN6Lsq92oxwdWEyRNI043fQtWEk0N9eXhdsRX1xz8T7c6IoWd1m06XwwIz3B hzNhUAy/jwdqsIdYaVvkekGTlZRK/EEUWBL1Chvck7J8MPv2iQ92tNfRoC72L+0kkkbdo6Cn4NyO jsA6SdPiD4STfr+cAUcUD6hDZSMkasYyQpGswLVN0Cpy3f3AlFWhlj+FEWWjmXAeULfxW3J+lpCQ v9ssZMsa8xz+JaI46jlkFCYR/vwCC9b/fx/FcX3bSHOEdKqzxCSe8oZQ0hvXrPsa/bxxLsb9h/E5 ap+HjwZX3us+AfQIDtSNaps7EJLOXF/eOBJFsoVV58OX7Ay4Pj1UAtNaWefhruNwV8MJgqjKyQLv fv0rst6CtxHchFxqL5yfSwW7bHY1W/B3jixOXQx0JTRjZHQjRIEXus7+pS5a1TB4qZOrDJe3Atzp lK2qjRb0O27krp6uyzhBMCt71AHe0Y99+fT8jxrKe6aMgYUpSWgX4bCMJFbUZFqoUMA9NOPuDYgV JNYVsqTtnrhHE5C7zy92bEFT9guuboAFnk2cldlPo2tVG/diO3McJd8V0dboAwpu+NpMbb0wiR/v 4lPYdscRlzPfyanf4I7w0nZ+gGbB0mxnWt0yOuTAr9auSf4qV1jB4EEsvxO/ym9FjO32VllWG2+t KnTXNqOhT0D1Oj+2/IPYgB3xm/FKr2JjU/7Vyy3X+Lwlmvd0XTWw== X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= X-OQ-MSGID: Date: Wed, 25 Jun 2025 18:41:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Chentaotao Subject: Re: [PATCH v2 1/5] drm/i915: Use kernel_write() in shmem object create To: Matthew Wilcox , =?UTF-8?B?6ZmI5rab5rabIFRhb3RhbyBDaGVu?= Cc: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20250624121149.2927-1-chentaotao@didiglobal.com> <20250624121149.2927-2-chentaotao@didiglobal.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 220A4140017 X-Stat-Signature: a6wd6gka5g6nb6g8j19og3m7gyr8y71j X-HE-Tag: 1750848130-851815 X-HE-Meta: U2FsdGVkX1/hqCOkUGLyG+I5JXJ/shuYwOpsLbISx0kEkgpAlRQcJvDI4+AEdhnO33zXVd5PK74ZqLqsp0iuOKkz7KB3CKAkG9yM+vAxOdpLx/3g1/A+4TsOyzulQzvW8gRunGaMvbIkLtcqMQzDqo1//Tzt2ZKdZQyaJHAspqwkP7MTHD94mRnqLD+g2GkJbN5RI9nqFZkBRtPEGlilxy8yho22UhxizhJo1mwoPhRmY8sHXykkwsbpXr7156HoSApZJ6SZDj6tMIDCjgkVG4YXLQYp0Fj07L5rTzy3D83zVmHm9y5aTOUDHbw8IgVRtWvpMIRJ2qTvSaLCCGPc9tSTOi7nL1di9v2hdXYVsH5bANoGFgj+p5XfLU6YiFHNBOQkZ+IDy5U962wcwHjc+uU8CbiwwaPastcfNw4f/LPplhC0LI4nHbSV46YLXViT7P4shZiyovhPDwP8znRl334e8GIr+wYYrB+o7ITvxegXNTSfWnNCm4Gg6cVCzBdCqI3F0VhHBo50M6+Tfl+bpAVupwiulNBSKm2KKl5BGNE9ZrODqjFROctv3lFx1YyDwkS42Sswx3diRqN8nYPDVsQF0Ngr7v79whiZC+dR5noSxUm+W+mIDfkh0jwJj3DijWyL0k8OvQ3CZaRECsEUW7v/J3cdOUujkmEnzV/NDNN0CwwzQdxvhpyCAqh63mlCbgJsCqiM8ohZ1paIJh17kxWCWZSvMak6mXmzK5DiWO0K6mHgoPWATlEUwiouoDaIdRQtV0eXQldnhIsrhRk/eQdr3+u4g2sG9P7JT8eaXxtd233KNGYI6qdCQw7EiDLK1AR1x5tWNvLe2989C2z+ht413Ak1uTeoTQydee1GBmty1rQkSjUP06VIBKvqvK7qhjqhtG+WgX4Gx4Au2pb7jQ45KVB6rIJIHYUqamILP08Pjmr01cve4IyAkn7TaA6Oooq/jYHXl0VODJ67fmX OfbHbAR/ J3a0FAw6z+J4LoFSCnYHLBH1cJtztXu7JCPurlqnMjfoVo0pa67LnBWxhc1lrpesp2jNfwwxOSj/TQRHKe+ORt4L3o/Fr+Q4B8MwJV0lNCvirRtOJM32r1KQbdasPadElE2g9mG3fX9KP1qarrlKqq5uOxbdGjmyry/YSjGte57jlEKy4PKImUmHCFQOVpwyR7X4hVOt8pNklXXwosV+oASMo4STWW2hOepQwivrd7V2oWt9Dn34+2fzypNfvSDwE15aH4aExSecxtSWuhcUnVtwANHClZy79YGvP0LOKqjhvd+5FNWPrnAk5r1fCBiQBj/WhpjZKwF8xA3U7Mkh70AGsEUoTfR6LAY5yJbqvxUVSuRFH4zZFLvWBptxkeeFfgrHEEE/zH83CMSxAJ/oms3XCYAPnXvJKiB+x2GkJOfAhrgDyCHkB/f1IxdZH059CemV5ntNU7bCPr2w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/6/24 20:23, Matthew Wilcox 写道: > On Tue, Jun 24, 2025 at 12:12:04PM +0000, 陈涛涛 Taotao Chen wrote: >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c >> @@ -637,8 +637,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *i915, >> { >> struct drm_i915_gem_object *obj; >> struct file *file; >> - const struct address_space_operations *aops; >> - loff_t pos; >> + loff_t pos = 0; >> int err; > I think 'err' needs to become ssize_t to avoid writes larger than 2GB > from being misinterpreted as errors. Thanks for the great catch! I’ve changed int err; to ssize_t err; as you suggested.