From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66659E77173 for ; Sun, 8 Dec 2024 13:55:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2356B0379; Sun, 8 Dec 2024 08:55:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76A646B037A; Sun, 8 Dec 2024 08:55:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60C156B037B; Sun, 8 Dec 2024 08:55:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 431936B0379 for ; Sun, 8 Dec 2024 08:55:29 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CEEF91606DB for ; Sun, 8 Dec 2024 13:55:28 +0000 (UTC) X-FDA: 82871938548.10.0AE5B11 Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com [203.205.221.240]) by imf22.hostedemail.com (Postfix) with ESMTP id A78B9C0015 for ; Sun, 8 Dec 2024 13:55:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=S6N+gtE3; spf=pass (imf22.hostedemail.com: domain of fujunjie1@qq.com designates 203.205.221.240 as permitted sender) smtp.mailfrom=fujunjie1@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733666113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BZYvJo1qCFozwUl5OiMXNjuTzLKS0lZbicCI5uzJH4Q=; b=ixXEyxh6G1cQvy+2GkeBs/qwtobQujNSMqUs2WDUlNPi3EvMT4k/csuBVTNxHdRTSPU66t +O9P7v0yHW6hKGJ0sBbOCwFCN8o//M955NwMlJgtUx7CuxVPjHOauiBB3npIugUSSyhiEc IdrEbKs8x72HrzCZRrxquU7tekmQ9S4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733666113; a=rsa-sha256; cv=none; b=BllN88oGPTDi/FodYF63/LDlXkh4U/afogqYG80SFSHClX+qAItNgSpWR+ZeNU7oGwUIVa oOkabhoMqySZtEt7w0/N7bMM7PI8Phwe7CB7kP7Dv2jBsTyrKrjDS4kMzLfj5+l0CSYr19 p7o49APuBduPvj2x8cJ+z8nPB2NgdCE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=S6N+gtE3; spf=pass (imf22.hostedemail.com: domain of fujunjie1@qq.com designates 203.205.221.240 as permitted sender) smtp.mailfrom=fujunjie1@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1733665809; bh=BZYvJo1qCFozwUl5OiMXNjuTzLKS0lZbicCI5uzJH4Q=; h=Date:Subject:To:References:From:Cc:In-Reply-To; b=S6N+gtE3rDmWdeugiypaCxaD74gxiEFMvbTagdRP1tPE2PiGiRDiGs2hUH+zV34lO /ancf8WGvGm5IO9P8FGYkicYb+3lZWPkiSrcR95mv4hWRY60Yru88w4Zjh1RuAKF8g hNjV06DVRu83iyLq2Dum4ZtfCWmbnBNQnjbvgGJk= Received: from [IPV6:2409:875e:a030:1001:14::e66] ([2409:875e:a030:1001:14::e66]) by newxmesmtplogicsvrszb20-0.qq.com (NewEsmtp) with SMTP id C8790CAD; Sun, 08 Dec 2024 21:50:07 +0800 X-QQ-mid: xmsmtpt1733665807tjgkympcs Message-ID: X-QQ-XMAILINFO: MB5+LsFw85No6iy5gp/z4MecSTaeEqWcjw/8utYM7xr3RYG95WO4LQR4iS3BYg +DN58pYutgQ5HtBkrPnE2IaXlcmzqjpOdwvWHcdyu0ipuWEd8UJ//ksdAQmyv80hmIoM0/obQROa g6IO1Nlqb2VxkAl777jE+QiTum99++AdS1YjYMw/O+f3u1tHvwoeGhXENKx5ANP0Cgyc8etUaROP XMFbYpV5kYR2aYVFobxU6vjLzopjhhS/yrVI0x1d8mB4JmBqY8U95qIisGwxyGJRFZZq/7ym4+XD qXTqII+6OeeN0VAtyP3gmc6A1OnTfNhiWOv5Q7fLcmdKnohgt+6brQrrNYAt5yRZcdXHdaoLrFtD HltqtxWehKJAIZPEHDt/7EF1hqLaTBiBrGFk6NF0U5OMhuOezWCEeOjwO79LlLK+qR/8CmlMlcAS 47C6KbjJmmAoa+k+NGlq3P+kOXrWJEnk/Xat65qWLuN55BrKH8atbc9r+aX+pKwgDf9+LPn36lbJ tc9wc+hwMlpI326yfMIDN4HcyxiCfxAoVju8KyMUbumiVN5J5sN8ZXnOu5qoBYNbAo/b//LvymsG VWiGNvnb7UpMm4s7Je8wdoZW1k0SYFKlQlQugUC1jq1EldrZcQqHr+VDx8h0Uv2bKa9nlwJ9Dr/M Fa2KWHzD2TA2DYVkajPv2j+/H+rxuL10NeCRuaarktheAJI7roLUcgoa4zFIBjgHww73Mo3xAdy7 HhiQcD2zlEdE/pl97lRhiOK8VCgjhDmk+oM3+YMWXurBRcBRw6QMnt/cOr2HtlUE8jIZqAvEtqyV 0eVprEBg7A7JTV7taTazclBZ39ANZth+dhaEcIGzooRfXmmLXDTbGkt8xVGhp9BMFe3BQSqJ/sZX 6h8zOLdB6MLKnr3+rTC366mgm0OBXpSm6mM0wiYc9NhJ0cM5ZD/tFg6HU3Xypop7ST2yTKPUVDel kGLcKv5qX2CO5eMMK5Fo8OBbb4s59f X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= X-OQ-MSGID: Date: Sun, 8 Dec 2024 21:50:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mempolicy.h: Remove unnecessary header file inclusions To: SeongJae Park References: <20241207195341.279560-1-sj@kernel.org> From: Junjie Fu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, Michal Hocko , akpm@linux-foundation.org, gourry@gourry.net, fujunjie1@qq.com In-Reply-To: <20241207195341.279560-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A78B9C0015 X-Stat-Signature: r7bgew6snjn4ixsbdj4garedkhcjypkr X-Rspam-User: X-HE-Tag: 1733666104-458645 X-HE-Meta: U2FsdGVkX1+j0BbZVm7brtlfhp+a4BsJh6Xgez6HKdZvEzdSuKAkKZqpcZ2W7YLJLKsaIqAfy1m2uIWgHCvnaz8MUVdSYi+amda1hYaeRrcElG8wYK13YvwR8duYk9hvEa5rqT9ng8D0XOm7DEcMlXskkhTt0N1fFkjrY1wdnqYryh6rKJ9fcUsx27ErgCspkj5QFZOLRknnx7JB6RjF1OKx3Mevyf+/wgRD05vg14cn5n7IGIUBUg/CQEmVhLbvVbaomcYeS2Itrb6CmYxLeR0Ygd9G2Jbqb/8fXZo8FELec2jl1eBmECWqtdpeIfydyWfr2lBzaJn7LAdnB5MsvRJjfJgsS+5Qbc2/1FbHzve2aNhW2VkYPCMNy964iKXvWuc/GqNczZBZ388TXhcFX+HEBxRG8YEhb8SS5SeUbENAP2yrvdtmEMg/LDwBLGPZXKdq2XwthNFuup00AuPwWEUM9t6zveZVRDMS+4LAhjBdf3TihKP3gfOZpxCazy0n51LEOhaMY15zXlIa0cfYwtqEcuFqLFXZOs6+moqs/s93wAwKpIWxlDgIoqmTxw4YGvoJZnr8cjRbUSfcUldUg6qRG+HItyJN0WzQTyVaQ2VJHWwA0UNDH8UrxPb2RZ0J2ZRqxs1JZoESJId9PTl18+LNwyY7qMC8jJy74v3qzHXJsgFNCbReL3LQ7ufd69Y6dSHJHHDZKCwaWtnR16hMA4WItY6wFwDaul+HoZit1m3noX7TOqmDsnuVoVjSH1kdtaHj3s48GHXUxDQrh9bb2VlRyOiUyS0olcfzCpCdCREayooLzZSdi+a2sT7wtnGA1v31ebgUpdRtZVFLYDOO2HaBwLoZxW5144koXl7/uTehFsmk5GMISCV8QooadvRxvE8umXAjc8S2/ICm9fl2g0VBq8KJ3YNLch4TJs62Szdpvhtrg10x94XRgcyjG7Own2o+Py5HC+5aPYolPN4 G6GcrB00 hCnn/zmXlipNVGRlBcd//D3LgYD8xCus4c1DfPnITxip3SikVbhpjsjy84WQKj4RAF0rmvQAzIAnKGBRYoxGm6194VNrxNkEKaHpIFLpjcBRFlK6bQvFf2rfZZLggRHd7+t0TTDzQWcc6bkFM4PW85RAFEfFVAkEx28EJ33VNYxbDidPHE+gA6DdE3YNVKsErDWw1aHAqiboZnb2hSG9hAc5itmB9zwxIz6sWDxnsn9b/kTgVMHBK00uNbCsGU2GfU2DopORrR5G78VLvmNh4j/uK37n2zyCX1Rh8zpmg5+TVOjkgTb0F4oNeueV2SbhDhiVD X-Bogosity: Ham, tests=bogofilter, spamicity=0.388217, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On December 8, 2024 at 3:53, SeongJae Park wrote: > I noticed kunit UM build errors as below on mm-unstable, and git bisect points > this patch. > > $ ./tools/testing/kunit/kunit.py run --kunitconfig ./mm/damon/tests/ > [...] > fs/aio.c:525:71: error: ‘FGP_CREAT’ undeclared (first use in this function); did you mean ‘IPC_CREAT’? > 525 | FGP_LOCK | FGP_ACCESSED | FGP_CREAT, > | ^~~~~~~~~ > | IPC_CREAT > fs/aio.c:532:17: error: implicit declaration of function ‘folio_end_read’; did you mean ‘folio_test_head’? [-Werror=implicit-function-declaration] > 532 | folio_end_read(folio, true); > | ^~~~~~~~~~~~~~ > | folio_test_head > [...] > > I also confirmed including pagemap.h on fs/aio.c as below fixes the issue. I > would like to hear you or others opinions though, since I'm not familiar with > the inclusion routes of the file. Including unnecessary header files in a .h file is not a good practice. It can lead to troublesome dependency issues in the future. However, based on the testing on your side, this change might cause some other compilation issues, as indicated in your patch. I think all these issues should be resolvable by including the pagemap.h in the .c files instead.