From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FBBC25B08 for ; Wed, 17 Aug 2022 09:13:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBB9F6B0073; Wed, 17 Aug 2022 05:13:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6B7D6B0074; Wed, 17 Aug 2022 05:13:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C33758D0002; Wed, 17 Aug 2022 05:13:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B40A06B0073 for ; Wed, 17 Aug 2022 05:13:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 89CC01A0192 for ; Wed, 17 Aug 2022 09:13:46 +0000 (UTC) X-FDA: 79808522052.18.39C3B1B Received: from out162-62-57-87.mail.qq.com (out162-62-57-87.mail.qq.com [162.62.57.87]) by imf29.hostedemail.com (Postfix) with ESMTP id 1797F120047 for ; Wed, 17 Aug 2022 09:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1660727621; bh=nh2QU61hpt6/O4Lk5RHrl+cxe7dbuPlQa/H2TfJa/Zc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=LBXTeH09Q4+TSy2pm2XH5dR2t2IF1AJHMJYziBf1qqvyIwH5bhCoT9sJVTpc/Wgmj WUZi16FkwEVh7HpL9R/k9S0Ht2ATOLQuBxass8eAKYHaku7UeDvdPBhE65eMpAeSn4 imqkhDW2K0a1yhHEHwXWXcBI7GWdswVcpi5K1uQY= Received: from [192.55.46.54] ([192.55.46.54]) by newxmesmtplogicsvrsza8.qq.com (NewEsmtp) with SMTP id 3629F04E; Wed, 17 Aug 2022 17:13:34 +0800 X-QQ-mid: xmsmtpt1660727614ta040c16f Message-ID: X-QQ-XMAILINFO: NfU6lHG00mqc24BEan3XrraVF8V6n1BcjXM6RfVuW4uYmFSJPVSqKjLzg0b8u2 rRvunCrUyMdE7Y43KEuLi+S4mz8o5Kra4KMeUFkA1nPk2C/tiHGs5bZrxW5JlelngShSYC2Eg4YB JUImg5CX2ThFU4BWFhKZcVAUB3NPdFARxFkEBZpYBbIMtqzLpTfsQxOPyJi9fIx0tBkw6QubVC1G hJSfTnKQK/OLBiVXCS5u/Uv1hj7+H2yVTDUuvY93kG+mmnwdAXJIgWZ+iMGFDKriV/Z6T17JOelW mQpkk5SA/UtIO2GNln4/Z2fF7CKzOccLRSNOMgL5oGVIaPwuAwAP9+Anli4T2nSMg+eUkoz20yeQ Ck5B+aPwAkm+y73SXECmKyUsmF5ih4LsK2lyaAKu02n3j+UtqY5hkUvhp1MzlFEvKDsC93+xU2Nt XPFK3zvZ86ADk5UWF1ykMbvkN5o2yKXG2PJHoLCxy3tfmnEHLZakl0+9RPo0F0Kq+2vvEAv0IHnl qLnJcisUu++LdMI0qeKT7+mJwaF99j0fN3oXKdnCSKiQDnmTyKJx2v3J3j/OP2xrUZdtb992+G3g 9vqxJm8QO2ECM13hH2yFaIXBg2Kp/xWkrry3n1fLl9DLYr4crbgBZAga0YkInaAeO0mVh+3HzReN iIw28MwgiYNU6NEfjlZRdKfj7iIW4EFXCwvnfEuvF7d/fy68TsJtl8dseqwFUKnlijo8otZ0C3+0 vOAdcQUiZkmFbnCyELqMm4FK8CTDCwJxLpU1mdgA01TAZT32QkY/R9sALTvbMgFq1i+nm228cvDc Nc60fKi/34Bx3Tm1KH+Msb8CQ+QFiq6c23Z48Vvf+weQG7YY2YCuLuPtWzBY4oD+qLeOXukZM1rk PAf94ioWBB/c4ZmI2NxcVQjFbnlAX3e+XUh03CJgkene1RCojQ7XxBMoU/GgWCo7mbvXzh+VTe3N t7GpPYaPDxDdzEcmEbQopMFH7lu8BX X-OQ-MSGID: Date: Wed, 17 Aug 2022 17:13:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.12.0 Subject: Re: [PATCH 4/6] mm: hugetlb_vmemmap: add missing smp_wmb() before set_pte_at() Content-Language: en-US To: Miaohe Lin , Muchun Song Cc: Andrew Morton , Mike Kravetz , Muchun Song , Linux MM , linux-kernel@vger.kernel.org References: <20220816130553.31406-1-linmiaohe@huawei.com> <20220816130553.31406-5-linmiaohe@huawei.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660727626; a=rsa-sha256; cv=none; b=fjPhB3OBN+F4+axi9OwHZynCSvpKmHrZu9tXcJAfElkpN0jTZnWaZQj+deNY22jgPq6C89 FefRhtFHvDJo2BmzbUgB4R2RgP4TMySvXKDVDA4iN6oQCxryoJpdbsA1kJSPvU0NoR0RgW bHF7gyfFIBgX79kkcdv4PUl4Nk2e5ww= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=LBXTeH09; spf=pass (imf29.hostedemail.com: domain of nh26223@qq.com designates 162.62.57.87 as permitted sender) smtp.mailfrom=nh26223@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660727626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nh2QU61hpt6/O4Lk5RHrl+cxe7dbuPlQa/H2TfJa/Zc=; b=FGd/GK9/wrDDDnzM+YUaKl8Vn71OFyoq0U4vb4XXLH/SkFBNkH18JAFKft1+XQAkHZszHY pnd8TmXeLmcIn/XW5d1sS4vt81J9Tn4PWtMhqH1+TT8u3ncyvEdxvlBwKLG3s06mxctJzS O1r+hczCU+6CQtnAGVctnq6PcpjpZYw= Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=LBXTeH09; spf=pass (imf29.hostedemail.com: domain of nh26223@qq.com designates 162.62.57.87 as permitted sender) smtp.mailfrom=nh26223@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: wmpbznrcgscd8jm4mt7qhmzpomsh47tp X-Rspamd-Queue-Id: 1797F120047 X-HE-Tag: 1660727624-188781 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000896, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/17/2022 4:41 PM, Miaohe Lin wrote: > So I think a memory barrier is needed before the set_pte_at() write. Or am I miss something? Yes. I agree with you. The memory barrier should be put between page content change and pte update. The patch looks good to me. Thanks. Regards Yin, Fengwei > > Thanks, > Miaohe Lin