From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD8AC54EBE for ; Tue, 17 Jan 2023 02:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4C196B0073; Mon, 16 Jan 2023 21:01:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FC446B0074; Mon, 16 Jan 2023 21:01:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C4496B0075; Mon, 16 Jan 2023 21:01:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7C1E06B0074 for ; Mon, 16 Jan 2023 21:01:37 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1D3B61207A9 for ; Tue, 17 Jan 2023 02:01:37 +0000 (UTC) X-FDA: 80362639434.08.ABDE1E7 Received: from out203-205-221-242.mail.qq.com (out203-205-221-242.mail.qq.com [203.205.221.242]) by imf01.hostedemail.com (Postfix) with ESMTP id DB9814001D for ; Tue, 17 Jan 2023 02:01:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=FeA1CCXX; spf=pass (imf01.hostedemail.com: domain of rtoax@foxmail.com designates 203.205.221.242 as permitted sender) smtp.mailfrom=rtoax@foxmail.com; dmarc=pass (policy=none) header.from=foxmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673920894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I2vm4MRIsf5pQ5CahD50YQYpP2cLY65PJqtTtgqvRb4=; b=bfFuG0EmQKg8mVqo8ztF2kAnRz0GQqH024hmlZWwHjjOuJgcU6P+15SZwodTk4VZP2IxRs ughIgcqaRaft2HnqA7BQNuuarWLjBvkH7lExpRUSeHKtE+Pphwkwp00DWYF0jxp5BSAEFA oyPgNq0H2XkYkNSYl6OJpxGcrz3iE8o= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=FeA1CCXX; spf=pass (imf01.hostedemail.com: domain of rtoax@foxmail.com designates 203.205.221.242 as permitted sender) smtp.mailfrom=rtoax@foxmail.com; dmarc=pass (policy=none) header.from=foxmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673920894; a=rsa-sha256; cv=none; b=DK1FFYL2RVtvBGeREQYtBThkTF21TzLTudyvcjXdvh8UpHu+ZedlxGsCuj9A4VwyFxv/mT Rx+219NNCUH9EuUwJwnxZRSwBEZINPBr9UiulLZkjjlylarYxv0iV/z+43nFBGiwNfkp3o 98Ap/KAQD9jPFjWo6csM8eteqg0zs2I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1673920887; bh=I2vm4MRIsf5pQ5CahD50YQYpP2cLY65PJqtTtgqvRb4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FeA1CCXXEVI9b6rS5BMxPFNnHYGbpoxlO4aCNGpyfdPOR79/Qo4/6rhrmbs9UBrEx 2vCKQJoaecvAL8H6ln65R25tBXJAL+9FeG81pbnwj0RdL5qfd2/sFctjwt7QJGALc8 bwoitiEUL3aG7n6yjMR+YxeAwRO8//C1qo+azADk= Received: from localhost.localdomain ([39.156.73.13]) by newxmesmtplogicsvrszc1-0.qq.com (NewEsmtp) with SMTP id 5701441; Tue, 17 Jan 2023 10:01:23 +0800 X-QQ-mid: xmsmtpt1673920883t6pllruzu Message-ID: X-QQ-XMAILINFO: M6vtNMKjypDN/Me4jSRtt+E2tDl/QO17ApX8XtBjXWMxfLJJ06crsXIxfrtJho 59p4yckD2w8ggrIrKRQsOWPiyLfA4bt+fSYeGGDYjYQwDUTemT4NaezGViy9U8z+7k160villQtL fIonhjHOdTrfSeZ43LhSQo8mi3IzIOJLkqN3i19ZvS+6sHHwGWzaTT5G68cl940WqDJ8O7Vfvd16 XKvdARe2bWmJSg7XZerwYw5xIJE569At6VZbuGieYI9hEfGWo/HclDJNDSqKNIa7CNw0BIDhj4E+ BnXrw+SGTLg5+0IrVEqQUXMNKRWfonEKgqE+TA6t5JVt3NMtKIr0p0lPZxjx9J4zbSy1KL5vT1cR Egu7kUyDfyV+5NDB6pEokqj4+bnV1EjZdCY49+V8QrNEzKfF6dmUPFXmwrG0gvzruCJJg/SWS1Sm 02Zth8dCDdlo19RMPEM0a97l+5vX4F3g6MlwIRWWfTenJ7tmsgRKUXRPuYETAIzXHHwJ8Ry+50bh kua5I6gEufy3xT5Nyq51A37CG5afx0Loe3XPIlFfpwOIK98S+K4jeFKVEH4THJoLvqXAXwm+blkn IrvM4hPkxqpyR5n4kMcoWpB7TRVdc6dIfNLQcV27jY3xtfnZz1/KKrq0oox7USkgqgfckDj5sMke nV2Wg2GrvkU7kVxSsD4Mld0/lHASrYB1ZKgsVR4N5s8i/Z1WQoIBqwn+RvGV+xb9ddrq8mdjymCj fwjgntkwaNRXDt7lj/Z5k0tDspRKUfRHDCeFKKtEaIK5VpGoqrQcDU9HlvXfJHlE7QSGSxvtcwOC 3Mfr2nvq4JAJzfRg2nesGR93Yq8Zg9PVTUjBvQ7A+oj7OjXBOIRKTu10IcZPYbcC/g5Zv90m+aBE BOWnVqmvAAB7J/B+7KN7ftuCdR/9WAcNa3zwGhA+0uGj0+mrJGMdCVKaskgDgsUPoGB939UYxOzP rjFDsda41PGV7hqyx+pr5IhuacOubBasFck2GCQ3X7fbTbrxYR+g== From: Rong Tao To: 42.hyeyoo@gmail.com Cc: akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, rongtao@cestc.cn, rtoax@foxmail.com, sdf@google.com, vbabka@suse.cz, yhs@fb.com Subject: Re: [PATCH] mm: Functions used internally should not be put into Date: Tue, 17 Jan 2023 10:01:21 +0800 X-OQ-MSGID: <20230117020121.45230-1-rtoax@foxmail.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: cw34x1kyw1ttr6qzxchyfqqns7fz19c3 X-Rspam-User: X-Rspamd-Queue-Id: DB9814001D X-Rspamd-Server: rspam06 X-HE-Tag: 1673920891-677258 X-HE-Meta: U2FsdGVkX1+HPgteoJuPkkBagJj0oxaTQq+5ESAZJvc9wPLTVrcPZUku97xQCmlay9eCN0jXGj7Hwj1dbMxhLGL4eN+vB5jOKm+EZO39OkePFOxGfsbU6CeJR35z9qB2rAZk5YuunEVEMUJ27pEjnbXUppYoB6vo2BE/P9BNlgIQ9TnUm1jZgniHY0s6DKoGXybiM3v0v3S/okM74+flhheP16gp44hEkFI/mO3oVdNXlPlSxq2kWfG3/MIgj9lzWgEz0PkGxwO7q7AsZ7BDKDPqH5nReu5sTxri/5gc46PrxelMjXBlrnjOR0tc89BfIxZ4xUM42+tD42SPkcq6Nnf3ELGkfQty2q/N+fdX4vvZrYkzZFoVb9Hb406cEOKqzOfba+IrE7WaVMzlML8vLpqa9gQ5xACIHDUhYzSbRrUcBBMstBi14NJqLPWu/67t7zfYeOE+ghIx7P85yNtOtb21GRKnjVV9RAcaT0oHJbCaVEc8MVwML9lfBbyMWjFsMhwh/VPRSlY8QzG9f9ljcWFhi8LPOrhaGz6iBiB4FDNgOQNN+v9TCRo8WyQuY+1/dlvOFctmWkkko6EysbBaffSD2Q8CHFe2J4oRbCsLcXzTg6VilvxwUYQmMxInHY++TT/aSsoNRdkOd4u9A7wDD5x3ibpm6Ef8Ka3rkTb9dDKQ5idBGAEKxyl8DNcyaULE27RNzY2uznj/vxEs4pLFVDyszA2cKNx4nHode/LDPrW7sSPzJX19CTY9C1b2DRVuLOHyhOXhnGz+9c7keJ2+ztlbDZLMNkzqqmSVVGx71zx8Ez0JKbtKPn3eVHUop0Ky6THR19lfEz0reZUFsmvNVyKKAP5fXxHDiU6V4iTLLOUWEAOuEm55DkD04I2zl4DDKmwvOS/2ogzUsMEQ9lDT7Wa8mhLAYogx1xAvmWPYuYhlHilTCaA6WYHh3Z7vbo7w X-Bogosity: Ham, tests=bogofilter, spamicity=0.001164, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, dear Hyeonggon. If sl*b_def.h is not intended to be used externally. That is to say we should never include sl*b_def.h in module? The following code will not compile success since commit 40f3bf0cb04c("mm: Convert struct page to struct slab in functions used by other subsystems"), but success in older kernel. Especially for modules that use the kmem_cache structure, this is catastrophic. #include #include #include #include static int kernel_init(void) { printk(KERN_INFO "my init.\n"); return 0; } static void kernel_exit(void) { printk(KERN_INFO "my exit.\n"); } module_init(kernel_init); module_exit(kernel_exit); You are right, if sl*b_def.h is not intended to used externally, Modules that use kmem_cache structures should not be designed from the outset to use kmem_cache structures. Or the kernel can use this patch, and these modules can be compiled successfully. Best wishes. Rong Tao