From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5F4C4332F for ; Sat, 12 Nov 2022 05:01:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3B3E8E0021; Sat, 12 Nov 2022 00:01:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EEB7C8E001D; Sat, 12 Nov 2022 00:01:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDA658E0021; Sat, 12 Nov 2022 00:01:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CFC518E001D for ; Sat, 12 Nov 2022 00:01:18 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9CDBC14094E for ; Sat, 12 Nov 2022 05:01:18 +0000 (UTC) X-FDA: 80123591436.29.D69FDDC Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by imf04.hostedemail.com (Postfix) with ESMTP id 2EDE540007 for ; Sat, 12 Nov 2022 05:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1668229268; bh=UKrCkq3xKMj8sSLZqZpNU4Q0Lx+VN8Ps1Ny3URH+YVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=oRZ28lxCd4gp2bUNfLLdo6H1sRmHsATg14NXMIb8+wJJmPAhajG4KM2P06CULSzn2 rVW1LRLo6uQM9LKWvbLXdiyZvr/IoZywCIqIRqAR5fBWVHtQ3mhWTGK31asOGiHhMM 92OWQuuSRPx+JlRkP86TwysW3+CSsnA2rueVc5vY= Received: from localhost.localdomain ([111.199.191.46]) by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP id 450F4C4; Sat, 12 Nov 2022 13:01:05 +0800 X-QQ-mid: xmsmtpt1668229265t93w5drhr Message-ID: X-QQ-XMAILINFO: NKv2G1wnhDBnrr4E/kVfuAaOl1xdaPmH2g5MNcAlnARbTJTbpo2cOTjBhWNPR5 uGpsVe1XUsORP3gpZQmITaJAeWOU6WToXQr8yE9Eojcu1DpdAdsk4lE9iwL04PEGNPaxPVol36N5 W0zrLApB5zjHdUMxGZ/+0skjluPgfcViwQtw+YRsmmUNnkjOJi2UAMPx7U+l2OmDha5M+BcjDqbn GqJsdbk0WDCIZpdggcJZboR4Rgp9CqT0qa0hFmPz7JxN8U1fpM6Vre5Hd37W16JgIjInFjEbcF+4 ru6MbpqBnGDcM47iWxssziI3GKPo+Lr3hLFt815RGapVRRYXCOWnWXWzJDZXBZrb2LQElxGaqaPq MTh/2hCcjZT1QCZNDUHTAzh+aNE6HaSZmVZVPDmLlgh3JKQpdxtTb6pS5SYJDGzRlEy09oU/peAx ZLMQggZFLf6NZo5srGxkIttroOSR0eBnoQLFQtGXhkrDdtWKacevNdRN0MO6shMziVNjXTxYDiMQ BD45EE5UaAxxv4gSr0bT8jY9UYwNUWDRqTYms5YnBsy04IU3kFZffsrCZM1BrX0czsfNLE1JYQYY k/Me8aVOjGwKsIeGD1f/YsauWxhGEKH6ooD69baH8cg3gCe/qNewUYKCpopvZPevBYXfEa+eZOCH uBlho+DLL7EeNRpf7WHrnngiVahhp6VQ2GS861E3gT+YQaEQOkPCRz/oplB33uvJBUYKiqMTigpz CgSvKsXYYHGamRV5UIFlZEAGQMD6FKDSYGUv6YVOQIv7vRtKQXW7w93+FNR6DC4iaLWe/XAZGbaE 0iqWMYfpvMtpPqJbygyqkMHkjQwooiTEhx39CgQrXK7p+HD9w34duXzRuka3IrEbEdeHrUyYZ2zo SH0G3NidKkhxaCFcGXEKYLn4mb4AgHUErt4nHzr6FwkYoDd+bJ84E2ktHfjiANIMPa2JWd3N+6oV +J7Ljiap2SQNvqbFfIPAOqYdOg2bxXQMpISlFq5pFZ2lrlZj405A== From: Rong Tao To: sj@kernel.org Cc: damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, rongtao@cestc.cn, rtoax@foxmail.com, shuah@kernel.org, yuanchu@google.com Subject: Re: Re: [PATCH] selftests/damon: Fix unnecessary compilation warnings Date: Sat, 12 Nov 2022 13:01:04 +0800 X-OQ-MSGID: <20221112050104.22783-1-rtoax@foxmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221111173855.108360-1-sj@kernel.org> References: <20221111173855.108360-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668229278; a=rsa-sha256; cv=none; b=OxPEr+iwBRDjEX7hCYWZuLMWM2f1igxrzL3kLu7kYWddgdq3h8lOqA6zqgK/p6j6namaDC 0SRFHUbDfp14LXBwRVposRsjxwkly8q3p39zCVmA1En/azaRwjIf2P7+7AR7wBBGTmHF8I /cW5UdIcI1isAAm8k82GQ3PedluUBMk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=oRZ28lxC; dmarc=pass (policy=none) header.from=foxmail.com; spf=pass (imf04.hostedemail.com: domain of rtoax@foxmail.com designates 162.62.57.252 as permitted sender) smtp.mailfrom=rtoax@foxmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668229278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UKrCkq3xKMj8sSLZqZpNU4Q0Lx+VN8Ps1Ny3URH+YVY=; b=sL/kGayuCANSPBiLW73u/0otID/lRohWooLycfC4x161InJa1UEVWCeBOR/9LyLP5qzM3p 9a9HiECPXZC3/VQd1NED8u+RjKZlyR7wPxA0HMv7tvp+uEXQZhXRNSqfG0F+ySNii5E4Bd Su2FC1dyhWbdGDcQOBsNL0kMf3ZLeAA= X-Rspam-User: X-Stat-Signature: oxupwk5bmfoq8yuqbtmqisk8frjhf5kn X-Rspamd-Queue-Id: 2EDE540007 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=foxmail.com header.s=s201512 header.b=oRZ28lxC; dmarc=pass (policy=none) header.from=foxmail.com; spf=pass (imf04.hostedemail.com: domain of rtoax@foxmail.com designates 162.62.57.252 as permitted sender) smtp.mailfrom=rtoax@foxmail.com X-Rspamd-Server: rspam03 X-HE-Tag: 1668229276-891462 X-Bogosity: Ham, tests=bogofilter, spamicity=0.090682, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Park, I just search on GCC source code, found GCC support "-Wstringop-overread" at least gcc-11.1.0, commit d14c547abd48("Add -Wstringop-overread for reading past the end by string functions."). AND found a testsuite gcc/gcc/testsuite/gcc.dg/pragma-diag-10.c 10 #pragma GCC diagnostic push 11 #pragma GCC diagnostic ignored "-Wstringop-overflow" 12 #pragma GCC diagnostic ignored "-Wstringop-overread" 13 if (c != 0) 14 return __builtin_memchr (s, c, (unsigned long)-1); 15 #pragma GCC diagnostic pop it's totally same as this PATCH. I think the motivation for this patch is to eliminate the compilation warning, maybe one day we will compile the kernel with "-Werror -Wall", at which point this compilation warning will turn into a compilation error, and in case we already know it, we should fix this error in advance. For old gcc, we can add this? #pragma GCC diagnostic push +#if __GNUC__ >= 11 && __GNUC_MINOR__ >= 1 /* Ignore read(2) overflow and write(2) overread compile warnings */ #pragma GCC diagnostic ignored "-Wstringop-overread" #pragma GCC diagnostic ignored "-Wstringop-overflow" +#endif What do you think? Good day! Rong Tao