From: Rong Tao <rtoax@foxmail.com>
To: sj@kernel.org
Cc: damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
rongtao@cestc.cn, rtoax@foxmail.com, shuah@kernel.org,
yuanchu@google.com
Subject: [PATCH] selftests/damon: Fix unnecessary compilation warnings
Date: Fri, 11 Nov 2022 10:37:20 +0800 [thread overview]
Message-ID: <tencent_32CBE47252C5F69571B40751DE6054082D05@qq.com> (raw)
In-Reply-To: <20221110200939.101886-1-sj@kernel.org>
From: Rong Tao <rongtao@cestc.cn>
When testing overflow and overread, there is no need to keep unnecessary
compilation warnings, we should simply ignore them.
How to reproduce the problem:
$ make -C tools/testing/selftests/
...
warning: ‘write’ reading 4294967295 bytes from a region of size 1
[-Wstringop-overread]
warning: ‘read’ writing 4294967295 bytes into a region of size 25
overflows the destination [-Wstringop-overflow=]
Signed-off-by: Rong Tao <rongtao@cestc.cn>
---
tools/testing/selftests/damon/huge_count_read_write.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/testing/selftests/damon/huge_count_read_write.c b/tools/testing/selftests/damon/huge_count_read_write.c
index ad7a6b4cf338..8fbe276870e7 100644
--- a/tools/testing/selftests/damon/huge_count_read_write.c
+++ b/tools/testing/selftests/damon/huge_count_read_write.c
@@ -8,6 +8,11 @@
#include <unistd.h>
#include <stdio.h>
+#pragma GCC diagnostic push
+/* Ignore read(2) overflow and write(2) overread compile warnings */
+#pragma GCC diagnostic ignored "-Wstringop-overread"
+#pragma GCC diagnostic ignored "-Wstringop-overflow"
+
void write_read_with_huge_count(char *file)
{
int filedesc = open(file, O_RDWR);
@@ -27,6 +32,8 @@ void write_read_with_huge_count(char *file)
close(filedesc);
}
+#pragma GCC diagnostic pop
+
int main(int argc, char *argv[])
{
if (argc != 2) {
--
2.31.1
next prev parent reply other threads:[~2022-11-11 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:34 Rong Tao
2022-11-10 20:09 ` SeongJae Park
2022-11-11 2:37 ` Rong Tao [this message]
2022-11-11 17:38 ` SeongJae Park
2022-11-12 5:01 ` Rong Tao
2022-11-12 18:30 ` SeongJae Park
2022-11-13 0:38 ` [PATCH v3] " Rong Tao
2022-11-13 19:49 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_32CBE47252C5F69571B40751DE6054082D05@qq.com \
--to=rtoax@foxmail.com \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rongtao@cestc.cn \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox