From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E5EC71130 for ; Tue, 8 Jul 2025 02:47:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5335D6B03AE; Mon, 7 Jul 2025 22:47:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50A026B03AF; Mon, 7 Jul 2025 22:47:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 447DC6B03B2; Mon, 7 Jul 2025 22:47:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 359436B03AE for ; Mon, 7 Jul 2025 22:47:13 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F2EA01A0477 for ; Tue, 8 Jul 2025 02:47:12 +0000 (UTC) X-FDA: 83639560704.25.8108C3A Received: from out162-62-57-210.mail.qq.com (out162-62-57-210.mail.qq.com [162.62.57.210]) by imf25.hostedemail.com (Postfix) with ESMTP id 48AA8A000F for ; Tue, 8 Jul 2025 02:47:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=d0JvU2UM; spf=pass (imf25.hostedemail.com: domain of chentao325@qq.com designates 162.62.57.210 as permitted sender) smtp.mailfrom=chentao325@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751942831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kvzF1+p5zL61FS2tiZH6CM11U4IQ8gp2XDypmzE3OA4=; b=OoQgPl3IBOgI081z4PMd0QROXurjdg9gH+pb7HkmKSaRbtdjdFKiG9nA4tuid1lrKMNG2M Uv2Sbg3//OJNATOKTpk25j2r4s/AJmiaQRBXqxBRLNlXm+rK68Drvuocv9bh7iXbZ505MH bv1BBoglLbcxhXqtEgSmPbPOn3gO20g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=d0JvU2UM; spf=pass (imf25.hostedemail.com: domain of chentao325@qq.com designates 162.62.57.210 as permitted sender) smtp.mailfrom=chentao325@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751942831; a=rsa-sha256; cv=none; b=DRqFFmixdttQkodZe6Q6kt32eHCE8Ore38a/JCM7c5oz13T5cSq5U+aeDDUWpihn0evwF0 GwcWg0k/HxoXHZ5Wwq8GsqEUcMQSJveqDMy1oLh83ZVvz5rl27khISQuCR7M/uPpWdxyv6 9I6gDJGGa+Sxjt+tLTxQFa4ZvOUA+a4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1751942826; bh=kvzF1+p5zL61FS2tiZH6CM11U4IQ8gp2XDypmzE3OA4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=d0JvU2UMtIogZgewcxyEA7IMJH21U9+s0etDUMX7Z6dNQtUxu/1W/lKR5sZSahYfc a8xMGwukUL5kjnc/niGjzdhF9MeUdeKr2so7NcOOzytBaRDDrsWljVwbBC/zqFd221 EfGFuffqJfQlSTE/YPwGzXZOuaCCWBU1pfCyT/kY= Received: from [172.25.28.139] ([210.12.148.147]) by newxmesmtplogicsvrszc16-0.qq.com (NewEsmtp) with SMTP id A34B4E63; Tue, 08 Jul 2025 10:40:52 +0800 X-QQ-mid: xmsmtpt1751942452tqb7p6kqb Message-ID: X-QQ-XMAILINFO: OdIVOfqOaVcrB8J1/3pY4XbUjodfVtvPJYY8MEIntC/Qk0T7VCsqouThYi3dUz nBB+HWRWUrC/DjWaMIe3fDKXL+/1yL0ONPwSf6VzAi9s+e53grwuKj0NrQxQfDB/tvErjLQT6kN+ ku8eDgRQ2ZJks+cyE6nUh2pt+o3LhMMpdTbK4oHplFtkSFGZrcvGgOsZ8iRSuF3JWM+VTBJ6/zs8 ELuPCcaem7SCKvoIQ+LGmhscZdTrg+SX+8O+82yQWsfR3GzYefu6z/uqvB+9+MfattdYmOk319DS i3L+xjwYpRyws77ucRGqvnAiZTclJvNdvW5Do35M3N/EIDqb55mbXU/mZyehhaKEjZOJ/CJCXtBV I1yVo9hxMcnZji1oHD2QmHiurcR21qkFJ48nUrE5bgKQHEs0NtHEUk2OgOI8e3UHB98GapKPZEvq J2H/qWdMeLiDnQOOikfFUpYXv0d5J5xBMhOh2S06+Wy1vvATxmpH7knEDr9Pk1rIhFOclUXQ4z2S 6Tm0+J3brxOwAa6HklGaUpXatvdWB77/jDpyae1VhaJFS144yMZXQi4xwZvd5MmOTSqDkf+Z6Byf U67miPCw/wdH+aeKBdmaFlAFZ8TvAKPgrP9yB0GOMn+Sbq+fYXl5kyBMA/tuI0jGAYtqf9B7EUbl 5noJVRcbZQtSROy6bdSLFIW4bKRDmmpIcC1Ako6Wei97QHe5E16b5+Z16k3QUZ4FLEC45fwNHB8o ACB8jBz9fsfYwsIHRrBtBPctVuDEoXwr8hkqUUd+9Pe+h6S0P8WDHc2zKDUEj1hrzy7yhqT2WOBM 0Gbj+Ajmjfj+YVEpDCWs5akjrfVRsOiXTi6mr9zJ2szYtAyWOjshuTybaVqNyzlqOoW+I8UVBng3 mQJyqxNfJsPJ0PQXKAgN09aGyzNEOOmpvp0Q5ZrgBz/bbuBIvnOpYZa15Fe0HNTZbF36qh61wzN2 JrQJ6uYekSONwhYqbUGREsMuMnQ6/KpP+y7u/MmU0FGWNV07kXgKgmjJ9G9dO3VXhNeqZGyag= X-QQ-XMRINFO: Nq+8W0+stu50PRdwbJxPCL0= X-OQ-MSGID: <321af03f-1f7d-4ea5-81f4-28938410a7fe@qq.com> Date: Tue, 8 Jul 2025 10:40:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/5] mm/filemap: add write_begin_get_folio() helper function To: Matthew Wilcox , =?UTF-8?B?6ZmI5rab5rabIFRhb3RhbyBDaGVu?= Cc: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "frank.li@vivo.com" References: <20250707070023.206725-1-chentaotao@didiglobal.com> <20250707070023.206725-5-chentaotao@didiglobal.com> From: Taotao Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: sjxh7qpxqiwk19eeboor3f1q1dzmptd4 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 48AA8A000F X-HE-Tag: 1751942829-993637 X-HE-Meta: U2FsdGVkX1/+B4X7xvbrApYwebxKyUHKgUx6KqCtospG04c7QEjUjbJZ9QCFuX9ts3rMga3I6wENpAozxXW4tVzQwfCTVGry6pSBR0D30yYzixZjEMr/ZH6psdADL8Sn/cnScxM8i+n5uDifEEnPS8olZD/Sisf9YOFvcQ4XpDBD5p+3vM3BkqaOxXUoxDdGz+f+W2nuwxg3I4N4/MwfHPFnDa4O/QCRY1V0PnIHom3fVrU6Fuyvd4FzniDbpCAt5YYZoypo9RcnZ2vv+DO2upYX0e49s/6RkUEYz7D8a2Akj1RWSBRj80++eXorN5HxxlTPHxHLJwWfzg8qttkKGv6noLm7vdCaBTCTg1gozTjuEfi1uzdCGK4/7q2AIhBxbQFS/kcTh+FVW1RUKqZ0emik3Wv9nsn3YG9lIZaEZK8wSzO0BdZVCssPUNrOUs/qEXwniVu/kUQtdfchUXINftlJ0ka5gNReEZ8rhuOgJL2eVLYBnRI51v4k/gvOYttK/7hexccCEgiBBYPcHvcKj9LUVMBGOPp0igoLI0dyE1mBrgH8dcmWLu8ZOoc7Lf1mlpgefEeE9Cm6dNUGPYVqrEnAkLLaKi3DzQBRno3aaiblVFKHBPn0lIXawc+6WTO58Vj0DqSuPe+edjWDAoF9Xf1XBWtgBhz/5Ch9nH7rwAf3Ez9IWcv8JqQ0AAIV8Bhs2WjY27JZCxIayoMyMtJezPV9kfhn2ZFpRk8g8VcTzKdlx/DNhqRakPHwpQxOx82TAzR7ID8IR6+fsukLakoLF6cA5sMBciIaALBSk3Vrftp0uikd2b6y02R8XZG7Qvg7ltcFJR0uOZ+Xa/brT8uz2e0Q/fN42LQ6y+hPQ6bG3Pt9T3V/TRnn/cKQusq5hNqX4aqAoS78vTA1Oq4UfFyPOjrnl6i59XWVB5z+IA4hPFuqdhIv5xgf4rFh6udvYeNcfmw44LzULrC5bCpo9aq bcanCzlA l7neSd1UyS0gj2cTCkh3/sTgUplBbTWZyQNq6oi4eToKGjMZaw9ZhWtgDtLymyOf4y7WZ6lJztdzu9F6BQpCTl8ZvCtp51pUCnxwVc++hwchbary3S1pdQG73eFcPd7UICWMTVb9KoAriAhWsC6O/3/o+IkQAW444gMPQPv5Kt+wM25zS+DIuRtyKEat8SsNx/KVG8b9ry0ldoUIkS+moy9NS71muMkLNxX4MXZiXW059lOj9Wi47061tIjC1gbcogmHbCjVZCzRv4QDjx+zNoDncn67Qy/NSGojQoz4eubOsNMsb7hB8M3lF8bGyZw2y62gVvFmNld+eZ4XlPA6EXUF01A9Yj1vlZxb733hzd/kUyleGatk8hmADcjo7EU9iXxI6z4O+5kJMxMNkVr+CCORNVrO/7t1P0vMrm5Qrc2nccSz9d3mJy8CnA/DAZQgv4Bi/+BjpD1GCOu+5h95gutgvbpim5QwbnZTN/FaZbu3cQ9rDMYLUTtMYxyqoOOsx/m1mgrDkl+IKpI13j2+ca0Md49QdXW0SyrHPnNoDLhetsDDAs101mCO0OH+Hx4cOLx0Oq6r7/jxlS4pCrPz0UvkQ5g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/7/7 22:54, Matthew Wilcox 写道: > On Mon, Jul 07, 2025 at 07:00:33AM +0000, 陈涛涛 Taotao Chen wrote: >> +++ b/mm/filemap.c > I think this should be a static inline function. I don't think it's > worth moving out of line. Of course if you have measurements that show > differently, you can change my mind. > >> +/** >> + * write_begin_get_folio - Get folio for write_begin with flags >> + * @iocb: kiocb passed from write_begin (may be NULL) >> + * @mapping: the address space to search in >> + * @index: page cache index >> + * @len: length of data being written >> + * >> + * This is a helper for filesystem write_begin() implementations. >> + * It wraps __filemap_get_folio(), setting appropriate flags in >> + * the write begin context. >> + * >> + * Returns a folio or an ERR_PTR. > We prefer: > > * Return: A folio or an ERR_PTR > > as this gets its own section in the kernel-doc output. Hi, I’ll update both in the next version. Thanks for your review! --Taotao