From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D96CC021A4 for ; Tue, 25 Feb 2025 02:20:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CDE26B0085; Mon, 24 Feb 2025 21:20:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 77E38280002; Mon, 24 Feb 2025 21:20:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66C8E280001; Mon, 24 Feb 2025 21:20:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 484AF6B0085 for ; Mon, 24 Feb 2025 21:20:57 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 674AE1A07E3 for ; Tue, 25 Feb 2025 02:20:56 +0000 (UTC) X-FDA: 83156864112.13.2626DF4 Received: from out162-62-58-216.mail.qq.com (out162-62-58-216.mail.qq.com [162.62.58.216]) by imf16.hostedemail.com (Postfix) with ESMTP id 00D90180002 for ; Tue, 25 Feb 2025 02:20:53 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=m8H9uwVm; spf=pass (imf16.hostedemail.com: domain of 76824143@qq.com designates 162.62.58.216 as permitted sender) smtp.mailfrom=76824143@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740450054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=WuJE8U+JldV4rGuUdxTv6JlPIXc+epfnHjhcFUtAv5A=; b=kropGK0MhdX3i0n2YFUrejxkm8dK82igFLDW5FBqsMxRKDObiv2iAlT87+8XKoh/Dg246n YK1PsQK1kX18K/Bu39IS3fkthY1zCwZkSQsf5hpolO9mrvffKr+uwEhpO8NVdOEjP+7V4w WQPVf7zmoAMtdUADiy4Rktct/IeLklI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740450054; a=rsa-sha256; cv=none; b=gFENZrVeNsGXXYdstBhbLYA8w5Hhd1Ey4ygCe6KzHQ/VOUctNOGIFz5Jml8LO2OPHUYQCI mvAmi8v+dIlN3uYmJD64wZ/XGFtZVQtNyTAkhmEuDhfBCfI3zQRWlAO4JY6BfYShWR5qBf ixkNqPZp6+avoDQDkB8cbAaH5GTTWDQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=m8H9uwVm; spf=pass (imf16.hostedemail.com: domain of 76824143@qq.com designates 162.62.58.216 as permitted sender) smtp.mailfrom=76824143@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1740450043; bh=WuJE8U+JldV4rGuUdxTv6JlPIXc+epfnHjhcFUtAv5A=; h=From:To:Cc:Subject:Date; b=m8H9uwVmgcMDcwbGkwMcZOBxmUFX6+F40f7OjgphFOb0ALoCal6z50ZngJV2kOssq 0gtbthMmI5YfQqMmr4TaJexztoNWMSWVV05g15/6gZM40D7m6Hq9zftD8PufbcFSaC ExZxHUAi9gSrJwg8po3JoocPlemtQZ9EWYqtDJRo= Received: from localhost.localdomain ([116.128.244.169]) by newxmesmtplogicsvrszgpua8-1.qq.com (NewEsmtp) with SMTP id 52321632; Tue, 25 Feb 2025 10:20:35 +0800 X-QQ-mid: xmsmtpt1740450035tx00fay0i Message-ID: X-QQ-XMAILINFO: MqswyhUqVe0CYMouaKCY/K8f8nIUWbt1GHPkys0aiqxIZAe5AGKjJJvjOgc9Vb FHR9bGvwJz4KrsbiInopig97KFLM2crUh1wq7EMcH3wET6tpgPfCMjPP0FkHwMqYCQl69LwVkgUN rVprn7u0uiHz2xTOo4prxpENUUHo9cing11ZbMg3jNmLWAVUGyTOB3AIEJTRuteFVRRgGj7KBoEL 62XzqpKq5TBZQYqCEwd6z31cmTSlsDcIkgeaehnjC2qVmQhwEyYhjBV4CvBdyf3DZCx5qLcRPpDN bISahCArXmQ+9yeY6uEBSgEwujOHQNfZj3IcTb4HOBQvXXyjL9aHn3ceAzADnVCDSdHXKavEu1Sn 2YuCltm0E2PycnF0ELZdyleeCbuDvEAU4zQzZ2OvAwZZF6XDQerJzqNVxfskWS/dtURaD+vgyTxZ +3xIXZ8M1Oh/ek2/f2dyKMfNSqO3ZQDbWxnf2SX2Elypy6PMX/xPfbe70uuPsOjYRowPMwtwyjOe 1ka29jeZCT1tqNx15Y0LkIYMURkVk7Ct/VxM9rviMRhg51GqTztug/NIBya/hD8eIXLirn4Yiz/d MoB31G8WdAJKzmVc1Mpnu5pxS7umsWckrDRAABIL7oYlTbdjcLQ89uCCU9CllAXdbdo/5mIAJm4S X74eTz7tyjrH3O7ZtM2GN1cc258qhPg3SQTLqyvD5BvtQsvu9+u72sY0jgUaJzbIqR3U+uzuu/yO jk7B+riixqt00lVotYdTSzgyUI1rQRsFZj2zNza/CrzzG+rk2jK5FzEWyQ2tjkduQ7k0bwbDiCSu EBaO+ZOiMiRVHdquQ+Q8pP8FkMytt423GO1OBFXlPXwBBizBkqsghPzW82zeo+gsEv4+I76nj4jO zXV5P+bCrCewrs0jufMkPfb50YcWMrLiFQQapdwknNKePA2uDR5uN1wV0g5CNHsigR5dD9TkH2e1 NENgf0vqnLZvjsQ/eLFIgM4GfHJGFaBghoGvhoi9Y= X-QQ-XMRINFO: OD9hHCdaPRBwq3WW+NvGbIU= From: 76824143@qq.com To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, Hao Zhang , syzbot+0cfd5e38e96a5596f2b6@syzkaller.appspotmail.com Subject: [PATCH] mm/page_alloc: Fix uninitialized variable Date: Tue, 25 Feb 2025 10:20:34 +0800 X-OQ-MSGID: <20250225022034.83379-1-76824143@qq.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 00D90180002 X-Rspamd-Server: rspam07 X-Stat-Signature: nc61uwocfdxwxdh71musuit7a3htneh9 X-HE-Tag: 1740450053-849761 X-HE-Meta: U2FsdGVkX18pccZx6FmXNBbsB0COkFZ/4BG3faSRkS6GV1HAzwXiDl0P/LehZjbwfcOr7VKz5k+DBiykzLkOg3YW9A8416ynI+P4dQe81RLMZ1dkxecoj4/MhPikESqXUXZQtjYyRtyepVHl/Wmsvo/44r1rFtgj7LVOR8g5ZlLkfHkih/KFDtD4VFdtTwxqxv+HUddFgXwHBaDU0Tsnia0cnm2dpU6o7YMlZFuPQ93mUlCE+T32UBDjeHR54hSpZ0LRiWqqPv67QFgIo8yKOBIWf0ldjEG8GQwInxrQ4P2Jxykpnm+EfReRpwhPxUL1O2L9y9QrHYpNG0SV1zf5BEBF8U4lvz/yM46dZKmjaQZgH+XXNQimYMOJ0cdtHThks+hvTaVZ81Mn1gz/ckwJuCQuS04Kr/O2BjVjNGv0ajK1t1M2/yBqAaL8/5bDDAKt7dE5Bof1YlBH/PP+ZCiWpvoE5SYh3XjHKXDNyt8/niJOZwqSKrWh8+gT+kt1k+x7hNemQlsweiHzYF9VUlMmJ8jVWcp/lyEHr2LJwmwp33MeD3TSbr+Zst7/r99dje3h04HyDfCfr+A1HVW2U6+E6TWEcn0NyQBfzgu6nzZpZxDujElx78vPmUqHuQQZO2zLyOuj3UMqLLePWfFz5T/RtZ4qCxXbeeSwIaaIfKoyL9ecQJAt5MDBhyJER/Yf4hiN6qSJjWtgA3kWcCjaPhMs8H9V86zTTHnjA/sEm/hAiG8IcrujWvZLkYqtfVzdXjRsY1ocUmhc+GNAQqPGGW0eOu6b1rxYfCqDrPXizvkWJO1yw7eNmZRcDejv4x4uwjj6DhorG8GFEfDdqceg8Sb//atgcx81etqBK5qaDx75U2gqyH9r6d+F9iA6+6CrrDP+CCxVh3QUt9T0TCXFXUxEQVXK+k2U76w3ZxZzf9Dyh37Tv5DNnhHAnSl1kA+Ab+5j3SluJLT5L4d9Z/xqRCA P9ZM12Ec R3glvWykOFeFtPYrSqIBiwt/HoC8BQIK3dZJm6yAlk8pWpw7Qe/JtJpF5Rte8ptZaBRvmeDYxIvh7QMxpF267NBSWHqR84jsn8v+8u4XwRgE0Rvc9nfFxgoB//8Mee6HVdbkhATBN200SIMdPTITP7FK2Z0Q5e+5y181MqcBRYCeYHRsX1CZ7FRUfRM6J3LHLgMW//hqPa4PkaGj3HDOAMtEHZ6SNSc1TQf0EFtZR/dpPwYez5iJkaKUP9/CI2VrHFHEt5O7IGw2j8RNCMAk+l+UvK5/f1sETGYahJzSuFH2Gnl0So05vf9AheqTh5OKoWBeKeJ+dpASgV9/eKrzQpSs428FAp2JZQK7GBNFoWPgMc842FYanq5tdTuV/4r7QckbRnvnEOBnztb/Azq9pQtbjufVUPMBmkLgkuoae2MdEKXyXyHs1qZbLE3ipCTJHx+VU9XCDsjvn0/U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001237, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Zhang The variable "compact_result" is not initialized in function __alloc_pages_direct_compact if order is zero. If order is zero, initialize "compact_result" to COMPACT_SKIPPED. BUG: KMSAN: uninit-value in __alloc_pages_slowpath+0xee8/0x16c0 mm/page_alloc.c:4416 __alloc_pages_slowpath+0xee8/0x16c0 mm/page_alloc.c:4416 __alloc_frozen_pages_noprof+0xa4c/0xe00 mm/page_alloc.c:4752 alloc_pages_mpol+0x4cd/0x890 mm/mempolicy.c:2270 alloc_frozen_pages_noprof mm/mempolicy.c:2341 [inline] alloc_pages_noprof mm/mempolicy.c:2361 [inline] folio_alloc_noprof+0x1dc/0x350 mm/mempolicy.c:2371 filemap_alloc_folio_noprof+0xa6/0x440 mm/filemap.c:1019 __filemap_get_folio+0xb9a/0x1840 mm/filemap.c:1970 grow_dev_folio fs/buffer.c:1039 [inline] grow_buffers fs/buffer.c:1105 [inline] __getblk_slow fs/buffer.c:1131 [inline] bdev_getblk+0x2c9/0xab0 fs/buffer.c:1431 getblk_unmovable include/linux/buffer_head.h:369 [inline] ext4_getblk+0x3b7/0xe50 fs/ext4/inode.c:864 ext4_bread_batch+0x9f/0x7d0 fs/ext4/inode.c:933 __ext4_find_entry+0x1ebb/0x36c0 fs/ext4/namei.c:1627 ext4_lookup_entry fs/ext4/namei.c:1729 [inline] ext4_lookup+0x189/0xb40 fs/ext4/namei.c:1797 __lookup_slow+0x538/0x710 fs/namei.c:1793 lookup_slow+0x6a/0xd0 fs/namei.c:1810 walk_component fs/namei.c:2114 [inline] link_path_walk+0xf29/0x1420 fs/namei.c:2479 path_openat+0x30f/0x6250 fs/namei.c:3985 do_filp_open+0x268/0x600 fs/namei.c:4016 do_sys_openat2+0x1bf/0x2f0 fs/open.c:1428 do_sys_open fs/open.c:1443 [inline] __do_sys_openat fs/open.c:1459 [inline] __se_sys_openat fs/open.c:1454 [inline] __x64_sys_openat+0x2a1/0x310 fs/open.c:1454 x64_sys_call+0x36f5/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:258 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Local variable compact_result created at: __alloc_pages_slowpath+0x66/0x16c0 mm/page_alloc.c:4218 __alloc_frozen_pages_noprof+0xa4c/0xe00 mm/page_alloc.c:4752 Reported-by: syzbot+0cfd5e38e96a5596f2b6@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=0cfd5e38e96a5596f2b6 Signed-off-by: Hao Zhang --- mm/page_alloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 579789600a3c..7f0136a404b5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3675,8 +3675,10 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, unsigned long pflags; unsigned int noreclaim_flag; - if (!order) + if (!order) { + *compact_result = COMPACT_SKIPPED; return NULL; + } psi_memstall_enter(&pflags); delayacct_compact_start(); base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6 -- 2.25.1