From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80416C25B74 for ; Tue, 21 May 2024 19:29:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71DD26B007B; Tue, 21 May 2024 15:29:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CD256B0082; Tue, 21 May 2024 15:29:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 594B76B0083; Tue, 21 May 2024 15:29:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3BA936B007B for ; Tue, 21 May 2024 15:29:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A932C12134C for ; Tue, 21 May 2024 19:29:48 +0000 (UTC) X-FDA: 82143392856.03.58C2CC6 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) by imf22.hostedemail.com (Postfix) with ESMTP id 65DBEC0008 for ; Tue, 21 May 2024 19:29:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PeGr+tAM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716319786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jalEsNaUolsuLrS6kfuLi9+NeOcqrQKeJyldtUe5VCw=; b=XzpmVyWnEo3C3RbheDm1fJRRVNwoDW8p4NC0HlL/Mhp09/VhleRp8vgrEOAJPRbHTOLWhO rtcMLutaDTSoeMqLQW9Dro2ImXVBbex3OTj9+jTzg/8HHUjqzVBU6DX4qB+xii1R9jhBSP 3hjPbjb8to85eyiAsaTKyi4lSyJ9PwA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=PeGr+tAM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716319786; a=rsa-sha256; cv=none; b=RCuN4e75aS6qX7VAeF7S5uJyi8peCMl8vq4ubYRWdJzq3GyKUMfS74SJpScDnihaiJYNJb bFkGzxURFw/wez2ekpTJo1HD/5FdAUTDJtP6EZZnRF891bv8QhFg/qkf+J/rnMcjA0nc/X EE1g4UWysbUNm2UWUFAlPzuNUlGCd9U= X-Envelope-To: willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716319783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jalEsNaUolsuLrS6kfuLi9+NeOcqrQKeJyldtUe5VCw=; b=PeGr+tAMufg5tm3E5oOpzYZtLInc+EAmNTJjUioYd2Mdx5dZkptLmQoNTeKMFbOO8yPO7S CUesLkwFtTJM2f7U6Vy4/bL7JJgi5jyZInPq1PUyMggO6fDEhTzn3WAnMfbL9Y5XtQwf0F VPLrs1q6+KbA5VS/YuGXZTex1WTWx+c= X-Envelope-To: wangkefeng.wang@huawei.com X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: muchun.song@linux.dev X-Envelope-To: linux-mm@kvack.org X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: urezki@gmail.com X-Envelope-To: hch@infradead.org X-Envelope-To: lstoakes@gmail.com Date: Tue, 21 May 2024 12:29:39 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Matthew Wilcox Cc: Kefeng Wang , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes Subject: Re: [PATCH] mm: memcontrol: remove page_memcg() Message-ID: References: <20240521131556.142176-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 65DBEC0008 X-Stat-Signature: pgb6djaq69m3z9wr1o8h15tabs8srcmh X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716319786-491519 X-HE-Meta: U2FsdGVkX185A3fHuS/Qal0XbJqGULr5WHcxPg6zsv0N7/ZORmyhsYZvblbA+hstSB1xxoqhKWyi+0y9cItT/TnMrW/Lr4R02Lys8HQ7KH/nUzvPTt4EJoUvWwJFVgQZhmFPgTdi50aA4JGpVVU5hThNfcm7sSUI1VBaEHl4y9VAf33VRklkiSUyjCxgNGPJrC20ROKV7mmBs0HwKNN0p3yzu6zmasBQE0CZDPFJJMjKX53Yxx7CzFq3AMmr1/7jlg31Ylv4kaHxCu6wWZbsqGJUuqZbOpaY2xMS1AxXfF+NwRIqbTDA+Lpx1cLZgombw1AWs2gLynLEa3aIl1cuRky6DZOHsTtrM9IC2uk36n0yF2Qr+ioeEUOv7u4M4X3YDBUG2YtztUXxW3o3aKnGvZpc2PwJW0bnG/FMCnBSWwlDqlTie4i9uatVFUCojtukvRTh7tbMu7rwkqyMxB205mZRiI3r7KbW7R0Xu7mKiFH253zRIUZ04lVnkRXMyjt+UQMAU1iQvHoCAprqEcgEQtSedfDmO4xFXEd+hF8NkhQ8hXI9yV0W8IhgXU2Yck54KBy3F+YNZtCAElXqX7Cwaxaw3Il048DvAE28/0a8UO181N6k/jIREneECU3HX5f4jpylfHCuNb+lVEYEc295MJpg/nBaJ1LnQoODfwaG23KzZIrszu8qAGvbgB3XMA90uTBlGyLXMBXNYRVabLmpaQ9lQDyVQalRMmgz3H64xtyiRr/8U8HfIPF0oZoUDQ+Ot0NrEJrG1sn1F+TatOunqU5ZK3eqpPIpZCNdNeIUj6L//JYsm28AJTckaShFctU3sYBlGfEePXS+/E2/CP26HIDFcHx2V5/7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 21, 2024 at 03:44:21PM +0100, Matthew Wilcox wrote: > On Tue, May 21, 2024 at 09:15:56PM +0800, Kefeng Wang wrote: > > The page_memcg() only called by mod_memcg_page_state(), so squash it to > > cleanup page_memcg(). > > This isn't wrong, except that the entire usage of memcg is wrong in the > only two callers of mod_memcg_page_state(): > > $ git grep mod_memcg_page_state > include/linux/memcontrol.h:static inline void mod_memcg_page_state(struct page *page, > include/linux/memcontrol.h:static inline void mod_memcg_page_state(struct page *page, > mm/vmalloc.c: mod_memcg_page_state(page, MEMCG_VMALLOC, -1); > mm/vmalloc.c: mod_memcg_page_state(area->pages[i], MEMCG_VMALLOC, 1); > > The memcg should not be attached to the individual pages that make up a > vmalloc allocation. Rather, it should be managed by the vmalloc > allocation itself. I don't have the knowledge to poke around inside > vmalloc right now, but maybe somebody else could take that on. Are you concerned about accessing just memcg or any field of the sub-page? There are drivers accessing fields of pages allocated through vmalloc. Some details at 3b8000ae185c ("mm/vmalloc: huge vmalloc backing pages should be split rather than compound").