From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E28C4829E for ; Thu, 15 Feb 2024 21:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC298D0010; Thu, 15 Feb 2024 16:37:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48BEA8D0006; Thu, 15 Feb 2024 16:37:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37B5B8D0010; Thu, 15 Feb 2024 16:37:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 26DE68D0006 for ; Thu, 15 Feb 2024 16:37:26 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B9BECA2548 for ; Thu, 15 Feb 2024 21:37:25 +0000 (UTC) X-FDA: 81795349650.24.814DA84 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf24.hostedemail.com (Postfix) with ESMTP id D40C1180029 for ; Thu, 15 Feb 2024 21:37:23 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Rnhwg+O/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708033044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=39zmCdbpcZTkNZlIqIoMaXRRJS4y9GsAOFJTtoi5f0I=; b=F4rwEL5I/DCgxoGl1xh01DIrVwEGWF+sHSkhJrbE3QpP7brvfT/uj8hTwLc1+Kn9pJg9TC 1Aog0IXohz6i0tFmnRYfFRsDRtph4O3NOQtWxvTqKgr01RL0hLXI1IQWFvyseqOhyUVujK 8YQX8OzyIOypbwjVyO4YI2YK2/Ktq24= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Rnhwg+O/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708033044; a=rsa-sha256; cv=none; b=zjEP4CIkm/6aDR8P1xZa18di79peFzvdOrD6OIYja00aYWdT6pWNQHOVBusWZyPXGdTClk Bj3nH0ymUDJm3biwzaHga4dSNhFaNgOoTKLnOQpWMsPRN0E3VaAeEKIX3ZtEm8LP2s2RYf gi1TXpSXmaxDbn9UpvBGatR0BiE98Mo= Date: Thu, 15 Feb 2024 16:37:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708033041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=39zmCdbpcZTkNZlIqIoMaXRRJS4y9GsAOFJTtoi5f0I=; b=Rnhwg+O/fGg3InE7Iv5/dEuDz/AEL63LsTs3WOHzJhbI+Tp0Mqj1CPfI1GKmY5eOPSTVzM WeRBqw3S9FwgsAKOKdiLzXtsQQjE2MutvjEpVCTjrw7I3WMwInP/mysrsYUnh/9HHdE6gr C4/HCaIEa+ME+cB+PteBQP1XD+6Hwbg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Vlastimil Babka Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 07/35] mm/slab: introduce SLAB_NO_OBJ_EXT to avoid obj_ext creation Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-8-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: D40C1180029 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 93f87wi4c89c9tyyu3pqhyj9xsb3jz5i X-HE-Tag: 1708033043-576659 X-HE-Meta: U2FsdGVkX1/FpfnwzDT4etYeymKi17WH1dF7jKoxSr/oShvcEfRdLCyfZEF2pyGYn2Y6qjaJVCJtcNE12A12hF9ASyEQ3F7Ko1j/TSr6rrjMEf8BflM2tvDXifKwsyWPbVBgpTfpwwD8WggDN+9Nk58IzirCHeVyV8VM8T/xJFmy4+PztCGOD/jHmq+2sYLXqFQIlGig0fJqSmj5VlSE7DsmNMyCQwgPdTrRKv5pC5lxOqBBgDyVG6u7jYo4DbqDuJTGkR0JTfprvUN9YAujGSCDBNkqPO7JAi6m2nt3MyEjMmXxOKXG1gmO55Gyve6zz7HIRpXcU3/YxD3z55/kAVBc161mBTCY5fBhrsQYzHNz2W8xRPp/6ThpjP3lJHV/udlrbxLKAdMWnlKlg/g3t23CiYST9lNlwYsovg9gdSDILFN07Wnoio7u4Nn4rtHnKfKxBJSAKUa4hvMKZFuLdoXjnQFKUrC4HVYr84fvV/vB6euZdZ8QEf6Kgy40sKJc+X+e+HIPRB1jYkg6Sh1/HAYW1uUZGlab8vR+fn+l90896Wy69le70g8/6edIFPDs1XmFgqVU4aA68+JzrzDHiwJ1y7RhaT47Vr0Jf45tQGQ4USrvFzYWv0vlXmqYSuf3bZTarsQtTOlN8qFU4yhxFV3gCn6P1IkuVNTg4d9bO8DebLko4FEInxKY4W1W8KkQTSGD0Seu3Z7a5Jd2gNRKG3Z2FaNYGRPeBQaVylLpUHIjPRDA8SaF7h1yKiJA01n1h2QGAFVYJXYBkCKMH2UnfEIC0kmPZo6GyREEtvgi4TWrUQXuxKK3P7R5dNrJnB8yRhp8BoBKV24My4flRWOI6ATRrwLBYrVpQpDUh+ZpIdM8OkGdyugWtVYch3WP7Pnr9wI8L5+Tf2SfFHUWKvMYq6he9NKJM8dr9hQgOApU7yV8CBvgufScqFlBO4+NPODxwkqYYietPr3OAMO2hDg aT2jeZ+V 4axB7O0GGiUeuU8ogZoaM7InfkwEb9avEmmLfy5s7PwwSkuiJ4XjZitkCwObBtHukW564RyIQkPeC0wkca4b5GJrwuPENrIaO8TYRJQJXFgXq0FKlMhU8qjqlgm53bkTywZ2ZloHSlGYZ/45A+vBvvyCPZ4MWkZxapwBYcGaWSqC4uXgMJwefKK6Qg6VUrayltZnaIi8Xis3iE6+xPlM2UOXjgkc+UjX+0xQ5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:31:06PM +0100, Vlastimil Babka wrote: > On 2/12/24 22:38, Suren Baghdasaryan wrote: > > Slab extension objects can't be allocated before slab infrastructure is > > initialized. Some caches, like kmem_cache and kmem_cache_node, are created > > before slab infrastructure is initialized. Objects from these caches can't > > have extension objects. Introduce SLAB_NO_OBJ_EXT slab flag to mark these > > caches and avoid creating extensions for objects allocated from these > > slabs. > > > > Signed-off-by: Suren Baghdasaryan > > --- > > include/linux/slab.h | 7 +++++++ > > mm/slub.c | 5 +++-- > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index b5f5ee8308d0..3ac2fc830f0f 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -164,6 +164,13 @@ > > #endif > > #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ > > > > +#ifdef CONFIG_SLAB_OBJ_EXT > > +/* Slab created using create_boot_cache */ > > +#define SLAB_NO_OBJ_EXT ((slab_flags_t __force)0x20000000U) > > There's > #define SLAB_SKIP_KFENCE ((slab_flags_t __force)0x20000000U) > already, so need some other one? What's up with the order of flags in that file? They don't seem to follow any particular ordering. Seems like some cleanup is in order, but any history/context we should know first?