From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7DAC3ABAB for ; Tue, 29 Apr 2025 17:49:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B48AD6B0011; Tue, 29 Apr 2025 13:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD2856B0012; Tue, 29 Apr 2025 13:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 925D26B0022; Tue, 29 Apr 2025 13:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6B2CC6B0011 for ; Tue, 29 Apr 2025 13:48:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3AE23C0D8A for ; Tue, 29 Apr 2025 17:48:59 +0000 (UTC) X-FDA: 83387817198.17.552C5F6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf11.hostedemail.com (Postfix) with ESMTP id F3D9C40005 for ; Tue, 29 Apr 2025 17:48:56 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BFbaX4nJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ipjcTets; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BFbaX4nJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ipjcTets; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745948937; a=rsa-sha256; cv=none; b=nm5JSxmoQltIDrjp0tMBiyxwP/EgCO8/RcEwPz4LWXdkiLK841Se38G+3i4vcuuYdfVr7F asb0fNptp+k9BncFfPArF7tHYRkqGXbXIidmnxRF6Ic8RACvjz46/kjLIcSmVTPiuDKn/A vRO4A7xekqCeHZGZ58BLPr0pxFERtSw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BFbaX4nJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ipjcTets; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=BFbaX4nJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ipjcTets; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745948937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lTHNAhL1imP4GkDhXUvjZKI3AbLRKvWJAvbA1bxankc=; b=DBtIm+JQZ3jH7nikihEj+ZzIZGBa3g2MIglX4Av3bJ2B5VgWbiUBE9wtjh4DLRWwNp1EnU WSDcu0Q1v4jpmr+lJfnd2/tMyaULJ08jcmFwjZFNi2Tsv91ZNIgXL81dVuhHHdeWyTZzyr 7Xht1vnex2mzZJzjQefG7NeQK+vstQc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5936E1F391; Tue, 29 Apr 2025 17:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745948935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lTHNAhL1imP4GkDhXUvjZKI3AbLRKvWJAvbA1bxankc=; b=BFbaX4nJAwTBBAnxUyQSfr55ulQflvKe6ZAbSYX87t1Gp8kazIbi4MvzFuCLZWcRWlDAX9 T7G9tUHmETHIa0vTsLhMGBzrIwhcknEAAV8IiCFdAfnxlzCckeMQ3fn4075GQAG0cmo+zc wUCnBPFXA0nn+soXRx1kWabTAQ5PQ0k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745948935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lTHNAhL1imP4GkDhXUvjZKI3AbLRKvWJAvbA1bxankc=; b=ipjcTetsXy8srqbFtLmajErI1oOrE4zMUG0JEo1kJajm73qrX+KYW5APKmFCHbQM5xDTcE B/Wo8ZuBM+EpBpBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745948935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lTHNAhL1imP4GkDhXUvjZKI3AbLRKvWJAvbA1bxankc=; b=BFbaX4nJAwTBBAnxUyQSfr55ulQflvKe6ZAbSYX87t1Gp8kazIbi4MvzFuCLZWcRWlDAX9 T7G9tUHmETHIa0vTsLhMGBzrIwhcknEAAV8IiCFdAfnxlzCckeMQ3fn4075GQAG0cmo+zc wUCnBPFXA0nn+soXRx1kWabTAQ5PQ0k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745948935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lTHNAhL1imP4GkDhXUvjZKI3AbLRKvWJAvbA1bxankc=; b=ipjcTetsXy8srqbFtLmajErI1oOrE4zMUG0JEo1kJajm73qrX+KYW5APKmFCHbQM5xDTcE B/Wo8ZuBM+EpBpBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6D14D1340C; Tue, 29 Apr 2025 17:48:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t89uFwYREWhJNgAAD6G6ig (envelope-from ); Tue, 29 Apr 2025 17:48:54 +0000 Date: Tue, 29 Apr 2025 18:48:52 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , David Hildenbrand , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] mm: abstract initial stack setup to mm subsystem Message-ID: References: <118c950ef7a8dd19ab20a23a68c3603751acd30e.1745853549.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <118c950ef7a8dd19ab20a23a68c3603751acd30e.1745853549.git.lorenzo.stoakes@oracle.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F3D9C40005 X-Stat-Signature: fww5dey4w5anmkgi19m7ozgfaskrnyji X-Rspam-User: X-HE-Tag: 1745948936-193750 X-HE-Meta: U2FsdGVkX1+6k68VS0fMp8fnvDMR1NgAU5XMPU8TCO6bHH6cqTZonOwj6YJU5Qx6/IQYh19MeBNtLEvt+8hxQ8bvq/WGuor5Dw1zSpXfHm0Am8KCWYFGIGE56PNJ7UlzZGzAMK9WP5OmSOetGavBGIwm8JKOe6pM+VXSqvwsx2PdogNCgBpojuLHgIfv5nWaT6k7K5bl+GdWVNWHEVlY9L4Rx4qxIW/JcVy37Bf5vLBVZIgFd8a72kqyZnDUERJ2ZsbM+Kmrs7sT4v0veleSjwfXMbwOYTwKAKkJl+wz3UxflzBQRd7almmKiSwn9/nTpfq55sJJqrSWISm1aAKwvwJDSvdXofuuvGUf5tZ/qEYS0roggWI67XwGox6LA6dfuIv3FK7yxB7OVAZdHAl64Wfx9+JMgaxIUYtTukS9vpVjR+nYgdh3PM2gENoVJvz8LyearOfKnjkg/6t3kQ2IbXZcQBzCrMQ5qJfzlEEk1PHK+rR0h/G/Qw7pANk4NXUaGQzZ1nJTPCPL7gabbDrZNWE06GO5HrFQLgy+eTvcKKS69PbpLwxq4+qyL3uDtgddTyQDdr6y9ZOnruS08MxCTd2l4/UpJ+BmR5NNAZnzbDGMZC8TtN6sPReTjOXw4CJzS4db9mCytbcyrcDFQF9E+SOy3wvhghOZnNMl8mlPXAhkiM7vWbFSulrN7AGaMa2h9IOUZNAAtrUspAbFbAYIwUs1li4WJeJHQOB5KTa7ZA90CzbFSM1GBmNtwsqTtNC3kdFGv4AuMLT4B34gchjE2Bu6JEqEKeDJVFAz8TeBrVu+CHQ6xT+w4pxA7oUwTrFaq8NhM/pdd/b0ISM9qT4y7RZQnMdSZLAdpbEr459+v2qLiU6m9FlwGzjlF1ZBjHPcsuDhA4BvOhPLsWxSgh59lSr4KfNORi6geGtZPs4GYDYYj1thLNkPNlj1Ti+LMrGT6lCFwSaFvq8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 04:28:15PM +0100, Lorenzo Stoakes wrote: > There are peculiarities within the kernel where what is very clearly mm > code is performed elsewhere arbitrarily. > > This violates separation of concerns and makes it harder to refactor code > to make changes to how fundamental initialisation and operation of mm logic > is performed. > > One such case is the creation of the VMA containing the initial stack upon > execve()'ing a new process. This is currently performed in __bprm_mm_init() > in fs/exec.c. > > Abstract this operation to create_init_stack_vma(). This allows us to limit > use of vma allocation and free code to fork and mm only. > > We previously did the same for the step at which we relocate the initial > stack VMA downwards via relocate_vma_down(), now we move the initial VMA > establishment too. > > Take the opportunity to also move insert_vm_struct() to mm/vma.c as it's no > longer needed anywhere outside of mm. > > Signed-off-by: Lorenzo Stoakes > Acked-by: David Hildenbrand > Reviewed-by: Suren Baghdasaryan Reviewed-by: Pedro Falcato -- Pedro