From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B6CC71135 for ; Mon, 16 Jun 2025 03:40:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98B7B6B0088; Sun, 15 Jun 2025 23:40:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 962FF6B0089; Sun, 15 Jun 2025 23:40:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A0296B008A; Sun, 15 Jun 2025 23:40:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7DA366B0088 for ; Sun, 15 Jun 2025 23:40:34 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C6E4A1A020B for ; Mon, 16 Jun 2025 03:40:33 +0000 (UTC) X-FDA: 83559861546.30.D3D1511 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf29.hostedemail.com (Postfix) with ESMTP id DC2C4120002 for ; Mon, 16 Jun 2025 03:40:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="b7//YpT8"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750045232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M9RfW2nEE+0kGLXPH3AFsKi1E6NDrayrZ4jmqmjVjj0=; b=8UzAYPKOZFgVuJlFMPzr49uUPHO6dzJqkCr22D/qvmqdtMALToTR9TI5sOfKEZ2zEEL5Lm aKnkvepeNK3q/mRj3UzKE+BBNH9JxFOA8KsY+FmeHlHFTWS4VgrPm+Xpc+bhWWcc4FIHI1 h9+cw5b0ch01bx64U0gsCN55AjXOb6E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750045232; a=rsa-sha256; cv=none; b=0FrnE7f9hxAf/y6RRK/TYTbIKHcdnsRapYMuTJz0Bo6+g8y6nYSLLORvH81+twdUHCIrKj lKqaE+BGvC3C7k0X0hm4MtLe+s06CyXboUtfjYZYnQmZwxkXmXvmTHBwfxHlfT3+vgR1V2 AAdugDGNFH5cx3YYVQf2YP9Snp6FJQY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="b7//YpT8"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf29.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev Date: Sun, 15 Jun 2025 23:40:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750045229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M9RfW2nEE+0kGLXPH3AFsKi1E6NDrayrZ4jmqmjVjj0=; b=b7//YpT8dFWW5uGmVDNMa1r6x35hfPi94C990VZASQjFQkgq0t5Wr9msvjLYReyjQ05+BG CslOmSdtr99RZZazz/BkzOSRozMPJUcuzwI/jCeJNYDLOmMv/oPovu8txjZ9u7YUqJnMQz /NM3wwtmNmWb9UKLTMOHVowVCMtrVyM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Matthew Wilcox Cc: Hao Ge , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Mike Rapoport , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge Subject: Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures Message-ID: References: <57e110be6d8387e403b4ef1f3b10714c36afbb51.1750040317.git.gehao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DC2C4120002 X-Stat-Signature: o8md3q98hsyyrmp7eshxwnx6dn8p6ana X-Rspam-User: X-HE-Tag: 1750045231-335482 X-HE-Meta: U2FsdGVkX1/wY4z+XejcSzpiUSxpghaRuC4g6y34s8OpNgv6Vnh/BxDhPpuytsjkiPcBVScRIRpLmzQRI9x+4pGJnAJfTAucISQQ3ocWoQ/MgjVeAOTedcx49OCch0sX0leWevcWDTlEqUIOmkpfLz83YvkEkWJO7Olcr2rWU96iLg6UsrVD/+M8z6URm/+P8wBnJuIikv5KuK1fiIWAxsiqbvF6qoZj6YhRQAdSzSa+dJ2ktW0dozo0CvlYuuqB5jeZfRoRfVIilBExGtZ940qmjJmgcYj8OPTNGFUfErnbbTUPQbIYGQfFmNZx9iejELPktnp9n2bqIB2EzY0E+GvEU8R8I4PCJoqivLv5Rd4dr6CUzeDO12klopdJRhrm+as+RNeC94Iu7+oSYr6+pKbXvB+ATjS7TtNMXRkOYV6nx76RNPU5rEszFwV9TfSWY6ScxvdKTKyMP9p3sRHMjojrC2GsJjqsWx0p3Es9M+fx7sN8i3N8hNI5NkXl8AQp4fuWcrexueoHJ83Ag7OzdGljF7RfK97GDLBko+KpqnWF69b0SBPMhN53gvWuWgQltcRJx/prDefiA2DeHtjHUfVo8873oDTH70eKcdtm04Shl80jQUTITBNL8XG7LXhEFUYGa++RFMXilkbXQxviQWNlwZvU+2udFJ0+mf35lrvTZE4NR7iyJsA4cwPqgAwHPh+RTWLzHp/L7ALJtB7BY7BH5LFcJFxA+nTi1HoF/xyEFOSgTMPz8MpgKiUD/u0A38pRVkuRSIP2u7ZLK3TtYPAgrBRbpTR7KaQp/zKw0uzGBQXZhMD1Mm4kE4I/8t6O7d0CpBwCervQZwFg8RUjThI4YEbyFpbe9Jj4S87SRPOQ5YZC0vmb0o0sdvPQFj4QfARbqlNuGyv5OCbkJJu1v+HXf7EyZdSOrTFOS1VOTxBgQuKnYDwBKr8rQ+FPGbGT4+dStDWVHKg7nb2STFh Fc/LTlif W3H16Xnzo5wsm3rJ5us+N78wLIOjMhBfFchQwg+CYBiFeJf4C0QECEZ4+cqZH/B/8Jv7A+bbDZEzUdxb0fvdoVESrJNMifNo6YPfiekL7wwuQoAXCfeMtqXFpvh0AT/bW67zcCuWEGcmu8FYjjCqMWKJEteoS2UhdUNm3QB2SVHQoBdbM89iA4s/zub3kTitFcQ5vzsiS/hsiElkXW+FweEeZdETpue+Guq4Auhbl0c81xq7lUzaD9oLXNUZb1nWLhhUcQ9dv5tjco0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 04:13:55AM +0100, Matthew Wilcox wrote: > On Mon, Jun 16, 2025 at 10:29:17AM +0800, Hao Ge wrote: > > +++ b/mm/Kconfig > > @@ -929,6 +929,10 @@ config ARCH_SUPPORTS_PUD_PFNMAP > > def_bool y > > depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > > > > +# s390 and alpha should be enabled,see comments for DECLARE_PER_CPU_SECTION > > This comment is inappropriate and should be removed. Inappropriate? That's not a word I'm accustomed to hearing as an engineering justification. It's referring the reader to context they might want to know about, and other comments they might want to read. Looks like a good comment to me, if perhaps a bit terse.