From: Kent Overstreet <kent.overstreet@linux.dev>
To: Matthew Wilcox <willy@infradead.org>
Cc: Hao Ge <hao.ge@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Suren Baghdasaryan <surenb@google.com>,
Mike Rapoport <rppt@kernel.org>,
Richard Henderson <richard.henderson@linaro.org>,
Matt Turner <mattst88@gmail.com>,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org,
Hao Ge <gehao@kylinos.cn>
Subject: Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures
Date: Sun, 15 Jun 2025 23:40:22 -0400 [thread overview]
Message-ID: <tb3jmhwt2ftchoual2futd7g4ltkswpwvmwei2ff5grmxrovub@ftna7njmn34u> (raw)
In-Reply-To: <aE-L81GzxzWBTfPb@casper.infradead.org>
On Mon, Jun 16, 2025 at 04:13:55AM +0100, Matthew Wilcox wrote:
> On Mon, Jun 16, 2025 at 10:29:17AM +0800, Hao Ge wrote:
> > +++ b/mm/Kconfig
> > @@ -929,6 +929,10 @@ config ARCH_SUPPORTS_PUD_PFNMAP
> > def_bool y
> > depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
> >
> > +# s390 and alpha should be enabled,see comments for DECLARE_PER_CPU_SECTION
>
> This comment is inappropriate and should be removed.
Inappropriate? That's not a word I'm accustomed to hearing as an
engineering justification.
It's referring the reader to context they might want to know about, and
other comments they might want to read. Looks like a good comment to me,
if perhaps a bit terse.
next prev parent reply other threads:[~2025-06-16 3:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 2:29 [PATCH v3 0/2] mm: Restrict the static definition of the per-CPU variable _shared_alloc_tag to s390 and alpha architectures only Hao Ge
2025-06-16 2:29 ` [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures Hao Ge
2025-06-16 3:13 ` Matthew Wilcox
2025-06-16 3:40 ` Kent Overstreet [this message]
2025-06-16 7:59 ` David Hildenbrand
2025-06-16 8:55 ` Mike Rapoport
2025-06-16 23:49 ` Suren Baghdasaryan
2025-06-16 2:29 ` [PATCH v3 2/2] mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when statically defining the percpu variable _shared_alloc_tag Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tb3jmhwt2ftchoual2futd7g4ltkswpwvmwei2ff5grmxrovub@ftna7njmn34u \
--to=kent.overstreet@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=dennis@kernel.org \
--cc=gehao@kylinos.cn \
--cc=gor@linux.ibm.com \
--cc=hao.ge@linux.dev \
--cc=hca@linux.ibm.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mattst88@gmail.com \
--cc=richard.henderson@linaro.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=svens@linux.ibm.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox